164481 2016-11-07 07:39:26 -0800 [GTK] Do not use gstreamer-gl when accelerated compositing is disabled 2016-11-14 07:24:29 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply commit-queue oldest_to_newest 1248743 0 magomez 2016-11-07 07:39:26 -0800 If the build is done with GSTREAMER_GL enabled, we need to be sure that it's not used when accelerated compositing is disabled using the WEBKIT_DISABLE_COMPOSITING_MODE environment variable. 1248750 1 294063 magomez 2016-11-07 08:07:21 -0800 Created attachment 294063 Patch 1248983 2 294063 zan 2016-11-07 23:00:32 -0800 Comment on attachment 294063 Patch LGTM. Currently there's an infrastructure problem and we're discouraged from landing patches, so setting cq- until we can land this. 1249762 3 294063 commit-queue 2016-11-10 05:36:30 -0800 Comment on attachment 294063 Patch Rejecting attachment 294063 from commit-queue. magomez@igalia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 1250964 4 294063 commit-queue 2016-11-14 07:24:25 -0800 Comment on attachment 294063 Patch Clearing flags on attachment: 294063 Committed r208680: <http://trac.webkit.org/changeset/208680> 1250965 5 commit-queue 2016-11-14 07:24:29 -0800 All reviewed patches have been landed. Closing bug. 294063 2016-11-07 08:07:21 -0800 2016-11-14 07:24:25 -0800 Patch bug-164481-20161107170313.patch text/plain 1773 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIzN2Y5YTg3ZDg0N2Nj NDFmMTI1ZjBkYzljZThjOGQ3M2NmMmZmNy4uMzc0Y2VkNmIwOTc2MDA5NWMzMTk4ZjgwZjljMmVl NjNjZjExNWMwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTExLTA3ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gRG8gbm90IHVz ZSBnc3RyZWFtZXItZ2wgd2hlbiBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBpcyBkaXNhYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NDgxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgd2hl dGhlciBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBpcyBlbmFibGVkIGJlZm9yZSBjcmVhdGluZyB0 aGUgZ3N0cmVhbWVyLWdsIHZpZGVvIHNpbmsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChDb3Zl cmVkIGJ5IGV4aXN0aW5nIHRlc3RzKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNyZWF0ZVZpZGVvU2luayk6 CisKIDIwMTYtMTEtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXVEY6OlBhcmtpbmdMb3Qgc2hvdWxkIHN0b3AgdXNpbmcgc3RkOjpjaHJvbm8gYmVjYXVzZSBz dGQ6OmNocm9ubzo6ZHVyYXRpb24gY2FzdHMgYXJlIHByb25lIHRvIG92ZXJmbG93cwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4 IDExZDcyNDk1ZWE1MGI5NTUyMjk5NjcyN2VjNTZlYzMwYzQwY2NmNzUuLjk5MjBmOTQ0Yzg2Y2Nj NTc4YjlmZGUxZTQzOWU4NDllZmQ5N2JhZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKQEAgLTEwMjQsNyArMTAyNCw4IEBAIEdz dEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNyZWF0ZVZpZGVvU2lu a0dMKCkKIEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNyZWF0 ZVZpZGVvU2luaygpCiB7CiAjaWYgVVNFKEdTVFJFQU1FUl9HTCkKLSAgICBtX3ZpZGVvU2luayA9 IGNyZWF0ZVZpZGVvU2lua0dMKCk7CisgICAgaWYgKG1fcGxheWVyLT5jbGllbnQoKS5tZWRpYVBs YXllclJlbmRlcmluZ0NhbkJlQWNjZWxlcmF0ZWQobV9wbGF5ZXIpKQorICAgICAgICBtX3ZpZGVv U2luayA9IGNyZWF0ZVZpZGVvU2lua0dMKCk7CiAjZW5kaWYKIAogICAgIGlmICghbV92aWRlb1Np bmspIHsK