16448 2007-12-15 03:47:25 -0800 [GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac 2007-12-16 17:15:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk, Performance P2 Normal --- 1 alp mrowe mrowe oldest_to_newest 64270 0 alp 2007-12-15 03:47:25 -0800 The GTK+ port takes an unexpectedly high time on the Celtic Kane "Array object" benchmark: http://celtickane.com/webdesign/jsspeed2007.php wk 605ms fx2 264ms the DOM test is also suspiciously slow: wk 261ms fx2 179ms Probably something silly going on. We need to throw a profiler at this. 64296 1 mrowe 2007-12-15 08:18:17 -0800 Grr, I spent a little while this evening trying to find a profiler on Linux that would give me understandable data but failed miserably. 64360 2 mrowe 2007-12-16 02:50:06 -0800 Finally got gprof working. Most of the time looks to be spent inside toString in the comparison function below ArrayInstance::sort. I have a patch locally that tweaks ArrayInstance::sort to call toString O(N) times rather than O(N log N) times, which drop the Array test from 158 to 7ms on my Linux machine. I'm not entirely sure *why* toString was proving more expensive on Linux as gprof output isn't proving very enlightening. The patch is also a win on Mac (36 -> 6ms on Array). 64411 3 mrowe 2007-12-16 14:19:42 -0800 I'm not seeing the DOM test as being slow on my machine. It consistently takes around 25ms. 64413 4 mrowe 2007-12-16 14:21:22 -0800 I'm re-titling this bug for now to cover the Array aspect for which I have a patch. We should file separate bugs on other parts of the benchmark that are slower than expected. 64414 5 17939 mrowe 2007-12-16 14:34:46 -0800 Created attachment 17939 Patch 64421 6 17939 mjs 2007-12-16 14:59:15 -0800 Comment on attachment 17939 Patch r=me 64422 7 mjs 2007-12-16 14:59:32 -0800 (But I suggested an improvement to the comment) 64444 8 mrowe 2007-12-16 17:15:09 -0800 Landed in r28782. 17939 2007-12-16 14:34:46 -0800 2007-12-16 14:59:15 -0800 Patch 0001-Fix-http-bugs.webkit.org-show_bug.cgi-id-16448.patch text/plain 6257 mrowe RnJvbSBlOWE0Y2IyNGRjNjRhNjhiNGY0NDNiOWRjN2U3YjAzZjBjODFhMGUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIFJvd2UgPG1yb3dlQGFwcGxlLmNvbT4KRGF0ZTogTW9u LCAxNyBEZWMgMjAwNyAxMToyNjo1MyArMTMwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBodHRwOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ0OAogQnVnIDE2NDQ4OiBbR1RLXSBD ZWx0aWMgS2FuZSBKYXZhU2NyaXB0IHBlcmZvcm1hbmNlIG9uIEFycmF5IHRlc3QgaXMgc2xvdyBy ZWxhdGl2ZSB0byBNYWMKCioga2pzL2FycmF5X2luc3RhbmNlLmNwcDoKKEtKUzo6Y29tcGFyZUJ5 U3RyaW5nUGFpckZvclFTb3J0KToKKEtKUzo6QXJyYXlJbnN0YW5jZTo6c29ydCk6IFVzZSB0aGUg ZGVjb3JhdGUtc29ydC11bmRlY29yYXRlIGlkaW9tIHRvIG1pbmltaXNlIHRoZSBudW1iZXIgb2Yg Y2FsbHMKdG8gdG9TdHJpbmcoKS4gIFRoaXMgcmVxdWlyZXMgYSB0ZW1wb3JhcnkgYnVmZmVyIHNv IHdlIG9ubHkgdXNlIHRoaXMgYXBwcm9hY2ggaW4gY2FzZXMgd2hlcmUgdGhlCmFycmF5IGJlaW5n IHNvcnRlZCBpcyBub3QgdG9vIGxhcmdlLgotLS0KIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgfCAgIDEzICsrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9ranMvYXJyYXlfaW5z dGFuY2UuY3BwIHwgICA1NSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KIDIgZmls ZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmlu ZGV4IDljN2U1ZWYuLmVlMmExYzMgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv ZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwNy0x Mi0xNiAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBodHRwOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjQ0OAorICAgICAgICBCdWcgMTY0NDg6IFtHVEtdIENlbHRpYyBLYW5l IEphdmFTY3JpcHQgcGVyZm9ybWFuY2Ugb24gQXJyYXkgdGVzdCBpcyBzbG93IHJlbGF0aXZlIHRv IE1hYworCisgICAgICAgICoga2pzL2FycmF5X2luc3RhbmNlLmNwcDoKKyAgICAgICAgKEtKUzo6 Y29tcGFyZUJ5U3RyaW5nUGFpckZvclFTb3J0KToKKyAgICAgICAgKEtKUzo6QXJyYXlJbnN0YW5j ZTo6c29ydCk6IFVzZSB0aGUgZGVjb3JhdGUtc29ydC11bmRlY29yYXRlIGlkaW9tIHRvIG1pbmlt aXNlIHRoZSBudW1iZXIgb2YgY2FsbHMKKyAgICAgICAgdG8gdG9TdHJpbmcoKS4gIFRoaXMgcmVx dWlyZXMgYSB0ZW1wb3JhcnkgYnVmZmVyIHNvIHdlIG9ubHkgdXNlIHRoaXMgYXBwcm9hY2ggaW4g Y2FzZXMgd2hlcmUgdGhlCisgICAgICAgIGFycmF5IGJlaW5nIHNvcnRlZCBpcyBub3QgdG9vIGxh cmdlLgorCiAyMDA3LTEyLTE0ICBBbHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBNYXJrIFJvd2UuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ranMv YXJyYXlfaW5zdGFuY2UuY3BwIGIvSmF2YVNjcmlwdENvcmUva2pzL2FycmF5X2luc3RhbmNlLmNw cAppbmRleCBjYzkxZGUzLi4yNTQ3Mjk5IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9ranMv YXJyYXlfaW5zdGFuY2UuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL2tqcy9hcnJheV9pbnN0YW5j ZS5jcHAKQEAgLTQ5LDcgKzQ5LDcgQEAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIG1heEFycmF5SW5k ZXggPSAweEZGRkZGRkZFVTsKIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBzcGFyc2VBcnJheUN1dG9m ZiA9IDEwMDAwOwogc3RhdGljIGNvbnN0IHVuc2lnbmVkIG1pbkRlbnNpdHlNdWx0aXBsaWVyID0g ODsKIAotc3RhdGljIGNvbnN0IHVuc2lnbmVkIG1lcmdlU29ydEN1dG9mZiA9IDEwMDAwOworc3Rh dGljIGNvbnN0IHVuc2lnbmVkIGNvcHlpbmdTb3J0Q3V0b2ZmID0gNTAwMDA7CiAKIGNvbnN0IENs YXNzSW5mbyBBcnJheUluc3RhbmNlOjppbmZvID0geyJBcnJheSIsIDAsIDB9OwogCkBAIC00Mjks OCArNDI5LDE0IEBAIHZvaWQgQXJyYXlJbnN0YW5jZTo6bWFyaygpCiAgICAgfQogfQogCi1zdGF0 aWMgRXhlY1N0YXRlKiBleGVjRm9yQ29tcGFyZUJ5U3RyaW5nRm9yUVNvcnQgPSAwOworc3RhdGlj IGludCBjb21wYXJlQnlTdHJpbmdQYWlyRm9yUVNvcnQoY29uc3Qgdm9pZCogYSwgY29uc3Qgdm9p ZCogYikKK3sKKyAgICBjb25zdCBzdGQ6OnBhaXI8SlNWYWx1ZSosIFVTdHJpbmc+KiB2YSA9IHN0 YXRpY19jYXN0PGNvbnN0IHN0ZDo6cGFpcjxKU1ZhbHVlKiwgVVN0cmluZz4qPihhKTsKKyAgICBj b25zdCBzdGQ6OnBhaXI8SlNWYWx1ZSosIFVTdHJpbmc+KiB2YiA9IHN0YXRpY19jYXN0PGNvbnN0 IHN0ZDo6cGFpcjxKU1ZhbHVlKiwgVVN0cmluZz4qPihiKTsKKyAgICByZXR1cm4gY29tcGFyZSh2 YS0+c2Vjb25kLCB2Yi0+c2Vjb25kKTsKK30KIAorc3RhdGljIEV4ZWNTdGF0ZSogZXhlY0ZvckNv bXBhcmVCeVN0cmluZ0ZvclFTb3J0ID0gMDsKIHN0YXRpYyBpbnQgY29tcGFyZUJ5U3RyaW5nRm9y UVNvcnQoY29uc3Qgdm9pZCogYSwgY29uc3Qgdm9pZCogYikKIHsKICAgICBFeGVjU3RhdGUqIGV4 ZWMgPSBleGVjRm9yQ29tcGFyZUJ5U3RyaW5nRm9yUVNvcnQ7CkBAIC00NDcsMzQgKzQ1MywzMyBA QCB2b2lkIEFycmF5SW5zdGFuY2U6OnNvcnQoRXhlY1N0YXRlKiBleGVjKQogewogICAgIHVuc2ln bmVkIGxlbmd0aE5vdEluY2x1ZGluZ1VuZGVmaW5lZCA9IGNvbXBhY3RGb3JTb3J0aW5nKCk7CiAK LSAgICBFeGVjU3RhdGUqIG9sZEV4ZWMgPSBleGVjRm9yQ29tcGFyZUJ5U3RyaW5nRm9yUVNvcnQ7 Ci0gICAgZXhlY0ZvckNvbXBhcmVCeVN0cmluZ0ZvclFTb3J0ID0gZXhlYzsKKyAgICBpZiAobGVu Z3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkIDwgY29weWluZ1NvcnRDdXRvZmYpIHsKKyAgICAgICAg Ly8gRGVjb3JhdGUtc29ydC11bmRlY29yYXRlIGlzIGNvbnNpZGVyYWJseSBmYXN0ZXIgdGhhbiBz b3J0aW5nIHRoZSB1bmRlY29yYXRlZCB2ZWN0b3IgYnV0IHJlcXVpcmVzCisgICAgICAgIC8vIGEg bGFyZ2UgdGVtcG9yYXJ5IGJ1ZmZlci4gIEZvciBsYXJnZSBhcnJheXMsIHdlIGZhbGwgYmFjayB0 byBxc29ydCB3aXRob3V0IGFueSBjb3BpZXMuCiAKLSNpZiBIQVZFKE1FUkdFU09SVCkKLSAgICAv LyBCZWNhdXNlIG1lcmdlc29ydCB1c3VhbGx5IGRvZXMgZmV3ZXIgY29tcGFyZXMsIGl0IGlzIGZh c3RlciB0aGFuIHFzb3J0IGhlcmUuCi0gICAgLy8gSG93ZXZlciwgYmVjYXVzZSBpdCByZXF1aXJl cyBleHRyYSBjb3BpZXMgb2YgdGhlIHN0b3JhZ2UgYnVmZmVyLCBkb24ndCB1c2UgaXQgZm9yIHZl cnkKLSAgICAvLyBsYXJnZSBhcnJheXMuCisgICAgICAgIFZlY3RvcjxzdGQ6OnBhaXI8SlNWYWx1 ZSosIFVTdHJpbmc+ID4gdmFsdWVzKGxlbmd0aE5vdEluY2x1ZGluZ1VuZGVmaW5lZCk7CisgICAg ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGVuZ3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkOyBp KyspIHsKKyAgICAgICAgICAgIEpTVmFsdWUqIHZhbHVlID0gbV9zdG9yYWdlLT5tX3ZlY3Rvcltp XTsKKyAgICAgICAgICAgIEFTU0VSVCghdmFsdWUtPmlzVW5kZWZpbmVkKCkpOworICAgICAgICAg ICAgdmFsdWVzW2ldLmZpcnN0ID0gdmFsdWU7CisgICAgICAgICAgICB2YWx1ZXNbaV0uc2Vjb25k ID0gdmFsdWUtPnRvU3RyaW5nKGV4ZWMpOworICAgICAgICB9CiAKLSAgICAvLyBGSVhNRTogU2lu Y2Ugd2Ugc29ydCBieSBzdHJpbmcgdmFsdWUsIGEgZmFzdCBhbGdvcml0aG0gbWlnaHQgYmUgdG8g Y29udmVydCBhbGwgdGhlCi0gICAgLy8gdmFsdWVzIHRvIHN0cmluZyBvbmNlIHVwIGZyb250LCBh bmQgdGhlbiB1c2UgYSByYWRpeCBzb3J0LiBUaGF0IHdvdWxkIGJlIE8oTikgcmF0aGVyCi0gICAg Ly8gdGhhbiBPKE4gbG9nIE4pLgorICAgICAgICAvLyBGSVhNRTogU2luY2Ugd2Ugc29ydCBieSBz dHJpbmcgdmFsdWUsIGEgZmFzdCBhbGdvcml0aG0gbWlnaHQgYmUgdG8gdXNlIGEgcmFkaXggc29y dC4gVGhhdCB3b3VsZCBiZSBPKE4pIHJhdGhlcgorICAgICAgICAvLyB0aGFuIE8oTiBsb2cgTiku CiAKLSAgICBpZiAobGVuZ3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkIDwgbWVyZ2VTb3J0Q3V0b2Zm KSB7Ci0gICAgICAgIC8vIER1cmluZyB0aGUgc29ydCwgd2UgY291bGQgZG8gYSBnYXJiYWdlIGNv bGxlY3QsIGFuZCBpdCdzIGltcG9ydGFudCB0byBzdGlsbAotICAgICAgICAvLyBoYXZlIHJlZmVy ZW5jZXMgdG8gZXZlcnkgb2JqZWN0IGluIHRoZSBhcnJheSBmb3IgQXJyYXlJbnN0YW5jZTo6bWFy ay4KLSAgICAgICAgLy8gVGhlIG1lcmdlc29ydCBhbGdvcml0aG0gZG9lcyBub3QgZ3VhcmFudGVl IHRoaXMsIHNvIHdlIHNvcnQgYSBjb3B5IHJhdGhlcgotICAgICAgICAvLyB0aGFuIHRoZSBvcmln aW5hbC4KLSAgICAgICAgc2l6ZV90IHNpemUgPSBzdG9yYWdlU2l6ZShtX3ZlY3Rvckxlbmd0aCk7 Ci0gICAgICAgIEFycmF5U3RvcmFnZSogY29weSA9IHN0YXRpY19jYXN0PEFycmF5U3RvcmFnZSo+ KGZhc3RNYWxsb2Moc2l6ZSkpOwotICAgICAgICBtZW1jcHkoY29weSwgbV9zdG9yYWdlLCBzaXpl KTsKLSAgICAgICAgbWVyZ2Vzb3J0KGNvcHktPm1fdmVjdG9yLCBsZW5ndGhOb3RJbmNsdWRpbmdV bmRlZmluZWQsIHNpemVvZihKU1ZhbHVlKiksIGNvbXBhcmVCeVN0cmluZ0ZvclFTb3J0KTsKLSAg ICAgICAgZmFzdEZyZWUobV9zdG9yYWdlKTsKLSAgICAgICAgbV9zdG9yYWdlID0gY29weTsKLSAg ICAgICAgZXhlY0ZvckNvbXBhcmVCeVN0cmluZ0ZvclFTb3J0ID0gb2xkRXhlYzsKKyNpZiBIQVZF KE1FUkdFU09SVCkKKyAgICAgICAgbWVyZ2Vzb3J0KHZhbHVlcy5iZWdpbigpLCB2YWx1ZXMuc2l6 ZSgpLCBzaXplb2Yoc3RkOjpwYWlyPEpTVmFsdWUqLCBVU3RyaW5nPiksIGNvbXBhcmVCeVN0cmlu Z1BhaXJGb3JRU29ydCk7CisjZWxzZQorICAgICAgICBxc29ydCh2YWx1ZXMuYmVnaW4oKSwgdmFs dWVzLnNpemUoKSwgc2l6ZW9mKHN0ZDo6cGFpcjxKU1ZhbHVlKiwgVVN0cmluZz4pLCBjb21wYXJl QnlTdHJpbmdQYWlyRm9yUVNvcnQpOworI2VuZGlmCisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgbGVuZ3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkOyBpKyspCisgICAgICAgICAgICBtX3N0 b3JhZ2UtPm1fdmVjdG9yW2ldID0gdmFsdWVzW2ldLmZpcnN0OwogICAgICAgICByZXR1cm47CiAg ICAgfQotI2VuZGlmCiAKKyAgICBFeGVjU3RhdGUqIG9sZEV4ZWMgPSBleGVjRm9yQ29tcGFyZUJ5 U3RyaW5nRm9yUVNvcnQ7CisgICAgZXhlY0ZvckNvbXBhcmVCeVN0cmluZ0ZvclFTb3J0ID0gZXhl YzsKICAgICBxc29ydChtX3N0b3JhZ2UtPm1fdmVjdG9yLCBsZW5ndGhOb3RJbmNsdWRpbmdVbmRl ZmluZWQsIHNpemVvZihKU1ZhbHVlKiksIGNvbXBhcmVCeVN0cmluZ0ZvclFTb3J0KTsKICAgICBl eGVjRm9yQ29tcGFyZUJ5U3RyaW5nRm9yUVNvcnQgPSBvbGRFeGVjOwogfQpAQCAtNTI4LDcgKzUz Myw3IEBAIHZvaWQgQXJyYXlJbnN0YW5jZTo6c29ydChFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0 KiBjb21wYXJlRnVuY3Rpb24pCiAgICAgLy8gRklYTUU6IEEgdHJlZSBzb3J0IHVzaW5nIGEgcGVy ZmVjdGx5IGJhbGFuY2VkIHRyZWUgKGUuZy4gYW4gQVZMIHRyZWUpIGNvdWxkIGRvIGFuIGV2ZW4K ICAgICAvLyBiZXR0ZXIgam9iIG9mIG1pbmltaXppbmcgY29tcGFyZXMuCiAKLSAgICBpZiAobGVu Z3RoTm90SW5jbHVkaW5nVW5kZWZpbmVkIDwgbWVyZ2VTb3J0Q3V0b2ZmKSB7CisgICAgaWYgKGxl bmd0aE5vdEluY2x1ZGluZ1VuZGVmaW5lZCA8IGNvcHlpbmdTb3J0Q3V0b2ZmKSB7CiAgICAgICAg IC8vIER1cmluZyB0aGUgc29ydCwgd2UgY291bGQgZG8gYSBnYXJiYWdlIGNvbGxlY3QsIGFuZCBp dCdzIGltcG9ydGFudCB0byBzdGlsbAogICAgICAgICAvLyBoYXZlIHJlZmVyZW5jZXMgdG8gZXZl cnkgb2JqZWN0IGluIHRoZSBhcnJheSBmb3IgQXJyYXlJbnN0YW5jZTo6bWFyay4KICAgICAgICAg Ly8gVGhlIG1lcmdlc29ydCBhbGdvcml0aG0gZG9lcyBub3QgZ3VhcmFudGVlIHRoaXMsIHNvIHdl IHNvcnQgYSBjb3B5IHJhdGhlcgotLSAKMS41LjQucmMwLjcuZzkxM2I0Cgo=