<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164479</bug_id>
          
          <creation_ts>2016-11-07 06:12:44 -0800</creation_ts>
          <short_desc>Fix various --minimal build issue</short_desc>
          <delta_ts>2016-11-14 08:06:42 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Csaba Osztrogonác">ossy</assigned_to>
          <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>kangil.han</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1248732</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-11-07 06:12:44 -0800</bug_when>
    <thetext>1.) Source/WebCore/dom/Node.cpp should include ExceptionCode.h
HIERARCHY_REQUEST_ERR, NOT_FOUND_ERR, NOT_SUPPORTED_ERR, ... are defined in ExceptionCode.h
In normal WebKit build ExceptionCode.h is included indirectly, but --minimal build fails.

2.) Source/WebCore/page/Page.cpp shouldn&apos;t call the undefined PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary()
It is defined on Mac always and on !Mac inside ENABLE(VIDEO) || ENABLE(WEB_AUDIO) guards.

3.) emptyString() can&apos;t be converted to ExceptionOr&lt;String&gt; in Source/WebCore/testing/Internals.cpp
../../Source/WebCore/testing/Internals.cpp: In member function &apos;WebCore::ExceptionOr&lt;WTF::String&gt; WebCore::Internals::captionsStyleSheetOverride()&apos;:
../../Source/WebCore/testing/Internals.cpp:2511:23: error: could not convert &apos;WTF::emptyString()&apos; from &apos;const WTF::String&apos; to &apos;WebCore::ExceptionOr&lt;WTF::String&gt;&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1248733</commentid>
    <comment_count>1</comment_count>
      <attachid>294058</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-11-07 06:13:45 -0800</bug_when>
    <thetext>Created attachment 294058
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1248986</commentid>
    <comment_count>2</comment_count>
      <attachid>294058</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-11-07 23:12:39 -0800</bug_when>
    <thetext>Comment on attachment 294058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294058&amp;action=review

I am OK with these build fixes, but the ones in Page.cpp could be done a little better.

&gt; Source/WebCore/page/Page.cpp:1450
&gt; +#if PLATFORM(MAC) || ENABLE(VIDEO) || ENABLE(WEB_AUDIO)

If we keep this conditional, there is no reason for it to mention #if PLATFORM(MAC). Just ENABLE(VIDEO) || ENABLE(WEB_AUDIO) should do.

&gt; Source/WebCore/page/Page.cpp:1473
&gt; +#if PLATFORM(MAC) || ENABLE(VIDEO) || ENABLE(WEB_AUDIO)
&gt;      if (wasVisibleAndActive != isVisibleAndActive())
&gt;          PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary();
&gt; +#endif

Ditto.

But maybe this conditional is not needed. Instead, perhaps PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary should be defined even when ENABLE(VIDEO) || ENABLE(WEB_AUDIO) is false, in PlatformMediaSessionManager.cpp. Since the header is not conditional, it seems to me that the function body shouldn’t be either. It‘s not like we need to optimize this case to avoid the function call.

&gt; Source/WebCore/testing/Internals.cpp:2511
&gt; -    return emptyString();
&gt; +    return String();

If we want to return an empty string and not null, then it would be better to return:

    return String { emptyString() };

But I guess it’s OK your way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1250959</commentid>
    <comment_count>3</comment_count>
      <attachid>294699</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-11-14 06:21:09 -0800</bug_when>
    <thetext>Created attachment 294699
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1250961</commentid>
    <comment_count>4</comment_count>
      <attachid>294701</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2016-11-14 06:30:23 -0800</bug_when>
    <thetext>Created attachment 294701
patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1250968</commentid>
    <comment_count>5</comment_count>
      <attachid>294701</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-11-14 07:42:52 -0800</bug_when>
    <thetext>Comment on attachment 294701
patch for landing

Clearing flags on attachment: 294701

Committed r208682: &lt;http://trac.webkit.org/changeset/208682&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>294058</attachid>
            <date>2016-11-07 06:13:45 -0800</date>
            <delta_ts>2016-11-07 23:12:39 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-164479-20161107150937.patch</filename>
            <type>text/plain</type>
            <size>2869</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIzN2Y5YTg3ZDg0N2Nj
NDFmMTI1ZjBkYzljZThjOGQ3M2NmMmZmNy4uZmNlNzA2YmQ1NzVjYWIyZmI0MTc2MmE2YjJjZGEz
MDE4NjQxYzEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTExLTA3ICBDc2Fi
YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHZhcmlvdXMg
LS1taW5pbWFsIGJ1aWxkIGlzc3VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNjQ0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6UGFnZTo6c2V0QWN0aXZpdHlTdGF0ZSk6CisgICAgICAgICogdGVz
dGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxzOjpjYXB0aW9u
c1N0eWxlU2hlZXRPdmVycmlkZSk6CisKIDIwMTYtMTEtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxv
QGFwcGxlLmNvbT4KIAogICAgICAgICBXVEY6OlBhcmtpbmdMb3Qgc2hvdWxkIHN0b3AgdXNpbmcg
c3RkOjpjaHJvbm8gYmVjYXVzZSBzdGQ6OmNocm9ubzo6ZHVyYXRpb24gY2FzdHMgYXJlIHByb25l
IHRvIG92ZXJmbG93cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwIGIv
U291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IDlhYzllOGI1MmQyYzk1Nzc4YmNiYmQ0
ZmIwNGJhYzRiZGYyNjgxZjUuLjU3NGVkYjA2YTcyOGQzMWVhZTg2MjEzY2RlYzdlM2Q0MDE0MWEz
M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTQxLDYgKzQxLDcgQEAKICNpbmNsdWRlICJFbGVtZW50
VHJhdmVyc2FsLmgiCiAjaW5jbHVkZSAiRXZlbnREaXNwYXRjaGVyLmgiCiAjaW5jbHVkZSAiRXZl
bnRIYW5kbGVyLmgiCisjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgogI2luY2x1ZGUgIkZyYW1l
Vmlldy5oIgogI2luY2x1ZGUgIkhUTUxCb2R5RWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxDb2xs
ZWN0aW9uLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIvU291
cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAppbmRleCAyNDAxOTgxODY4N2E2ZDcxNTg0NTViYmQw
Y2ZhOTRlMDYxM2E4ZTQyLi5hMTk4NWQ2OTY0NjczYWMxMGNhZTNkN2ZmMzQzMDE5ZWVhNTRmZjc5
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL3BhZ2UvUGFnZS5jcHAKQEAgLTE0NDcsNyArMTQ0Nyw5IEBAIHZvaWQgUGFnZTo6c2V0
QWN0aXZpdHlTdGF0ZShBY3Rpdml0eVN0YXRlOjpGbGFncyBhY3Rpdml0eVN0YXRlKQogCiAgICAg
QWN0aXZpdHlTdGF0ZTo6RmxhZ3Mgb2xkQWN0aXZpdHlTdGF0ZSA9IG1fYWN0aXZpdHlTdGF0ZTsK
IAorI2lmIFBMQVRGT1JNKE1BQykgfHwgRU5BQkxFKFZJREVPKSB8fCBFTkFCTEUoV0VCX0FVRElP
KQogICAgIGJvb2wgd2FzVmlzaWJsZUFuZEFjdGl2ZSA9IGlzVmlzaWJsZUFuZEFjdGl2ZSgpOwor
I2VuZGlmCiAgICAgbV9hY3Rpdml0eVN0YXRlID0gYWN0aXZpdHlTdGF0ZTsKIAogICAgIG1fZm9j
dXNDb250cm9sbGVyLT5zZXRBY3Rpdml0eVN0YXRlKGFjdGl2aXR5U3RhdGUpOwpAQCAtMTQ2NSw4
ICsxNDY3LDEwIEBAIHZvaWQgUGFnZTo6c2V0QWN0aXZpdHlTdGF0ZShBY3Rpdml0eVN0YXRlOjpG
bGFncyBhY3Rpdml0eVN0YXRlKQogICAgIGZvciAoYXV0byogb2JzZXJ2ZXIgOiBtX2FjdGl2aXR5
U3RhdGVDaGFuZ2VPYnNlcnZlcnMpCiAgICAgICAgIG9ic2VydmVyLT5hY3Rpdml0eVN0YXRlRGlk
Q2hhbmdlKG9sZEFjdGl2aXR5U3RhdGUsIG1fYWN0aXZpdHlTdGF0ZSk7CiAKKyNpZiBQTEFURk9S
TShNQUMpIHx8IEVOQUJMRShWSURFTykgfHwgRU5BQkxFKFdFQl9BVURJTykKICAgICBpZiAod2Fz
VmlzaWJsZUFuZEFjdGl2ZSAhPSBpc1Zpc2libGVBbmRBY3RpdmUoKSkKICAgICAgICAgUGxhdGZv
cm1NZWRpYVNlc3Npb25NYW5hZ2VyOjp1cGRhdGVOb3dQbGF5aW5nSW5mb0lmTmVjZXNzYXJ5KCk7
CisjZW5kaWYKIH0KIAogYm9vbCBQYWdlOjppc1Zpc2libGVBbmRBY3RpdmUoKSBjb25zdApkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dl
YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDU5MTdmYTBhZDA5ZmMwMjA5NDIxMTZk
OWY0N2I4NDhhMzA4YzE3ZjUuLmVmZWIxZDYwNTQ2ZjU2ODEwNzBlY2UzNmIyMjEyM2FhNzIzMzVk
ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAgLTI1MDgsNyArMjUwOCw3
IEBAIEV4Y2VwdGlvbk9yPFN0cmluZz4gSW50ZXJuYWxzOjpjYXB0aW9uc1N0eWxlU2hlZXRPdmVy
cmlkZSgpCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAgIHJldHVybiBkb2N1bWVudC0+cGFn
ZSgpLT5ncm91cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLmNhcHRpb25zU3R5bGVTaGVldE92ZXJy
aWRlKCk7CiAjZWxzZQotICAgIHJldHVybiBlbXB0eVN0cmluZygpOworICAgIHJldHVybiBTdHJp
bmcoKTsKICNlbmRpZgogfQogCg==
</data>
<flag name="review"
          id="316839"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>294699</attachid>
            <date>2016-11-14 06:21:09 -0800</date>
            <delta_ts>2016-11-14 06:31:10 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>bug-164479-20161114151649.patch</filename>
            <type>text/plain</type>
            <size>3527</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Njc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNhNzg3ZWZmNzVhYzQ4
ZjYxNTI1NmRkYWE3ZWZiZTFmOTg3YWZjOC4uNzQ3NmEwNDI4MTQyMDg2ODcxNDQ3OTk0OWNiMGRm
NmJlNmQ5YzY2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE2LTExLTE0ICBDc2Fi
YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgRml4IHZhcmlvdXMg
LS1taW5pbWFsIGJ1aWxkIGlzc3VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNjQ0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K
KworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9QbGF0
Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxz
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6Y2FwdGlvbnNTdHlsZVNoZWV0T3Zl
cnJpZGUpOgorCisyMDE2LTExLTA4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v
cmc+CisKKyAgICAgICAgVHlwbyBmaXggYWZ0ZXIgcjE2Mjc4MgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NDczCisKKyAgICAgICAgVW5yZXZpZXdl
ZCB0cml2aWFsIGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL1RocmVhZEdsb2JhbERhdGEuY3Bw
OgorCisyMDE2LTExLTE0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK
ICAgICAgICAgRml4IHRoZSAhRU5BQkxFKENTU19CT1hfREVDT1JBVElPTl9CUkVBSykgYnVpbGQK
ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDQ3OAog
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29y
ZS9kb20vTm9kZS5jcHAKaW5kZXggODQ0Y2U5YWVlNjA5ZmM2MDM5OTE1MDIxYWExZjAxZDQzNjY4
NzhlZC4uZGFkYzhhYjRhZGI5OGZiNjYxMzM0NzQ5OTlkM2JiZGRmMDAzODhlZCAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9O
b2RlLmNwcApAQCAtNDEsNiArNDEsNyBAQAogI2luY2x1ZGUgIkVsZW1lbnRUcmF2ZXJzYWwuaCIK
ICNpbmNsdWRlICJFdmVudERpc3BhdGNoZXIuaCIKICNpbmNsdWRlICJFdmVudEhhbmRsZXIuaCIK
KyNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3LmgiCiAjaW5j
bHVkZSAiSFRNTEJvZHlFbGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTENvbGxlY3Rpb24uaCIKZGlm
ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVkaWFTZXNz
aW9uTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QbGF0Zm9ybU1l
ZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCmluZGV4IGVkNmEzZDE4OWQ3ODViYWEwMTBiNzI2MWYxNDdh
ODlhZDE1ZDVjNTYuLjI1YjU3ZDc1YTQ2ZTA5YmNkZmE2ZjI0MjVkMmY0ZTE4ZjdmOTI0OWUgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVkaWFTZXNz
aW9uTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vUGxhdGZv
cm1NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcApAQCAtMjYsNyArMjYsNiBAQAogI2luY2x1ZGUgImNv
bmZpZy5oIgogI2luY2x1ZGUgIlBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5oIgogCi0jaWYg
RU5BQkxFKFZJREVPKSB8fCBFTkFCTEUoV0VCX0FVRElPKQogCiAjaW5jbHVkZSAiQXVkaW9TZXNz
aW9uLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKQEAgLTM3LDEyICszNiwxNCBAQAogbmFtZXNw
YWNlIFdlYkNvcmUgewogCiAjaWYgIVBMQVRGT1JNKE1BQykKLQogdm9pZCBQbGF0Zm9ybU1lZGlh
U2Vzc2lvbk1hbmFnZXI6OnVwZGF0ZU5vd1BsYXlpbmdJbmZvSWZOZWNlc3NhcnkoKQogewogfQor
I2VuZGlmCisKKyNpZiBFTkFCTEUoVklERU8pIHx8IEVOQUJMRShXRUJfQVVESU8pCiAKLSNpZiAh
UExBVEZPUk0oSU9TKQorI2lmICFQTEFURk9STShDT0NPQSkKIHN0YXRpYyBQbGF0Zm9ybU1lZGlh
U2Vzc2lvbk1hbmFnZXIqIHBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciA9IG51bGxwdHI7CiAK
IFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciYgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2Vy
OjpzaGFyZWRNYW5hZ2VyKCkKQEAgLTU2LDkgKzU3LDcgQEAgUGxhdGZvcm1NZWRpYVNlc3Npb25N
YW5hZ2VyKiBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJZkV4aXN0
cygKIHsKICAgICByZXR1cm4gcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOwogfQotI2VuZGlm
IC8vICFQTEFURk9STShJT1MpCi0KLSNlbmRpZiAvLyAhUExBVEZPUk0oTUFDKQorI2VuZGlmIC8v
ICFQTEFURk9STShDT0NPQSkKIAogUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpQbGF0Zm9y
bU1lZGlhU2Vzc2lvbk1hbmFnZXIoKQogICAgIDogbV9zeXN0ZW1TbGVlcExpc3RlbmVyKFN5c3Rl
bVNsZWVwTGlzdGVuZXI6OmNyZWF0ZSgqdGhpcykpCkBAIC00NDEsNiArNDQwLDYgQEAgYm9vbCBQ
bGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OmFueU9mU2Vzc2lvbnMoc3RkOjpmdW5jdGlvbjxi
b29sKFBsYXRmb3JtTWVkaWEKICAgICByZXR1cm4gZm91bmQ7CiB9CiAKLX0KKyNlbmRpZiAvLyBF
TkFCTEUoVklERU8pIHx8IEVOQUJMRShXRUJfQVVESU8pCiAKLSNlbmRpZgorfSAvLyBuYW1lc3Bh
Y2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMu
Y3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDM1ZDk3MWNj
Yjk3Zjg5MGE3NGE4NDhhZWNlM2VlMDhmNzg3OWMzNGIuLmI4MTQ3ODVlZGVmNTg5NGJlYzk2YmE5
ODBhZmY3ZGE2MWU5MGI3YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50
ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKQEAg
LTI1MjcsNyArMjUyNyw3IEBAIEV4Y2VwdGlvbk9yPFN0cmluZz4gSW50ZXJuYWxzOjpjYXB0aW9u
c1N0eWxlU2hlZXRPdmVycmlkZSgpCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAgIHJldHVy
biBkb2N1bWVudC0+cGFnZSgpLT5ncm91cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLmNhcHRpb25z
U3R5bGVTaGVldE92ZXJyaWRlKCk7CiAjZWxzZQotICAgIHJldHVybiBlbXB0eVN0cmluZygpOwor
ICAgIHJldHVybiBTdHJpbmcgeyBlbXB0eVN0cmluZygpIH07CiAjZW5kaWYKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>294701</attachid>
            <date>2016-11-14 06:30:23 -0800</date>
            <delta_ts>2016-11-14 07:42:52 -0800</delta_ts>
            <desc>patch for landing</desc>
            <filename>bug-164479-20161114152604.patch</filename>
            <type>text/plain</type>
            <size>3305</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4Njc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNhNzg3ZWZmNzVhYzQ4
ZjYxNTI1NmRkYWE3ZWZiZTFmOTg3YWZjOC4uMDI3MWIwYjRiZTI4YWFmMDBiY2JmYzdhNjBmNWRj
YmQ1MjA3ZGZmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTExLTE0ICBDc2Fi
YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKKyAgICAgICAgRml4IHZhcmlvdXMg
LS1taW5pbWFsIGJ1aWxkIGlzc3VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0xNjQ0NzkKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K
KworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9QbGF0
Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxz
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6Y2FwdGlvbnNTdHlsZVNoZWV0T3Zl
cnJpZGUpOgorCisyMDE2LTExLTE0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v
cmc+CisKICAgICAgICAgRml4IHRoZSAhRU5BQkxFKENTU19CT1hfREVDT1JBVElPTl9CUkVBSykg
YnVpbGQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2
NDQ3OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggODQ0Y2U5YWVlNjA5ZmM2MDM5OTE1MDIxYWExZjAx
ZDQzNjY4NzhlZC4uZGFkYzhhYjRhZGI5OGZiNjYxMzM0NzQ5OTlkM2JiZGRmMDAzODhlZCAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl
L2RvbS9Ob2RlLmNwcApAQCAtNDEsNiArNDEsNyBAQAogI2luY2x1ZGUgIkVsZW1lbnRUcmF2ZXJz
YWwuaCIKICNpbmNsdWRlICJFdmVudERpc3BhdGNoZXIuaCIKICNpbmNsdWRlICJFdmVudEhhbmRs
ZXIuaCIKKyNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCiAjaW5jbHVkZSAiRnJhbWVWaWV3Lmgi
CiAjaW5jbHVkZSAiSFRNTEJvZHlFbGVtZW50LmgiCiAjaW5jbHVkZSAiSFRNTENvbGxlY3Rpb24u
aCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVk
aWFTZXNzaW9uTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QbGF0
Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCmluZGV4IGVkNmEzZDE4OWQ3ODViYWEwMTBiNzI2
MWYxNDdhODlhZDE1ZDVjNTYuLjI1YjU3ZDc1YTQ2ZTA5YmNkZmE2ZjI0MjVkMmY0ZTE4ZjdmOTI0
OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL1BsYXRmb3JtTWVk
aWFTZXNzaW9uTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v
UGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcApAQCAtMjYsNyArMjYsNiBAQAogI2luY2x1
ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5oIgog
Ci0jaWYgRU5BQkxFKFZJREVPKSB8fCBFTkFCTEUoV0VCX0FVRElPKQogCiAjaW5jbHVkZSAiQXVk
aW9TZXNzaW9uLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKQEAgLTM3LDEyICszNiwxNCBAQAog
bmFtZXNwYWNlIFdlYkNvcmUgewogCiAjaWYgIVBMQVRGT1JNKE1BQykKLQogdm9pZCBQbGF0Zm9y
bU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnVwZGF0ZU5vd1BsYXlpbmdJbmZvSWZOZWNlc3NhcnkoKQog
ewogfQorI2VuZGlmCisKKyNpZiBFTkFCTEUoVklERU8pIHx8IEVOQUJMRShXRUJfQVVESU8pCiAK
LSNpZiAhUExBVEZPUk0oSU9TKQorI2lmICFQTEFURk9STShDT0NPQSkKIHN0YXRpYyBQbGF0Zm9y
bU1lZGlhU2Vzc2lvbk1hbmFnZXIqIHBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciA9IG51bGxw
dHI7CiAKIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciYgUGxhdGZvcm1NZWRpYVNlc3Npb25N
YW5hZ2VyOjpzaGFyZWRNYW5hZ2VyKCkKQEAgLTU2LDkgKzU3LDcgQEAgUGxhdGZvcm1NZWRpYVNl
c3Npb25NYW5hZ2VyKiBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNoYXJlZE1hbmFnZXJJ
ZkV4aXN0cygKIHsKICAgICByZXR1cm4gcGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOwogfQot
I2VuZGlmIC8vICFQTEFURk9STShJT1MpCi0KLSNlbmRpZiAvLyAhUExBVEZPUk0oTUFDKQorI2Vu
ZGlmIC8vICFQTEFURk9STShDT0NPQSkKIAogUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpQ
bGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIoKQogICAgIDogbV9zeXN0ZW1TbGVlcExpc3RlbmVy
KFN5c3RlbVNsZWVwTGlzdGVuZXI6OmNyZWF0ZSgqdGhpcykpCkBAIC00NDEsNiArNDQwLDYgQEAg
Ym9vbCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OmFueU9mU2Vzc2lvbnMoc3RkOjpmdW5j
dGlvbjxib29sKFBsYXRmb3JtTWVkaWEKICAgICByZXR1cm4gZm91bmQ7CiB9CiAKLX0KKyNlbmRp
ZiAvLyBFTkFCTEUoVklERU8pIHx8IEVOQUJMRShXRUJfQVVESU8pCiAKLSNlbmRpZgorfSAvLyBu
YW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl
cm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IDM1
ZDk3MWNjYjk3Zjg5MGE3NGE4NDhhZWNlM2VlMDhmNzg3OWMzNGIuLmI4MTQ3ODVlZGVmNTg5NGJl
Yzk2YmE5ODBhZmY3ZGE2MWU5MGI3YWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3Rp
bmcvSW50ZXJuYWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5j
cHAKQEAgLTI1MjcsNyArMjUyNyw3IEBAIEV4Y2VwdGlvbk9yPFN0cmluZz4gSW50ZXJuYWxzOjpj
YXB0aW9uc1N0eWxlU2hlZXRPdmVycmlkZSgpCiAjaWYgRU5BQkxFKFZJREVPX1RSQUNLKQogICAg
IHJldHVybiBkb2N1bWVudC0+cGFnZSgpLT5ncm91cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLmNh
cHRpb25zU3R5bGVTaGVldE92ZXJyaWRlKCk7CiAjZWxzZQotICAgIHJldHVybiBlbXB0eVN0cmlu
ZygpOworICAgIHJldHVybiBTdHJpbmcgeyBlbXB0eVN0cmluZygpIH07CiAjZW5kaWYKIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>