164475 2016-11-07 04:50:36 -0800 [EFL] Suppress build warning in generated Geoclue2Interface.c 2016-11-14 04:25:37 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159128 1 ossy ossy cgarcia commit-queue gyuyoung.kim tonikitoo oldest_to_newest 1248720 0 ossy 2016-11-07 04:50:36 -0800 https://trac.webkit.org/changeset/202479 disabled werror for this file, but I think this noisy build output isn't good, let's suppress this warning. [1270/5284] Building C object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/Geoclue2Interface.c.o DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_get_client': DerivedSources/WebCore/Geoclue2Interface.c:673:21: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_manager_complete_add_agent': DerivedSources/WebCore/Geoclue2Interface.c:693:21: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_start': DerivedSources/WebCore/Geoclue2Interface.c:2373:20: warning: unused parameter 'object' [-Wunused-parameter] DerivedSources/WebCore/Geoclue2Interface.c: In function 'geoclue_client_complete_stop': DerivedSources/WebCore/Geoclue2Interface.c:2391:20: warning: unused parameter 'object' [-Wunused-parameter] It turned out, GTK already suppresses this warning: https://bugs.webkit.org/show_bug.cgi?id=163733#c3 1248721 1 294054 ossy 2016-11-07 04:51:37 -0800 Created attachment 294054 Patch 1250953 2 294054 commit-queue 2016-11-14 04:25:32 -0800 Comment on attachment 294054 Patch Clearing flags on attachment: 294054 Committed r208677: <http://trac.webkit.org/changeset/208677> 1250954 3 commit-queue 2016-11-14 04:25:37 -0800 All reviewed patches have been landed. Closing bug. 294054 2016-11-07 04:51:37 -0800 2016-11-14 04:25:32 -0800 Patch bug-164475-20161107134730.patch text/plain 1712 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIzN2Y5YTg3ZDg0N2Nj NDFmMTI1ZjBkYzljZThjOGQ3M2NmMmZmNy4uMjkxOTE4YWFiYjk5MWVkOTAxMTk1MTYxZDc2OTcy NTVhYWYyZTExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTExLTA3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0VGTF0gU3VwcHJl c3MgYnVpbGQgd2FybmluZyBpbiBnZW5lcmF0ZWQgR2VvY2x1ZTJJbnRlcmZhY2UuYworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NDc1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVmbC5j bWFrZToKKwogMjAxNi0xMS0wNCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAg ICAgICAgIFdURjo6UGFya2luZ0xvdCBzaG91bGQgc3RvcCB1c2luZyBzdGQ6OmNocm9ubyBiZWNh dXNlIHN0ZDo6Y2hyb25vOjpkdXJhdGlvbiBjYXN0cyBhcmUgcHJvbmUgdG8gb3ZlcmZsb3dzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1NvdXJjZS9XZWJD b3JlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IDcyYTFjNzIyODY0Zjg5ZjEzMGVkNjdmZTdmYzc2 OTVkNzY2YjliZWEuLjI3YWFkNWYwNzBhZmFiMjEzODUxZDQ4ZTI1NjU1ZDM3NzRiNmZkMmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC0yMzYsOCArMjM2LDggQEAgaWYgKFVTRV9HRU9D TFVFMikKICAgICAgICAgIE9VVFBVVCAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vR2Vv Y2x1ZTJJbnRlcmZhY2UuYyAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vR2VvY2x1ZTJJ bnRlcmZhY2UuaAogICAgICAgICAgQ09NTUFORCBnZGJ1cy1jb2RlZ2VuIC0taW50ZXJmYWNlLXBy ZWZpeCBvcmcuZnJlZWRlc2t0b3AuR2VvQ2x1ZTIuIC0tYy1uYW1lc3BhY2UgR2VvY2x1ZSAtLWdl bmVyYXRlLWMtY29kZSAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vR2VvY2x1ZTJJbnRl cmZhY2UgJHtHRU9DTFVFX0RCVVNfSU5URVJGQUNFfQogICAgICkKLSAgICAjIEdlb2NsdWUySW50 ZXJmYWNlLmMgZ2VuZXJhdGVzIHVudXNlZC1wYXJhbWV0ZXIgYnVpbGQgd2FybmluZywgaXQgY2F1 c2VzIGJ1aWxkIGVycm9yIHdoZW4gdXNpbmcgZ2VvY2x1ZTIgbGlicmFyeS4KLSAgICBzZXRfc291 cmNlX2ZpbGVzX3Byb3BlcnRpZXMoJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L0dlb2Ns dWUySW50ZXJmYWNlLmMgUFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTIC1Xbm8tZXJyb3IpCisgICAg c2V0X3NvdXJjZV9maWxlc19wcm9wZXJ0aWVzKCR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElS fS9HZW9jbHVlMkludGVyZmFjZS5jIFBST1BFUlRJRVMgQ09NUElMRV9GTEFHUyAtV25vLXVudXNl ZC1wYXJhbWV0ZXIpCisKIGVuZGlmICgpCiAKIGlmIChFTkFCTEVfR0FNRVBBRF9ERVBSRUNBVEVE KQo=