164448 2016-11-05 06:25:11 -0700 [MinGW] Fixed C99/C++11 format attributes in printf-like functions 2016-11-07 12:38:15 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen commit-queue mcatanzaro ossy pvollan oldest_to_newest 1248480 0 annulen 2016-11-05 06:25:11 -0700 By default MinGW uses printf-like function provided in msvcrt.dll, however they miss support for C99/C++11 format attributes. Use MinGW implementations instead. 1248481 1 293993 annulen 2016-11-05 06:35:43 -0700 Created attachment 293993 Patch 1248484 2 293993 mcatanzaro 2016-11-05 07:59:22 -0700 Comment on attachment 293993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293993&action=review > Source/WTF/wtf/Assertions.h:55 > +#if COMPILER(MINGW) > +/* For __MINGW_PRINTF_FORMAT */ > +#include <stdio.h> > +#endif stdio.h exists everywhere, so I think this isn't worth the preprocessor guards. 1248485 3 annulen 2016-11-05 08:03:54 -0700 I was unsure if it gets included everywhere 1248486 4 mcatanzaro 2016-11-05 08:30:19 -0700 It probably does and it will probably slow things down very slightly, but honestly, I'd rather have fewer platform-specific #include differences. Anyone actually using mingw to develop is going to break the build by forgetting to include stdio.h now! But you know, maybe a better solution would be to eschew the header and just open-code the value of __MINGW_PRINTF_FORMAT instead. 1248487 5 annulen 2016-11-05 08:41:58 -0700 __MINGW_PRINTF_FORMAT is defined as gnu_printf. I was following recommended usage of __USE_MINGW_ANSI_STDIO, however it seems that gnu_printf is not MinGW-specific so it should be safe to use it without macro 1248515 6 annulen 2016-11-05 11:01:33 -0700 Committed r208418: <http://trac.webkit.org/changeset/208418> 293993 2016-11-05 06:35:43 -0700 2016-11-05 08:03:05 -0700 Patch bug-164448-20161105163139.patch text/plain 3743 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRhYWI1NDNiNmNmMTYwNTQzYjVlZjY1 MDNjMzk5NzBjNTAxN2VlYmEuLmJlNWIwM2M4YTlhYjE3MmYzODcxOTBjMzJlZmM4M2M3Mjg1NjRi ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMTEtMDUgIEtvbnN0YW50aW4gVG9rYXJldiAg PGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFtNaW5HV10gRml4ZWQgQzk5L0MrKzExIGZv cm1hdCBhdHRyaWJ1dGVzIGluIHByaW50Zi1saWtlIGZ1bmN0aW9ucworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NDQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnkgZGVmYXVsdCBNaW5HVyB1c2VzIHBy aW50Zi1saWtlIGZ1bmN0aW9uIHByb3ZpZGVkIGluIG1zdmNydC5kbGwsCisgICAgICAgIGhvd2V2 ZXIgdGhleSBtaXNzIHN1cHBvcnQgZm9yIEM5OS9DKysxMSBmb3JtYXQgYXR0cmlidXRlcy4gVXNl IE1pbkdXCisgICAgICAgIGltcGxlbWVudGF0aW9ucyBpbnN0ZWFkLgorCisgICAgICAgICogd3Rm L0Fzc2VydGlvbnMuaDogVXNlIF9fTUlOR1dfUFJJTlRGX0ZPUk1BVCBpbiBXVEZfQVRUUklCVVRF X1BSSU5URgorCiAyMDE2LTExLTA1ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFtKU0NPbmx5XSBSdW5Mb29wR2VuZXJpYyBzaG91bGQgYWRvcHQgTW9u b3RvbmljVGltZSAvIFdhbGxUaW1lIGNoYW5nZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYv QXNzZXJ0aW9ucy5oIGIvU291cmNlL1dURi93dGYvQXNzZXJ0aW9ucy5oCmluZGV4IGY4Njc1OTk0 NDBlNjBkZTZlMTVlZDgzZjVhN2Y5NTgxNWI3YjZhOWQuLmRlZTFlOTg3MTBjNmIzNDQ3MzQ3MTZm YjBiYzRhOTZlMWIyZTc1OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMu aAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmgKQEAgLTQ5LDYgKzQ5LDExIEBACiAj aW5jbHVkZSA8b3MvbG9nLmg+CiAjZW5kaWYKIAorI2lmIENPTVBJTEVSKE1JTkdXKQorLyogRm9y IF9fTUlOR1dfUFJJTlRGX0ZPUk1BVCAqLworI2luY2x1ZGUgPHN0ZGlvLmg+CisjZW5kaWYKKwog I2lmZGVmIE5ERUJVRwogLyogRGlzYWJsZSBBU1NFUlQqIG1hY3JvcyBpbiByZWxlYXNlIG1vZGUu ICovCiAjZGVmaW5lIEFTU0VSVElPTlNfRElTQUJMRURfREVGQVVMVCAxCkBAIC05NCwxMCArOTks MTMgQEAKICNkZWZpbmUgV1RGX1BSRVRUWV9GVU5DVElPTiBfX0ZVTkNUSU9OX18KICNlbmRpZgog CisjaWYgQ09NUElMRVIoTUlOR1cpICYmIGRlZmluZWQoX19NSU5HV19QUklOVEZfRk9STUFUKQor LyogQnkgZGVmYXVsdCBNaW5HVyBlbWl0cyB3YXJuaW5ncyB3aGVuIEM5OSBmb3JtYXQgYXR0cmli dXRlcyBhcmUgdXNlZCwgZXZlbiBpZiBfX1VTRV9NSU5HV19BTlNJX1NURElPIGlzIGRlZmluZWQg Ki8KKyNkZWZpbmUgV1RGX0FUVFJJQlVURV9QUklOVEYoZm9ybWF0U3RyaW5nQXJndW1lbnQsIGV4 dHJhQXJndW1lbnRzKSBfX2F0dHJpYnV0ZV9fKChfX2Zvcm1hdF9fKF9fTUlOR1dfUFJJTlRGX0ZP Uk1BVCwgZm9ybWF0U3RyaW5nQXJndW1lbnQsIGV4dHJhQXJndW1lbnRzKSkpCisjZWxpZiBDT01Q SUxFUihHQ0NfT1JfQ0xBTkcpICYmICFkZWZpbmVkKF9fT0JKQ19fKQogLyogV1RGIGxvZ2dpbmcg ZnVuY3Rpb25zIGNhbiBwcm9jZXNzICVAIGluIHRoZSBmb3JtYXQgc3RyaW5nIHRvIGxvZyBhIE5T T2JqZWN0KiBidXQgdGhlIHByaW50ZiBmb3JtYXQgYXR0cmlidXRlCiAgICBlbWl0cyBhIHdhcm5p bmcgd2hlbiAlQCBpcyB1c2VkIGluIHRoZSBmb3JtYXQgc3RyaW5nLiAgVW50aWwgPHJkYXI6Ly9w cm9ibGVtLzUxOTU0Mzc+IGlzIHJlc29sdmVkIHdlIGNhbid0IGluY2x1ZGUKICAgIHRoZSBhdHRy aWJ1dGUgd2hlbiBiZWluZyB1c2VkIGZyb20gT2JqZWN0aXZlLUMgY29kZSBpbiBjYXNlIGl0IGRl Y2lkZXMgdG8gdXNlICVALiAqLwotI2lmIENPTVBJTEVSKEdDQ19PUl9DTEFORykgJiYgIWRlZmlu ZWQoX19PQkpDX18pCiAjZGVmaW5lIFdURl9BVFRSSUJVVEVfUFJJTlRGKGZvcm1hdFN0cmluZ0Fy Z3VtZW50LCBleHRyYUFyZ3VtZW50cykgX19hdHRyaWJ1dGVfXygoX19mb3JtYXRfXyhwcmludGYs IGZvcm1hdFN0cmluZ0FyZ3VtZW50LCBleHRyYUFyZ3VtZW50cykpKQogI2Vsc2UKICNkZWZpbmUg V1RGX0FUVFJJQlVURV9QUklOVEYoZm9ybWF0U3RyaW5nQXJndW1lbnQsIGV4dHJhQXJndW1lbnRz KQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UgYi9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQppbmRleCA4Y2ZlZjdmNmVkM2M0MmJkMTQ3N2YyNjkz ZjI3M2EzNGU3YTc1OGI2Li41OWI3MTI4MmU1N2NjZGIwMmQzYWI3ODQ3OWM1ZDIwN2I3NzdmYzdi IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysgYi9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQpAQCAtNTAsNiArNTAsNyBAQCBlbmRpZiAoKQog CiBpZiAoV0lOMzIgQU5EIENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORykKICAgICBzZXQoQ01BS0Vf Q1hYX0ZMQUdTICIke0NNQUtFX0NYWF9GTEFHU30gLW1uby1tcy1iaXRmaWVsZHMgLVduby11bmtu b3duLXByYWdtYXMiKQorICAgIGFkZF9kZWZpbml0aW9ucygtRF9fVVNFX01JTkdXX0FOU0lfU1RE SU89MSkKIGVuZGlmICgpCiAKICMgRW5zdXJlIHRoYXQgdGhlIGRlZmF1bHQgaW5jbHVkZSBzeXN0 ZW0gZGlyZWN0b3JpZXMgYXJlIGFkZGVkIHRvIHRoZSBsaXN0IG9mIENNYWtlIGltcGxpY2l0IGlu Y2x1ZGVzLgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGYyZDI2NWQ5 NDVhNTkzMmNlNTgxNTg3ZWM1YjI2MDk1MDFlMTYxOTkuLjMxOWQwODkyNzZmMjEyZjc0YTUxZmZm N2MzNGY4M2I2ODdmZjRjMTIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNiBAQAorMjAxNi0xMS0wNSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxl bkB5YW5kZXgucnU+CisKKyAgICAgICAgW01pbkdXXSBGaXhlZCBDOTkvQysrMTEgZm9ybWF0IGF0 dHJpYnV0ZXMgaW4gcHJpbnRmLWxpa2UgZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQ0NDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBkZWZhdWx0IE1pbkdXIHVzZXMgcHJpbnRmLWxp a2UgZnVuY3Rpb24gcHJvdmlkZWQgaW4gbXN2Y3J0LmRsbCwKKyAgICAgICAgaG93ZXZlciB0aGV5 IG1pc3Mgc3VwcG9ydCBmb3IgQzk5L0MrKzExIGZvcm1hdCBhdHRyaWJ1dGVzLiBVc2UgTWluR1cK KyAgICAgICAgaW1wbGVtZW50YXRpb25zIGluc3RlYWQuCisKKyAgICAgICAgKiBTb3VyY2UvY21h a2UvT3B0aW9uc0NvbW1vbi5jbWFrZTogRGVmaW5lIF9fVVNFX01JTkdXX0FOU0lfU1RESU8KKwog MjAxNi0xMS0wMyAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAg ICAgICAgRml4ZXMgdG8gYnVpbGQgSlNDT25seSBvbiBtYWNPUwo=