164444 2016-11-04 18:42:10 -0700 testWASM should be very sad if no options are provided 2016-11-04 19:51:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159775 1 jfbastien jfbastien commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1248401 0 jfbastien 2016-11-04 18:42:10 -0700 Because I've been running it wrong all along. 1248402 1 293967 jfbastien 2016-11-04 18:43:43 -0700 Created attachment 293967 patch 1248403 2 293967 saam 2016-11-04 18:47:38 -0700 Comment on attachment 293967 patch View in context: https://bugs.webkit.org/attachment.cgi?id=293967&action=review > Source/JavaScriptCore/testWasm.cpp:78 > + continue; Should be RELEASE_ASSERT_NOT_REACHED() IMO 1248405 3 293969 jfbastien 2016-11-04 18:51:50 -0700 Created attachment 293969 patch Address comment. 1248419 4 293969 commit-queue 2016-11-04 19:51:16 -0700 Comment on attachment 293969 patch Clearing flags on attachment: 293969 Committed r208413: <http://trac.webkit.org/changeset/208413> 1248420 5 commit-queue 2016-11-04 19:51:19 -0700 All reviewed patches have been landed. Closing bug. 293967 2016-11-04 18:43:43 -0700 2016-11-04 18:51:50 -0700 patch 0001-testWASM-should-be-very-sad-if-no-options-are-provid.patch text/plain 2443 jfbastien RnJvbSBiMDc5YTFiOWQ0MGM4MTc0YzdhNTc2NjYzZmYxODA4Zjg2MTMzY2YyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDQgTm92IDIwMTYgMTg6Mzk6MTIgLTA3MDAKU3ViamVjdDogW1BBVENIXSB0ZXN0V0FT TSBzaG91bGQgYmUgdmVyeSBzYWQgaWYgbm8gb3B0aW9ucyBhcmUgcHJvdmlkZWQKCi0tLQogU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICB8IDEyICsrKysrKysrKysrKwogU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RXYXNtLmNwcCB8IDI0ICsrKysrKysrKysrKysrKystLS0tLS0t LQogMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBmZDRhMWYuLmUwZDExMWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTExLTA0ICBKRiBCYXN0aWVuICA8amZi YXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICB0ZXN0V0FTTSBzaG91bGQgYmUgdmVyeSBzYWQg aWYgbm8gb3B0aW9ucyBhcmUgcHJvdmlkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NDQ0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIERldGVjdCBtaXNzaW5nIG9yIGludmFsaWQgb3B0aW9ucyBvbiB0 aGUgY29tbWFuZCBsaW5lLgorCisgICAgICAgICogdGVzdFdhc20uY3BwOgorICAgICAgICAoQ29t bWFuZExpbmU6OnBhcnNlQXJndW1lbnRzKToKKwogMjAxNi0xMS0wNCAgTWFyayBMYW0gIDxtYXJr LmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRXJyb3IgZGVzY3JpcHRpb24gY29kZSBzaG91bGQg YmUgYWJsZSB0byBoYW5kbGUgU3ltYm9sIHZhbHVlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0V2FzbS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdFdhc20u Y3BwCmluZGV4IDAyZWRkNTEuLjMzOGNlMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS90ZXN0V2FzbS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RXYXNtLmNw cApAQCAtNDYsNyArNDYsNiBAQCBwdWJsaWM6CiAgICAgICAgIHBhcnNlQXJndW1lbnRzKGFyZ2Ms IGFyZ3YpOwogICAgIH0KIAotICAgIFZlY3RvcjxTdHJpbmc+IG1fYXJndW1lbnRzOwogICAgIGJv b2wgbV9ydW5MRUJUZXN0cyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX3J1bldhc21UZXN0cyB7IGZh bHNlIH07CiAKQEAgLTY4LDIxICs2NywzMCBAQCB2b2lkIENvbW1hbmRMaW5lOjpwYXJzZUFyZ3Vt ZW50cyhpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CiAgICAgaW50IGkgPSAxOwogCisgICAgaWYg KGFyZ2MgPT0gaSkKKyAgICAgICAgcHJpbnRVc2FnZVN0YXRlbWVudChmYWxzZSk7CisKICAgICBm b3IgKDsgaSA8IGFyZ2M7ICsraSkgewogICAgICAgICBjb25zdCBjaGFyKiBhcmcgPSBhcmd2W2ld OwotICAgICAgICBpZiAoIXN0cmNtcChhcmcsICItaCIpIHx8ICFzdHJjbXAoYXJnLCAiLS1oZWxw IikpCisKKyAgICAgICAgaWYgKCFzdHJjbXAoYXJnLCAiLWgiKSB8fCAhc3RyY21wKGFyZywgIi0t aGVscCIpKSB7CiAgICAgICAgICAgICBwcmludFVzYWdlU3RhdGVtZW50KHRydWUpOworICAgICAg ICAgICAgY29udGludWU7CisgICAgICAgIH0KIAotICAgICAgICBpZiAoIXN0cmNtcChhcmcsICIt bCIpIHx8ICFzdHJjbXAoYXJnLCAiLS1sZWIiKSkKKyAgICAgICAgaWYgKCFzdHJjbXAoYXJnLCAi LWwiKSB8fCAhc3RyY21wKGFyZywgIi0tbGViIikpIHsKICAgICAgICAgICAgIG1fcnVuTEVCVGVz dHMgPSB0cnVlOworICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIH0KIAotICAgICAgICBp ZiAoIXN0cmNtcChhcmcsICItdyIpIHx8ICFzdHJjbXAoYXJnLCAiLS13ZWIiKSkKKyAgICAgICAg aWYgKCFzdHJjbXAoYXJnLCAiLXciKSB8fCAhc3RyY21wKGFyZywgIi0td2ViIikpIHsKICAgICAg ICAgICAgIG1fcnVuV2FzbVRlc3RzID0gdHJ1ZTsKLSAgICB9Ci0KLSAgICBmb3IgKDsgaSA8IGFy Z2M7ICsraSkKLSAgICAgICAgbV9hcmd1bWVudHMuYXBwZW5kKGFyZ3ZbaV0pOworICAgICAgICAg ICAgY29udGludWU7CisgICAgICAgIH0KIAorICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIlVua25v d24gb3B0aW9uICVzXG4iLCBhcmcpOworICAgICAgICBwcmludFVzYWdlU3RhdGVtZW50KGZhbHNl KTsKKyAgICB9CiB9CiAKIFN0YXRpY0xvY2sgY3Jhc2hMb2NrOwotLSAKMi45LjMKCg== 293969 2016-11-04 18:51:50 -0700 2016-11-04 19:51:16 -0700 patch 0001-testWASM-should-be-very-sad-if-no-options-are-provid.patch text/plain 2460 jfbastien RnJvbSA1OWZjMGEyZjg1YWJhYjFjMGFmZDU4ZDM5YTg3MjU5YWNlODkzNGMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBGcmksIDQgTm92IDIwMTYgMTg6Mzk6MTIgLTA3MDAKU3ViamVjdDogW1BBVENIXSB0ZXN0V0FT TSBzaG91bGQgYmUgdmVyeSBzYWQgaWYgbm8gb3B0aW9ucyBhcmUgcHJvdmlkZWQKCi0tLQogU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICB8IDEyICsrKysrKysrKysrKwogU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RXYXNtLmNwcCB8IDI0ICsrKysrKysrKysrKysrKystLS0tLS0t LQogMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDBmZDRhMWYuLjQzOTFhOWYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTExLTA0ICBKRiBCYXN0aWVuICA8amZi YXN0aWVuQGFwcGxlLmNvbT4KKworICAgICAgICB0ZXN0V0FTTSBzaG91bGQgYmUgdmVyeSBzYWQg aWYgbm8gb3B0aW9ucyBhcmUgcHJvdmlkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NDQ0NAorCisgICAgICAgIFJldmlld2VkIGJ5IFNhYW0gQmFy YXRpLgorCisgICAgICAgIERldGVjdCBtaXNzaW5nIG9yIGludmFsaWQgb3B0aW9ucyBvbiB0aGUg Y29tbWFuZCBsaW5lLgorCisgICAgICAgICogdGVzdFdhc20uY3BwOgorICAgICAgICAoQ29tbWFu ZExpbmU6OnBhcnNlQXJndW1lbnRzKToKKwogMjAxNi0xMS0wNCAgTWFyayBMYW0gIDxtYXJrLmxh bUBhcHBsZS5jb20+CiAKICAgICAgICAgRXJyb3IgZGVzY3JpcHRpb24gY29kZSBzaG91bGQgYmUg YWJsZSB0byBoYW5kbGUgU3ltYm9sIHZhbHVlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS90ZXN0V2FzbS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdFdhc20uY3Bw CmluZGV4IDAyZWRkNTEuLmI3NTk1NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS90ZXN0V2FzbS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RXYXNtLmNwcApA QCAtNDYsNyArNDYsNiBAQCBwdWJsaWM6CiAgICAgICAgIHBhcnNlQXJndW1lbnRzKGFyZ2MsIGFy Z3YpOwogICAgIH0KIAotICAgIFZlY3RvcjxTdHJpbmc+IG1fYXJndW1lbnRzOwogICAgIGJvb2wg bV9ydW5MRUJUZXN0cyB7IGZhbHNlIH07CiAgICAgYm9vbCBtX3J1bldhc21UZXN0cyB7IGZhbHNl IH07CiAKQEAgLTY4LDIxICs2NywzMCBAQCB2b2lkIENvbW1hbmRMaW5lOjpwYXJzZUFyZ3VtZW50 cyhpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CiAgICAgaW50IGkgPSAxOwogCisgICAgaWYgKGFy Z2MgPT0gaSkKKyAgICAgICAgcHJpbnRVc2FnZVN0YXRlbWVudChmYWxzZSk7CisKICAgICBmb3Ig KDsgaSA8IGFyZ2M7ICsraSkgewogICAgICAgICBjb25zdCBjaGFyKiBhcmcgPSBhcmd2W2ldOwot ICAgICAgICBpZiAoIXN0cmNtcChhcmcsICItaCIpIHx8ICFzdHJjbXAoYXJnLCAiLS1oZWxwIikp CisKKyAgICAgICAgaWYgKCFzdHJjbXAoYXJnLCAiLWgiKSB8fCAhc3RyY21wKGFyZywgIi0taGVs cCIpKSB7CiAgICAgICAgICAgICBwcmludFVzYWdlU3RhdGVtZW50KHRydWUpOworICAgICAgICAg ICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgfQogCi0gICAgICAgIGlm ICghc3RyY21wKGFyZywgIi1sIikgfHwgIXN0cmNtcChhcmcsICItLWxlYiIpKQorICAgICAgICBp ZiAoIXN0cmNtcChhcmcsICItbCIpIHx8ICFzdHJjbXAoYXJnLCAiLS1sZWIiKSkgewogICAgICAg ICAgICAgbV9ydW5MRUJUZXN0cyA9IHRydWU7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAg ICAgfQogCi0gICAgICAgIGlmICghc3RyY21wKGFyZywgIi13IikgfHwgIXN0cmNtcChhcmcsICIt LXdlYiIpKQorICAgICAgICBpZiAoIXN0cmNtcChhcmcsICItdyIpIHx8ICFzdHJjbXAoYXJnLCAi LS13ZWIiKSkgewogICAgICAgICAgICAgbV9ydW5XYXNtVGVzdHMgPSB0cnVlOwotICAgIH0KLQot ICAgIGZvciAoOyBpIDwgYXJnYzsgKytpKQotICAgICAgICBtX2FyZ3VtZW50cy5hcHBlbmQoYXJn dltpXSk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQogCisgICAgICAgIGZwcmlu dGYoc3RkZXJyLCAiVW5rbm93biBvcHRpb24gJXNcbiIsIGFyZyk7CisgICAgICAgIHByaW50VXNh Z2VTdGF0ZW1lbnQoZmFsc2UpOworICAgIH0KIH0KIAogU3RhdGljTG9jayBjcmFzaExvY2s7Ci0t IAoyLjkuMwoK