164436 2016-11-04 16:07:44 -0700 Error description code should be able to handle Symbol values. 2016-11-15 16:13:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren jfbastien joepeck keith_miller msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1248341 0 mark.lam 2016-11-04 16:07:44 -0700 Currently, we try to toString() the Symbol value, resulting in it throwing an exception in errorDescriptionForValue() which breaks the invariant that errorDescriptionForValue() should not throw. 1248343 1 mark.lam 2016-11-04 16:08:38 -0700 <rdar://problem/29115583> 1248349 2 293952 mark.lam 2016-11-04 16:14:41 -0700 Created attachment 293952 proposed patch. 1248351 3 293952 saam 2016-11-04 16:16:54 -0700 Comment on attachment 293952 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=293952&action=review > JSTests/stress/error-description-on-symbols-should-not-crash.js:4 > +} catch (e) { What's the error message show here? Can you add a test that asserts. 1248352 4 mark.lam 2016-11-04 16:17:51 -0700 (In reply to comment #3) > Comment on attachment 293952 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=293952&action=review > > > JSTests/stress/error-description-on-symbols-should-not-crash.js:4 > > +} catch (e) { > > What's the error message show here? Can you add a test that asserts. That's a good idea. I will update the test. 1248359 5 293957 mark.lam 2016-11-04 16:24:46 -0700 Created attachment 293957 patch for landing. 1248392 6 mark.lam 2016-11-04 17:51:36 -0700 Thanks for the reviews. Landed in r208410: <http://trac.webkit.org/r208410>. 1251293 7 293957 joepeck 2016-11-14 17:45:11 -0800 Comment on attachment 293957 patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=293957&action=review > JSTests/stress/error-description-on-symbols-should-not-crash.js:1 > +//@ runFTLNoCJIT Any particular reason this is here? I'm wondering so I can know when I should add it in future tests myself. 1251702 8 mark.lam 2016-11-15 16:13:25 -0800 (In reply to comment #7) > Comment on attachment 293957 [details] > patch for landing. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=293957&action=review > > > JSTests/stress/error-description-on-symbols-should-not-crash.js:1 > > +//@ runFTLNoCJIT > > Any particular reason this is here? I'm wondering so I can know when I > should add it in future tests myself. "//@ runFTLNoCJIT" means only run with the 1 test configuration that has the FTL but does not use the ConcurrentJIT. The reason I chose this is because this test does not really benefit from running multiple test configurations. So, I only want to run it on one configuration. runFTLNoCJIT is a good one to choose by default. 293952 2016-11-04 16:14:41 -0700 2016-11-04 16:24:46 -0700 proposed patch. bug-164436.patch text/plain 3389 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDg0MDQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTExLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBFcnJvciBkZXNjcmlwdGlvbiBjb2RlIHNob3VsZCBiZSBhYmxlIHRvIGhh bmRsZSBTeW1ib2wgdmFsdWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY0NDM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTExNTU4Mz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9l cnJvci1kZXNjcmlwdGlvbi1vbi1zeW1ib2xzLXNob3VsZC1ub3QtY3Jhc2guanM6IEFkZGVkLgor CiAyMDE2LTExLTAzICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRXZhbENvZGVDYWNoZSBzaG91bGQgbm90IGdpdmUgdXAgaW4gc3RyaWN0IG1vZGUgYW5kIG90 aGVyIGNhc2VzCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9lcnJvci1kZXNjcmlwdGlvbi1vbi1zeW1i b2xzLXNob3VsZC1ub3QtY3Jhc2guanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvZXJy b3ItZGVzY3JpcHRpb24tb24tc3ltYm9scy1zaG91bGQtbm90LWNyYXNoLmpzCShub25leGlzdGVu dCkKKysrIEpTVGVzdHMvc3RyZXNzL2Vycm9yLWRlc2NyaXB0aW9uLW9uLXN5bWJvbHMtc2hvdWxk LW5vdC1jcmFzaC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUgQEAKKy8vQCBydW5GVExO b0NKSVQKK3RyeSB7CisgICAgU3ltYm9sKDEpKCk7Cit9IGNhdGNoIChlKSB7Cit9CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODM3NykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAxNi0x MS0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRXJyb3IgZGVz Y3JpcHRpb24gY29kZSBzaG91bGQgYmUgYWJsZSB0byBoYW5kbGUgU3ltYm9sIHZhbHVlcy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDQzNgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjkxMTU1ODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUHJldmlvdXNseSwgd2UgdHJ5IHRvIHRvU3RyaW5nKCkg dGhlIFN5bWJvbCB2YWx1ZSwgcmVzdWx0aW5nIGluIGl0IHRocm93aW5nIGFuCisgICAgICAgIGV4 Y2VwdGlvbiBpbiBlcnJvckRlc2NyaXB0aW9uRm9yVmFsdWUoKSB3aGljaCBicmVha3MgdGhlIGlu dmFyaWFudCB0aGF0CisgICAgICAgIGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZSgpIHNob3VsZCBu b3QgdGhyb3cuCisKKyAgICAgICAgV2UgZml4ZWQgdGhpcyBieSBtYWtpbmcgZXJyb3JEZXNjcmlw dGlvbkZvclZhbHVlKCkgYXdhcmUgb2YgdGhlIFN5bWJvbCB0eXBlLCBhbmQKKyAgICAgICAgbm90 IHNvIGEgdG9TdHJpbmcoKSBvbiBTeW1ib2wgdmFsdWVzLiAgQWxzbyBmaXhlZCBub3RBRnVuY3Rp b25Tb3VyY2VBcHBlbmRlcigpCisgICAgICAgIHRvIGJ1aWxkIGEgbmljZXIgbWVzc2FnZSBmb3Ig U3ltYm9sIHZhbHVlcy4KKworICAgICAgICAqIHJ1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHA6 CisgICAgICAgIChKU0M6OmVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZSk6CisgICAgICAgIChKU0M6 Om5vdEFGdW5jdGlvblNvdXJjZUFwcGVuZGVyKToKKwogMjAxNi0xMS0wMyAgTWFyayBMYW0gIDxt YXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xvbmVkQXJndW1lbnRzIG5lZWQgdG8gYWxz byBzdXBwb3J0IGhhdmVBQmFkVGltZSBtb2RlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAJKHJldmlzaW9uIDIwODM3NykK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4Niw4IEBAIEpTU3RyaW5nKiBlcnJvckRlc2NyaXB0aW9u Rm9yVmFsdWUoRXhlY1MKIHsKICAgICBpZiAodi5pc1N0cmluZygpKQogICAgICAgICByZXR1cm4g anNOb250cml2aWFsU3RyaW5nKGV4ZWMsIG1ha2VTdHJpbmcoJyInLCAgYXNTdHJpbmcodiktPnZh bHVlKGV4ZWMpLCAnIicpKTsKKyAgICBpZiAodi5pc1N5bWJvbCgpKQorICAgICAgICByZXR1cm4g anNOb250cml2aWFsU3RyaW5nKGV4ZWMsIGFzU3ltYm9sKHYpLT5kZXNjcmlwdGl2ZVN0cmluZygp KTsKICAgICBpZiAodi5pc09iamVjdCgpKSB7CiAgICAgICAgIENhbGxEYXRhIGNhbGxEYXRhOwog ICAgICAgICBKU09iamVjdCogb2JqZWN0ID0gYXNPYmplY3Qodik7CkBAIC0xODIsOSArMTg0LDEz IEBAIHN0YXRpYyBTdHJpbmcgbm90QUZ1bmN0aW9uU291cmNlQXBwZW5kZXIKICAgICBidWlsZGVy LmFwcGVuZExpdGVyYWwoIicsICciKTsKICAgICBidWlsZGVyLmFwcGVuZChiYXNlKTsKICAgICBi dWlsZGVyLmFwcGVuZExpdGVyYWwoIicgaXMgIik7Ci0gICAgaWYgKHR5cGUgPT0gVHlwZU9iamVj dCkKLSAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJhbiBpbnN0YW5jZSBvZiAiKTsKLSAg ICBidWlsZGVyLmFwcGVuZChkaXNwbGF5VmFsdWUpOworICAgIGlmICh0eXBlID09IFR5cGVTeW1i b2wpCisgICAgICAgIGJ1aWxkZXIuYXBwZW5kTGl0ZXJhbCgiYSBTeW1ib2wiKTsKKyAgICBlbHNl IHsKKyAgICAgICAgaWYgKHR5cGUgPT0gVHlwZU9iamVjdCkKKyAgICAgICAgICAgIGJ1aWxkZXIu YXBwZW5kTGl0ZXJhbCgiYW4gaW5zdGFuY2Ugb2YgIik7CisgICAgICAgIGJ1aWxkZXIuYXBwZW5k KGRpc3BsYXlWYWx1ZSk7CisgICAgfQogICAgIGJ1aWxkZXIuYXBwZW5kKCcpJyk7CiAKICAgICBy ZXR1cm4gYnVpbGRlci50b1N0cmluZygpOwo= 293957 2016-11-04 16:24:46 -0700 2016-11-04 16:24:46 -0700 patch for landing. bug-164436.patch text/plain 3734 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDg0MDQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTExLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBFcnJvciBkZXNjcmlwdGlvbiBjb2RlIHNob3VsZCBiZSBhYmxlIHRvIGhh bmRsZSBTeW1ib2wgdmFsdWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY0NDM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTExNTU4Mz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBGaWxpcCBQaXpsbyBhbmQgU2FhbSBCYXJhdGkuCisKKyAgICAg ICAgKiBzdHJlc3MvZXJyb3ItZGVzY3JpcHRpb24tb24tc3ltYm9scy1zaG91bGQtbm90LWNyYXNo LmpzOiBBZGRlZC4KKwogMjAxNi0xMS0wMyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIEV2YWxDb2RlQ2FjaGUgc2hvdWxkIG5vdCBnaXZlIHVwIGluIHN0cmlj dCBtb2RlIGFuZCBvdGhlciBjYXNlcwpJbmRleDogSlNUZXN0cy9zdHJlc3MvZXJyb3ItZGVzY3Jp cHRpb24tb24tc3ltYm9scy1zaG91bGQtbm90LWNyYXNoLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVz dHMvc3RyZXNzL2Vycm9yLWRlc2NyaXB0aW9uLW9uLXN5bWJvbHMtc2hvdWxkLW5vdC1jcmFzaC5q cwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9lcnJvci1kZXNjcmlwdGlvbi1vbi1z eW1ib2xzLXNob3VsZC1ub3QtY3Jhc2guanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNyBA QAorLy9AIHJ1bkZUTE5vQ0pJVAorCitmdW5jdGlvbiBzaG91bGRFcXVhbChhY3R1YWwsIGV4cGVj dGVkKSB7CisgICAgaWYgKGFjdHVhbCAhPSBleHBlY3RlZCkgeworICAgICAgICB0aHJvdyAiRVJS T1I6IGV4cGVjdCAiICsgZXhwZWN0ZWQgKyAiLCBhY3R1YWwgIiArIGFjdHVhbDsKKyAgICB9Cit9 CisKK3ZhciBleGNlcHRpb247CisKK3RyeSB7CisgICAgU3ltYm9sKDEpKCk7Cit9IGNhdGNoIChl KSB7CisgICAgZXhjZXB0aW9uID0gZTsKK30KKworc2hvdWxkRXF1YWwoZXhjZXB0aW9uLCAiVHlw ZUVycm9yOiBTeW1ib2woMSkgaXMgbm90IGEgZnVuY3Rpb24uIChJbiAnU3ltYm9sKDEpKCknLCAn U3ltYm9sKDEpJyBpcyBhIFN5bWJvbCkiKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwko cmV2aXNpb24gMjA4NDA0KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE2LTExLTA0ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBFcnJvciBkZXNjcmlwdGlvbiBjb2RlIHNob3VsZCBi ZSBhYmxlIHRvIGhhbmRsZSBTeW1ib2wgdmFsdWVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0NDM2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y OTExNTU4Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBGaWxpcCBQaXpsbyBhbmQgU2FhbSBCYXJh dGkuCisKKyAgICAgICAgUHJldmlvdXNseSwgd2UgdHJ5IHRvIHRvU3RyaW5nKCkgdGhlIFN5bWJv bCB2YWx1ZSwgcmVzdWx0aW5nIGluIGl0IHRocm93aW5nIGFuCisgICAgICAgIGV4Y2VwdGlvbiBp biBlcnJvckRlc2NyaXB0aW9uRm9yVmFsdWUoKSB3aGljaCBicmVha3MgdGhlIGludmFyaWFudCB0 aGF0CisgICAgICAgIGVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZSgpIHNob3VsZCBub3QgdGhyb3cu CisKKyAgICAgICAgV2UgZml4ZWQgdGhpcyBieSBtYWtpbmcgZXJyb3JEZXNjcmlwdGlvbkZvclZh bHVlKCkgYXdhcmUgb2YgdGhlIFN5bWJvbCB0eXBlLCBhbmQKKyAgICAgICAgbm90IHNvIGEgdG9T dHJpbmcoKSBvbiBTeW1ib2wgdmFsdWVzLiAgQWxzbyBmaXhlZCBub3RBRnVuY3Rpb25Tb3VyY2VB cHBlbmRlcigpCisgICAgICAgIHRvIGJ1aWxkIGEgbmljZXIgbWVzc2FnZSBmb3IgU3ltYm9sIHZh bHVlcy4KKworICAgICAgICAqIHJ1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAg IChKU0M6OmVycm9yRGVzY3JpcHRpb25Gb3JWYWx1ZSk6CisgICAgICAgIChKU0M6Om5vdEFGdW5j dGlvblNvdXJjZUFwcGVuZGVyKToKKwogMjAxNi0xMS0wMiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2Fy ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEV2YWxDb2RlQ2FjaGUgc2hvdWxkIG5vdCBnaXZlIHVw IGluIHN0cmljdCBtb2RlIGFuZCBvdGhlciBjYXNlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5jcHAJKHJldmlzaW9uIDIwODQw NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC04Niw2ICs4Niw4IEBAIEpTU3RyaW5nKiBlcnJvckRlc2NyaXB0 aW9uRm9yVmFsdWUoRXhlY1MKIHsKICAgICBpZiAodi5pc1N0cmluZygpKQogICAgICAgICByZXR1 cm4ganNOb250cml2aWFsU3RyaW5nKGV4ZWMsIG1ha2VTdHJpbmcoJyInLCAgYXNTdHJpbmcodikt PnZhbHVlKGV4ZWMpLCAnIicpKTsKKyAgICBpZiAodi5pc1N5bWJvbCgpKQorICAgICAgICByZXR1 cm4ganNOb250cml2aWFsU3RyaW5nKGV4ZWMsIGFzU3ltYm9sKHYpLT5kZXNjcmlwdGl2ZVN0cmlu ZygpKTsKICAgICBpZiAodi5pc09iamVjdCgpKSB7CiAgICAgICAgIENhbGxEYXRhIGNhbGxEYXRh OwogICAgICAgICBKU09iamVjdCogb2JqZWN0ID0gYXNPYmplY3Qodik7CkBAIC0xODIsOSArMTg0 LDEzIEBAIHN0YXRpYyBTdHJpbmcgbm90QUZ1bmN0aW9uU291cmNlQXBwZW5kZXIKICAgICBidWls ZGVyLmFwcGVuZExpdGVyYWwoIicsICciKTsKICAgICBidWlsZGVyLmFwcGVuZChiYXNlKTsKICAg ICBidWlsZGVyLmFwcGVuZExpdGVyYWwoIicgaXMgIik7Ci0gICAgaWYgKHR5cGUgPT0gVHlwZU9i amVjdCkKLSAgICAgICAgYnVpbGRlci5hcHBlbmRMaXRlcmFsKCJhbiBpbnN0YW5jZSBvZiAiKTsK LSAgICBidWlsZGVyLmFwcGVuZChkaXNwbGF5VmFsdWUpOworICAgIGlmICh0eXBlID09IFR5cGVT eW1ib2wpCisgICAgICAgIGJ1aWxkZXIuYXBwZW5kTGl0ZXJhbCgiYSBTeW1ib2wiKTsKKyAgICBl bHNlIHsKKyAgICAgICAgaWYgKHR5cGUgPT0gVHlwZU9iamVjdCkKKyAgICAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kTGl0ZXJhbCgiYW4gaW5zdGFuY2Ugb2YgIik7CisgICAgICAgIGJ1aWxkZXIuYXBw ZW5kKGRpc3BsYXlWYWx1ZSk7CisgICAgfQogICAgIGJ1aWxkZXIuYXBwZW5kKCcpJyk7CiAKICAg ICByZXR1cm4gYnVpbGRlci50b1N0cmluZygpOwo=