164431 2016-11-04 13:59:38 -0700 Implement MallocScribble for bmalloc 2018-02-14 10:35:53 -0800 1 1 1 Unclassified WebKit bmalloc Safari 10 Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=128249 InRadar P2 Normal --- 1 ddkilzer ddkilzer beidson ggaren webkit-bug-importer oldest_to_newest 1248260 0 ddkilzer 2016-11-04 13:59:38 -0700 We should add support for MallocScribble to bmalloc. 1248261 1 webkit-bug-importer 2016-11-04 14:00:00 -0700 <rdar://problem/29118340> 1251992 2 294968 ddkilzer 2016-11-16 13:14:27 -0800 Created attachment 294968 Patch v1 1251994 3 294968 ggaren 2016-11-16 13:32:39 -0800 Comment on attachment 294968 Patch v1 Why do we want to implement scribbling in bmalloc instead of deferring to system malloc? Do we also plan to duplicate the 14 other Malloc* options, or is there something special about scribbling? In general, I think it's best to defer debugging options to a separate implementation -- system malloc or our own -- so that debugging cruft doesn't sneak into high-performance code. For example, I don't think we want to do the m_isMallocScribbleEnabled check in deallocateFastCase. Even if we mark it unlikely, we still increase code size and harm register allocation. I went out of my way to avoid even checking m_isBmallocEnabled in deallocateFastCase. I'd like to keep that code as tight as possible. 1399135 4 294968 beidson 2018-02-14 10:35:53 -0800 Comment on attachment 294968 Patch v1 Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form. If this patch is still important please rebase it and post it for review again. 294968 2016-11-16 13:14:27 -0800 2018-02-14 10:35:53 -0800 Patch v1 bug-164431-20161116131423.patch text/plain 9577 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4NzcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggYWUzNjY2ZDIzMjM3OWFh ODkwMWQwODcxYTNjZDA5Y2U0OTM3NmYwOC4uZjUyMWFmZjc0NWY5ZDE2ZjVkZWZkYmQwNjhlODYx MTI1ZWIyODQwNSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQyIEBACisyMDE2LTExLTE2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IE1hbGxv Y1NjcmliYmxlIGZvciBibWFsbG9jCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xNjQ0 MzE+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTExODM0MD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJtYWxsb2MvQWxsb2NhdG9yLmNwcDoK KyAgICAgICAgKGJtYWxsb2M6OkFsbG9jYXRvcjo6dHJ5QWxsb2NhdGUpOgorICAgICAgICAoYm1h bGxvYzo6QWxsb2NhdG9yOjphbGxvY2F0ZUltcGwpOgorICAgICAgICAoYm1hbGxvYzo6QWxsb2Nh dG9yOjpyZWFsbG9jYXRlKToKKyAgICAgICAgKGJtYWxsb2M6OkFsbG9jYXRvcjo6YWxsb2NhdGVT bG93Q2FzZSk6CisgICAgICAgIC0gRGVwbG95IEJVTkxJS0VMWSghbV9pc0JtYWxsb2NFbmFibGVk KS4KKworICAgICAgICAqIGJtYWxsb2MvQWxsb2NhdG9yLmg6CisgICAgICAgIC0gRGVmYXVsdCB2 YWx1ZSBpbml0aWFsaXphdGlvbiBmb3IgbV9pc0JtYWxsb2NFbmFibGVkLgorCisgICAgICAgICog Ym1hbGxvYy9CUGxhdGZvcm0uaDoKKyAgICAgICAgKEJVTkxJS0VMWSk6IEltcGxlbWVudCBVTkxJ S0VMWSgpIG1hY3JvIGZvciBibWFsbG9jLgorCisgICAgICAgICogYm1hbGxvYy9EZWFsbG9jYXRv ci5jcHA6CisgICAgICAgIChibWFsbG9jOjpEZWFsbG9jYXRvcjo6RGVhbGxvY2F0b3IpOgorICAg ICAgICAoYm1hbGxvYzo6RGVhbGxvY2F0b3I6OmRlYWxsb2NhdGVTbG93Q2FzZSk6CisgICAgICAg ICogYm1hbGxvYy9EZWFsbG9jYXRvci5oOgorICAgICAgICAoYm1hbGxvYzo6RGVhbGxvY2F0b3I6 OmRlYWxsb2NhdGVGYXN0Q2FzZSk6CisgICAgICAgICogYm1hbGxvYy9IZWFwLmNwcDoKKyAgICAg ICAgKGJtYWxsb2M6OkhlYXA6OmRlYWxsb2NhdGVMYXJnZSk6CisgICAgICAgIC0gRGVwbG95IEJV TkxJS0VMWSghbV9pc0JtYWxsb2NFbmFibGVkKS4KKyAgICAgICAgLSBJbXBsZW1lbnQgTWFsbG9j U2NyaWJibGUuCisKKyAgICAgICAgKiBibWFsbG9jL0Vudmlyb25tZW50LmNwcDoKKyAgICAgICAg KGJtYWxsb2M6OmlzTWFsbG9jRW52aXJvbm1lbnRWYXJpYWJsZVNldCk6CisgICAgICAgIChibWFs bG9jOjpFbnZpcm9ubWVudDo6RW52aXJvbm1lbnQpOgorICAgICAgICAoYm1hbGxvYzo6RW52aXJv bm1lbnQ6OmNvbXB1dGVJc01hbGxvY1NjcmliYmxlRW5hYmxlZCk6CisgICAgICAgICogYm1hbGxv Yy9FbnZpcm9ubWVudC5oOgorICAgICAgICAoYm1hbGxvYzo6RW52aXJvbm1lbnQ6OmlzTWFsbG9j U2NyaWJibGVFbmFibGVkKToKKyAgICAgICAgLSBDaGVjayBNYWxsb2NTY3JpYmJsZSBlbnZpcm9u bWVudCB2YXJpYWJsZS4KKwogMjAxNi0xMS0xMCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogCiAgICAgICAgIGJtYWxsb2MgdGhyZWFkcyBzaG91bGQgaGF2ZSBhIG5vbi1kZWZh dWx0IFFvUwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BbGxvY2F0b3IuY3Bw IGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9BbGxvY2F0b3IuY3BwCmluZGV4IGJhZjM4NzY5ZTZj Y2IzNGZhNzZjYWY2YzBkYzAwZjBkMjczMzUxOWYuLjBkNDA5YTEyZDZhNTk4YzUzYThkNjcyOGVj NWJkODA3NmJjOThjMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQWxsb2Nh dG9yLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0FsbG9jYXRvci5jcHAKQEAgLTUy LDcgKzUyLDcgQEAgQWxsb2NhdG9yOjp+QWxsb2NhdG9yKCkKIAogdm9pZCogQWxsb2NhdG9yOjp0 cnlBbGxvY2F0ZShzaXplX3Qgc2l6ZSkKIHsKLSAgICBpZiAoIW1faXNCbWFsbG9jRW5hYmxlZCkK KyAgICBpZiAoQlVOTElLRUxZKCFtX2lzQm1hbGxvY0VuYWJsZWQpKQogICAgICAgICByZXR1cm4g bWFsbG9jKHNpemUpOwogCiAgICAgaWYgKHNpemUgPD0gc21hbGxNYXgpCkBAIC03OCw3ICs3OCw3 IEBAIHZvaWQqIEFsbG9jYXRvcjo6YWxsb2NhdGVJbXBsKHNpemVfdCBhbGlnbm1lbnQsIHNpemVf dCBzaXplLCBib29sIGNyYXNoT25GYWlsdXJlCiB7CiAgICAgQkFTU0VSVChpc1Bvd2VyT2ZUd28o YWxpZ25tZW50KSk7CiAKLSAgICBpZiAoIW1faXNCbWFsbG9jRW5hYmxlZCkgeworICAgIGlmIChC VU5MSUtFTFkoIW1faXNCbWFsbG9jRW5hYmxlZCkpIHsKICAgICAgICAgdm9pZCogcmVzdWx0ID0g bnVsbHB0cjsKICAgICAgICAgaWYgKHBvc2l4X21lbWFsaWduKCZyZXN1bHQsIGFsaWdubWVudCwg c2l6ZSkpIHsKICAgICAgICAgICAgIGlmIChjcmFzaE9uRmFpbHVyZSkKQEAgLTEwMyw3ICsxMDMs NyBAQCB2b2lkKiBBbGxvY2F0b3I6OmFsbG9jYXRlSW1wbChzaXplX3QgYWxpZ25tZW50LCBzaXpl X3Qgc2l6ZSwgYm9vbCBjcmFzaE9uRmFpbHVyZQogCiB2b2lkKiBBbGxvY2F0b3I6OnJlYWxsb2Nh dGUodm9pZCogb2JqZWN0LCBzaXplX3QgbmV3U2l6ZSkKIHsKLSAgICBpZiAoIW1faXNCbWFsbG9j RW5hYmxlZCkgeworICAgIGlmIChCVU5MSUtFTFkoIW1faXNCbWFsbG9jRW5hYmxlZCkpIHsKICAg ICAgICAgdm9pZCogcmVzdWx0ID0gcmVhbGxvYyhvYmplY3QsIG5ld1NpemUpOwogICAgICAgICBp ZiAoIXJlc3VsdCkKICAgICAgICAgICAgIEJDUkFTSCgpOwpAQCAtMTkzLDcgKzE5Myw3IEBAIE5P X0lOTElORSB2b2lkKiBBbGxvY2F0b3I6OmFsbG9jYXRlTG9nU2l6ZUNsYXNzKHNpemVfdCBzaXpl KQogCiB2b2lkKiBBbGxvY2F0b3I6OmFsbG9jYXRlU2xvd0Nhc2Uoc2l6ZV90IHNpemUpCiB7Ci0g ICAgaWYgKCFtX2lzQm1hbGxvY0VuYWJsZWQpIHsKKyAgICBpZiAoQlVOTElLRUxZKCFtX2lzQm1h bGxvY0VuYWJsZWQpKSB7CiAgICAgICAgIHZvaWQqIHJlc3VsdCA9IG1hbGxvYyhzaXplKTsKICAg ICAgICAgaWYgKCFyZXN1bHQpCiAgICAgICAgICAgICBCQ1JBU0goKTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9ibWFsbG9jL2JtYWxsb2MvQWxsb2NhdG9yLmggYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9j L0FsbG9jYXRvci5oCmluZGV4IDI3NTdmMDBhYWUxYzYwY2NlZDVhMmI3NGZlMzc3ZGJkNjBiMDAw OGEuLjdiOTEyY2M4Zjk4OWNiYjVhMDlhN2ZkMzk1ZDg3NzZjZmVhOGU3MTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQWxsb2NhdG9yLmgKKysrIGIvU291cmNlL2JtYWxsb2Mv Ym1hbGxvYy9BbGxvY2F0b3IuaApAQCAtNjQsNyArNjQsNyBAQCBwcml2YXRlOgogICAgIHN0ZDo6 YXJyYXk8QnVtcEFsbG9jYXRvciwgc2l6ZUNsYXNzQ291bnQ+IG1fYnVtcEFsbG9jYXRvcnM7CiAg ICAgc3RkOjphcnJheTxCdW1wUmFuZ2VDYWNoZSwgc2l6ZUNsYXNzQ291bnQ+IG1fYnVtcFJhbmdl Q2FjaGVzOwogCi0gICAgYm9vbCBtX2lzQm1hbGxvY0VuYWJsZWQ7CisgICAgYm9vbCBtX2lzQm1h bGxvY0VuYWJsZWQgeyB0cnVlIH07CiAgICAgRGVhbGxvY2F0b3ImIG1fZGVhbGxvY2F0b3I7CiB9 OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oIGIvU291 cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaAppbmRleCA4ZDc2OGRiNjNmYmRkNTJjODky ODkzNWNkMDZjNWJkYjM0ZDBlOWFiLi4yODA2NWRmNzdmZjk3MzE5MTgzOGMxM2E4NjM0NTU2MjVk OTVhMDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCisr KyBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmgKQEAgLTE5NCwzICsxOTQsMTIg QEAKICNpZiAoQlBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJF RCA+PSAxMDEyMDApIHx8IChCUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMDAwMDApCiAjZGVmaW5lIEJVU0VfT1NfTE9HIDEKICNlbmRpZgorCisv KiBCVU5MSUtFTFkgKi8KKyNpZiAhZGVmaW5lZChCVU5MSUtFTFkpICYmIGRlZmluZWQoX19HTlVD X18pCisjZGVmaW5lIEJVTkxJS0VMWSh4KSBfX2J1aWx0aW5fZXhwZWN0KCEhKHgpLCAwKQorI2Vu ZGlmCisKKyNpZiAhZGVmaW5lZChCVU5MSUtFTFkpCisjZGVmaW5lIEJVTkxJS0VMWSh4KSAoeCkK KyNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9EZWFsbG9jYXRvci5j cHAgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0RlYWxsb2NhdG9yLmNwcAppbmRleCBjNGZiYTEx OTZiYmYyOTkwMjlkYThjODc3MTc2ZTI2NjllOTc4YWJkLi43ZDM4MGQwZmI2Yjc4YjA0MTJiOTA5 YTcwNDhmNmY0ZGIzYmIzODI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Rl YWxsb2NhdG9yLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0RlYWxsb2NhdG9yLmNw cApAQCAtMjgsNyArMjgsNiBAQAogI2luY2x1ZGUgIkRlYWxsb2NhdG9yLmgiCiAjaW5jbHVkZSAi SGVhcC5oIgogI2luY2x1ZGUgIklubGluZS5oIgotI2luY2x1ZGUgIk9iamVjdC5oIgogI2luY2x1 ZGUgIlBlclByb2Nlc3MuaCIKICNpbmNsdWRlIDxhbGdvcml0aG0+CiAjaW5jbHVkZSA8Y3N0ZGxp Yj4KQEAgLTQwLDggKzM5LDkgQEAgbmFtZXNwYWNlIGJtYWxsb2MgewogCiBEZWFsbG9jYXRvcjo6 RGVhbGxvY2F0b3IoSGVhcCogaGVhcCkKICAgICA6IG1faXNCbWFsbG9jRW5hYmxlZChoZWFwLT5l bnZpcm9ubWVudCgpLmlzQm1hbGxvY0VuYWJsZWQoKSkKKyAgICAsIG1faXNNYWxsb2NTY3JpYmJs ZUVuYWJsZWQoaGVhcC0+ZW52aXJvbm1lbnQoKS5pc01hbGxvY1NjcmliYmxlRW5hYmxlZCgpKQog ewotICAgIGlmICghbV9pc0JtYWxsb2NFbmFibGVkKSB7CisgICAgaWYgKEJVTkxJS0VMWSghbV9p c0JtYWxsb2NFbmFibGVkKSkgewogICAgICAgICAvLyBGaWxsIHRoZSBvYmplY3QgbG9nIGluIG9y ZGVyIHRvIGRpc2FibGUgdGhlIGZhc3QgcGF0aC4KICAgICAgICAgd2hpbGUgKG1fb2JqZWN0TG9n LnNpemUoKSAhPSBtX29iamVjdExvZy5jYXBhY2l0eSgpKQogICAgICAgICAgICAgbV9vYmplY3RM b2cucHVzaChudWxscHRyKTsKQEAgLTc3LDcgKzc3LDcgQEAgdm9pZCBEZWFsbG9jYXRvcjo6cHJv Y2Vzc09iamVjdExvZygpCiAKIHZvaWQgRGVhbGxvY2F0b3I6OmRlYWxsb2NhdGVTbG93Q2FzZSh2 b2lkKiBvYmplY3QpCiB7Ci0gICAgaWYgKCFtX2lzQm1hbGxvY0VuYWJsZWQpIHsKKyAgICBpZiAo QlVOTElLRUxZKCFtX2lzQm1hbGxvY0VuYWJsZWQpKSB7CiAgICAgICAgIGZyZWUob2JqZWN0KTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTk0LDYgKzk0LDEyIEBAIHZvaWQgRGVhbGxvY2F0 b3I6OmRlYWxsb2NhdGVTbG93Q2FzZSh2b2lkKiBvYmplY3QpCiAgICAgaWYgKG1fb2JqZWN0TG9n LnNpemUoKSA9PSBtX29iamVjdExvZy5jYXBhY2l0eSgpKQogICAgICAgICBwcm9jZXNzT2JqZWN0 TG9nKGxvY2spOwogCisgICAgaWYgKEJVTkxJS0VMWShtX2lzTWFsbG9jU2NyaWJibGVFbmFibGVk KSkgeworICAgICAgICBzaXplX3Qgc2l6ZUNsYXNzID0gT2JqZWN0KG9iamVjdCkucGFnZSgpLT5z aXplQ2xhc3MoKTsKKyAgICAgICAgc2l6ZV90IHNpemUgPSBvYmplY3RTaXplKHNpemVDbGFzcyk7 CisgICAgICAgIG1lbXNldChvYmplY3QsIDB4NTUsIHNpemUpOworICAgIH0KKwogICAgIG1fb2Jq ZWN0TG9nLnB1c2gob2JqZWN0KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1h bGxvYy9EZWFsbG9jYXRvci5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9EZWFsbG9jYXRvci5o CmluZGV4IDdmY2E5NTYyYzU5OTMyMjMyMTBmMzQ0MjY3YTM4NWE3ZjMyNDEwZmMuLmNjNTlkMGY3 Y2E2Zjc0YzlmNjI1MGMwYTU4NTIzZmRhMDA2NWM2YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFs bG9jL2JtYWxsb2MvRGVhbGxvY2F0b3IuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Rl YWxsb2NhdG9yLmgKQEAgLTI3LDYgKzI3LDggQEAKICNkZWZpbmUgRGVhbGxvY2F0b3JfaAogCiAj aW5jbHVkZSAiRml4ZWRWZWN0b3IuaCIKKyNpbmNsdWRlICJPYmplY3QuaCIKKyNpbmNsdWRlICJT bWFsbFBhZ2UuaCIKICNpbmNsdWRlIDxtdXRleD4KIAogbmFtZXNwYWNlIGJtYWxsb2MgewpAQCAt NTIsNyArNTQsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgZGVhbGxvY2F0ZVNsb3dDYXNlKHZvaWQq KTsKIAogICAgIEZpeGVkVmVjdG9yPHZvaWQqLCBkZWFsbG9jYXRvckxvZ0NhcGFjaXR5PiBtX29i amVjdExvZzsKLSAgICBib29sIG1faXNCbWFsbG9jRW5hYmxlZDsKKyAgICBib29sIG1faXNCbWFs bG9jRW5hYmxlZCB7IHRydWUgfTsKKyAgICBib29sIG1faXNNYWxsb2NTY3JpYmJsZUVuYWJsZWQg eyBmYWxzZSB9OwogfTsKIAogaW5saW5lIGJvb2wgRGVhbGxvY2F0b3I6OmRlYWxsb2NhdGVGYXN0 Q2FzZSh2b2lkKiBvYmplY3QpCkBAIC02NCw2ICs2NywxMiBAQCBpbmxpbmUgYm9vbCBEZWFsbG9j YXRvcjo6ZGVhbGxvY2F0ZUZhc3RDYXNlKHZvaWQqIG9iamVjdCkKICAgICBpZiAobV9vYmplY3RM b2cuc2l6ZSgpID09IG1fb2JqZWN0TG9nLmNhcGFjaXR5KCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAorICAgIGlmIChCVU5MSUtFTFkobV9pc01hbGxvY1NjcmliYmxlRW5hYmxlZCkpIHsKKyAg ICAgICAgc2l6ZV90IHNpemVDbGFzcyA9IE9iamVjdChvYmplY3QpLnBhZ2UoKS0+c2l6ZUNsYXNz KCk7CisgICAgICAgIHNpemVfdCBzaXplID0gb2JqZWN0U2l6ZShzaXplQ2xhc3MpOworICAgICAg ICBtZW1zZXQob2JqZWN0LCAweDU1LCBzaXplKTsKKyAgICB9CisKICAgICBtX29iamVjdExvZy5w dXNoKG9iamVjdCk7CiAgICAgcmV0dXJuIHRydWU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0Vudmlyb25tZW50LmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52 aXJvbm1lbnQuY3BwCmluZGV4IDBkOTUwNzEwMzRhNjg3NzVmMmUwOWJjNjMyYzhiMmVmZmNiNGFh NmEuLmIyZDA3YTk5MzhiNzY2NmU2OWEwNjIyODhjMWQ1YTAzMTNhZDVhYzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCisrKyBiL1NvdXJjZS9ibWFs bG9jL2JtYWxsb2MvRW52aXJvbm1lbnQuY3BwCkBAIC00Niw3ICs0Niw3IEBAIHN0YXRpYyBib29s IGlzTWFsbG9jRW52aXJvbm1lbnRWYXJpYWJsZVNldCgpCiAgICAgICAgICJNYWxsb2NTdGFja0xv Z2dpbmciLAogICAgICAgICAiTWFsbG9jU3RhY2tMb2dnaW5nTm9Db21wYWN0IiwKICAgICAgICAg Ik1hbGxvY1N0YWNrTG9nZ2luZ0RpcmVjdG9yeSIsCi0gICAgICAgICJNYWxsb2NTY3JpYmJsZSIs CisgICAgICAgICJNYWxsb2NQcmVTY3JpYmJsZSIsCiAgICAgICAgICJNYWxsb2NDaGVja0hlYXBT dGFydCIsCiAgICAgICAgICJNYWxsb2NDaGVja0hlYXBFYWNoIiwKICAgICAgICAgIk1hbGxvY0No ZWNrSGVhcFNsZWVwIiwKQEAgLTEwOSw2ICsxMDksNyBAQCBzdGF0aWMgYm9vbCBpc1Nhbml0aXpl ckVuYWJsZWQoKQogCiBFbnZpcm9ubWVudDo6RW52aXJvbm1lbnQoKQogICAgIDogbV9pc0JtYWxs b2NFbmFibGVkKGNvbXB1dGVJc0JtYWxsb2NFbmFibGVkKCkpCisgICAgLCBtX2lzTWFsbG9jU2Ny aWJibGVFbmFibGVkKGNvbXB1dGVJc01hbGxvY1NjcmliYmxlRW5hYmxlZCgpKQogewogfQogCkBA IC0xMjMsNCArMTI0LDEyIEBAIGJvb2wgRW52aXJvbm1lbnQ6OmNvbXB1dGVJc0JtYWxsb2NFbmFi bGVkKCkKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorYm9vbCBFbnZpcm9ubWVudDo6Y29tcHV0ZUlz TWFsbG9jU2NyaWJibGVFbmFibGVkKCkKK3sKKyAgICBpZiAoZ2V0ZW52KCJNYWxsb2NTY3JpYmJs ZSIpKQorICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIHJldHVybiBmYWxzZTsKK30KKwogfSAv LyBuYW1lc3BhY2UgYm1hbGxvYwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9F bnZpcm9ubWVudC5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9FbnZpcm9ubWVudC5oCmluZGV4 IDg4Nzc3NmQ1NzA4YzZmZGVmYTVkMWQxOTM5YTdkNjIzOTI0MjRhYjAuLjExYWE3MDhiYzViYzk4 OGIxMTlmOGVlYmE2NDhiMjA1NTE5ZDc3NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2Jt YWxsb2MvRW52aXJvbm1lbnQuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0Vudmlyb25t ZW50LmgKQEAgLTMxLDEzICszMSwxNiBAQCBuYW1lc3BhY2UgYm1hbGxvYyB7CiBjbGFzcyBFbnZp cm9ubWVudCB7CiBwdWJsaWM6CiAgICAgRW52aXJvbm1lbnQoKTsKLSAgICAKKwogICAgIGJvb2wg aXNCbWFsbG9jRW5hYmxlZCgpIHsgcmV0dXJuIG1faXNCbWFsbG9jRW5hYmxlZDsgfQorICAgIGJv b2wgaXNNYWxsb2NTY3JpYmJsZUVuYWJsZWQoKSB7IHJldHVybiBtX2lzTWFsbG9jU2NyaWJibGVF bmFibGVkOyB9CiAKIHByaXZhdGU6CiAgICAgYm9vbCBjb21wdXRlSXNCbWFsbG9jRW5hYmxlZCgp OworICAgIGJvb2wgY29tcHV0ZUlzTWFsbG9jU2NyaWJibGVFbmFibGVkKCk7CiAKLSAgICBib29s IG1faXNCbWFsbG9jRW5hYmxlZDsKKyAgICBib29sIG1faXNCbWFsbG9jRW5hYmxlZCB7IHRydWUg fTsKKyAgICBib29sIG1faXNNYWxsb2NTY3JpYmJsZUVuYWJsZWQgeyBmYWxzZSB9OwogfTsKIAog fSAvLyBuYW1lc3BhY2UgYm1hbGxvYwpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9IZWFwLmNwcCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvSGVhcC5jcHAKaW5kZXggMGJiNjVl N2IyMjYxY2ViZWUxNDI2Mjk0MGFlZGYwMzk1ZmVmODFkMi4uZWZmNzk5YTU2MTAxZTcyYTkyMzQw YTA2OGQ3ZjBiODU4MDIxNDQzZSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9I ZWFwLmNwcAorKysgYi9Tb3VyY2UvYm1hbGxvYy9ibWFsbG9jL0hlYXAuY3BwCkBAIC00MDEsNiAr NDAxLDggQEAgdm9pZCBIZWFwOjpzaHJpbmtMYXJnZShzdGQ6OmxvY2tfZ3VhcmQ8U3RhdGljTXV0 ZXg+JiwgY29uc3QgUmFuZ2UmIG9iamVjdCwgc2l6ZV8KIHZvaWQgSGVhcDo6ZGVhbGxvY2F0ZUxh cmdlKHN0ZDo6bG9ja19ndWFyZDxTdGF0aWNNdXRleD4mLCB2b2lkKiBvYmplY3QpCiB7CiAgICAg c2l6ZV90IHNpemUgPSBtX2xhcmdlQWxsb2NhdGVkLnJlbW92ZShvYmplY3QpOworICAgIGlmIChC VU5MSUtFTFkobV9lbnZpcm9ubWVudC5pc01hbGxvY1NjcmliYmxlRW5hYmxlZCgpKSkKKyAgICAg ICAgbWVtc2V0KG9iamVjdCwgMHg1NSwgc2l6ZSk7CiAgICAgbV9sYXJnZUZyZWUuYWRkKExhcmdl UmFuZ2Uob2JqZWN0LCBzaXplLCBzaXplKSk7CiAgICAgCiAgICAgbV9zY2F2ZW5nZXIucnVuKCk7 Cg==