16441 2007-12-14 14:37:47 -0800 Support for saving js stack trace to file 2014-12-14 20:02:12 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID InRadar P2 Enhancement --- 1 vicki webkit-unassigned burg kmccullough oldest_to_newest 64211 0 vicki 2007-12-14 14:37:47 -0800 I'd like to be able to save a javascript stack trace to a file from within Drosera. Ideally it would show me the function body as well as the function name. 64212 1 vicki 2007-12-14 14:39:06 -0800 <rdar://problem/5645672> 69117 2 18857 sajesh.ramachandran 2008-02-01 15:13:31 -0800 Created attachment 18857 enable webkit to save javascript trace from inspector window changes are done in 1. inspector.html/inspector.js - to add the check box to toggle the functionlity 2. InspectorController.cpp/InspectorController.h - to save the log 69145 3 18863 sajesh.ramachandran 2008-02-01 17:24:20 -0800 Created attachment 18863 patch that saves the JS trace to file 69146 4 sajesh.ramachandran 2008-02-01 17:26:40 -0800 (In reply to comment #0) > I'd like to be able to save a javascript stack trace to a file from within > Drosera. Ideally it would show me the function body as well as the function > name. > the saving function is there in JavaScriptCore/kjs/function.cpp. Currently these changes are integrated with the Inspector window. This can also be done from Drosera. 73685 5 18857 aroben 2008-03-13 22:51:04 -0700 Comment on attachment 18857 enable webkit to save javascript trace from inspector window Thanks for the patch! Patches need to be marked r? in order to be reviewed. You need to explain the changes you made in your ChangeLog. You should also set the CHANGE_LOG_NAME and CHANGE_LOG_EMAIL_ADDRESS environment variables so that prepare-ChangeLog will generate a correct ChangeLog header. This patch puts a lot of CoreFoundation-specific code into a cross-platform source file, InspectorController.cpp. We should be using WebCore's cross-platform functions/types instead. We don't normally put in comments referencing the bug report that motivated the addition of the code. I think this feature would make a lot more sense in the Inspector if we had an integrated JavaScript debugger (see bug 17134). Until then it makes more sense in Drosera. We probably want to present a file picker to the user so that they can choose where to save the file instead of saving to an arbitrary file in a Mac-specific location (we want this to work on non-Mac platforms as well). Please read our code style guidelines at <http://webkit.org/coding/coding-style.html> and make sure your code conforms to them. 73686 6 18863 aroben 2008-03-13 22:51:43 -0700 Comment on attachment 18863 patch that saves the JS trace to file I'm not sure we want to save the stack trace for every function that's called. That seems a bit overkill. And the user of environment variables to set the location seems rather fragile. 75050 7 timothy 2008-03-24 20:08:40 -0700 I am not sure this is needed once we have console.trace() (bug 14354) and fast in-process debugging (bug 17134, bug 17770, bug 17778). 80725 8 timothy 2008-05-17 09:44:50 -0700 This also sounds like functionality a JavaScript profiler would provide. We are in the process of adding a profiler. 18857 2008-02-01 15:13:31 -0800 2010-06-10 15:37:42 -0700 enable webkit to save javascript trace from inspector window patch-16441.txt text/plain 5649 sajesh.ramachandran SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI5OTI3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNDQgQEAKKzIwMDgtMDIt MDEgIGFwcGxlICA8c2V0IEVNQUlMX0FERFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8g VEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBwYWdlL0luc3BlY3RvckNv bnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dG9nZ2xlSlN0cmFjZSk6CisgICAgICAg IChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjp0b2dnbGVKU1RyYWNlKToKKyAgICAgICAg KiBwYWdlL0luc3BlY3RvckNvbnRyb2xsZXIuaDoKKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9p bnNwZWN0b3IuaHRtbDoKKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanM6CisK IApJbmRleDogcGFnZS9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwYWdl L0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAyOTg3OCkKKysrIHBhZ2UvSW5zcGVj dG9yQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwLDYgKzYwLDggQEAKICNpbmNs dWRlIDxKYXZhU2NyaXB0Q29yZS9KU1JldGFpblB0ci5oPgogI2luY2x1ZGUgPEphdmFTY3JpcHRD b3JlL0pTU3RyaW5nUmVmLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KKyNpbmNsdWRl IDxKYXZhU2NyaXB0Q29yZS9KU1N0cmluZ1JlZkNGLmg+CisjaW1wb3J0IDxBcHBsaWNhdGlvblNl cnZpY2VzL0FwcGxpY2F0aW9uU2VydmljZXMuaD4KIAorCitzdGF0aWMgSlNWYWx1ZVJlZiB0b2dn bGVKU3RyYWNlKEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVmIC8qZnVuY3Rpb24qLywgSlNP YmplY3RSZWYgdGhpc09iamVjdCwgc2l6ZV90IGFyZ3VtZW50Q291bnQsIGNvbnN0IEpTVmFsdWVS ZWYgYXJndW1lbnRzW10sIEpTVmFsdWVSZWYqIC8qZXhjZXB0aW9uKi8pCit7CisgICAgSW5zcGVj dG9yQ29udHJvbGxlciogY29udHJvbGxlciA9IHJlaW50ZXJwcmV0X2Nhc3Q8SW5zcGVjdG9yQ29u dHJvbGxlcio+KEpTT2JqZWN0R2V0UHJpdmF0ZSh0aGlzT2JqZWN0KSk7CisgICAgaWYgKCFjb250 cm9sbGVyKQorICAgICAgICByZXR1cm4gSlNWYWx1ZU1ha2VVbmRlZmluZWQoY3R4KTsKKworICAg IGlmIChhcmd1bWVudENvdW50IDwgMSB8fCAhSlNWYWx1ZUlzQm9vbGVhbihjdHgsIGFyZ3VtZW50 c1swXSkpCisgICAgICAgIHJldHVybiBKU1ZhbHVlTWFrZVVuZGVmaW5lZChjdHgpOworCisgICAg Ym9vbCB0b2dnbGUgPSBKU1ZhbHVlVG9Cb29sZWFuKCBjdHgsIGFyZ3VtZW50c1swXSApOworICAg IGNvbnRyb2xsZXItPnRvZ2dsZUpTVHJhY2UodG9nZ2xlKTsKKworICAgIHJldHVybiBKU1ZhbHVl TWFrZVVuZGVmaW5lZChjdHgpOworfQorCiAKQEAgLTc1NSw2ICs4ODcsNyBAQCB2b2lkIEluc3Bl Y3RvckNvbnRyb2xsZXI6OndpbmRvd1NjcmlwdE9iCiAgICAgICAgIHsgIndpbmRvd1VubG9hZGlu ZyIsIHVubG9hZGluZywga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCiAgICAgICAgIHsgImF0 dGFjaCIsIGF0dGFjaCwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCiAgICAgICAgIHsgImRl dGFjaCIsIGRldGFjaCwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCiAgICAgICAgIHsgInNl YXJjaCIsIHNlYXJjaCwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCiAjaWYgRU5BQkxFKERB VEFCQVNFKQogICAgICAgICB7ICJkYXRhYmFzZVRhYmxlTmFtZXMiLCBkYXRhYmFzZVRhYmxlTmFt ZXMsIGtKU1Byb3BlcnR5QXR0cmlidXRlTm9uZSB9LApAQCAtNzYzLDYgKzg5NiwxMCBAQCB2b2lk IEluc3BlY3RvckNvbnRyb2xsZXI6OndpbmRvd1NjcmlwdE9iCiAgICAgICAgIHsgImxvY2FsaXpl ZFN0cmluZ3NVUkwiLCBsb2NhbGl6ZWRTdHJpbmdzLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUg fSwKICAgICAgICAgeyAicGxhdGZvcm0iLCBwbGF0Zm9ybSwga0pTUHJvcGVydHlBdHRyaWJ1dGVO b25lIH0sCiAgICAgICAgIHsgIm1vdmVCeVVucmVzdHJpY3RlZCIsIG1vdmVCeVVucmVzdHJpY3Rl ZCwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCisgICAgICAgIHsgInRvZ2dsZUpTdHJhY2Ui LCB0b2dnbGVKU3RyYWNlLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5vbmUgfSwKICAgICAgICAgeyAw LCAwLCAwIH0KICAgICB9OwogCkBAIC0xNTcyLDQgKzE3MDksMjgyIEBAIHZvaWQgSW5zcGVjdG9y Q29udHJvbGxlcjo6bW92ZVdpbmRvd0J5KGYKICAgICBtX3BhZ2UtPmNocm9tZSgpLT5zZXRXaW5k b3dSZWN0KGZyYW1lUmVjdCk7CiB9CiAKKworQ0ZTdHJpbmdSZWYgSW5zcGVjdG9yQ29udHJvbGxl cjo6Z2V0Q3VycmVudFVzZXJIb21lRGlyKCkKK3sKKyAgICBPU0VyciBlcnI7CisgICAgRlNSZWYg cHJlZkZvbGRlclJlZjsKKyAgICBDRlVSTFJlZiBwcmVmVVJMID0gTlVMTDsKKyAgICAKKyAgICBl cnIgPSBGU0ZpbmRGb2xkZXIoa1VzZXJEb21haW4sIGtDdXJyZW50VXNlckZvbGRlclR5cGUsIGtE b250Q3JlYXRlRm9sZGVyLCAmcHJlZkZvbGRlclJlZik7CisgICAgCisgICAgaWYgKGVyciA9PSBu b0VycikgCisgICAgICAgIHByZWZVUkwgPSBDRlVSTENyZWF0ZUZyb21GU1JlZihrQ0ZBbGxvY2F0 b3JTeXN0ZW1EZWZhdWx0LCAmcHJlZkZvbGRlclJlZik7CisgICAgCisgICAgQ0ZTdHJpbmdSZWYg ZnNQYXRoID0gQ0ZVUkxDb3B5RmlsZVN5c3RlbVBhdGggKHByZWZVUkwsIGtDRlVSTFBPU0lYUGF0 aFN0eWxlKTsKKyAgICAKKyAgICByZXR1cm4gZnNQYXRoOworfQorCit2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OnRvZ2dsZUpTVHJhY2UoYm9vbCB0b2dnbGUpCit7CisgICAgLy90byBlbmFibGUg YW5kIGRpc2FibGUgdHJhY2UKKyAgICBDRlN0cmluZ1JlZiBob21lRGlyID0gZ2V0Q3VycmVudFVz ZXJIb21lRGlyKCk7CisgICAgQ0ZNdXRhYmxlU3RyaW5nUmVmIGxvZ0ZpbGUgPSBDRlN0cmluZ0Ny ZWF0ZU11dGFibGUgKGtDRkFsbG9jYXRvckRlZmF1bHQsIDApOworICAgIAorICAgIENGU3RyaW5n QXBwZW5kKGxvZ0ZpbGUsIGhvbWVEaXIpOworICAgIENGU3RyaW5nQXBwZW5kKGxvZ0ZpbGUsIENG U1RSKCIvTGlicmFyeS9Mb2dzL3dlYmtpdC1qYXZhc2NyaXB0LXN0YWNrLXRyYWNlLmxvZyIpKTsK KyAgICBjb25zdCBjaGFyICpsb2dEaXIgPSBDRlN0cmluZ0dldENTdHJpbmdQdHIobG9nRmlsZSwg TlVMTCk7CisgICAgc2V0ZW52KCJKU0hPTUUiLCBsb2dEaXIsIDEpOworICAgIAorICAgIGlmICgg dG9nZ2xlICkgCisgICAgICAgIHNldGVudigiSlNUUkFDRSIsICJZRVMiLCAxKTsKKyAgICBlbHNl CisgICAgICAgIHNldGVudigiSlNUUkFDRSIsICJOTyIsIDEpOworfQorCisKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKSW5kZXg6IHBhZ2UvSW5zcGVjdG9yQ29udHJvbGxlci5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIHBhZ2UvSW5zcGVjdG9yQ29udHJvbGxlci5oCShyZXZpc2lvbiAyOTg3OCkKKysrIHBhZ2Uv SW5zcGVjdG9yQ29udHJvbGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTUsNiArMTE1LDIxIEBA IHB1YmxpYzoKICAgICB2b2lkIGRpZE9wZW5EYXRhYmFzZShEYXRhYmFzZSosIGNvbnN0IFN0cmlu ZyYgZG9tYWluLCBjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmVyc2lvbik7CiAj ZW5kaWYKIAorICAgLy9CdWcgMTY0NDA6IEVSOiBmaWxlIHJlcGxhY2VtZW50IHN1cHBvcnQgJiBC dWcgMTY0NDE6IEVSOiBzdXBwb3J0IGZvciBzYXZpbmcganMgc3RhY2sgdHJhY2UgdG8gZmlsZQor ICAgIHZvaWQgdG9nZ2xlSlNUcmFjZShib29sIHRvZ2dsZSk7CisgICAgQ0ZTdHJpbmdSZWYgZ2V0 Q3VycmVudFVzZXJIb21lRGlyKCk7CisKICAgICBjb25zdCBSZXNvdXJjZXNNYXAmIHJlc291cmNl cygpIGNvbnN0IHsgcmV0dXJuIG1fcmVzb3VyY2VzOyB9CiAKICAgICB2b2lkIG1vdmVXaW5kb3dC eShmbG9hdCB4LCBmbG9hdCB5KSBjb25zdDsKSW5kZXg6IHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rv ci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5odG1sCShyZXZp c2lvbiAyOTg3OCkKKysrIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5odG1sCSh3b3JraW5nIGNv cHkpCkBAIC01NCw2ICs1NCw4IEBAIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE8KIDxib2R5IGNsYXNzPSJkZXRhY2hlZCI+CiAgICAgPGRpdiBpZD0idG9vbGJhciI+CiAg ICAgICAgIDxidXR0b24gaWQ9ImJhY2siIGNsYXNzPSJzcGxpdC1idXR0b24gZmlyc3QiPjxpbWc+ PC9idXR0b24+PGltZyBjbGFzcz0ic3BsaXQtYnV0dG9uLWRpdmlkZXIiPjxidXR0b24gaWQ9ImZv cndhcmQiIGNsYXNzPSJzcGxpdC1idXR0b24gbGFzdCI+PGltZz48L2J1dHRvbj4KKwkJPGlucHV0 IHR5cGU9J2NoZWNrYm94JyB2YWx1ZT0nU2F2ZSBKUycgaWQ9J2Noa0JveCcgdGl0bGU9J1NhdmUg SlMgdHJhY2UnIG9uY2xpY2s9IldlYkluc3BlY3Rvci50b2dnbGVKU3RyYWNlKCkiPjwvaW5wdXQ+ CisJCTxsYWJlbCBmb3I9J2Noa0JveCc+U2F2ZSBKUyB0cmFjZTwvbGFiZWw+CiAgICAgICAgIDxz cGFuIGlkPSJ0b29sYmFyQnV0dG9ucyI+PC9zcGFuPgogICAgICAgICA8aW5wdXQgaWQ9InNlYXJj aCIgdHlwZT0ic2VhcmNoIiBhdXRvc2F2ZT0iaW5zcGVjdG9yU2VhcmNoIiByZXN1bHRzPSIyMCIg aW5jcmVtZW50YWw9ImluY3JlbWVudGFsIiBvbnNlYXJjaD0iV2ViSW5zcGVjdG9yLnBlcmZvcm1T ZWFyY2godGhpcy52YWx1ZSkiPgogICAgIDwvZGl2PgpJbmRleDogcGFnZS9pbnNwZWN0b3IvaW5z cGVjdG9yLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvaW5zcGVjdG9yL2luc3BlY3Rvci5qcwkocmV2 aXNpb24gMjk4NzgpCisrKyBwYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanMJKHdvcmtpbmcgY29w eSkKQEAgLTExODQsMyArMTE4NCw1OSBAQCBXZWJJbnNwZWN0b3IuTUlNRVR5cGVzID0gewogICAg ICJ0ZXh0L2pzY3JpcHQiOiAgICAgICAgICAgICAgICB7NDogdHJ1ZX0sCiAgICAgInRleHQvbGl2 ZXNjcmlwdCI6ICAgICAgICAgICAgIHs0OiB0cnVlfSwKIH0KCitXZWJJbnNwZWN0b3IudG9nZ2xl SlN0cmFjZSA9IGZ1bmN0aW9uKCkKK3sKKwlpZiAoIGV2ZW50LnRhcmdldC5jaGVja2VkICkKKwl7 CisJCUluc3BlY3RvckNvbnRyb2xsZXIudG9nZ2xlSlN0cmFjZSggdHJ1ZSApIDsKKwl9CisJZWxz ZQorCXsKKwkJSW5zcGVjdG9yQ29udHJvbGxlci50b2dnbGVKU3RyYWNlKCBmYWxzZSApIDsKKwl9 Cit9CisK 18863 2008-02-01 17:24:20 -0800 2008-03-13 22:51:07 -0700 patch that saves the JS trace to file patch-16441-JSCore.txt text/plain 1061 sajesh.ramachandran PyAgICAgIHBhdGNoSlMudHh0CkluZGV4OiBranMvZnVuY3Rpb24uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGtqcy9mdW5jdGlvbi5jcHAJKHJldmlzaW9uIDI5ODc4KQorKysga2pzL2Z1bmN0aW9uLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNzIsNiArNzIsMjEgQEAgdm9pZCBGdW5jdGlvbkltcDo6bWFyaygp CiAKIEpTVmFsdWUqIEZ1bmN0aW9uSW1wOjpjYWxsQXNGdW5jdGlvbihFeGVjU3RhdGUqIGV4ZWMs IEpTT2JqZWN0KiB0aGlzT2JqLCBjb25zdCBMaXN0JiBhcmdzKQogeworICAgLy9CdWcgMTY0NDE6 IEVSOiBzdXBwb3J0IGZvciBzYXZpbmcganMgc3RhY2sgdHJhY2UgdG8gZmlsZSB+L0xpYnJhcnkv TG9ncy93ZWJraXQtamF2YXNjcmlwdC1zdGFjay10cmFjZS5sb2cKKyAgIGNoYXIgKmV2ID0gZ2V0 ZW52KCJKU1RSQUNFIik7CisgICBpZiAoZXYgJiYgIXN0cmNtcChldiwgIllFUyIpKSB7CisgICAg ICAgIEZJTEUgKnBGaWxlOworICAgICAgICBjaGFyICpmaWxlTmFtZSA9IGdldGVudigiSlNIT01F Iik7CisgICAgICAgIGNoYXIgYnVmZmVyW3N0cmxlbih0b1N0cmluZyhleGVjKS5hc2NpaSgpKV07 CisgICAgICAgIHN0cmNweShidWZmZXIsIHRvU3RyaW5nKGV4ZWMpLmFzY2lpKCkpOworICAgICAg ICBwRmlsZT1mb3BlbiAoZmlsZU5hbWUsICJhIik7CisgICAgICAgIHNldGJ1ZiggcEZpbGUgLCBi dWZmZXIgKTsKKyAgICAgICAgZnB1dHMoYnVmZmVyLCBwRmlsZSk7CisgICAgICAgIGZmbHVzaChw RmlsZSk7ICAgIAorICAgICAgICBmY2xvc2UocEZpbGUpOworICAgICAgICBmcmVlKGZpbGVOYW1l KTsKKyAgICB9CisKICAgICBGdW5jdGlvbkV4ZWNTdGF0ZSBuZXdFeGVjKGV4ZWMtPmR5bmFtaWNH bG9iYWxPYmplY3QoKSwgdGhpc09iaiwgYm9keS5nZXQoKSwgZXhlYywgdGhpcywgYXJncyk7CiAg ICAgSlNWYWx1ZSogcmVzdWx0ID0gYm9keS0+ZXhlY3V0ZSgmbmV3RXhlYyk7CiAgICAgaWYgKG5l d0V4ZWMuY29tcGxldGlvblR5cGUoKSA9PSBUaHJvdykgewo=