164396 2016-11-03 19:39:02 -0700 Add an assertion to diagnose stress GC bots test failures 2016-11-03 20:49:55 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 154907 1 rniwa rniwa cdumez commit-queue dbates esprehn+autocc kangil.han oldest_to_newest 1247994 0 rniwa 2016-11-03 19:39:02 -0700 Somehow we're hitting an assertion in ElementQueue::invokeAll. As far as I understand, this assertion should only fire when ElementQueue::add is called while we're inside invokeAll. Add an assertion to figure out where this is happening because I can't reproduce locally. <rdar://problem/28945851> 1248001 1 293847 rniwa 2016-11-03 19:52:27 -0700 Created attachment 293847 Adds an assertion 1248002 2 293847 koivisto 2016-11-03 19:55:14 -0700 Comment on attachment 293847 Adds an assertion View in context: https://bugs.webkit.org/attachment.cgi?id=293847&action=review > Source/WebCore/dom/CustomElementReactionQueue.cpp:210 > +#if !ASSERT_DISABLED > + ASSERT(!m_invoking); > +#endif Don't need ASSERT_DISABLED test here. 1248005 3 293848 rniwa 2016-11-03 20:01:39 -0700 Created attachment 293848 Patch for landing 1248015 4 commit-queue 2016-11-03 20:49:27 -0700 The commit-queue encountered the following flaky tests while processing attachment 293848: inspector/sampling-profiler/call-frame-with-dom-functions.html bug 164399 (author: sbarati@apple.com) The commit-queue is continuing to process your patch. 1248016 5 293848 commit-queue 2016-11-03 20:49:50 -0700 Comment on attachment 293848 Patch for landing Clearing flags on attachment: 293848 Committed r208366: <http://trac.webkit.org/changeset/208366> 1248017 6 commit-queue 2016-11-03 20:49:55 -0700 All reviewed patches have been landed. Closing bug. 293847 2016-11-03 19:52:27 -0700 2016-11-03 20:01:33 -0700 Adds an assertion bug-164396-20161103194826.patch text/plain 2447 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNkZmRkNzA2MWFmOTg2 ZGEwMjhkZjNmMGIwYTFhOTJhODcyZjMyNS4uYWQwY2Q2MTdmYzgxYjAyNjNjMThhMmY2OGNmZTI1 MGIxMjA2OTU3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTExLTAzICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24g dG8gZGlhZ25vc2Ugc3RyZXNzIEdDIGJvdHMgdGVzdCBmYWlsdXJlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0Mzk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYW4gYXNzZXJ0aW9uIGZvciBj YWxsaW5nIEVsZW1lbnRRdWV1ZTo6YWRkIHdoaWxlIEVsZW1lbnRRdWV1ZTo6aW52b2tlQWxsIGlz IGluIHByb2dyZXNzLgorICAgICAgICBUaGlzIHNob3VsZCBuZXZlciBoYXBwZW4gYXMgbG9uZyBh cyBhbGwgRE9NIEFQSSBoYXMgYW4gYXBwcm9wcmlhdGUgQ0VSZWFjdGlvbnMgSURMIGF0dHJpYnV0 ZS4KKworICAgICAgICAqIGRvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6RWxlbWVudFF1ZXVlOjph ZGQpOgorICAgICAgICAoV2ViQ29yZTo6Q3VzdG9tRWxlbWVudFJlYWN0aW9uU3RhY2s6OkVsZW1l bnRRdWV1ZTo6aW52b2tlQWxsKToKKyAgICAgICAgKiBkb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9u UXVldWUuaDoKKwogMjAxNi0xMS0wMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggQ0xvb3AgYnVpbGQgYWZ0ZXIgcjIwODMy MC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25R dWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUu Y3BwCmluZGV4IDY0Y2JiZjk4OGIyNDUxZGUxNTUwNDNkYWM3NjBjN2ViMzM4YjllZjUuLmFhM2Iy YmEwYjIxMGZjNmFjZGUwMTg4MWU4Mjk5NTA4NWIyZjAzM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNwcApAQCAtMjA1LDEyICsyMDUs MTggQEAgdm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZTo6aW52b2tlQWxsKEVsZW1lbnQm IGVsZW1lbnQpCiAKIGlubGluZSB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlvblN0YWNrOjpFbGVt ZW50UXVldWU6OmFkZChFbGVtZW50JiBlbGVtZW50KQogeworI2lmICFBU1NFUlRfRElTQUJMRUQK KyAgICBBU1NFUlQoIW1faW52b2tpbmcpOworI2VuZGlmCiAgICAgLy8gRklYTUU6IEF2b2lkIGlu c2VydGluZyB0aGUgc2FtZSBlbGVtZW50IG11bHRpcGxlIHRpbWVzLgogICAgIG1fZWxlbWVudHMu YXBwZW5kKGVsZW1lbnQpOwogfQogCiBpbmxpbmUgdm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25T dGFjazo6RWxlbWVudFF1ZXVlOjppbnZva2VBbGwoKQogeworI2lmICFBU1NFUlRfRElTQUJMRUQK KyAgICBUZW1wb3JhcnlDaGFuZ2U8Ym9vbD4gaW52b2tpbmcobV9pbnZva2luZyk7CisjZW5kaWYK ICAgICBWZWN0b3I8UmVmPEVsZW1lbnQ+PiBlbGVtZW50czsKICAgICBlbGVtZW50cy5zd2FwKG1f ZWxlbWVudHMpOwogICAgIGZvciAoYXV0byYgZWxlbWVudCA6IGVsZW1lbnRzKSB7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUuaCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5oCmluZGV4IDE4NTQ5 ZmVhZTBmMjA3YmI2M2JkYWU2MTE3N2ExMDg4ZjVhMGYzZDQuLmZhZTZkZTg5Yzg3ODE2NDY0MGMw MWRhMTVkMjBmZGJiNzdjODZlNjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0 b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21F bGVtZW50UmVhY3Rpb25RdWV1ZS5oCkBAIC04OSw2ICs4OSw5IEBAIHByaXZhdGU6CiAKICAgICBw cml2YXRlOgogICAgICAgICBWZWN0b3I8UmVmPEVsZW1lbnQ+PiBtX2VsZW1lbnRzOworI2lmICFB U1NFUlRfRElTQUJMRUQKKyAgICAgICAgYm9vbCBtX2ludm9raW5nIHsgZmFsc2UgfTsKKyNlbmRp ZgogICAgIH07CiAKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHByb2Nlc3NRdWV1ZSgpOwo= 293848 2016-11-03 20:01:39 -0700 2016-11-03 20:49:50 -0700 Patch for landing bug-164396-20161103195737.patch text/plain 2417 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNkZmRkNzA2MWFmOTg2 ZGEwMjhkZjNmMGIwYTFhOTJhODcyZjMyNS4uYjc5YmViMDQxM2MwZWI5OGQzYjdiZDBiZDM2NTVk YTdhOTBmY2VlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTExLTAzICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBhbiBhc3NlcnRpb24g dG8gZGlhZ25vc2Ugc3RyZXNzIEdDIGJvdHMgdGVzdCBmYWlsdXJlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0Mzk2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQW50dGkgS29pdmlzdG8uCisKKyAgICAgICAgQWRkZWQgYW4gYXNzZXJ0aW9uIGZvciBj YWxsaW5nIEVsZW1lbnRRdWV1ZTo6YWRkIHdoaWxlIEVsZW1lbnRRdWV1ZTo6aW52b2tlQWxsIGlz IGluIHByb2dyZXNzLgorICAgICAgICBUaGlzIHNob3VsZCBuZXZlciBoYXBwZW4gYXMgbG9uZyBh cyBhbGwgRE9NIEFQSSBoYXMgYW4gYXBwcm9wcmlhdGUgQ0VSZWFjdGlvbnMgSURMIGF0dHJpYnV0 ZS4KKworICAgICAgICAqIGRvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6RWxlbWVudFF1ZXVlOjph ZGQpOgorICAgICAgICAoV2ViQ29yZTo6Q3VzdG9tRWxlbWVudFJlYWN0aW9uU3RhY2s6OkVsZW1l bnRRdWV1ZTo6aW52b2tlQWxsKToKKyAgICAgICAgKiBkb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9u UXVldWUuaDoKKwogMjAxNi0xMS0wMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggQ0xvb3AgYnVpbGQgYWZ0ZXIgcjIwODMy MC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25R dWV1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9tRWxlbWVudFJlYWN0aW9uUXVldWUu Y3BwCmluZGV4IDY0Y2JiZjk4OGIyNDUxZGUxNTUwNDNkYWM3NjBjN2ViMzM4YjllZjUuLmZlN2Q0 OTg1NmI3YzAyODdhZjYzZjA4MjViY2UzMmViYjg4MjI2NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0N1c3RvbUVsZW1lbnRSZWFjdGlvblF1ZXVlLmNwcApAQCAtMjA1LDEyICsyMDUs MTYgQEAgdm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZTo6aW52b2tlQWxsKEVsZW1lbnQm IGVsZW1lbnQpCiAKIGlubGluZSB2b2lkIEN1c3RvbUVsZW1lbnRSZWFjdGlvblN0YWNrOjpFbGVt ZW50UXVldWU6OmFkZChFbGVtZW50JiBlbGVtZW50KQogeworICAgIEFTU0VSVCghbV9pbnZva2lu Zyk7CiAgICAgLy8gRklYTUU6IEF2b2lkIGluc2VydGluZyB0aGUgc2FtZSBlbGVtZW50IG11bHRp cGxlIHRpbWVzLgogICAgIG1fZWxlbWVudHMuYXBwZW5kKGVsZW1lbnQpOwogfQogCiBpbmxpbmUg dm9pZCBDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjazo6RWxlbWVudFF1ZXVlOjppbnZva2VBbGwo KQogeworI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICBUZW1wb3JhcnlDaGFuZ2U8Ym9vbD4gaW52 b2tpbmcobV9pbnZva2luZyk7CisjZW5kaWYKICAgICBWZWN0b3I8UmVmPEVsZW1lbnQ+PiBlbGVt ZW50czsKICAgICBlbGVtZW50cy5zd2FwKG1fZWxlbWVudHMpOwogICAgIGZvciAoYXV0byYgZWxl bWVudCA6IGVsZW1lbnRzKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ3VzdG9t RWxlbWVudFJlYWN0aW9uUXVldWUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50 UmVhY3Rpb25RdWV1ZS5oCmluZGV4IDE4NTQ5ZmVhZTBmMjA3YmI2M2JkYWU2MTE3N2ExMDg4ZjVh MGYzZDQuLmZhZTZkZTg5Yzg3ODE2NDY0MGMwMWRhMTVkMjBmZGJiNzdjODZlNjMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9DdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1ZS5oCkBAIC04OSw2 ICs4OSw5IEBAIHByaXZhdGU6CiAKICAgICBwcml2YXRlOgogICAgICAgICBWZWN0b3I8UmVmPEVs ZW1lbnQ+PiBtX2VsZW1lbnRzOworI2lmICFBU1NFUlRfRElTQUJMRUQKKyAgICAgICAgYm9vbCBt X2ludm9raW5nIHsgZmFsc2UgfTsKKyNlbmRpZgogICAgIH07CiAKICAgICBXRUJDT1JFX0VYUE9S VCB2b2lkIHByb2Nlc3NRdWV1ZSgpOwo=