164370 2016-11-03 10:31:42 -0700 [Win][Direct2D] Native Windows widgets are drawn upside-down 2016-11-03 12:12:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build PC All RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham commit-queue dino pvollan simon.fraser oldest_to_newest 1247747 0 bfulgham 2016-11-03 10:31:42 -0700 The concept of up/down in GDI is inverted compared to Direct2D. We need to properly flip the context of any bitmaps generated by dropping into GDI code paths. 1247748 1 293775 bfulgham 2016-11-03 10:34:39 -0700 Created attachment 293775 Patch 1247750 2 commit-queue 2016-11-03 10:36:57 -0700 Attachment 293775 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1247760 3 293780 bfulgham 2016-11-03 10:54:50 -0700 Created attachment 293780 Patch v2 Correct tabs in Changelog. 1247770 4 293780 achristensen 2016-11-03 11:37:19 -0700 Comment on attachment 293780 Patch v2 lol 1247789 5 293780 commit-queue 2016-11-03 12:12:40 -0700 Comment on attachment 293780 Patch v2 Clearing flags on attachment: 293780 Committed r208339: <http://trac.webkit.org/changeset/208339> 1247790 6 commit-queue 2016-11-03 12:12:45 -0700 All reviewed patches have been landed. Closing bug. 293775 2016-11-03 10:34:39 -0700 2016-11-03 10:54:50 -0700 Patch widgets.patch text/plain 2109 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODMyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTExLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dW0RpcmVjdDJEXSBO YXRpdmUgV2luZG93cyB3aWRnZXRzIGFyZSBkcmF3biB1cHNpZGUtZG93bgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MzcwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlXaGVuIHdlIHJldHVybiBmcm9tIGRyYXdpbmcg aW4gR0RJIGNvZGUsIHdlIG5lZWQgdG8gZmxpcCB0aGUgcmVzdWx0aW5nCisJYml0bWFwIHNvIHRo YXQgaXQgZHJhd3MgaW4gdGhlIHByb3BlciBvcmllbnRhdGlvbiBpbiBEaXJlY3QyRC4KKworICAg ICAgICBUZXN0ZWQgYnkgZXhpc3Rpbmcgd2lkZ2V0IHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dERpcmVjdDJELmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6cmVsZWFzZVdpbmRvd3NDb250ZXh0KTogRmxpcCBiZWZv cmUgZHJhd2luZworCXRvIG91ciBEaXJlY3QyRCBjb250ZXh0LgorCiAyMDE2LTExLTAxICBHYXZp biBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUg UGFnZVRocm90dGxlciAmIGFsbCByZWxhdGVkIGNvZGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHREaXJlY3QyRC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4 dERpcmVjdDJELmNwcAkocmV2aXNpb24gMjA4MjI0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dERpcmVjdDJELmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMjY4LDcgKzI2OCwyMSBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6cmVsZWFzZVdpbmRv d3NDb250CiAgICAgSFJFU1VMVCBociA9IHBsYXRmb3JtQ29udGV4dCgpLT5DcmVhdGVCaXRtYXAo cGl4ZWxEYXRhLnNpemUoKSwgcGl4ZWxEYXRhLmJ1ZmZlcigpLCBwaXhlbERhdGEuYnl0ZXNQZXJS b3coKSwgJmJpdG1hcFByb3BlcnRpZXMsICZiaXRtYXApOwogICAgIEFTU0VSVChTVUNDRUVERUQo aHIpKTsKIAotICAgIHBsYXRmb3JtQ29udGV4dCgpLT5EcmF3Qml0bWFwKGJpdG1hcC5nZXQoKSwg ZHN0UmVjdCk7CisgICAgRDJEQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlcigqbV9kYXRhKTsK KworICAgIC8vIE5vdGU6IFRoZSBjb250ZW50IGluIHRoZSBIREMgaXMgaW52ZXJ0ZWQgY29tcGFy ZWQgdG8gRGlyZWN0MkQsIHNvIGl0IG5lZWRzIHRvIGJlIGZsaXBwZWQuCisgICAgYXV0byBjb250 ZXh0ID0gcGxhdGZvcm1Db250ZXh0KCk7CisKKyAgICBEMkQxX01BVFJJWF8zWDJfRiBjdXJyZW50 VHJhbnNmb3JtOworICAgIGNvbnRleHQtPkdldFRyYW5zZm9ybSgmY3VycmVudFRyYW5zZm9ybSk7 CisKKyAgICBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtKGN1cnJlbnRUcmFuc2Zvcm0pOworICAg IHRyYW5zZm9ybS50cmFuc2xhdGUoZHN0UmVjdC5sb2NhdGlvbigpKTsKKyAgICB0cmFuc2Zvcm0u c2NhbGUoMS4wLCAtMS4wKTsKKyAgICB0cmFuc2Zvcm0udHJhbnNsYXRlKDAsIC1kc3RSZWN0Lmhl aWdodCgpKTsKKworICAgIGNvbnRleHQtPlNldFRyYW5zZm9ybSh0cmFuc2Zvcm0pOworICAgIGNv bnRleHQtPkRyYXdCaXRtYXAoYml0bWFwLmdldCgpLCBEMkQxOjpSZWN0RigwLCAwLCBkc3RSZWN0 LndpZHRoKCksIGRzdFJlY3QuaGVpZ2h0KCkpKTsKIAogICAgIDo6RGVsZXRlREMoaGRjKTsKIH0K 293780 2016-11-03 10:54:50 -0700 2016-11-03 12:12:40 -0700 Patch v2 widgets.patch text/plain 2130 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODMyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTExLTAzICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dW0RpcmVjdDJEXSBO YXRpdmUgV2luZG93cyB3aWRnZXRzIGFyZSBkcmF3biB1cHNpZGUtZG93bgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MzcwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB3ZSByZXR1cm4gZnJvbSBk cmF3aW5nIGluIEdESSBjb2RlLCB3ZSBuZWVkIHRvIGZsaXAgdGhlIHJlc3VsdGluZworICAgICAg ICBiaXRtYXAgc28gdGhhdCBpdCBkcmF3cyBpbiB0aGUgcHJvcGVyIG9yaWVudGF0aW9uIGluIERp cmVjdDJELgorCisgICAgICAgIFRlc3RlZCBieSBleGlzdGluZyB3aWRnZXQgdGVzdHMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0RGlyZWN0MkQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpyZWxlYXNlV2luZG93c0NvbnRl eHQpOiBGbGlwIGJlZm9yZSBkcmF3aW5nCisgICAgICAgIHRvIG91ciBEaXJlY3QyRCBjb250ZXh0 LgorCiAyMDE2LTExLTAxICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNv bT4KIAogICAgICAgICBSZW1vdmUgUGFnZVRocm90dGxlciAmIGFsbCByZWxhdGVkIGNvZGUKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRE aXJlY3QyRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvd2luL0dyYXBoaWNzQ29udGV4dERpcmVjdDJELmNwcAkocmV2aXNpb24gMjA4MjI0KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dERpcmVj dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY4LDcgKzI2OCwyMSBAQCB2b2lkIEdyYXBoaWNz Q29udGV4dDo6cmVsZWFzZVdpbmRvd3NDb250CiAgICAgSFJFU1VMVCBociA9IHBsYXRmb3JtQ29u dGV4dCgpLT5DcmVhdGVCaXRtYXAocGl4ZWxEYXRhLnNpemUoKSwgcGl4ZWxEYXRhLmJ1ZmZlcigp LCBwaXhlbERhdGEuYnl0ZXNQZXJSb3coKSwgJmJpdG1hcFByb3BlcnRpZXMsICZiaXRtYXApOwog ICAgIEFTU0VSVChTVUNDRUVERUQoaHIpKTsKIAotICAgIHBsYXRmb3JtQ29udGV4dCgpLT5EcmF3 Qml0bWFwKGJpdG1hcC5nZXQoKSwgZHN0UmVjdCk7CisgICAgRDJEQ29udGV4dFN0YXRlU2F2ZXIg c3RhdGVTYXZlcigqbV9kYXRhKTsKKworICAgIC8vIE5vdGU6IFRoZSBjb250ZW50IGluIHRoZSBI REMgaXMgaW52ZXJ0ZWQgY29tcGFyZWQgdG8gRGlyZWN0MkQsIHNvIGl0IG5lZWRzIHRvIGJlIGZs aXBwZWQuCisgICAgYXV0byBjb250ZXh0ID0gcGxhdGZvcm1Db250ZXh0KCk7CisKKyAgICBEMkQx X01BVFJJWF8zWDJfRiBjdXJyZW50VHJhbnNmb3JtOworICAgIGNvbnRleHQtPkdldFRyYW5zZm9y bSgmY3VycmVudFRyYW5zZm9ybSk7CisKKyAgICBBZmZpbmVUcmFuc2Zvcm0gdHJhbnNmb3JtKGN1 cnJlbnRUcmFuc2Zvcm0pOworICAgIHRyYW5zZm9ybS50cmFuc2xhdGUoZHN0UmVjdC5sb2NhdGlv bigpKTsKKyAgICB0cmFuc2Zvcm0uc2NhbGUoMS4wLCAtMS4wKTsKKyAgICB0cmFuc2Zvcm0udHJh bnNsYXRlKDAsIC1kc3RSZWN0LmhlaWdodCgpKTsKKworICAgIGNvbnRleHQtPlNldFRyYW5zZm9y bSh0cmFuc2Zvcm0pOworICAgIGNvbnRleHQtPkRyYXdCaXRtYXAoYml0bWFwLmdldCgpLCBEMkQx OjpSZWN0RigwLCAwLCBkc3RSZWN0LndpZHRoKCksIGRzdFJlY3QuaGVpZ2h0KCkpKTsKIAogICAg IDo6RGVsZXRlREMoaGRjKTsKIH0K