16433 2007-12-14 02:40:52 -0800 LOW_BANDWIDTH_DISPLAY build is broken 2007-12-22 12:04:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Normal --- 1 alp webkit-unassigned dacarson klobag oldest_to_newest 64139 0 alp 2007-12-14 02:40:52 -0800 The first breakage was due to the recent KURL url() refactoring. With that fixed, I got this: g++ -c -pipe -D_REENTRANT -I/usr/include -Wall -W -Wcast-align -Wchar-subscripts -Wformat-security -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-format-y2k -Wno-unused-parameter -Wundef -pipe -fno-exceptions -fno-rtti -O2 -D_REENTRANT -I/opt/fdo/include/cairo -I/opt/fdo/include/directfb -I/opt/fdo/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -D_REENTRANT -I/opt/fdo/include/cairo -I/opt/fdo/include/directfb -I/opt/fdo/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -D_REENTRANT -I/opt/fdo/include/cairo -I/opt/fdo/include/directfb -I/opt/fdo/include/pixman-1 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -pthread -DORBIT2=1 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/libxml2 -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -DQT_SHARED -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DUSE_SYSTEM_MALLOC -DNDEBUG -DHAVE_STDINT_H -DBUILD_WEBKIT -DUSE_LOW_BANDWIDTH_DISPLAY=1 -DWTF_USE_LOW_BANDWIDTH_DISPLAY=1 -DENABLE_DATABASE=1 -DENABLE_ICONDATABASE=1 -DENABLE_XPATH=1 -DENABLE_XSLT=1 -DENABLE_SVG=0 -DENABLE_VIDEO=1 -DWTF_CHANGES=1 -DBUILDING_GTK__ -I/usr/share/qt4/mkspecs/linux-g++ -I../../../WebCore -I../../../../webkit -I../../../WebCore/platform/gtk -I../../../WebCore/platform/network/curl -I../../../WebCore/platform/graphics/cairo -I../../../WebCore/loader/gtk -I../../../WebCore/page/gtk -I../../../WebKit/gtk/WebView -I../../../WebKit/gtk/WebCoreSupport -I../../../JavaScriptCore -I../../../JavaScriptCore/kjs -I../../../JavaScriptCore/bindings -I../../../JavaScriptCore/bindings/c -I../../../JavaScriptCore/wtf -I../../../JavaScriptCore/ForwardingHeaders -I../../../WebCore -I../../../WebCore/ForwardingHeaders -I../../../WebCore/platform -I../../../WebCore/platform/network -I../../../WebCore/platform/graphics -I../../../WebCore/loader -I../../../WebCore/page -I../../../WebCore/css -I../../../WebCore/dom -I../../../WebCore/bridge -I../../../WebCore/editing -I../../../WebCore/rendering -I../../../WebCore/history -I../../../WebCore/xml -I../../../WebCore/html -Itmp -Itmp -I../../../JavaScriptCore -I../../../JavaScriptCore/kjs -I../../../JavaScriptCore/bindings -I../../../JavaScriptCore/bindings/c -I../../../JavaScriptCore/wtf -I../../../JavaScriptCore/pcre -I../JavaScriptCore/kjs/tmp -I../../../WebCore/platform/gtk -I../../../WebCore/platform/graphics/gtk -I../../../WebCore/platform/graphics/cairo -I../../../WebCore/svg/graphics/cairo -I../../../WebCore/platform/network/curl -I../../../WebCore/platform/image-decoders -I../../../WebCore/platform/image-decoders/bmp -I../../../WebCore/platform/image-decoders/gif -I../../../WebCore/platform/image-decoders/ico -I../../../WebCore/platform/image-decoders/jpeg -I../../../WebCore/platform/image-decoders/png -I../../../WebCore/platform/image-decoders/xbm -I../../../WebCore/loader/gtk -I../../../WebCore/page/gtk -I../../../WebKit/gtk/WebCoreSupport -I../../../WebKit/gtk/WebView -I../../../WebCore -I../../../WebCore/ForwardingHeaders -I../../../../webkit -I../../../JavaScriptCore/kjs -I../../../JavaScriptCore/bindings -I../../../JavaScriptCore/wtf -I../../../WebCore/platform -I../../../WebCore/platform/network -I../../../WebCore/platform/graphics -I../../../WebCore/svg/graphics -I../../../WebCore/svg/graphics/filters -I../../../WebCore/platform/sql -I../../../WebCore/platform/text -I../../../WebCore/storage -I../../../WebCore/loader -I../../../WebCore/loader/icon -I../../../WebCore/css -I../../../WebCore/dom -I../../../WebCore/page -I../../../WebCore/bridge -I../../../WebCore/editing -I../../../WebCore/rendering -I../../../WebCore/history -I../../../WebCore/xml -I../../../WebCore/html -I../../../WebCore/bindings/js -I../../../WebCore/svg -I../../../WebCore/platform/image-decoders -I/usr/X11R6/include -I../../../WebCore -I. -o tmp/FrameLoader.o ../../../WebCore/loader/FrameLoader.cpp ../../../WebCore/loader/FrameLoader.cpp: In member function ‘bool WebCore::FrameLoader::addLowBandwidthDisplayRequest(WebCore::CachedResource*)’: ../../../WebCore/loader/FrameLoader.cpp:4715: warning: enumeration value ‘FontResource’ not handled in switch ../../../WebCore/loader/FrameLoader.cpp: In member function ‘void WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady()’: ../../../WebCore/loader/FrameLoader.cpp:4780: error: no matching function for call to ‘WebCore::DOMImplementation::createDocument(WebCore::String&, WebCore::FrameView*, bool)’ ../../../WebCore/dom/DOMImplementation.h:50: note: candidates are: WTF::PassRefPtr<WebCore::Document> WebCore::DOMImplementation::createDocument(const WebCore::String&, const WebCore::String&, WebCore::DocumentType*, WebCore::ExceptionCode&) ../../../WebCore/dom/DOMImplementation.h:61: note: WTF::PassRefPtr<WebCore::Document> WebCore::DOMImplementation::createDocument(const WebCore::String&, WebCore::Frame*, bool) ../../../WebCore/dom/DOMImplementation.h:62: note: WTF::PassRefPtr<WebCore::Document> WebCore::DOMImplementation::createDocument(WebCore::Frame*) ../../../WebCore/loader/FrameLoader.cpp:4782: error: no matching function for call to ‘WebCore::Document::setURL(WebCore::String)’ ../../../WebCore/dom/Document.h:365: note: candidates are: void WebCore::Document::setURL(const WebCore::DeprecatedString&) ../../../WebCore/loader/FrameLoader.cpp:4783: error: no matching function for call to ‘WebCore::Document::setBaseURL(WebCore::String)’ ../../../WebCore/dom/Document.h:368: note: candidates are: void WebCore::Document::setBaseURL(const WebCore::DeprecatedString&) ../../../WebCore/loader/FrameLoader.cpp:4787: error: ‘partClearedInBegin’ was not declared in this scope When was the last time someone built this feature? It's a shame for it to fall out of sync :-( I might spend some time looking into this. Could be a fun win for the various mobile ports, maybe even the iPhone port. This issue was noticed with the GTK+ but appears to affect all ports. 64290 1 ddkilzer 2007-12-15 06:08:46 -0800 Bug 12279 implemented this feature. 64346 2 17923 klobag 2007-12-15 20:14:51 -0800 Created attachment 17923 Make LOW_BANDWIDTH_DISPLAY compile The patch should make the project compile and it is what we use. But it doesn't work with Mac port any more. Can someone inside Apple take a look? ASSERTION FAILED: thisDocumentView != nil (/Volumes/Android/appleWebKit/WebKit/WebCoreSupport/WebFrameLoaderClient.mm:222 forceLayoutForNonHTML) 64390 3 17923 darin 2007-12-16 10:19:16 -0800 Comment on attachment 17923 Make LOW_BANDWIDTH_DISPLAY compile The rest of the changes look fine, but the change to FrameLoader doesn't seem to have anything to do with LOW_BANDWIDTH_DISPLAY. I'm guessing that for some reason Android derives a subclass from FrameLoader. That doesn't sound like a good idea to me, but also seems unrelated to LOW_BANDWIDTH_DISPLAY so should not be controlled by the same ifdef. 64425 4 klobag 2007-12-16 15:32:46 -0800 The change in the FrameLoader.h was in the original patch. Android doesn't need it. But we discovered that we had to add it to avoid crash in the Mac port back then. I am happy to remove it. (In reply to comment #3) > (From update of attachment 17923 [edit]) > The rest of the changes look fine, but the change to FrameLoader doesn't seem > to have anything to do with LOW_BANDWIDTH_DISPLAY. > > I'm guessing that for some reason Android derives a subclass from FrameLoader. > That doesn't sound like a good idea to me, but also seems unrelated to > LOW_BANDWIDTH_DISPLAY so should not be controlled by the same ifdef. > 64426 5 17941 klobag 2007-12-16 15:34:05 -0800 Created attachment 17941 new patch to make LOW_BANDWIDTH_DISPLAY compile Remove the change in the FrameLoader.h 64428 6 17941 darin 2007-12-16 15:40:15 -0800 Comment on attachment 17941 new patch to make LOW_BANDWIDTH_DISPLAY compile r=me 64447 7 mrowe 2007-12-16 17:27:08 -0800 Landed in r28784. 65078 8 alp 2007-12-22 12:04:28 -0800 The additional KURL API change fix was landed in r28960. 17923 2007-12-15 20:14:51 -0800 2007-12-16 15:34:05 -0800 Make LOW_BANDWIDTH_DISPLAY compile double.txt text/plain 2428 klobag SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDI3NDUzKQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODAsMTEgKzI4MCwxMSBAQCBEb2N1bWVudDo6RG9jdW1l bnQoRE9NSW1wbGVtZW50YXRpb24qIGltCiAgICAgLCBtX2luUGFnZUNhY2hlKGZhbHNlKQogICAg ICwgbV9pc0FsbG93ZWRUb0xvYWRMb2NhbFJlc291cmNlcyhmYWxzZSkKICAgICAsIG1fdXNlU2Vj dXJlS2V5Ym9hcmRFbnRyeVdoZW5BY3RpdmUoZmFsc2UpCisgICAgLCBtX2lzWEhUTUwoaXNYSFRN TCkKKyAgICAsIG1fbnVtTm9kZUxpc3RzKDApCiAjaWYgVVNFKExPV19CQU5EV0lEVEhfRElTUExB WSkKICAgICAsIG1faW5Mb3dCYW5kd2lkdGhEaXNwbGF5KGZhbHNlKQogI2VuZGlmCi0gICAgLCBt X2lzWEhUTUwoaXNYSFRNTCkKLSAgICAsIG1fbnVtTm9kZUxpc3RzKDApCiB7CiAgICAgbV9kb2N1 bWVudC5yZXNldFNraXBwaW5nUmVmKHRoaXMpOwogCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CShyZXZpc2lvbiAyNzQ1MykKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDY5MCw2ICs0NjkwLDcgQEAgYm9vbCBGcmFtZUxvYWRlcjo6YWRkTG93 QmFuZHdpZHRoRGlzcGxheQogICAgICAgICAgICAgY2FjaGUtPnJlZih0aGlzKTsKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpJbWFnZVJlc291 cmNlOgorICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpGb250UmVzb3VyY2U6CiAjaWYgRU5B QkxFKFhTTFQpCiAgICAgICAgIGNhc2UgQ2FjaGVkUmVzb3VyY2U6OlhTTFN0eWxlU2hlZXQ6CiAj ZW5kaWYKQEAgLTQ3NDcsMTQgKzQ3NDgsMTQgQEAgdm9pZCBGcmFtZUxvYWRlcjo6c3dpdGNoT3V0 TG93QmFuZHdpZHRoRAogICAgICAgICAgICAgCiAgICAgICAgICAgICAvLyBzaW1pbGFyIHRvIGJl Z2luKCksIHNob3VsZCBiZSByZWZhY3RvcmVkIHRvIHNoYXJlIG1vcmUgY29kZQogICAgICAgICAg ICAgUmVmUHRyPERvY3VtZW50PiBuZXdEb2MgPSBET01JbXBsZW1lbnRhdGlvbjo6aW5zdGFuY2Uo KS0+Ci0gICAgICAgICAgICAgICAgY3JlYXRlRG9jdW1lbnQobV9yZXNwb25zZU1JTUVUeXBlLCBt X2ZyYW1lLT52aWV3KCksIG1fZnJhbWUtPmluVmlld1NvdXJjZU1vZGUoKSk7CisgICAgICAgICAg ICAgICAgY3JlYXRlRG9jdW1lbnQobV9yZXNwb25zZU1JTUVUeXBlLCBtX2ZyYW1lLCBtX2ZyYW1l LT5pblZpZXdTb3VyY2VNb2RlKCkpOwogICAgICAgICAgICAgbV9mcmFtZS0+c2V0RG9jdW1lbnQo bmV3RG9jKTsKICAgICAgICAgICAgIG5ld0RvYy0+c2V0VVJMKG1fVVJMLnVybCgpKTsKICAgICAg ICAgICAgIG5ld0RvYy0+c2V0QmFzZVVSTChtX1VSTC51cmwoKSk7CiAgICAgICAgICAgICBpZiAo bV9kZWNvZGVyKQogICAgICAgICAgICAgICAgIG5ld0RvYy0+c2V0RGVjb2RlcihtX2RlY29kZXIu Z2V0KCkpOwogICAgICAgICAgICAgcmVzdG9yZURvY3VtZW50U3RhdGUoKTsKLSAgICAgICAgICAg IHBhcnRDbGVhcmVkSW5CZWdpbigpOyAgICAgICAgIAorICAgICAgICAgICAgZGlzcGF0Y2hXaW5k b3dPYmplY3RBdmFpbGFibGUoKTsgICAgICAgICAKICAgICAgICAgICAgIG5ld0RvYy0+aW1wbGlj aXRPcGVuKCk7CiAKICAgICAgICAgICAgIC8vIHN3YXAgRG9jTG9hZGVyIG93bmVyc2hpcApJbmRl eDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5oCShyZXZpc2lvbiAyNzQ1MykKKysrIFdlYkNvcmUvbG9hZGVyL0Zy YW1lTG9hZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyOSw4ICsxMjksMTEgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgIHsKICAgICBwdWJsaWM6CiAgICAgICAgIEZyYW1lTG9hZGVyKEZyYW1l KiwgRnJhbWVMb2FkZXJDbGllbnQqKTsKKyNpZiBVU0UoTE9XX0JBTkRXSURUSF9ESVNQTEFZKQor ICAgICAgICB2aXJ0dWFsIH5GcmFtZUxvYWRlcigpOworI2Vsc2UKICAgICAgICAgfkZyYW1lTG9h ZGVyKCk7Ci0KKyNlbmRpZgogICAgICAgICB2b2lkIGluaXQoKTsKIAogICAgICAgICBGcmFtZSog ZnJhbWUoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lOyB9Cg== 17941 2007-12-16 15:34:05 -0800 2007-12-16 15:40:15 -0800 new patch to make LOW_BANDWIDTH_DISPLAY compile double.txt text/plain 1934 klobag SW5kZXg6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDI3NDUzKQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODAsMTEgKzI4MCwxMSBAQCBEb2N1bWVudDo6RG9jdW1l bnQoRE9NSW1wbGVtZW50YXRpb24qIGltCiAgICAgLCBtX2luUGFnZUNhY2hlKGZhbHNlKQogICAg ICwgbV9pc0FsbG93ZWRUb0xvYWRMb2NhbFJlc291cmNlcyhmYWxzZSkKICAgICAsIG1fdXNlU2Vj dXJlS2V5Ym9hcmRFbnRyeVdoZW5BY3RpdmUoZmFsc2UpCisgICAgLCBtX2lzWEhUTUwoaXNYSFRN TCkKKyAgICAsIG1fbnVtTm9kZUxpc3RzKDApCiAjaWYgVVNFKExPV19CQU5EV0lEVEhfRElTUExB WSkKICAgICAsIG1faW5Mb3dCYW5kd2lkdGhEaXNwbGF5KGZhbHNlKQogI2VuZGlmCi0gICAgLCBt X2lzWEhUTUwoaXNYSFRNTCkKLSAgICAsIG1fbnVtTm9kZUxpc3RzKDApCiB7CiAgICAgbV9kb2N1 bWVudC5yZXNldFNraXBwaW5nUmVmKHRoaXMpOwogCkluZGV4OiBXZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CShyZXZpc2lvbiAyNzQ1MykKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDY5MCw2ICs0NjkwLDcgQEAgYm9vbCBGcmFtZUxvYWRlcjo6YWRkTG93 QmFuZHdpZHRoRGlzcGxheQogICAgICAgICAgICAgY2FjaGUtPnJlZih0aGlzKTsKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpJbWFnZVJlc291 cmNlOgorICAgICAgICBjYXNlIENhY2hlZFJlc291cmNlOjpGb250UmVzb3VyY2U6CiAjaWYgRU5B QkxFKFhTTFQpCiAgICAgICAgIGNhc2UgQ2FjaGVkUmVzb3VyY2U6OlhTTFN0eWxlU2hlZXQ6CiAj ZW5kaWYKQEAgLTQ3NDcsMTQgKzQ3NDgsMTQgQEAgdm9pZCBGcmFtZUxvYWRlcjo6c3dpdGNoT3V0 TG93QmFuZHdpZHRoRAogICAgICAgICAgICAgCiAgICAgICAgICAgICAvLyBzaW1pbGFyIHRvIGJl Z2luKCksIHNob3VsZCBiZSByZWZhY3RvcmVkIHRvIHNoYXJlIG1vcmUgY29kZQogICAgICAgICAg ICAgUmVmUHRyPERvY3VtZW50PiBuZXdEb2MgPSBET01JbXBsZW1lbnRhdGlvbjo6aW5zdGFuY2Uo KS0+Ci0gICAgICAgICAgICAgICAgY3JlYXRlRG9jdW1lbnQobV9yZXNwb25zZU1JTUVUeXBlLCBt X2ZyYW1lLT52aWV3KCksIG1fZnJhbWUtPmluVmlld1NvdXJjZU1vZGUoKSk7CisgICAgICAgICAg ICAgICAgY3JlYXRlRG9jdW1lbnQobV9yZXNwb25zZU1JTUVUeXBlLCBtX2ZyYW1lLCBtX2ZyYW1l LT5pblZpZXdTb3VyY2VNb2RlKCkpOwogICAgICAgICAgICAgbV9mcmFtZS0+c2V0RG9jdW1lbnQo bmV3RG9jKTsKICAgICAgICAgICAgIG5ld0RvYy0+c2V0VVJMKG1fVVJMLnVybCgpKTsKICAgICAg ICAgICAgIG5ld0RvYy0+c2V0QmFzZVVSTChtX1VSTC51cmwoKSk7CiAgICAgICAgICAgICBpZiAo bV9kZWNvZGVyKQogICAgICAgICAgICAgICAgIG5ld0RvYy0+c2V0RGVjb2RlcihtX2RlY29kZXIu Z2V0KCkpOwogICAgICAgICAgICAgcmVzdG9yZURvY3VtZW50U3RhdGUoKTsKLSAgICAgICAgICAg IHBhcnRDbGVhcmVkSW5CZWdpbigpOyAgICAgICAgIAorICAgICAgICAgICAgZGlzcGF0Y2hXaW5k b3dPYmplY3RBdmFpbGFibGUoKTsgICAgICAgICAKICAgICAgICAgICAgIG5ld0RvYy0+aW1wbGlj aXRPcGVuKCk7CiAKICAgICAgICAgICAgIC8vIHN3YXAgRG9jTG9hZGVyIG93bmVyc2hpcAo=