164311 2016-11-01 19:26:05 -0700 REGRESSION (r199558): File paths selected for upload are stored using the wrong string encoding 2017-06-05 09:32:50 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=137759 https://bugs.webkit.org/show_bug.cgi?id=164330 https://bugs.webkit.org/show_bug.cgi?id=166473 https://bugs.webkit.org/show_bug.cgi?id=172849 InRadar P2 Normal --- 1 aestes aestes andersca ap commit-queue darin pablo.caselas thorton webkit-bug-importer oldest_to_newest 1247199 0 aestes 2016-11-01 19:26:05 -0700 REGRESSION (r199558): File paths selected for upload are stored using the wrong string encoding 1247200 1 aestes 2016-11-01 19:27:07 -0700 <rdar://problem/26995374> 1247365 2 293669 aestes 2016-11-02 10:22:06 -0700 Created attachment 293669 Patch 1247386 3 293669 thorton 2016-11-02 11:09:26 -0700 Comment on attachment 293669 Patch This seems like one of those mistakes we've probably made in other places; should we look around and fix others? 1247390 4 aestes 2016-11-02 11:12:50 -0700 (In reply to comment #3) > Comment on attachment 293669 [details] > Patch > > This seems like one of those mistakes we've probably made in other places; > should we look around and fix others? Yeah, we should. I filed https://bugs.webkit.org/show_bug.cgi?id=164330 about this. 1247401 5 293679 aestes 2016-11-02 11:20:03 -0700 Created attachment 293679 Patch 1247414 6 293679 commit-queue 2016-11-02 11:55:36 -0700 Comment on attachment 293679 Patch Clearing flags on attachment: 293679 Committed r208295: <http://trac.webkit.org/changeset/208295> 1247415 7 commit-queue 2016-11-02 11:55:39 -0700 All reviewed patches have been landed. Closing bug. 1248557 8 293669 darin 2016-11-05 15:42:38 -0700 Comment on attachment 293669 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293669&action=review > Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:345 > - filenames.uncheckedAppend(fileURL.fileSystemRepresentation); > + filenames.uncheckedAppend(String::fromUTF8(fileURL.fileSystemRepresentation)); Instead of: String::fromUTF8(fileURL.fileSystemRepresentation) I believe we can, and should, just use: fileURL.path 1265099 9 aestes 2017-01-09 12:56:54 -0800 *** Bug 166473 has been marked as a duplicate of this bug. *** 293669 2016-11-02 10:22:06 -0700 2016-11-02 11:20:00 -0700 Patch bug-164311-20161102101807.patch text/plain 2000 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjRlZmJjM2MzOWFhZTE0 NmFiYWU1YjBmMDgxZDFkNTQ2MjBhNjMzYS4uYWJkM2UxYzNlOGZlOTI3NDRhMzMwZThlNDE5NTJl Nzg4YWFkY2I3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTExLTAxICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTk5NTU4 KTogRmlsZSBwYXRocyBzZWxlY3RlZCBmb3IgdXBsb2FkIGFyZSBzdG9yZWQgdXNpbmcgdGhlIHdy b25nIHN0cmluZyBlbmNvZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY0MzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgLVtOU1VSTCBmaWxlU3lzdGVtUmVwcmVzZW50YXRpb25dIHJldHVybnMgYSBj aGFyKiBpbiBmaWxlIHN5c3RlbSByZXByZXNlbnRhdGlvbiwgd2hpY2ggb24KKyAgICAgICAgaU9T IGlzIFVURi04LCBidXQgd2Ugd2VyZSBpbXBsaWNpdGx5IGNvbnZlcnRpbmcgaXQgdG8gYSBTdHJp bmcsIHdoaWNoIGFzc3VtZXMgYSBjaGFyKiBpcworICAgICAgICBMYXRpbi0xIGVuY29kZWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tOgorICAg ICAgICAoLVtXS0ZpbGVVcGxvYWRQYW5lbCBfY2hvb3NlRmlsZXM6ZGlzcGxheVN0cmluZzppY29u SW1hZ2U6XSk6IENoYW5nZWQgdG8gdXNlIGZyb21VVEY4KCkgdG8KKyAgICAgICAgY29udmVydCBm aWxlVVJMLmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbiB0byBhIFN0cmluZy4KKwogMjAxNi0xMS0w MSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBUdXJu IHRoZSBJbnB1dCBFdmVudHMgcnVudGltZSBmbGFnIG9uIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0g Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1t CmluZGV4IDQ3MzMyMWUzYWJjYTBlN2UwZmY1ZDc5MGI5MzU4YjYyZmM5YTgxZmYuLjI1M2I4YmNj OTE3MzNiZjZmOTRhNjYzY2MyMGQyNjhmYWZjZTA0ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQpAQCAtMzQy LDcgKzM0Miw3IEBAIC0gKHZvaWQpX2Nob29zZUZpbGVzOihOU0FycmF5ICopZmlsZVVSTHMgZGlz cGxheVN0cmluZzooTlNTdHJpbmcgKilkaXNwbGF5U3RyaW5nCiAgICAgVmVjdG9yPFN0cmluZz4g ZmlsZW5hbWVzOwogICAgIGZpbGVuYW1lcy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KGNvdW50KTsK ICAgICBmb3IgKE5TVVJMICpmaWxlVVJMIGluIGZpbGVVUkxzKQotICAgICAgICBmaWxlbmFtZXMu dW5jaGVja2VkQXBwZW5kKGZpbGVVUkwuZmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uKTsKKyAgICAg ICAgZmlsZW5hbWVzLnVuY2hlY2tlZEFwcGVuZChTdHJpbmc6OmZyb21VVEY4KGZpbGVVUkwuZmls ZVN5c3RlbVJlcHJlc2VudGF0aW9uKSk7CiAKICAgICBOU0RhdGEgKmpwZWcgPSBVSUltYWdlSlBF R1JlcHJlc2VudGF0aW9uKGljb25JbWFnZSwgMS4wKTsKICAgICBSZWZQdHI8QVBJOjpEYXRhPiBp Y29uSW1hZ2VEYXRhUmVmID0gYWRvcHRSZWYodG9JbXBsKFdLRGF0YUNyZWF0ZShyZWludGVycHJl dF9jYXN0PGNvbnN0IHVuc2lnbmVkIGNoYXIqPihbanBlZyBieXRlc10pLCBbanBlZyBsZW5ndGhd KSkpOwo= 293679 2016-11-02 11:20:03 -0700 2016-11-02 11:55:36 -0700 Patch bug-164311-20161102111604.patch text/plain 2031 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjRlZmJjM2MzOWFhZTE0 NmFiYWU1YjBmMDgxZDFkNTQ2MjBhNjMzYS4uMDc0NDVhMzNiMTE5NzVhMjM2Y2M1MGQ3MTFhNDQ3 MjQyNWE4MzkyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTExLTAxICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTk5NTU4 KTogRmlsZSBwYXRocyBzZWxlY3RlZCBmb3IgdXBsb2FkIGFyZSBzdG9yZWQgdXNpbmcgdGhlIHdy b25nIHN0cmluZyBlbmNvZGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY0MzExCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjk5NTM3ND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBUaW0gSG9ydG9uLgorCisgICAgICAgIC1bTlNVUkwgZmlsZVN5 c3RlbVJlcHJlc2VudGF0aW9uXSByZXR1cm5zIGEgY2hhciogaW4gZmlsZSBzeXN0ZW0gcmVwcmVz ZW50YXRpb24sIHdoaWNoIG9uCisgICAgICAgIGlPUyBpcyBVVEYtOCwgYnV0IHdlIHdlcmUgaW1w bGljaXRseSBjb252ZXJ0aW5nIGl0IHRvIGEgU3RyaW5nLCB3aGljaCBhc3N1bWVzIGEgY2hhciog aXMKKyAgICAgICAgTGF0aW4tMSBlbmNvZGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9m b3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbToKKyAgICAgICAgKC1bV0tGaWxlVXBsb2FkUGFuZWwg X2Nob29zZUZpbGVzOmRpc3BsYXlTdHJpbmc6aWNvbkltYWdlOl0pOiBDaGFuZ2VkIHRvIHVzZSBm cm9tVVRGOCgpIHRvCisgICAgICAgIGNvbnZlcnQgZmlsZVVSTC5maWxlU3lzdGVtUmVwcmVzZW50 YXRpb24gdG8gYSBTdHJpbmcuCisKIDIwMTYtMTEtMDEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9o c2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgVHVybiB0aGUgSW5wdXQgRXZlbnRzIHJ1bnRpbWUg ZmxhZyBvbiBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQppbmRleCA0NzMzMjFlM2FiY2EwZTdlMGZm NWQ3OTBiOTM1OGI2MmZjOWE4MWZmLi4yNTNiOGJjYzkxNzMzYmY2Zjk0YTY2M2NjMjBkMjY4ZmFm Y2UwNGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dL RmlsZVVwbG9hZFBhbmVsLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvZm9y bXMvV0tGaWxlVXBsb2FkUGFuZWwubW0KQEAgLTM0Miw3ICszNDIsNyBAQCAtICh2b2lkKV9jaG9v c2VGaWxlczooTlNBcnJheSAqKWZpbGVVUkxzIGRpc3BsYXlTdHJpbmc6KE5TU3RyaW5nICopZGlz cGxheVN0cmluZwogICAgIFZlY3RvcjxTdHJpbmc+IGZpbGVuYW1lczsKICAgICBmaWxlbmFtZXMu cmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShjb3VudCk7CiAgICAgZm9yIChOU1VSTCAqZmlsZVVSTCBp biBmaWxlVVJMcykKLSAgICAgICAgZmlsZW5hbWVzLnVuY2hlY2tlZEFwcGVuZChmaWxlVVJMLmZp bGVTeXN0ZW1SZXByZXNlbnRhdGlvbik7CisgICAgICAgIGZpbGVuYW1lcy51bmNoZWNrZWRBcHBl bmQoU3RyaW5nOjpmcm9tVVRGOChmaWxlVVJMLmZpbGVTeXN0ZW1SZXByZXNlbnRhdGlvbikpOwog CiAgICAgTlNEYXRhICpqcGVnID0gVUlJbWFnZUpQRUdSZXByZXNlbnRhdGlvbihpY29uSW1hZ2Us IDEuMCk7CiAgICAgUmVmUHRyPEFQSTo6RGF0YT4gaWNvbkltYWdlRGF0YVJlZiA9IGFkb3B0UmVm KHRvSW1wbChXS0RhdGFDcmVhdGUocmVpbnRlcnByZXRfY2FzdDxjb25zdCB1bnNpZ25lZCBjaGFy Kj4oW2pwZWcgYnl0ZXNdKSwgW2pwZWcgbGVuZ3RoXSkpKTsK