164300 2016-11-01 16:04:18 -0700 Web Inspector: Improve debugger highlight in some exception cases 2016-11-01 17:01:17 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1247102 0 joepeck 2016-11-01 16:04:18 -0700 Summary: Improve debugger highlight in some exception cases Test: <script> (function(f) { f(); }(function() { var error = new Error("message"); throw error; })); </script> Steps to Reproduce: 1. Inspect attached test case 2. Enable Pause on all Exceptions 3. Reload => pauses on throw statement => Entire program is highlighted, expected just the throw statement 1247104 1 293612 joepeck 2016-11-01 16:07:42 -0700 Created attachment 293612 [PATCH] Proposed Fix 1247126 2 293612 commit-queue 2016-11-01 16:42:07 -0700 Comment on attachment 293612 [PATCH] Proposed Fix Clearing flags on attachment: 293612 Committed r208260: <http://trac.webkit.org/changeset/208260> 1247127 3 commit-queue 2016-11-01 16:42:11 -0700 All reviewed patches have been landed. Closing bug. 1247140 4 webkit-bug-importer 2016-11-01 17:01:17 -0700 <rdar://problem/29055539> 293612 2016-11-01 16:07:42 -0700 2016-11-01 16:42:07 -0700 [PATCH] Proposed Fix highlight-1.patch text/plain 1792 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNhNzFiNDQuLjVhODhkZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTExLTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW1wcm92 ZSBkZWJ1Z2dlciBoaWdobGlnaHQgaW4gc29tZSBleGNlcHRpb24gY2FzZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDMwMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VD b2RlVGV4dEVkaXRvci5wcm90b3R5cGUudGV4dEVkaXRvckV4ZWN1dGlvbkhpZ2hsaWdodFJhbmdl KToKKyAgICAgICAgV2hlbiB3YWxraW5nIHVwIEFTVCBub2RlcyBhbmQgcmVhY2ggYSB0aHJvdyBz dGF0ZW1lbnQsIHVzZSB0aGF0LgorCisyMDE2LTExLTAxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYW51cCBzdGFsZSBj b2RlIGluIE5ldHdvcmtTaWRlYmFyUGFuZWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NDI5NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9y LmpzCmluZGV4IDY1MDQ3OTQuLmJkYmM1MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRp dG9yLmpzCkBAIC0xMjkxLDcgKzEyOTEsOCBAQCBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRF ZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3BlYwogCiAg ICAgICAgICAgICAgICAgLy8gSW4gYSBmdW5jdGlvbiBjYWxsLgogICAgICAgICAgICAgICAgIGlm IChub2RlLnR5cGUgPT09IFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVlLk5vZGVUeXBlLkNh bGxFeHByZXNzaW9uCi0gICAgICAgICAgICAgICAgICAgIHx8IG5vZGUudHlwZSA9PT0gV2ViSW5z cGVjdG9yLlNjcmlwdFN5bnRheFRyZWUuTm9kZVR5cGUuTmV3RXhwcmVzc2lvbikgeworICAgICAg ICAgICAgICAgICAgICB8fCBub2RlLnR5cGUgPT09IFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhU cmVlLk5vZGVUeXBlLk5ld0V4cHJlc3Npb24KKyAgICAgICAgICAgICAgICAgICAgfHwgbm9kZS50 eXBlID09PSBXZWJJbnNwZWN0b3IuU2NyaXB0U3ludGF4VHJlZS5Ob2RlVHlwZS5UaHJvd1N0YXRl bWVudCkgewogICAgICAgICAgICAgICAgICAgICBjYWxsYmFjayhjb252ZXJ0UmFuZ2VPZmZzZXRz VG9Tb3VyY2VDb2RlT2Zmc2V0cyhub2RlLnJhbmdlKSk7CiAgICAgICAgICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgICAgICAgICB9Cg==