164295 2016-11-01 15:11:45 -0700 Web Inspector: Cleanup stale code in NetworkSidebarPanel 2016-11-01 16:40:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1247075 0 joepeck 2016-11-01 15:11:45 -0700 Cleanup stale code in NetworkSidebarPanel It has WebInspector.frameResourceManager.removeEventListener but it doesn't have WebInspector.frameResourceManager.addEventListener. So this seems unnecessary. 1247076 1 293602 joepeck 2016-11-01 15:12:36 -0700 Created attachment 293602 [PATCH] Proposed Fix 1247124 2 293602 commit-queue 2016-11-01 16:40:00 -0700 Comment on attachment 293602 [PATCH] Proposed Fix Clearing flags on attachment: 293602 Committed r208259: <http://trac.webkit.org/changeset/208259> 1247125 3 commit-queue 2016-11-01 16:40:04 -0700 All reviewed patches have been landed. Closing bug. 293602 2016-11-01 15:12:36 -0700 2016-11-01 16:40:00 -0700 [PATCH] Proposed Fix cleaner-1.patch text/plain 1508 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRmNTg3YTQuLmNhNzFiNDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTExLTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ2xlYW51 cCBzdGFsZSBjb2RlIGluIE5ldHdvcmtTaWRlYmFyUGFuZWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDI5NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3Jr U2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtTaWRlYmFyUGFu ZWwucHJvdG90eXBlLmNsb3NlZCk6IERlbGV0ZWQuCisgICAgICAgIFRoaXMgZG9lc24ndCBhcHBl YXIgdG8gYmUgbmVlZGVkIHNpbmNlIE5ldHdvcmtTaWRlYmFyUGFuZWwgbmV2ZXIKKyAgICAgICAg cmVnaXN0ZXJlZCBhbnkgZXZlbnQgbGlzdGVuZXJzLgorCiAyMDE2LTExLTAxICBEZXZpbiBSb3Vz c28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIx OTE0MTkpOiBXZWIgSW5zcGVjdG9yOiBBdXRvY29tcGxldGUgaXMgYnJva2VuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrU2lkZWJh clBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0 d29ya1NpZGViYXJQYW5lbC5qcwppbmRleCA2ZjI1YmExLi40YWUyMzY3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrU2lkZWJhclBh bmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05l dHdvcmtTaWRlYmFyUGFuZWwuanMKQEAgLTc2LDEzICs3Niw2IEBAIFdlYkluc3BlY3Rvci5OZXR3 b3JrU2lkZWJhclBhbmVsID0gY2xhc3MgTmV0d29ya1NpZGViYXJQYW5lbCBleHRlbmRzIFdlYklu c3BlY3RvCiAgICAgICAgIHJldHVybiB0aGlzLl9uYXZpZ2F0aW9uQmFyLm1pbmltdW1XaWR0aDsK ICAgICB9CiAKLSAgICBjbG9zZWQoKQotICAgIHsKLSAgICAgICAgc3VwZXIuY2xvc2VkKCk7Ci0K LSAgICAgICAgV2ViSW5zcGVjdG9yLmZyYW1lUmVzb3VyY2VNYW5hZ2VyLnJlbW92ZUV2ZW50TGlz dGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7Ci0gICAgfQotCiAgICAgc2hvd0RlZmF1bHRDb250ZW50 VmlldygpCiAgICAgewogICAgICAgICB0aGlzLmNvbnRlbnRCcm93c2VyLnNob3dDb250ZW50Vmll dyh0aGlzLl9uZXR3b3JrR3JpZFZpZXcpOwo=