<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164270</bug_id>
          
          <creation_ts>2016-11-01 06:01:40 -0700</creation_ts>
          <short_desc>[GTK] Failed to generate GeoClue2Interface files.</short_desc>
          <delta_ts>2016-11-01 06:51:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hyowon Kim">hw1008.kim</reporter>
          <assigned_to name="Hyowon Kim">hw1008.kim</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1246885</commentid>
    <comment_count>0</comment_count>
    <who name="Hyowon Kim">hw1008.kim</who>
    <bug_when>2016-11-01 06:01:40 -0700</bug_when>
    <thetext>geoclue2 uses gdbus-codegen to generate codes for D-Bus Interfaces. But libgeoclue-2-dev doesn&apos;t contain D-Bus introspection XML files (org.freedesktop.GeoClue2.xml). So the below command in WebCore/PlatformGtk.cmake is not working properly.

add_custom_command(
   OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface.c ${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface.h
   COMMAND gdbus-codegen --interface-prefix org.freedesktop.GeoClue2. --c-namespace Geoclue --generate-c-    code ${DERIVED_SOURCES_WEBCORE_DIR}/Geoclue2Interface ${GEOCLUE_DBUS_INTERFACE}
)

Adding geoclue-2.0 package into install-dependencies seems to be needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246886</commentid>
    <comment_count>1</comment_count>
      <attachid>293550</attachid>
    <who name="Hyowon Kim">hw1008.kim</who>
    <bug_when>2016-11-01 06:10:11 -0700</bug_when>
    <thetext>Created attachment 293550
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246887</commentid>
    <comment_count>2</comment_count>
      <attachid>293550</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-11-01 06:51:39 -0700</bug_when>
    <thetext>Comment on attachment 293550
Patch

Clearing flags on attachment: 293550

Committed r208221: &lt;http://trac.webkit.org/changeset/208221&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246888</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-11-01 06:51:43 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>293550</attachid>
            <date>2016-11-01 06:10:11 -0700</date>
            <delta_ts>2016-11-01 06:51:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-164270-20161101220613.patch</filename>
            <type>text/plain</type>
            <size>1217</size>
            <attacher name="Hyowon Kim">hw1008.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MTM4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTVmMGJlMDlhYjRmZmZjYjcxYTAxODNjMTg5YWY4MThj
ZWEzNTNkZS4uMGQ5OGVjNjgyMTgyZTYxZDU3MjQ2MTU1NTEyZmUxNjI3MTc5MjY5MiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDE2LTExLTAxICBIeW93b24gS2ltICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KKwor
ICAgICAgICBbR1RLXSBGYWlsZWQgdG8gZ2VuZXJhdGUgR2VvQ2x1ZTJJbnRlcmZhY2UgZmlsZXMu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjQyNzAK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBnZW5l
cmF0ZSBjb2RlcyBmb3IgRC1CdXMgaW50ZXJmYWNlcywKKyAgICAgICAgZ2VvY2x1ZS0yLjAgcGFj
a2FnZSBpbmNsdWRpbmcgRC1CdXMgaW50cm9zcGVjdGlvbiBYTUwgZmlsZXMgc2hvdWxkIGJlIGlu
c3RhbGxlZC4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczogYWRkIGdlb2Ns
dWUtMi4wIHBhY2thZ2UuCisKIDIwMTYtMTAtMzAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9y
Zz4KIAogICAgICAgICBbV2ViSURMXSBSZXN0cnVjdHVyZSBJRExQYXJzZXIgc3RydWN0cyB0byBi
ZXR0ZXIgbWF0Y2ggbW9kZXJuIFdlYklETCBjb25jZXB0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3Rr
L2luc3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmlu
ZGV4IDQ2NGIwODUzZWEyZjY1NTM1NzNlMTMwMGJhODBhZTg4M2Q5YzFmOTguLjY0YTliMWIxYzg5
Njg5NmNiM2RhMjIwMWE4YjBlODI4MjgzZjJjYzIgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0
YWxsLWRlcGVuZGVuY2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAg
LTk2LDYgKzk2LDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAg
ICAgICBjbWFrZSBcCiAgICAgICAgIGZsZXggXAogICAgICAgICBnYXdrIFwKKyAgICAgICAgZ2Vv
Y2x1ZS0yLjAgXAogICAgICAgICBnbm9tZS1jb21tb24gXAogICAgICAgICBncGVyZiBcCiAgICAg
ICAgIGd0ay1kb2MtdG9vbHMgXAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>