164230 2016-10-31 10:49:19 -0700 LayoutTests/fast/frames/invalid-frameset.html is not clean by the end of FrameView::layout(). 2016-10-31 13:21:02 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162830 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1246483 0 zalan 2016-10-31 10:49:19 -0700 All renderers in the render tree should be clean when we finished with FrameView::layout() 1246496 1 293437 zalan 2016-10-31 10:59:18 -0700 Created attachment 293437 Patch 1246498 2 293437 simon.fraser 2016-10-31 11:01:14 -0700 Comment on attachment 293437 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293437&action=review > Source/WebCore/ChangeLog:8 > + This patch clears the needs layout bit on the descendants of the invalid framesets too (and not only the invalid frameset). This could be clearer about "all descendants, not just children". 1246513 3 293441 zalan 2016-10-31 11:17:46 -0700 Created attachment 293441 Patch 1246562 4 293441 commit-queue 2016-10-31 13:20:58 -0700 Comment on attachment 293441 Patch Clearing flags on attachment: 293441 Committed r208172: <http://trac.webkit.org/changeset/208172> 1246563 5 commit-queue 2016-10-31 13:21:02 -0700 All reviewed patches have been landed. Closing bug. 293437 2016-10-31 10:59:18 -0700 2016-10-31 11:17:42 -0700 Patch bug-164230-20161031105523.patch text/plain 1792 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTYyMGZhYmNiNzcwY2Fl ZjYyZTU1MjJlYWViYjM0NjViNzcwNGM3OS4uOGU1NTRlZTU0OWNjMjQwOTA5ZWZjMDFkYjBkZmQx ZTQ5ZmZjZGEzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEwLTMxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdHMvZmFzdC9m cmFtZXMvaW52YWxpZC1mcmFtZXNldC5odG1sIGlzIG5vdCBjbGVhbiBieSB0aGUgZW5kIG9mIEZy YW1lVmlldzo6bGF5b3V0KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjQyMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIHBhdGNoIGNsZWFycyB0aGUgbmVlZHMgbGF5b3V0IGJpdCBvbiB0aGUg ZGVzY2VuZGFudHMgb2YgdGhlIGludmFsaWQgZnJhbWVzZXRzIHRvbyAoYW5kIG5vdCBvbmx5IHRo ZSBpbnZhbGlkIGZyYW1lc2V0KS4KKworICAgICAgICBDb3ZlcmVkIGJ5IExheW91dFRlc3RzL2Zh c3QvZnJhbWVzL2ludmFsaWQtZnJhbWVzZXQuaHRtbC4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJGcmFtZVNldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGcmFtZVNldDo6cG9z aXRpb25GcmFtZXMpOgorCiAyMDE2LTEwLTI2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgSWdub3JlIG91dC1vZi1mbG93IHNpYmxpbmdzIHdoZW4gc2VhcmNoaW5n IGZvciBhIHNwYW5uZXIgY2FuZGlkYXRlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJGcmFtZVNldC5jcHAKaW5kZXggNzc0OGM0NzhlYjBkZTQ4Njg1NWFlMWRlZjc4NTZiYjMyZjI1 MzY0NS4uM2NkNjdmZTdjZjg2ZmI5Mjg5NDg1OTRlMGE1MTkxNGU5N2FiODU1NiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwCkBAIC01MzQsMTAgKzUzNCwx MCBAQCB2b2lkIFJlbmRlckZyYW1lU2V0Ojpwb3NpdGlvbkZyYW1lcygpCiAgICAgfQogCiAgICAg Ly8gYWxsIHRoZSByZW1haW5pbmcgZnJhbWVzIGFyZSBoaWRkZW4gdG8gYXZvaWQgdWdseSBzcHVy aW91cyB1bmZsb3dlZCBmcmFtZXMKLSAgICBmb3IgKDsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5l eHRTaWJsaW5nQm94KCkpIHsKLSAgICAgICAgY2hpbGQtPnNldFdpZHRoKDApOwotICAgICAgICBj aGlsZC0+c2V0SGVpZ2h0KDApOwotICAgICAgICBjaGlsZC0+Y2xlYXJOZWVkc0xheW91dCgpOwor ICAgIGZvciAoYXV0byogZGVzY2VuZGFudCA9IGNoaWxkOyBkZXNjZW5kYW50OyBkZXNjZW5kYW50 ID0gZG93bmNhc3Q8UmVuZGVyQm94PihSZW5kZXJPYmplY3RUcmF2ZXJzYWw6Om5leHQoKmRlc2Nl bmRhbnQsIHRoaXMpKSkgeworICAgICAgICBkZXNjZW5kYW50LT5zZXRXaWR0aCgwKTsKKyAgICAg ICAgZGVzY2VuZGFudC0+c2V0SGVpZ2h0KDApOworICAgICAgICBkZXNjZW5kYW50LT5jbGVhck5l ZWRzTGF5b3V0KCk7CiAgICAgfQogfQogCg== 293441 2016-10-31 11:17:46 -0700 2016-10-31 13:20:58 -0700 Patch bug-164230-20161031111350.patch text/plain 1820 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3OTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTYyMGZhYmNiNzcwY2Fl ZjYyZTU1MjJlYWViYjM0NjViNzcwNGM3OS4uZDA2MTFlMDBlZGNhZTNkMzFkODEwNjliNjU2ZGUz Zjg1NWYwNDhkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEwLTMxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdHMvZmFzdC9m cmFtZXMvaW52YWxpZC1mcmFtZXNldC5odG1sIGlzIG5vdCBjbGVhbiBieSB0aGUgZW5kIG9mIEZy YW1lVmlldzo6bGF5b3V0KCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjQyMzAKKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisK KyAgICAgICAgV2hlbiBhIDxmcmFtZXNldD4gaGFzIGludmFsaWQgY2hpbGRyZW4sIGluIGFkZGl0 aW9uIHRvIGNsZWFyIHRoZSBuZWVkcyBsYXlvdXQgZmxhZyBvbiB0aGUgY2hpbGRyZW4KKyAgICAg ICAgd2UgYWxzbyBuZWVkIHRvIGRvIGNsZWFyIHRoZSBkZXNjZW5kYW50cyB0b28uCisKKyAgICAg ICAgQ292ZXJlZCBieSBMYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy9pbnZhbGlkLWZyYW1lc2V0Lmh0 bWwuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyRnJhbWVTZXQ6OnBvc2l0aW9uRnJhbWVzKToKKwogMjAxNi0xMC0yNiAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIElnbm9yZSBvdXQtb2Yt ZmxvdyBzaWJsaW5ncyB3aGVuIHNlYXJjaGluZyBmb3IgYSBzcGFubmVyIGNhbmRpZGF0ZS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwCmluZGV4IDc3NDhjNDc4 ZWIwZGU0ODY4NTVhZTFkZWY3ODU2YmIzMmYyNTM2NDUuLjNjZDY3ZmU3Y2Y4NmZiOTI4OTQ4NTk0 ZTBhNTE5MTRlOTdhYjg1NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJGcmFtZVNldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZy YW1lU2V0LmNwcApAQCAtNTM0LDEwICs1MzQsMTAgQEAgdm9pZCBSZW5kZXJGcmFtZVNldDo6cG9z aXRpb25GcmFtZXMoKQogICAgIH0KIAogICAgIC8vIGFsbCB0aGUgcmVtYWluaW5nIGZyYW1lcyBh cmUgaGlkZGVuIHRvIGF2b2lkIHVnbHkgc3B1cmlvdXMgdW5mbG93ZWQgZnJhbWVzCi0gICAgZm9y ICg7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZ0JveCgpKSB7Ci0gICAgICAgIGNo aWxkLT5zZXRXaWR0aCgwKTsKLSAgICAgICAgY2hpbGQtPnNldEhlaWdodCgwKTsKLSAgICAgICAg Y2hpbGQtPmNsZWFyTmVlZHNMYXlvdXQoKTsKKyAgICBmb3IgKGF1dG8qIGRlc2NlbmRhbnQgPSBj aGlsZDsgZGVzY2VuZGFudDsgZGVzY2VuZGFudCA9IGRvd25jYXN0PFJlbmRlckJveD4oUmVuZGVy T2JqZWN0VHJhdmVyc2FsOjpuZXh0KCpkZXNjZW5kYW50LCB0aGlzKSkpIHsKKyAgICAgICAgZGVz Y2VuZGFudC0+c2V0V2lkdGgoMCk7CisgICAgICAgIGRlc2NlbmRhbnQtPnNldEhlaWdodCgwKTsK KyAgICAgICAgZGVzY2VuZGFudC0+Y2xlYXJOZWVkc0xheW91dCgpOwogICAgIH0KIH0KIAo=