<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164217</bug_id>
          
          <creation_ts>2016-10-31 01:00:18 -0700</creation_ts>
          <short_desc>Should we remove legacy RTCPeerConnection callback API?</short_desc>
          <delta_ts>2021-08-26 03:14:02 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>189040</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=167617</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=169646</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>143211</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="youenn fablet">youennf</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>adam.bergkvist</cc>
    
    <cc>agouaillard</cc>
    
    <cc>alex</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>gsnedders</cc>
    
    <cc>jonlee</cc>
    
    <cc>pnormand</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1246366</commentid>
    <comment_count>0</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2016-10-31 01:00:18 -0700</bug_when>
    <thetext>Is it time to remove RTCPeerConnection callback API?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246382</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Bergkvist">adam.bergkvist</who>
    <bug_when>2016-10-31 01:36:35 -0700</bug_when>
    <thetext>I don&apos;t think we can do that. These callbacks are also documented in the spec [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160913/webrtc.html#legacy-interface-extensions</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246889</commentid>
    <comment_count>2</comment_count>
    <who name="Alex. Gouaillard">agouaillard</who>
    <bug_when>2016-11-01 07:01:01 -0700</bug_when>
    <thetext>You cannot remove the API, but the specs leaves the freedom to make it but a wrapper around the promise API leaving only one implementation to maintain. See how navigator.getUserMedia is implemented (vs MediaDevices.getUserMedia)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246892</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Bergkvist">adam.bergkvist</who>
    <bug_when>2016-11-01 07:22:19 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; You cannot remove the API, but the specs leaves the freedom to make it but a
&gt; wrapper around the promise API leaving only one implementation to maintain.
&gt; See how navigator.getUserMedia is implemented (vs MediaDevices.getUserMedia)

This is how the RTCPeerConnection legacy callback API is implemented currently as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271285</commentid>
    <comment_count>4</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2017-01-30 09:39:31 -0800</bug_when>
    <thetext>Is there anything left here? Should we close this as WONTFIX?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271359</commentid>
    <comment_count>5</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-01-30 12:03:05 -0800</bug_when>
    <thetext>I am not sure this is WONTFIX.
WebKit hasn&apos;t shipped yet the feature so we have some freedom here.

The legacy APIs are wrappers around the promise-based APIs which are also evolving.
Probably legacy services need to be updated according these internal changes so I would think they could/are migrating to promise-based APIs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1271457</commentid>
    <comment_count>6</comment_count>
    <who name="youenn fablet">youennf</who>
    <bug_when>2017-01-30 15:54:35 -0800</bug_when>
    <thetext>WebRTC WG recently removed getStats legacy API.
We should at least do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1787526</commentid>
    <comment_count>7</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2021-08-26 03:14:02 -0700</bug_when>
    <thetext>bug 181480 disabled it by default and bug 189040 removed it entirely; forward duping to the latter given that totally removed it

*** This bug has been marked as a duplicate of bug 189040 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>