164211 2016-10-30 16:54:03 -0700 [CSS Parser] Miscellaneous bug fixes 2016-10-31 08:04:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 1246292 0 hyatt 2016-10-30 16:54:03 -0700 [CSS Parser] Miscellaneous bug fixes 1246293 1 293372 hyatt 2016-10-30 16:57:27 -0700 Created attachment 293372 Patch 1246306 2 293372 darin 2016-10-30 17:59:22 -0700 Comment on attachment 293372 Patch Strange to see all these patches for bug fixes, but no test cases. I assume that these fixes are needed to pass existing WebKit tests with the new parse? 1246310 3 293372 buildbot 2016-10-30 18:18:19 -0700 Comment on attachment 293372 Patch Attachment 293372 did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2407920 New failing tests: canvas/philip/tests/2d.canvas.reference.html 1246311 4 293379 buildbot 2016-10-30 18:18:22 -0700 Created attachment 293379 Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6 1246417 5 hyatt 2016-10-31 08:03:14 -0700 (In reply to comment #2) > Comment on attachment 293372 [details] > Patch > > Strange to see all these patches for bug fixes, but no test cases. I assume > that these fixes are needed to pass existing WebKit tests with the new parse? Yeah, all these fixes are about getting the new parser to pass our existing tests. 1246418 6 hyatt 2016-10-31 08:04:22 -0700 Fixed in r208142. 293372 2016-10-30 16:57:27 -0700 2016-10-30 18:18:19 -0700 Patch bug-164211-20161030185332.patch text/plain 4644 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODEzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTEwLTMwICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBNaXNjZWxsYW5l b3VzIGJ1ZyBmaXhlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTY0MjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBjc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1Byb3BlcnR5UGFyc2VyOjpjb25zdW1lVHJhbnNmb3JtT3JpZ2luKToKKyAgICAgICAg TWFrZSBzdXJlIHRvIHByb3Blcmx5IHJlamVjdCBpbnZhbGlkIHRyYW5zZm9ybS1vcmlnaW4teiB2 YWx1ZXMuCisKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1NlbGVjdG9yUGFyc2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkNTU1NlbGVjdG9yUGFyc2VyOjpjb25zdW1lQXR0cmlidXRlKToKKyAg ICAgICAgTWFrZSBhdHRyaWJ1dGUgc2VsZWN0b3IgcGFyc2luZyBzdHJpY3QgYWJvdXQgcmVxdWly aW5nIGEgXSB0byBlbmQKKyAgICAgICAgdGhlIHNlbGVjdG9yLgorCisgICAgICAgIChXZWJDb3Jl OjpDU1NTZWxlY3RvclBhcnNlcjo6Y29uc3VtZVBzZXVkbyk6CisgICAgICAgIEZvcmNlIHRoZSBu dGgtY2hpbGQgIm9mIiBzeW50YXggdG8gaGF2ZSB3aGl0ZXNwYWNlIGFmdGVyICJvZiIgYnV0Cisg ICAgICAgIGJlZm9yZSB0aGUgc2VsZWN0b3IuIEl0IGlzIHVuY2xlYXIgaWYgdGhpcyBzaG91bGQg YmUgYSByZXF1aXJlbWVudAorICAgICAgICBvciBub3QgKHNwZWMgaXMgYW1iaWd1b3VzKSwgYnV0 IGZvciBub3cgd2UgbWF0Y2ggdGhlIG9sZCBwYXJzZXIuCisKKyAgICAgICAgKFdlYkNvcmU6OkNT U1NlbGVjdG9yUGFyc2VyOjpjb25zdW1lQ29tYmluYXRvcik6CisgICAgICAgIEZpeCBhIGJ1ZyB0 aGF0IGNhdXNlZCB0aGUgZG91YmxlIGNoaWxkIGNvbWJpbmF0b3IgdG8gbWF0Y2ggZXZlbgorICAg ICAgICB3aGVuIHRoZXJlIHdhcyB3aGl0ZXNwYWNlIGJldHdlZW4gdGhlIHR3byA+IHN5bWJvbHMu CisKIDIwMTYtMTAtMzAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg IE1vdmUgRWxlbWVudCwgTmFtZWROb2RlTWFwLCBhbmQgRE9NU3RyaW5nTWFwIGZyb20gRXhjZXB0 aW9uQ29kZSB0byBFeGNlcHRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NT UHJvcGVydHlQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJz ZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDgxMzApCisrKyBTb3VyY2UvV2Vi Q29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzY0LDcgKzM2NCwxMSBAQCBib29sIENTU1Byb3BlcnR5UGFyc2VyOjpjb25zdW1lVHJhbnNmb3Jt CiAgICAgUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiByZXN1bHRYOwogICAgIFJlZlB0cjxDU1NQ cmltaXRpdmVWYWx1ZT4gcmVzdWx0WTsKICAgICBpZiAoY29uc3VtZU9uZU9yVHdvVmFsdWVkUG9z aXRpb24obV9yYW5nZSwgbV9jb250ZXh0Lm1vZGUsIFVuaXRsZXNzUXVpcms6OkZvcmJpZCwgcmVz dWx0WCwgcmVzdWx0WSkpIHsKKyAgICAgICAgbV9yYW5nZS5jb25zdW1lV2hpdGVzcGFjZSgpOwor ICAgICAgICBib29sIGF0RW5kID0gbV9yYW5nZS5hdEVuZCgpOwogICAgICAgICBSZWZQdHI8Q1NT UHJpbWl0aXZlVmFsdWU+IHJlc3VsdFogPSBjb25zdW1lTGVuZ3RoKG1fcmFuZ2UsIG1fY29udGV4 dC5tb2RlLCBWYWx1ZVJhbmdlQWxsKTsKKyAgICAgICAgaWYgKCFyZXN1bHRaICYmICFhdEVuZCkK KyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgaWYgKCFyZXN1bHRaKQogICAgICAg ICAgICAgcmVzdWx0WiA9IENTU1ZhbHVlUG9vbDo6c2luZ2xldG9uKCkuY3JlYXRlVmFsdWUoMCwg Q1NTUHJpbWl0aXZlVmFsdWU6OlVuaXRUeXBlczo6Q1NTX1BYKTsKICAgICAgICAgYWRkUHJvcGVy dHkoQ1NTUHJvcGVydHlUcmFuc2Zvcm1PcmlnaW5YLCBDU1NQcm9wZXJ0eVRyYW5zZm9ybU9yaWdp biwgcmVzdWx0WC5yZWxlYXNlTm9uTnVsbCgpLCBpbXBvcnRhbnQpOwpJbmRleDogU291cmNlL1dl YkNvcmUvY3NzL3BhcnNlci9DU1NTZWxlY3RvclBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NTZWxlY3RvclBhcnNlci5jcHAJKHJldmlzaW9uIDIw ODEzMykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTU2VsZWN0b3JQYXJzZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00MjAsNiArNDIwLDkgQEAgc3RkOjp1bmlxdWVfcHRyPENTU1Bh cnNlclNlbGVjdG9yPiBDU1NTZQogewogICAgIEFTU0VSVChyYW5nZS5wZWVrKCkudHlwZSgpID09 IExlZnRCcmFja2V0VG9rZW4pOwogICAgIENTU1BhcnNlclRva2VuUmFuZ2UgYmxvY2sgPSByYW5n ZS5jb25zdW1lQmxvY2soKTsKKyAgICBpZiAoYmxvY2suZW5kKCkgPT0gcmFuZ2UuZW5kKCkpCisg ICAgICAgIHJldHVybiBudWxscHRyOyAvLyBObyBdIHdhcyBmb3VuZC4gQmUgc3RyaWN0IGFib3V0 IHRoaXMuCisKICAgICBibG9jay5jb25zdW1lV2hpdGVzcGFjZSgpOwogCiAgICAgQXRvbWljU3Ry aW5nIG5hbWVzcGFjZVByZWZpeDsKQEAgLTU3Miw2ICs1NzUsOCBAQCBzdGQ6OnVuaXF1ZV9wdHI8 Q1NTUGFyc2VyU2VsZWN0b3I+IENTU1NlCiAgICAgICAgICAgICAgICAgY29uc3QgQ1NTUGFyc2Vy VG9rZW4mIGlkZW50ID0gYmxvY2suY29uc3VtZSgpOwogICAgICAgICAgICAgICAgIGlmICghZXF1 YWxJZ25vcmluZ0FTQ0lJQ2FzZShpZGVudC52YWx1ZSgpLCAib2YiKSkKICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgICAgICAgICAgICAgaWYgKGJsb2NrLnBlZWsoKS50 eXBlKCkgIT0gV2hpdGVzcGFjZVRva2VuKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gbnVs bHB0cjsKICAgICAgICAgICAgICAgICBEaXNhbGxvd1BzZXVkb0VsZW1lbnRzU2NvcGUgc2NvcGUo dGhpcyk7CiAgICAgICAgICAgICAgICAgYmxvY2suY29uc3VtZVdoaXRlc3BhY2UoKTsKICAgICAg ICAgICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8Q1NTU2VsZWN0b3JMaXN0PiBzZWxlY3Rvckxpc3Qg PSBzdGQ6OnVuaXF1ZV9wdHI8Q1NTU2VsZWN0b3JMaXN0PihuZXcgQ1NTU2VsZWN0b3JMaXN0KCkp OwpAQCAtNjcxLDE2ICs2NzYsMjUgQEAgQ1NTU2VsZWN0b3I6OlJlbGF0aW9uVHlwZSBDU1NTZWxl Y3RvclBhcgogICAgIFVDaGFyIGRlbGltaXRlciA9IHJhbmdlLnBlZWsoKS5kZWxpbWl0ZXIoKTsK IAogICAgIGlmIChkZWxpbWl0ZXIgPT0gJysnIHx8IGRlbGltaXRlciA9PSAnficgfHwgZGVsaW1p dGVyID09ICc+JykgewotICAgICAgICByYW5nZS5jb25zdW1lSW5jbHVkaW5nV2hpdGVzcGFjZSgp OwotICAgICAgICBpZiAoZGVsaW1pdGVyID09ICcrJykKKyAgICAgICAgaWYgKGRlbGltaXRlciA9 PSAnKycpIHsKKyAgICAgICAgICAgIHJhbmdlLmNvbnN1bWVJbmNsdWRpbmdXaGl0ZXNwYWNlKCk7 CiAgICAgICAgICAgICByZXR1cm4gQ1NTU2VsZWN0b3I6OkRpcmVjdEFkamFjZW50OwotICAgICAg ICBpZiAoZGVsaW1pdGVyID09ICd+JykKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgaWYg KGRlbGltaXRlciA9PSAnficpIHsKKyAgICAgICAgICAgIHJhbmdlLmNvbnN1bWVJbmNsdWRpbmdX aGl0ZXNwYWNlKCk7CiAgICAgICAgICAgICByZXR1cm4gQ1NTU2VsZWN0b3I6OkluZGlyZWN0QWRq YWNlbnQ7CisgICAgICAgIH0KKyAgICAgICAgCiAjaWYgRU5BQkxFX0NTU19TRUxFQ1RPUlNfTEVW RUw0Ci0gICAgICAgIGlmIChkZWxpbWl0ZXIgPT0gJz4nICYmIHJhbmdlLnBlZWsoKS50eXBlKCkg PT0gRGVsaW1pdGVyVG9rZW4gJiYgcmFuZ2UucGVlaygpLmRlbGltaXRlcigpID09ICc+Jykgewor ICAgICAgICByYW5nZS5jb25zdW1lKCk7CisgICAgICAgIGlmIChyYW5nZS5wZWVrKCkudHlwZSgp ID09IERlbGltaXRlclRva2VuICYmIHJhbmdlLnBlZWsoKS5kZWxpbWl0ZXIoKSA9PSAnPicpIHsK ICAgICAgICAgICAgIHJhbmdlLmNvbnN1bWVJbmNsdWRpbmdXaGl0ZXNwYWNlKCk7CiAgICAgICAg ICAgICByZXR1cm4gQ1NTU2VsZWN0b3I6OkRlc2NlbmRhbnREb3VibGVDaGlsZDsKICAgICAgICAg fQorICAgICAgICByYW5nZS5jb25zdW1lV2hpdGVzcGFjZSgpOworI2Vsc2UKKyAgICAgICAgcmFu Z2UuY29uc3VtZUluY2x1ZGluZ1doaXRlc3BhY2UoKTsKICNlbmRpZgogICAgICAgICByZXR1cm4g Q1NTU2VsZWN0b3I6OkNoaWxkOwogICAgIH0K 293379 2016-10-30 18:18:22 -0700 2016-10-30 18:18:22 -0700 Archive of layout-test-results from ews125 for ios-simulator-wk2 layout-test-results.zip application/zip 0 buildbot