164210 2016-10-30 15:25:43 -0700 [CSS Parser] Fix nth-child serialization 2016-10-30 15:36:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 1246276 0 hyatt 2016-10-30 15:25:43 -0700 [CSS Parser] Fix nth-child serialization 1246278 1 293371 hyatt 2016-10-30 15:29:21 -0700 Created attachment 293371 Patch 1246280 2 293371 darin 2016-10-30 15:33:23 -0700 Comment on attachment 293371 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293371&action=review I assume all of this gets covered by tests when we turn on the new CSS parser? > Source/WebCore/css/parser/CSSSelectorParser.cpp:544 > + const CSSParserToken& argumentStart = block.peek(); Why not auto&? > Source/WebCore/css/parser/CSSSelectorParser.cpp:565 > + const CSSParserToken& argumentEnd = block.peek(); Why not auto&? 1246283 3 hyatt 2016-10-30 15:36:05 -0700 Landed in r208133. 293371 2016-10-30 15:29:21 -0700 2016-10-30 15:33:23 -0700 Patch bug-164210-20161030172526.patch text/plain 3259 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODEzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDE2LTEwLTMwICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBGaXggbnRoLWNo aWxkIHNlcmlhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NDIxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE91ciBudGgtY2hpbGQgc2VyaWFsaXphdGlvbiBwcmVzZXJ2ZXMgd2hhdCB0aGUg YXV0aG9yIG9yaWdpbmFsbHkKKyAgICAgICAgdHlwZWQuIEV2ZW4gdGhvdWdoIHRoaXMgaXMgbm90 IHNwZWMtY29tcGxpYW50ICh0aGUgbGF0ZXN0IENTUyBTeW50YXgKKyAgICAgICAgc3BlYyBoYXMg YSBkdW1iZWQgZG93biBzZXJpYWxpemF0aW9uIHByb2Nlc3MgdGhhdCBkb2Vzbid0IHByZXNlcnZl IHdoYXQKKyAgICAgICAgdGhlIGF1dGhvciBvcmlnaW5hbGx5IHR5cGVkKSwgSSB0aGluayBpdCdz IGJldHRlciBiZWhhdmlvciB0byBwcmVzZXJ2ZQorICAgICAgICB0aGlzIHRleHQuCisKKyAgICAg ICAgKiBjc3MvcGFyc2VyL0NTU1BhcnNlclRva2VuLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNT U1BhcnNlclRva2VuOjpzZXJpYWxpemUpOgorICAgICAgICBGaXggYSBidWcgaW4gdGhlIHNlcmlh bGl6YXRpb24gb2YgbnVtYmVyIHRva2VucyB0aGF0IHN0YXJ0ZWQgd2l0aAorICAgICAgICBhIHBs dXMgc2lnbi4gTWFrZSBzdXJlIHRoZSBwbHVzIHNpZ24gaXMgcHJlc2VydmVkLgorCisgICAgICAg ICogY3NzL3BhcnNlci9DU1NTZWxlY3RvclBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD U1NTZWxlY3RvclBhcnNlcjo6Y29uc3VtZVBzZXVkbyk6CisgICAgICAgIEdyYWIgdGhlIHJhbmdl IG9mIHRva2VucyBmcm9tIGFmdGVyIHRoZSAoIGFuZCB1cCB0byB0aGUgKSBvciB0aGUgIm9mIgor ICAgICAgICBhbmQgdGhlbiBzZXJpYWxpemUgdGhlbS4gU3RyaXAgd2hpdGVwc2FjZSBmcm9tIHRo ZSBlbmRzIGFuZCBzZXQgdGhhdAorICAgICAgICBhcyB0aGUgc2VsZWN0b3IgYXJndW1lbnQuCisK IDIwMTYtMTAtMjggIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgW1dpbl1bRGlyZWN0MkRdIENvcnJlY3QgYm9va2tlZXBpbmcgZm9yIGJlZ2luL2VuZCBkcmF3 IHBhaXJzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlclRva2VuLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlclRva2Vu LmNwcAkocmV2aXNpb24gMjA4MTMwKQorKysgU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQ YXJzZXJUb2tlbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxMiw2ICs0MTIsOCBAQCB2b2lkIENT U1BhcnNlclRva2VuOjpzZXJpYWxpemUoU3RyaW5nQnVpCiAgICAgICAgIHJldHVybiBidWlsZGVy LmFwcGVuZChkZWxpbWl0ZXIoKSk7CiAgICAgY2FzZSBOdW1iZXJUb2tlbjoKICAgICAgICAgLy8g VGhlc2Ugd29uJ3QgcHJvcGVybHkgcHJlc2VydmUgdGhlIE51bWVyaWNWYWx1ZVR5cGUgZmxhZwor ICAgICAgICBpZiAobV9udW1lcmljU2lnbiA9PSBQbHVzU2lnbikKKyAgICAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kKCcrJyk7CiAgICAgICAgIHJldHVybiBidWlsZGVyLmFwcGVuZE51bWJlcihudW1l cmljVmFsdWUoKSk7CiAgICAgY2FzZSBQZXJjZW50YWdlVG9rZW46CiAgICAgICAgIGJ1aWxkZXIu YXBwZW5kTnVtYmVyKG51bWVyaWNWYWx1ZSgpKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9w YXJzZXIvQ1NTU2VsZWN0b3JQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2Nzcy9wYXJzZXIvQ1NTU2VsZWN0b3JQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDgxMzApCisrKyBT b3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1NlbGVjdG9yUGFyc2VyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTQwLDcgKzU0MCw5IEBAIHN0ZDo6dW5pcXVlX3B0cjxDU1NQYXJzZXJTZWxlY3Rv cj4gQ1NTU2UKICAgICBibG9jay5jb25zdW1lV2hpdGVzcGFjZSgpOwogICAgIGlmICh0b2tlbi50 eXBlKCkgIT0gRnVuY3Rpb25Ub2tlbikKICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0KKyAgICAK KyAgICBjb25zdCBDU1NQYXJzZXJUb2tlbiYgYXJndW1lbnRTdGFydCA9IGJsb2NrLnBlZWsoKTsK KyAgICAKICAgICBpZiAoc2VsZWN0b3ItPm1hdGNoKCkgPT0gQ1NTU2VsZWN0b3I6OlBzZXVkb0Ns YXNzKSB7CiAgICAgICAgIHN3aXRjaCAoc2VsZWN0b3ItPnBzZXVkb0NsYXNzVHlwZSgpKSB7CiAg ICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6OlBzZXVkb0NsYXNzTm90OiB7CkBAIC01NjAsNiArNTYy LDEwIEBAIHN0ZDo6dW5pcXVlX3B0cjxDU1NQYXJzZXJTZWxlY3Rvcj4gQ1NTU2UKICAgICAgICAg ICAgIGlmICghY29uc3VtZUFOUGx1c0IoYmxvY2ssIGFiKSkKICAgICAgICAgICAgICAgICByZXR1 cm4gbnVsbHB0cjsKICAgICAgICAgICAgIGJsb2NrLmNvbnN1bWVXaGl0ZXNwYWNlKCk7CisgICAg ICAgICAgICBjb25zdCBDU1NQYXJzZXJUb2tlbiYgYXJndW1lbnRFbmQgPSBibG9jay5wZWVrKCk7 CisgICAgICAgICAgICBDU1NQYXJzZXJUb2tlblJhbmdlIHJhbmdlT2ZBTlBsdXNCID0gYmxvY2su bWFrZVN1YlJhbmdlKCZhcmd1bWVudFN0YXJ0LCAmYXJndW1lbnRFbmQpOworICAgICAgICAgICAg U3RyaW5nIGFyZ3VtZW50ID0gcmFuZ2VPZkFOUGx1c0Iuc2VyaWFsaXplKCk7CisgICAgICAgICAg ICBzZWxlY3Rvci0+c2V0QXJndW1lbnQoYXJndW1lbnQuc3RyaXBXaGl0ZVNwYWNlKCkpOwogICAg ICAgICAgICAgaWYgKCFibG9jay5hdEVuZCgpKSB7CiAgICAgICAgICAgICAgICAgaWYgKGJsb2Nr LnBlZWsoKS50eXBlKCkgIT0gSWRlbnRUb2tlbikKICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IG51bGxwdHI7Cg==