16421 2007-12-13 10:22:17 -0800 REGRESSION(r28669): Page scrolls down when you hit space key in text area 2007-12-13 14:18:20 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows XP RESOLVED FIXED Regression P1 Normal --- 1 louise6380 ap oldest_to_newest 64087 0 louise6380 2007-12-13 10:22:17 -0800 When you are focused in text input area, hitting space key makes the page scroll down. Steps to reproduce: 1) Move the focus to text input area (ex. the comment input area of this page) 2) hit space key Actual Result: a space is entered in the text area but also the page is scrolled down. Expected Result: a space is entered in the text area without scrolling. tested with Safari 3.0.4 (523.12.9) webkit r28669, Windows XP SP2 -Doesn't occur on Safari 3.0.4 (523.12.9) webkit r28586, Windows XP SP2 (previous nightly) 64106 1 17879 ap 2007-12-13 13:41:16 -0800 Created attachment 17879 proposed fix 64110 2 ap 2007-12-13 14:18:20 -0800 Committed revision 28695. 17879 2007-12-13 13:41:16 -0800 2007-12-13 13:49:36 -0800 proposed fix 16421r1_patch.txt text/plain 5263 ap SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiAyODY5NCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMTItMTMgIEFsZXhleSBQcm9za3VyeWFrb3Yg IDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDIxCisg ICAgICAgIFJFR1JFU1NJT04ocjI4NjY5KTogUGFnZSBzY3JvbGxzIGRvd24gd2hlbiB5b3UgaGl0 IHNwYWNlIGtleSBpbiB0ZXh0IGFyZWEKKworICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAg ICAoV2ViVmlldzo6a2V5RG93bik6CisgICAgICAgIChXZWJWaWV3OjprZXlQcmVzcyk6CisgICAg ICAgIE1vdmVkIHNwYWNlIGhhbmRsaWluZyB0byBrZXlQcmVzcygpIHRvIGZpeCB0aGlzIGJ1ZyBh bmQgdG8gbWF0Y2ggSUUuIFNjcm9sbGluZyB2aWEgYXJyb3cga2V5cyBpcyBjb3JyZWN0bHkgaGFu ZGxlZAorICAgICAgICBpbiBrZXlEb3duKCkuCisKIDIwMDctMTItMTIgIEJyYWR5IEVpZHNvbiAg PGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcKSW5k ZXg6IFdlYktpdC93aW4vV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9XZWJW aWV3LmNwcAkocmV2aXNpb24gMjg2NDUpCisrKyBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNDIzLDcgKzE0MjMsNyBAQCBib29sIFdlYlZpZXc6OmtleURvd24oV1BB UkFNIHZpcnR1YWxLZXlDCiAgICAgZWxzZSBpZiAodmlydHVhbEtleUNvZGUgPT0gVktfQkFDSyB8 fCAodmlydHVhbEtleUNvZGUgPT0gVktfTEVGVCAmJiBrZXlFdmVudC5jdHJsS2V5KCkpKQogICAg ICAgICBtX3BhZ2UtPmdvQmFjaygpOwogICAgIAotICAgIC8vIE5lZWQgdG8gc2Nyb2xsIHRoZSBw YWdlIGlmIHRoZSBhcnJvdyBrZXlzLCBzcGFjZShzaGlmdCksIHBndXAvZG4sIG9yIGhvbWUvZW5k IGFyZSBoaXQuCisgICAgLy8gTmVlZCB0byBzY3JvbGwgdGhlIHBhZ2UgaWYgdGhlIGFycm93IGtl eXMsIHBndXAvZG4sIG9yIGhvbWUvZW5kIGFyZSBoaXQuCiAgICAgU2Nyb2xsRGlyZWN0aW9uIGRp cmVjdGlvbjsKICAgICBTY3JvbGxHcmFudWxhcml0eSBncmFudWxhcml0eTsKICAgICBzd2l0Y2gg KHZpcnR1YWxLZXlDb2RlKSB7CkBAIC0xNDUxLDEwICsxNDUxLDYgQEAgYm9vbCBXZWJWaWV3Ojpr ZXlEb3duKFdQQVJBTSB2aXJ0dWFsS2V5QwogICAgICAgICAgICAgZ3JhbnVsYXJpdHkgPSBTY3Jv bGxCeURvY3VtZW50OwogICAgICAgICAgICAgZGlyZWN0aW9uID0gU2Nyb2xsRG93bjsKICAgICAg ICAgICAgIGJyZWFrOwotICAgICAgICBjYXNlIFZLX1NQQUNFOgotICAgICAgICAgICAgZ3JhbnVs YXJpdHkgPSBTY3JvbGxCeVBhZ2U7Ci0gICAgICAgICAgICBkaXJlY3Rpb24gPSAoR2V0S2V5U3Rh dGUoVktfU0hJRlQpICYgMHg4MDAwKSA/IFNjcm9sbFVwIDogU2Nyb2xsRG93bjsKLSAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICBjYXNlIFZLX1BSSU9SOgogICAgICAgICAgICAgZ3JhbnVsYXJp dHkgPSBTY3JvbGxCeVBhZ2U7CiAgICAgICAgICAgICBkaXJlY3Rpb24gPSBTY3JvbGxVcDsKQEAg LTE0NjQsOCArMTQ2MCw2IEBAIGJvb2wgV2ViVmlldzo6a2V5RG93bihXUEFSQU0gdmlydHVhbEtl eUMKICAgICAgICAgICAgIGRpcmVjdGlvbiA9IFNjcm9sbERvd247CiAgICAgICAgICAgICBicmVh azsKICAgICAgICAgZGVmYXVsdDoKLSAgICAgICAgICAgIC8vIFdlIHdhbnQgdG8gbGV0IFdpbmRv d3MgaGFuZGxlIHRoZSBXTV9TWVNDSEFSIGV2ZW50IGlmIHdlIGNhbid0IGhhbmRsZSBpdAotICAg ICAgICAgICAgLy8gV2UgZG8gd2FudCB0byByZXR1cm4gdHJ1ZSBmb3IgcmVndWxhciBrZXkgZG93 biBjYXNlIHNvIHRoZSBXTV9DSEFSIGhhbmRsZXIgd29uJ3QgcGljayB1cCB1bmhhbmRsZWQgbWVz c2FnZXMKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKQEAgLTE0NzksNyArMTQ3 MywxNyBAQCBib29sIFdlYlZpZXc6OmtleVByZXNzKFdQQVJBTSBjaGFyQ29kZSwgCiAgICAgRnJh bWUqIGZyYW1lID0gbV9wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1l KCk7CiAKICAgICBQbGF0Zm9ybUtleWJvYXJkRXZlbnQga2V5RXZlbnQobV92aWV3V2luZG93LCBj aGFyQ29kZSwga2V5RGF0YSwgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpDaGFyLCBzeXN0ZW1LZXlE b3duKTsKLSAgICByZXR1cm4gZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5rZXlFdmVudChrZXlFdmVu dCk7CisgICAgaWYgKGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+a2V5RXZlbnQoa2V5RXZlbnQpKQor ICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIC8vIE5lZWQgdG8gc2Nyb2xsIHRoZSBwYWdlIGlm IHNwYWNlIGlzIGhpdC4KKyAgICBpZiAoY2hhckNvZGUgPT0gJyAnKSB7CisgICAgICAgIFNjcm9s bERpcmVjdGlvbiBkaXJlY3Rpb24gPSBrZXlFdmVudC5zaGlmdEtleSgpID8gU2Nyb2xsVXAgOiBT Y3JvbGxEb3duOworICAgICAgICBpZiAoIWZyYW1lLT5ldmVudEhhbmRsZXIoKS0+c2Nyb2xsT3Zl cmZsb3coZGlyZWN0aW9uLCBTY3JvbGxCeVBhZ2UpKQorICAgICAgICAgICAgZnJhbWUtPnZpZXco KS0+c2Nyb2xsKGRpcmVjdGlvbiwgU2Nyb2xsQnlQYWdlKTsKKyAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfQorICAgIHJldHVybiBmYWxzZTsKIH0KIAogYm9vbCBXZWJWaWV3OjppblJlc2l6ZXIo TFBBUkFNIGxQYXJhbSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4Njk0KQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTItMTMgIEFs ZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NDIxCisgICAgICAgIFJFR1JFU1NJT04ocjI4NjY5KTogUGFnZSBzY3JvbGxz IGRvd24gd2hlbiB5b3UgaGl0IHNwYWNlIGtleSBpbiB0ZXh0IGFyZWEKKworICAgICAgICAqIGZh c3QvZXZlbnRzL3NwYWNlLXNjcm9sbC1ldmVudC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZXZlbnRzL3NwYWNlLXNjcm9sbC1ldmVudC5odG1sOiBBZGRlZC4KKwogMjAwNy0x Mi0xMyAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv c3BhY2Utc2Nyb2xsLWV2ZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9zcGFjZS1zY3JvbGwtZXZlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvc3BhY2Utc2Nyb2xsLWV2ZW50LWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACitUZXN0IGZvciBidWcgMTYyNDE6IFJF R1JFU1NJT04ocjI4NjY5KTogUGFnZSBzY3JvbGxzIGRvd24gd2hlbiB5b3UgaGl0IHNwYWNlIGtl eSBpbiB0ZXh0IGFyZWEuCisKK1RvIHRlc3QgbWFudWFsbHksIHByZXNzIFNwYWNlIC0gdGhlIHBh Z2Ugc2hvdWxkIG5vdCBzY3JvbGwuCisKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvc3BhY2Utc2Nyb2xsLWV2ZW50LWV4cGVjdGVkLnR4dApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Ck5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0L3BsYWluCk5hbWU6IHN2bjplb2wtc3R5bGUK ICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGFjZS1zY3JvbGwt ZXZlbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9zcGFjZS1z Y3JvbGwtZXZlbnQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRz L3NwYWNlLXNjcm9sbC1ldmVudC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE1IEBACis8 Ym9keT4KKzxwPlRlc3QgZm9yIDxhIGhyZWY9Imh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NDIxIj5idWcgMTYyNDE8L2E+OgorUkVHUkVTU0lPTihyMjg2NjkpOiBQYWdl IHNjcm9sbHMgZG93biB3aGVuIHlvdSBoaXQgc3BhY2Uga2V5IGluIHRleHQgYXJlYS48L3A+Cis8 cD5UbyB0ZXN0IG1hbnVhbGx5LCBwcmVzcyBTcGFjZSAtIHRoZSBwYWdlIHNob3VsZCBub3Qgc2Ny b2xsLjwvcD4KKzxkaXYgc3R5bGU9IndpZHRoOjE7aGVpZ2h0OjUwMDAiPjwvZGl2PgorPHNjcmlw dD4KK2RvY3VtZW50Lm9ua2V5cHJlc3M9ZnVuY3Rpb24oKXtyZXR1cm4gZmFsc2U7fQorZG9jdW1l bnQub25zY3JvbGw9ZnVuY3Rpb24oKXthbGVydCgiRkFJTCAtIHNjcm9sbGVkISIpO30KKworaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKKyAgICBldmVudFNlbmRlci5rZXlEb3duKCIgIiwgW10pOworfQorPC9z Y3JpcHQ+Cis8L2JvZHk+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9zcGFjZS1zY3JvbGwtZXZlbnQuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5 cGUKICAgKyB0ZXh0L2h0bWwKCg==