<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>164204</bug_id>
          
          <creation_ts>2016-10-30 08:18:19 -0700</creation_ts>
          <short_desc>[GTK] Plugin process crash in WebKit::NetscapePluginX11::visibilityDidChange with evince browser plugin</short_desc>
          <delta_ts>2016-12-06 08:00:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Plug-ins</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugzilla.redhat.com/show_bug.cgi?id=1344157</see_also>
    
    <see_also>https://bugzilla.redhat.com/show_bug.cgi?id=1334971</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1246207</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-30 08:18:19 -0700</bug_when>
    <thetext>An Evince browser plugin crash. Full backtrace downstream as usual. Truncated backtrace:

Thread no. 1 (10 frames)
 #0 gdk_window_has_impl at gdkwindow.c:626
 #1 _gdk_window_has_impl at gdkwindow.c:627
 #2 gdk_x11_window_get_xid at gdkwindow-x11.c:5542
 #3 WebKit::NetscapePluginX11::visibilityDidChange at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:267
 #4 WebKit::PluginControllerProxy::visibilityDidChange at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:437
 #5 IPC::callMemberFunctionImpl&lt;WebKit::PluginControllerProxy, void (WebKit::PluginControllerProxy::*)(bool), std::tuple&lt;bool&gt;, 0ul&gt;(WebKit::PluginControllerProxy*, void (WebKit::PluginControllerProxy::*)(bool), std::tuple&lt;bool&gt;&amp;&amp;, std::index_sequence&lt;0ul&gt;) at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/HandleMessage.h:16
 #6 IPC::callMemberFunction&lt;WebKit::PluginControllerProxy, void (WebKit::PluginControllerProxy::*)(bool), std::tuple&lt;bool&gt;, std::make_index_sequence&lt;1ul&gt; &gt;(std::tuple&lt;bool&gt;&amp;&amp;, WebKit::PluginControllerProxy*, void (WebKit::PluginControllerProxy::*)(bool)) at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/HandleMessage.h:22
 #7 IPC::handleMessage&lt;Messages::PluginControllerProxy::MutedStateChanged, WebKit::PluginControllerProxy, void (WebKit::PluginControllerProxy::*)(bool)&gt; at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/Platform/IPC/HandleMessage.h:92
 #8 WebKit::PluginControllerProxy::didReceivePluginControllerProxyMessage at /usr/src/debug/webkitgtk-2.12.3/x86_64-redhat-linux-gnu/DerivedSources/WebKit2/PluginControllerProxyMessageReceiver.cpp:53
 #9 WebKit::WebProcessConnection::didReceiveMessage at /usr/src/debug/webkitgtk-2.12.3/Source/WebKit2/PluginProcess/WebProcessConnection.cpp:141</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246208</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-30 08:21:24 -0700</bug_when>
    <thetext>Here&apos;s a second one: https://bugzilla.gnome.org/show_bug.cgi?id=762838

That one is surely an evince problem though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246412</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-31 06:59:49 -0700</bug_when>
    <thetext>For some reason the plug is not embedded when NetscapePluginX11::visibilityDidChange is called. Do you remember if you were doing any tab drag an drop when this happened? Or was it after closing the tab?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246445</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-10-31 09:15:07 -0700</bug_when>
    <thetext>I don&apos;t remember, unfortunately I originally reported this in June and it just didn&apos;t make it upstream.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246465</commentid>
    <comment_count>4</comment_count>
      <attachid>293430</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-10-31 09:44:30 -0700</bug_when>
    <thetext>Created attachment 293430
Speculative fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1246466</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-10-31 09:45:55 -0700</bug_when>
    <thetext>This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at &quot;Source/JavaScriptCore/wasm/wasm.json&quot; and &quot;JSTests/wasm/wasm.json&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1247264</commentid>
    <comment_count>6</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-11-02 02:44:46 -0700</bug_when>
    <thetext>Committed r208272: &lt;http://trac.webkit.org/changeset/208272&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>293430</attachid>
            <date>2016-10-31 09:44:30 -0700</date>
            <delta_ts>2016-10-31 10:47:03 -0700</delta_ts>
            <desc>Speculative fix</desc>
            <filename>wk2-windowed-plugin-crash.diff</filename>
            <type>text/plain</type>
            <size>2218</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No
YW5nZUxvZwppbmRleCAwZWY1OTM0Li43YmM3YjM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg
QEAKIDIwMTYtMTAtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t
PgogCisgICAgICAgIFtHVEtdIFBsdWdpbiBwcm9jZXNzIGNyYXNoIGluIFdlYktpdDo6TmV0c2Nh
cGVQbHVnaW5YMTE6OnZpc2liaWxpdHlEaWRDaGFuZ2Ugd2l0aCBldmluY2UgYnJvd3NlciBwbHVn
aW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDIw
NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoZWNr
IHRoZSBwbGF0Zm9ybSBwbHVnaW4gd2lkZ2V0IGlzIGVtYmVkZGVkIGJlZm9yZSB0cnlpbmcgdG8g
Z2V0IGl0cyBzb2NrZXQgd2luZG93LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL05l
dHNjYXBlL3gxMS9OZXRzY2FwZVBsdWdpblgxMS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNj
YXBlUGx1Z2luWDExOjpnZW9tZXRyeURpZENoYW5nZSk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHNj
YXBlUGx1Z2luWDExOjp2aXNpYmlsaXR5RGlkQ2hhbmdlKToKKworMjAxNi0xMC0zMSAgQ2FybG9z
IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgUGx1Z2luSW5m
b1N0b3JlOjpsb2FkUGx1Z2luc0lmTmVjZXNzYXJ5IGNhbiBzdGlsbCBsb2FkIHBsdWdpbnMgbXVs
dGlwbGUgdGltZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE2NDEwMwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp
bnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luWDExLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dl
YlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCmluZGV4
IDg2ZGU4YmUuLmQwMDk0OTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv
UGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEuY3BwCisrKyBiL1NvdXJjZS9X
ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS94MTEvTmV0c2NhcGVQbHVnaW5YMTEu
Y3BwCkBAIC0yNDUsNiArMjQ1LDggQEAgdm9pZCBOZXRzY2FwZVBsdWdpblgxMTo6Z2VvbWV0cnlE
aWRDaGFuZ2UoKQogICAgIGlmIChtX3BsdWdpbi5pc1dpbmRvd2VkKCkpIHsKICAgICAgICAgdWlu
dDY0X3Qgd2luZG93SUQgPSAwOwogI2lmIFBMQVRGT1JNKEdUSykKKyAgICAgICAgaWYgKCFndGtf
cGx1Z19nZXRfZW1iZWRkZWQoR1RLX1BMVUcobV9wbGF0Zm9ybVBsdWdpbldpZGdldCkpKQorICAg
ICAgICAgICAgcmV0dXJuOwogICAgICAgICB3aW5kb3dJRCA9IHN0YXRpY19jYXN0PHVpbnQ2NF90
PihHREtfV0lORE9XX1hJRChndGtfcGx1Z19nZXRfc29ja2V0X3dpbmRvdyhHVEtfUExVRyhtX3Bs
YXRmb3JtUGx1Z2luV2lkZ2V0KSkpKTsKICNlbmRpZgogICAgICAgICBtX3BsdWdpbi5jb250cm9s
bGVyKCktPndpbmRvd2VkUGx1Z2luR2VvbWV0cnlEaWRDaGFuZ2UobV9wbHVnaW4uZnJhbWVSZWN0
SW5XaW5kb3dDb29yZGluYXRlcygpLCBtX3BsdWdpbi5jbGlwUmVjdCgpLCB3aW5kb3dJRCk7CkBA
IC0yNjQsNiArMjY2LDggQEAgdm9pZCBOZXRzY2FwZVBsdWdpblgxMTo6dmlzaWJpbGl0eURpZENo
YW5nZSgpCiAgICAgQVNTRVJUKG1fcGx1Z2luLmlzV2luZG93ZWQoKSk7CiAgICAgdWludDY0X3Qg
d2luZG93SUQgPSAwOwogI2lmIFBMQVRGT1JNKEdUSykKKyAgICBpZiAoIWd0a19wbHVnX2dldF9l
bWJlZGRlZChHVEtfUExVRyhtX3BsYXRmb3JtUGx1Z2luV2lkZ2V0KSkpCisgICAgICAgIHJldHVy
bjsKICAgICB3aW5kb3dJRCA9IHN0YXRpY19jYXN0PHVpbnQ2NF90PihHREtfV0lORE9XX1hJRChn
dGtfcGx1Z19nZXRfc29ja2V0X3dpbmRvdyhHVEtfUExVRyhtX3BsYXRmb3JtUGx1Z2luV2lkZ2V0
KSkpKTsKICNlbmRpZgogICAgIG1fcGx1Z2luLmNvbnRyb2xsZXIoKS0+d2luZG93ZWRQbHVnaW5W
aXNpYmlsaXR5RGlkQ2hhbmdlKG1fcGx1Z2luLmlzVmlzaWJsZSgpLCB3aW5kb3dJRCk7Cg==
</data>
<flag name="review"
          id="316307"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
          </attachment>
      

    </bug>

</bugzilla>