164170 2016-10-28 18:55:46 -0700 [GTK] Build break by missing geoclue-2.0. 2016-10-30 08:59:24 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164205 1 hw1008.kim hw1008.kim bugs-noreply commit-queue oldest_to_newest 1245926 0 hw1008.kim 2016-10-28 18:55:46 -0700 I got the following build error on my initial build for WebkitGTK. -- Checking for module 'geoclue-2.0' -- No package 'geoclue-2.0' found -- Could NOT find GEOCLUE2 (missing: VERSION_OK) -- Checking for module 'geoclue' -- No package 'geoclue' found -- Could NOT find GEOCLUE (missing: GEOCLUE_INCLUDE_DIRS GEOCLUE_LIBRARIES) CMake Error at Source/cmake/OptionsGTK.cmake:253 (message): Geoclue is needed for ENABLE_GEOLOCATION. Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:47 (include) CMakeLists.txt:137 (include) 1245931 1 293266 hw1008.kim 2016-10-28 19:02:08 -0700 Created attachment 293266 Patch 1246024 2 293266 mcatanzaro 2016-10-29 08:05:08 -0700 Comment on attachment 293266 Patch But we do have this function: $(aptIfElse libgeoclue-2-dev libgeoclue-dev) \ I guess it is broken for you for some reason, can you debug it? The pkg-config file should be in the -dev package, so there's no value in installing the base package explicitly. 1246199 3 293345 hw1008.kim 2016-10-30 04:53:11 -0700 Created attachment 293345 Patch 1246200 4 hw1008.kim 2016-10-30 04:53:58 -0700 (In reply to comment #2) > Comment on attachment 293266 [details] > Patch > > But we do have this function: > > $(aptIfElse libgeoclue-2-dev libgeoclue-dev) \ > > I guess it is broken for you for some reason, can you debug it? > > The pkg-config file should be in the -dev package, so there's no value in > installing the base package explicitly. It seems the pc file name installed by libgeoclue-2-dev is libgeoclue-2, not geoclue-2. Is my new patch an appropriate correction? 1246211 5 293345 mcatanzaro 2016-10-30 08:35:57 -0700 Comment on attachment 293345 Patch Ah, yes! Good catch! Seems that geoclue-2.0.pc ensures the D-Bus service exists (and it's what we use to find it in PlatformGTK.cmake). libgeoclue-2.0 is for the library and it's indeed what we're supposed to use here. 1246213 6 mcatanzaro 2016-10-30 08:47:31 -0700 So the reason it builds at all is simple: we do not actually use libgeoclue. Unfortunately while this commit is clearly correct -- the FindGeoClue2 module was broken -- it does mean we're now going to be unnecessarily linking against libgeoclue. :( And it's slightly tricky to fix, because we still have code to support geoclue1, and that code really does need to link to (the obsolete) libgeoclue. But we don't need to support geoclue1 anymore, since geoclue2 has been around for a long time. So I think we should remove the geoclue1 support entirely, and then we can also remove this unnecessary find module and stop linking to libgeoclue. I filed bug #164205 for this. I still give your patch r+, since the Find module was broken and that's what you were fixing. 1246214 7 293345 commit-queue 2016-10-30 08:59:20 -0700 Comment on attachment 293345 Patch Clearing flags on attachment: 293345 Committed r208127: <http://trac.webkit.org/changeset/208127> 1246215 8 commit-queue 2016-10-30 08:59:24 -0700 All reviewed patches have been landed. Closing bug. 293266 2016-10-28 19:02:08 -0700 2016-10-30 04:53:02 -0700 Patch bug-164170-20161029105816.patch text/plain 1148 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MDkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjNhYmFmNGVhNDNmZjkwMWY5MzZkY2VkMDUwMjBkMjk5 MTljZjcxZS4uZDhiMjQyZjkxMWIzZTFiMDM2NzE5M2NlMjNhYTJhY2Q5NDg2MjY4NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE2LTEwLTI4ICBIeW93b24gS2ltICA8aHcxMDA4LmtpbUBzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbR1RLXSBCdWlsZCBicmVhayBieSBtaXNzaW5nIGdlb2NsdWUtMi4wLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MTcwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEgYnVpbGQgYnJl YWsgY2F1c2VkIGJ5IG1pc3NpbmcgZ2VvY2x1ZS0yLjAgcGFja2FnZS4KKworICAgICAgICAqIGd0 ay9pbnN0YWxsLWRlcGVuZGVuY2llczogYWRkIGdlb2NsdWUtMi4wLgorCiAyMDE2LTEwLTI4ICBX ZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIGlPUyBhdXRv Y29ycmVjdGlvbiBkb2VzIG5vdCB0cmlnZ2VyIGFuIGlucHV0IGV2ZW50IG9mIGlucHV0VHlwZSAi aW5zZXJ0UmVwbGFjZW1lbnRUZXh0IgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2luc3RhbGwtZGVw ZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4IDQ2NGIwODUz ZWEyZjY1NTM1NzNlMTMwMGJhODBhZTg4M2Q5YzFmOTguLjY0YTliMWIxYzg5Njg5NmNiM2RhMjIw MWE4YjBlODI4MjgzZjJjYzIgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVu Y2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTk2LDYgKzk2LDcg QEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAgICAgICBjbWFrZSBc CiAgICAgICAgIGZsZXggXAogICAgICAgICBnYXdrIFwKKyAgICAgICAgZ2VvY2x1ZS0yLjAgXAog ICAgICAgICBnbm9tZS1jb21tb24gXAogICAgICAgICBncGVyZiBcCiAgICAgICAgIGd0ay1kb2Mt dG9vbHMgXAo= 293345 2016-10-30 04:53:11 -0700 2016-10-30 08:59:20 -0700 Patch bug-164170-20161030204916.patch text/plain 1175 hw1008.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZEdlb0NsdWUyLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRHZW9DbHVlMi5jbWFrZQppbmRleCAz MTQzYjQ0OTM2NzZlYmI2YjZlYzZiMmViZWUwOGVmOTQ5NzNlN2E4Li5mZDZjNmNmNjgzMzBlYjdl M2I0NWJhZDc4NmEyYWMwMjY0MjRiY2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEdl b0NsdWUyLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR2VvQ2x1ZTIuY21ha2UKQEAgLTMx LDcgKzMxLDcgQEAKICMgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CiAKIGZpbmRfcGFja2FnZShQa2dDb25maWcpCi1wa2dfY2hlY2tfbW9kdWxlcyhHRU9DTFVFMiBn ZW9jbHVlLTIuMCkKK3BrZ19jaGVja19tb2R1bGVzKEdFT0NMVUUyIGxpYmdlb2NsdWUtMi4wKQog CiBzZXQoVkVSU0lPTl9PSyBGQUxTRSkKIGlmIChHRU9DTFVFMl9WRVJTSU9OKQpkaWZmIC0tZ2l0 IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDkzNjFhMDE1Nzk3NmIwMTkwYzcxNzhiMDhm MmVkOTZkMmFiODY2YzIuLmU0YWYxMjg2ZDNlOGFhYjYxZjIwOThiYzhjZDE5MGQ4Mzg2YTZhYmMg MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAor MjAxNi0xMC0zMCAgSHlvd29uIEtpbSAgPGh3MTAwOC5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAg ICAgW0dUS10gQnVpbGQgYnJlYWsgYnkgbWlzc2luZyBnZW9jbHVlLTIuMC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDE3MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmlzZSB0aGUgbW9kdWxlIG5h bWUgZm9yIHBrZ19jaGVja19tb2R1bGVzKCkgaW4gRmluZEdlb0NsdWUyLmNtYWtlLgorCisgICAg ICAgICogU291cmNlL2NtYWtlL0ZpbmRHZW9DbHVlMi5jbWFrZTogcmVwbGFjZSBnZW9jbHVlLTIu MCB3aXRoIGxpYmdlb2NsdWUtMi4wLgorCiAyMDE2LTEwLTI5ICBGdWppaSBIaXJvbm9yaSAgPEhp cm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAgICAgIFtDTWFrZV1bV2luXSBWaXN1YWwgU3R1 ZGlvIGludm9rZXMgbWFrZV9zZXR0aW5ncy5wbCB0d2ljZQo=