164161 2016-10-28 15:58:29 -0700 [DOMJIT] Include identifier name in CallDOMGetter to dump it 2016-10-28 16:22:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1245844 0 ysuzuki 2016-10-28 15:58:29 -0700 Now, CallDOMGetter is super difficult to debug!!! Now, CallDOM is renamed to CallDOMGetter. So this node always has the identifier (since we do not emit this node if the getter is retrieved by getOwnPropertyDescriptor etc.) 1245850 1 293240 ysuzuki 2016-10-28 16:17:42 -0700 Created attachment 293240 Patch 1245851 2 293240 mark.lam 2016-10-28 16:20:23 -0700 Comment on attachment 293240 Patch r=me 1245852 3 ysuzuki 2016-10-28 16:22:02 -0700 Committed r208078: <http://trac.webkit.org/changeset/208078> 293240 2016-10-28 16:17:42 -0700 2016-10-28 16:20:23 -0700 Patch bug-164161-20161029081350.patch text/plain 5502 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ODYyNGRiOTRkMTU5NGVhOTcwMmUyZjNkNDYzMzY1MDYxOGNjNzE5Li40YWIwMzU3OTNlYzk1Zjdm YjAxODQzNDlkZWJmOTk3ZDJjOTE3OWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyNiBAQAogMjAxNi0xMC0yOCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAorICAgICAgICBbRE9NSklUXSBJbmNsdWRlIGlkZW50aWZpZXIgbmFtZSBpbiBDYWxs RE9NR2V0dGVyIHRvIGR1bXAgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2NDE2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhbiBpZGVudGlmaWVyIG51bWJlciB0byBDYWxs RE9NR2V0dGVyRGF0YSBhbmQgdXNlIGl0IHdoZW4gZHVtcGluZyB0aGUgZGF0YS4KKyAgICAgICAg Q2FsbERPTUdldHRlciBkaWQgbm90IGluY2x1ZGUgaWRlbnRpZmllci4gSXQgbWFkZSBDYWxsRE9N R2V0dGVyIHN1cGVyIGhhcmQgdG8gZGVidWcgd2hlbiBkdW1waW5nIERGRyBncmFwaC4KKworICAg ICAgICBUaGUgZHVtcCBiZWNvbWVzIGxpa2UgdGhpcy4KKworICAgICAgICAgICAgQ2FsbERPTUdl dHRlcihDZWxsOkAyMSwgSlN8TXVzdEdlbnxVc2VBc090aGVyLCBOb25ib29saW50MzIsIGlkMHtj dXN0b21HZXR0ZXJ9LCBkb21KSVQgPSAweDQyZjhhMCwgUjpXb3JsZCwgVzpIZWFwLCBFeGl0cywg Q2xvYmJlcnNFeGl0LCBiYyMxNSkgIHByZWRpY3RpbmcgTm9uYm9vbGludDMyCisKKyAgICAgICAg KiBkZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2Rl UGFyc2VyOjpoYW5kbGVET01KSVRHZXR0ZXIpOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2Rl UGFyc2VyOjpoYW5kbGVHZXRCeUlkKToKKyAgICAgICAgKiBkZmcvREZHR3JhcGguY3BwOgorICAg ICAgICAoSlNDOjpERkc6OkdyYXBoOjpkdW1wKToKKyAgICAgICAgKiBkZmcvREZHTm9kZS5oOgor CisyMDE2LTEwLTI4ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCiAg ICAgICAgIFtET01KSVRdIFJlbmFtZSBDYWxsRE9NIHRvIENhbGxET01HZXR0ZXIKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDE1NwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVDb2RlUGFyc2VyLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCmluZGV4IGE4ZWMy YWYwNmFhZjliYTUyZTNmZDA2NWQyNjQ2ZWE1YjgxMGJmZDguLmIyYjM0MDNjNmVhNmVjYTE4MzQ3 ODQwMzcxNjcxZDAzMmM5MTcyNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHQnl0ZUNvZGVQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQnl0ZUNvZGVQYXJzZXIuY3BwCkBAIC0yMTksNyArMjE5LDcgQEAgY2xhc3MgQnl0ZUNvZGVQ YXJzZXIgewogICAgIGJvb2wgaGFuZGxlQ29uc3RhbnRJbnRlcm5hbEZ1bmN0aW9uKE5vZGUqIGNh bGxUYXJnZXROb2RlLCBpbnQgcmVzdWx0T3BlcmFuZCwgSW50ZXJuYWxGdW5jdGlvbiosIGludCBy ZWdpc3Rlck9mZnNldCwgaW50IGFyZ3VtZW50Q291bnRJbmNsdWRpbmdUaGlzLCBDb2RlU3BlY2lh bGl6YXRpb25LaW5kLCBTcGVjdWxhdGVkVHlwZSwgY29uc3QgQ2hlY2tzRnVuY3RvciYgaW5zZXJ0 Q2hlY2tzKTsKICAgICBOb2RlKiBoYW5kbGVQdXRCeU9mZnNldChOb2RlKiBiYXNlLCB1bnNpZ25l ZCBpZGVudGlmaWVyLCBQcm9wZXJ0eU9mZnNldCwgY29uc3QgSW5mZXJyZWRUeXBlOjpEZXNjcmlw dG9yJiwgTm9kZSogdmFsdWUpOwogICAgIE5vZGUqIGhhbmRsZUdldEJ5T2Zmc2V0KFNwZWN1bGF0 ZWRUeXBlLCBOb2RlKiBiYXNlLCB1bnNpZ25lZCBpZGVudGlmaWVyTnVtYmVyLCBQcm9wZXJ0eU9m ZnNldCwgY29uc3QgSW5mZXJyZWRUeXBlOjpEZXNjcmlwdG9yJiwgTm9kZVR5cGUgPSBHZXRCeU9m ZnNldCk7Ci0gICAgYm9vbCBoYW5kbGVET01KSVRHZXR0ZXIoaW50IHJlc3VsdE9wZXJhbmQsIGNv bnN0IEdldEJ5SWRWYXJpYW50JiwgTm9kZSogdGhpc05vZGUsIFNwZWN1bGF0ZWRUeXBlIHByZWRp Y3Rpb24pOworICAgIGJvb2wgaGFuZGxlRE9NSklUR2V0dGVyKGludCByZXN1bHRPcGVyYW5kLCBj b25zdCBHZXRCeUlkVmFyaWFudCYsIE5vZGUqIHRoaXNOb2RlLCB1bnNpZ25lZCBpZGVudGlmaWVy TnVtYmVyLCBTcGVjdWxhdGVkVHlwZSBwcmVkaWN0aW9uKTsKIAogICAgIC8vIENyZWF0ZSBhIHBy ZXNlbmNlIE9iamVjdFByb3BlcnR5Q29uZGl0aW9uIGJhc2VkIG9uIHNvbWUga25vd24gb2Zmc2V0 IGFuZCBzdHJ1Y3R1cmUgc2V0LiBEb2VzIG5vdAogICAgIC8vIGNoZWNrIHRoZSB2YWxpZGl0eSBv ZiB0aGUgY29uZGl0aW9uLCBidXQgaXQgbWF5IHJldHVybiBhIG51bGwgb25lIGlmIGl0IGVuY291 bnRlcnMgYSBjb250cmFkaWN0aW9uLgpAQCAtMjY4MCw3ICsyNjgwLDcgQEAgc3RhdGljIHZvaWQg Ymxlc3NDYWxsRE9NR2V0dGVyKE5vZGUqIG5vZGUpCiAgICAgICAgIG5vZGUtPmNsZWFyRmxhZ3Mo Tm9kZU11c3RHZW5lcmF0ZSk7CiB9CiAKLWJvb2wgQnl0ZUNvZGVQYXJzZXI6OmhhbmRsZURPTUpJ VEdldHRlcihpbnQgcmVzdWx0T3BlcmFuZCwgY29uc3QgR2V0QnlJZFZhcmlhbnQmIHZhcmlhbnQs IE5vZGUqIHRoaXNOb2RlLCBTcGVjdWxhdGVkVHlwZSBwcmVkaWN0aW9uKQorYm9vbCBCeXRlQ29k ZVBhcnNlcjo6aGFuZGxlRE9NSklUR2V0dGVyKGludCByZXN1bHRPcGVyYW5kLCBjb25zdCBHZXRC eUlkVmFyaWFudCYgdmFyaWFudCwgTm9kZSogdGhpc05vZGUsIHVuc2lnbmVkIGlkZW50aWZpZXJO dW1iZXIsIFNwZWN1bGF0ZWRUeXBlIHByZWRpY3Rpb24pCiB7CiAgICAgaWYgKCF2YXJpYW50LmRv bUpJVCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CkBAIC0yNzA0LDYgKzI3MDQsNyBAQCBib29s IEJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVET01KSVRHZXR0ZXIoaW50IHJlc3VsdE9wZXJhbmQsIGNv bnN0IEdldEJ5SWRWYXJpYW50JgogCiAgICAgY2FsbERPTUdldHRlckRhdGEtPmRvbUpJVCA9IGRv bUpJVDsKICAgICBjYWxsRE9NR2V0dGVyRGF0YS0+cGF0Y2hwb2ludCA9IGNhbGxET01HZXR0ZXJQ YXRjaHBvaW50LnB0cigpOworICAgIGNhbGxET01HZXR0ZXJEYXRhLT5pZGVudGlmaWVyTnVtYmVy ID0gaWRlbnRpZmllck51bWJlcjsKIAogICAgIE5vZGUqIGNhbGxET01HZXR0ZXJOb2RlID0gbnVs bHB0cjsKICAgICAvLyBHbG9iYWxPYmplY3Qgb2YgdGhpc05vZGUgaXMgYWx3YXlzIHVzZWQgdG8g Y3JlYXRlIGEgRE9NV3JhcHBlci4KQEAgLTMzMTgsNyArMzMxOSw3IEBAIHZvaWQgQnl0ZUNvZGVQ YXJzZXI6OmhhbmRsZUdldEJ5SWQoCiAgICAgICAgIEFTU0VSVCghZ2V0QnlJZFN0YXR1cy5tYWtl c0NhbGxzKCkpOwogICAgICAgICBHZXRCeUlkVmFyaWFudCB2YXJpYW50ID0gZ2V0QnlJZFN0YXR1 c1swXTsKICAgICAgICAgQVNTRVJUKHZhcmlhbnQuZG9tSklUKCkpOwotICAgICAgICBpZiAoaGFu ZGxlRE9NSklUR2V0dGVyKGRlc3RpbmF0aW9uT3BlcmFuZCwgdmFyaWFudCwgYmFzZSwgcHJlZGlj dGlvbikpIHsKKyAgICAgICAgaWYgKGhhbmRsZURPTUpJVEdldHRlcihkZXN0aW5hdGlvbk9wZXJh bmQsIHZhcmlhbnQsIGJhc2UsIGlkZW50aWZpZXJOdW1iZXIsIHByZWRpY3Rpb24pKSB7CiAgICAg ICAgICAgICBpZiAobV9ncmFwaC5jb21waWxhdGlvbigpKQogICAgICAgICAgICAgICAgIG1fZ3Jh cGguY29tcGlsYXRpb24oKS0+bm90aWNlSW5saW5lZEdldEJ5SWQoKTsKICAgICAgICAgICAgIHJl dHVybjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKaW5kZXggYTBmNTM1ZjQz N2NhOGJjNWE1NGQwMDJiNTM0ZWYwMjllYmFmYTMzMy4uYjg3YzFmZTI2NDRkNWJiYjBlNzc1YTIx YzBkN2YyMmVmMTQ3OTkzZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdHcmFwaC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAK QEAgLTM0OCw2ICszNDgsMTEgQEAgdm9pZCBHcmFwaDo6ZHVtcChQcmludFN0cmVhbSYgb3V0LCBj b25zdCBjaGFyKiBwcmVmaXgsIE5vZGUqIG5vZGUsIER1bXBDb250ZXh0KgogICAgICAgICBvdXQu cHJpbnQoIiwgb2Zmc2V0ID0gIiwgZGF0YS0+b2Zmc2V0LCAiLCBtYW5kYXRvcnlNaW5pbXVtID0g IiwgZGF0YS0+bWFuZGF0b3J5TWluaW11bSk7CiAgICAgICAgIG91dC5wcmludCgiLCBsaW1pdCA9 ICIsIGRhdGEtPmxpbWl0KTsKICAgICB9CisgICAgaWYgKG5vZGUtPmhhc0NhbGxET01HZXR0ZXJE YXRhKCkpIHsKKyAgICAgICAgQ2FsbERPTUdldHRlckRhdGEqIGRhdGEgPSBub2RlLT5jYWxsRE9N R2V0dGVyRGF0YSgpOworICAgICAgICBvdXQucHJpbnQoY29tbWEsICJpZCIsIGRhdGEtPmlkZW50 aWZpZXJOdW1iZXIsICJ7IiwgaWRlbnRpZmllcnMoKVtkYXRhLT5pZGVudGlmaWVyTnVtYmVyXSwg In0iKTsKKyAgICAgICAgb3V0LnByaW50KCIsIGRvbUpJVCA9ICIsIFJhd1BvaW50ZXIoZGF0YS0+ ZG9tSklUKSk7CisgICAgfQogICAgIGlmIChub2RlLT5pc0NvbnN0YW50KCkpCiAgICAgICAgIG91 dC5wcmludChjb21tYSwgcG9pbnRlckR1bXBJbkNvbnRleHQobm9kZS0+Y29uc3RhbnQoKSwgY29u dGV4dCkpOwogICAgIGlmIChub2RlLT5pc0p1bXAoKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdO b2RlLmgKaW5kZXggZmYzOGM4N2E0M2Y1YjYxYWFiYjM2YjlkOTUzMTlmY2E4ODZjYTFkOC4uZGVl MDJjNzgyNTQzNDhmYWYxOTIxNThjMDZhMzBjOTcxZmJhMjNjNCAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdOb2RlLmgKQEAgLTIzNSw2ICsyMzUsNyBAQCBzdHJ1Y3QgU3RhY2tBY2Nlc3NEYXRh IHsKIHN0cnVjdCBDYWxsRE9NR2V0dGVyRGF0YSB7CiAgICAgRE9NSklUOjpHZXR0ZXJTZXR0ZXIq IGRvbUpJVCB7IG51bGxwdHIgfTsKICAgICBET01KSVQ6OkNhbGxET01HZXR0ZXJQYXRjaHBvaW50 KiBwYXRjaHBvaW50IHsgbnVsbHB0ciB9OworICAgIHVuc2lnbmVkIGlkZW50aWZpZXJOdW1iZXIg eyAwIH07CiB9OwogCiAvLyA9PT0gTm9kZSA9PT0K