164153 2016-10-28 14:32:48 -0700 [CSS Parser] Support hanging-punctuation 2016-10-28 14:55:26 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 1245794 0 hyatt 2016-10-28 14:32:48 -0700 [CSS Parser] Support hanging-punctuation 1245795 1 293218 hyatt 2016-10-28 14:33:50 -0700 Created attachment 293218 Patch 1245807 2 293218 simon.fraser 2016-10-28 14:44:34 -0700 Comment on attachment 293218 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=293218&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:3156 > + std::bitset<numCSSValueKeywords> seenValues; Do we really need a bitset with 906 entries when we're just looking for a few values? 1245813 3 hyatt 2016-10-28 14:55:26 -0700 Landed in r208073. 293218 2016-10-28 14:33:50 -0700 2016-10-28 14:44:34 -0700 Patch patch.txt text/plain 2779 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODA2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTI4ICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBTdXBwb3J0IGhh bmdpbmctcHVuY3R1YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NDE1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjb25zdW1lSGFuZ2luZ1B1bmN0dWF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkNT U1Byb3BlcnR5UGFyc2VyOjpwYXJzZVNpbmdsZVZhbHVlKToKKwogMjAxNi0xMC0yOCAgRGF2ZSBI eWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBbQ1NTIFBhcnNlcl0gU3VwcG9ydCBp bml0aWFsLWxldHRlcgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0 eVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQ cm9wZXJ0eVBhcnNlci5jcHAJKHJldmlzaW9uIDIwODA2OSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nz cy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MCw2ICs3 MCw3IEBACiAjaW5jbHVkZSAiU3R5bGVQcm9wZXJ0eVNob3J0aGFuZC5oIgogI2luY2x1ZGUgIlN0 eWxlUHJvcGVydHlTaG9ydGhhbmRGdW5jdGlvbnMuaCIKICNpbmNsdWRlICJXZWJLaXRDU1NUcmFu c2Zvcm1WYWx1ZS5oIgorI2luY2x1ZGUgPGJpdHNldD4KICNpbmNsdWRlIDxtZW1vcnk+CiAjaW5j bHVkZSA8d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogCkBAIC0zMTQ2LDYgKzMxNDcsMjkgQEAg c3RhdGljIFJlZlB0cjxDU1NWYWx1ZT4gY29uc3VtZUluaXRpYWxMZQogICAgIHJldHVybiBjcmVh dGVQcmltaXRpdmVWYWx1ZVBhaXIocG9zaXRpb24ucmVsZWFzZU5vbk51bGwoKSwgV1RGTW92ZSho ZWlnaHQpKTsKIH0KIAorc3RhdGljIFJlZlB0cjxDU1NWYWx1ZT4gY29uc3VtZUhhbmdpbmdQdW5j dHVhdGlvbihDU1NQYXJzZXJUb2tlblJhbmdlJiByYW5nZSkKK3sKKyAgICBpZiAocmFuZ2UucGVl aygpLmlkKCkgPT0gQ1NTVmFsdWVOb25lKQorICAgICAgICByZXR1cm4gY29uc3VtZUlkZW50KHJh bmdlKTsKKyAgICAKKyAgICBSZWZQdHI8Q1NTVmFsdWVMaXN0PiBsaXN0ID0gQ1NTVmFsdWVMaXN0 OjpjcmVhdGVTcGFjZVNlcGFyYXRlZCgpOworICAgIHN0ZDo6Yml0c2V0PG51bUNTU1ZhbHVlS2V5 d29yZHM+IHNlZW5WYWx1ZXM7CisgICAgd2hpbGUgKCFyYW5nZS5hdEVuZCgpKSB7CisgICAgICAg IENTU1ZhbHVlSUQgdmFsdWVJRCA9IHJhbmdlLnBlZWsoKS5pZCgpOworICAgICAgICBpZiAoc2Vl blZhbHVlc1t2YWx1ZUlEXQorICAgICAgICAgICAgfHwgKHZhbHVlSUQgPT0gQ1NTVmFsdWVBbGxv d0VuZCAmJiBzZWVuVmFsdWVzW0NTU1ZhbHVlRm9yY2VFbmRdKQorICAgICAgICAgICAgfHwgKHZh bHVlSUQgPT0gQ1NTVmFsdWVGb3JjZUVuZCAmJiBzZWVuVmFsdWVzW0NTU1ZhbHVlQWxsb3dFbmRd KSkKKyAgICAgICAgICAgIHJldHVybiBudWxscHRyOworICAgICAgICBSZWZQdHI8Q1NTVmFsdWU+ IGlkZW50ID0gY29uc3VtZUlkZW50PENTU1ZhbHVlQWxsb3dFbmQsIENTU1ZhbHVlRm9yY2VFbmQs IENTU1ZhbHVlRmlyc3QsIENTU1ZhbHVlTGFzdD4ocmFuZ2UpOworICAgICAgICBpZiAoIWlkZW50 KQorICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgICAgIHNlZW5WYWx1ZXMuc2V0KHZh bHVlSUQpOworICAgICAgICBsaXN0LT5hcHBlbmQoaWRlbnQucmVsZWFzZU5vbk51bGwoKSk7Cisg ICAgfQorICAgIAorICAgIHJldHVybiBsaXN0LT5sZW5ndGgoKSA/IGxpc3QgOiBudWxscHRyOwor fQorCiBzdGF0aWMgUmVmUHRyPENTU1ZhbHVlPiBjb25zdW1lV2Via2l0TWFycXVlZUluY3JlbWVu dChDU1NQYXJzZXJUb2tlblJhbmdlJiByYW5nZSwgQ1NTUGFyc2VyTW9kZSBjc3NQYXJzZXJNb2Rl KQogewogICAgIGlmIChyYW5nZS5wZWVrKCkudHlwZSgpID09IElkZW50VG9rZW4pCkBAIC0zNTM5 LDYgKzM1NjMsOCBAQCBSZWZQdHI8Q1NTVmFsdWU+IENTU1Byb3BlcnR5UGFyc2VyOjpwYXJzCiAg ICAgICAgIHJldHVybiBjb25zdW1lTGluZUdyaWQobV9yYW5nZSk7CiAgICAgY2FzZSBDU1NQcm9w ZXJ0eVdlYmtpdEluaXRpYWxMZXR0ZXI6CiAgICAgICAgIHJldHVybiBjb25zdW1lSW5pdGlhbExl dHRlcihtX3JhbmdlKTsKKyAgICBjYXNlIENTU1Byb3BlcnR5SGFuZ2luZ1B1bmN0dWF0aW9uOgor ICAgICAgICByZXR1cm4gY29uc3VtZUhhbmdpbmdQdW5jdHVhdGlvbihtX3JhbmdlKTsKICAgICBj YXNlIENTU1Byb3BlcnR5V2Via2l0TWFycXVlZUluY3JlbWVudDoKICAgICAgICAgcmV0dXJuIGNv bnN1bWVXZWJraXRNYXJxdWVlSW5jcmVtZW50KG1fcmFuZ2UsIG1fY29udGV4dC5tb2RlKTsKICAg ICBjYXNlIENTU1Byb3BlcnR5V2Via2l0TWFycXVlZVJlcGV0aXRpb246Cg==