164151 2016-10-28 14:15:46 -0700 [Win][Direct2D] Implement ImageBufferData::putData. 2016-10-28 15:13:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue oldest_to_newest 1245775 0 pvollan 2016-10-28 14:15:46 -0700 This method is not yet implemented for Direct2D. 1245786 1 293214 pvollan 2016-10-28 14:23:54 -0700 Created attachment 293214 Patch 1245791 2 293214 bfulgham 2016-10-28 14:28:42 -0700 Comment on attachment 293214 Patch r=me 1245811 3 pvollan 2016-10-28 14:53:15 -0700 (In reply to comment #2) > Comment on attachment 293214 [details] > Patch > > r=me Thanks for reviewing :) 1245822 4 293214 commit-queue 2016-10-28 15:13:28 -0700 Comment on attachment 293214 Patch Clearing flags on attachment: 293214 Committed r208075: <http://trac.webkit.org/changeset/208075> 1245823 5 commit-queue 2016-10-28 15:13:31 -0700 All reviewed patches have been landed. Closing bug. 293214 2016-10-28 14:23:54 -0700 2016-10-28 15:13:28 -0700 Patch bug-164151-20161028142426.patch text/plain 4708 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwODA2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTI4ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXVtEaXJlY3QyRF0g SW1wbGVtZW50IEltYWdlQnVmZmVyRGF0YTo6cHV0RGF0YS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDE1MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0ltYWdl QnVmZmVyRGF0YURpcmVjdDJELmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyRGF0 YTo6Z2V0RGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlckRhdGE6OnB1dERhdGEp OgorCiAyMDE2LTEwLTI4ICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IFtDU1MgUGFyc2VyXSBTdXBwb3J0IGluaXRpYWwtbGV0dGVyCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vSW1hZ2VCdWZmZXJEYXRhRGlyZWN0MkQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9JbWFnZUJ1ZmZl ckRhdGFEaXJlY3QyRC5jcHAJKHJldmlzaW9uIDIwODA0NykKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3dpbi9JbWFnZUJ1ZmZlckRhdGFEaXJlY3QyRC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTc5LDcgKzc5LDggQEAgUmVmUHRyPFVpbnQ4Q2xhbXBlZEFycmF5PiBJbWFnZUJ1 ZmZlckRhdAogCiAgICAgICAgIG9rID0gOjpCaXRCbHQoYml0bWFwREMuZ2V0KCksIDAsIDAsIHJl Y3Qud2lkdGgoKSwgcmVjdC5oZWlnaHQoKSwgaGRjLCByZWN0LngoKSwgcmVjdC55KCksIFNSQ0NP UFkpOwogCi0gICAgICAgIGhyID0gZ2RpUmVuZGVyVGFyZ2V0LT5SZWxlYXNlREMobnVsbHB0cik7 CisgICAgICAgIFJFQ1QgdXBkYXRlUmVjdCA9IHsgMCwgMCwgMCwgMCB9OworICAgICAgICBociA9 IGdkaVJlbmRlclRhcmdldC0+UmVsZWFzZURDKCZ1cGRhdGVSZWN0KTsKICAgICB9CiAKICAgICBp ZiAoIW9rKQpAQCAtOTAsOSArOTEsNzkgQEAgUmVmUHRyPFVpbnQ4Q2xhbXBlZEFycmF5PiBJbWFn ZUJ1ZmZlckRhdAogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKLXZvaWQgSW1hZ2VCdWZmZXJEYXRh OjpwdXREYXRhKFVpbnQ4Q2xhbXBlZEFycmF5KiYgLyogc291cmNlICovLCBjb25zdCBJbnRTaXpl JiAvKiBzb3VyY2VTaXplICovLCBjb25zdCBJbnRSZWN0JiAvKiBzb3VyY2VSZWN0ICovLCBjb25z dCBJbnRQb2ludCYgLyogZGVzdFBvaW50ICovLCBjb25zdCBJbnRTaXplJiAvKiBzaXplICovLCBi b29sIC8qIGFjY2VsZXJhdGVSZW5kZXJpbmcgKi8sIGJvb2wgLyogdW5tdWx0aXBsaWVkICovLCBm bG9hdCAvKiByZXNvbHV0aW9uU2NhbGUgKi8pCit2b2lkIEltYWdlQnVmZmVyRGF0YTo6cHV0RGF0 YShVaW50OENsYW1wZWRBcnJheSomIHNvdXJjZSwgY29uc3QgSW50U2l6ZSYgc291cmNlU2l6ZSwg Y29uc3QgSW50UmVjdCYgc291cmNlUmVjdCwgY29uc3QgSW50UG9pbnQmIGRlc3RQb2ludCwgY29u c3QgSW50U2l6ZSYgc2l6ZSwgYm9vbCAvKiBhY2NlbGVyYXRlUmVuZGVyaW5nICovLCBib29sIHVu bXVsdGlwbGllZCwgZmxvYXQgcmVzb2x1dGlvblNjYWxlKQogewotICAgIG5vdEltcGxlbWVudGVk KCk7CisgICAgYXV0byBwbGF0Zm9ybUNvbnRleHQgPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQo KTsKKyAgICBDT01QdHI8SUQyRDFCaXRtYXBSZW5kZXJUYXJnZXQ+IHJlbmRlclRhcmdldChRdWVy eSwgcGxhdGZvcm1Db250ZXh0KTsKKyAgICBpZiAoIXJlbmRlclRhcmdldCkKKyAgICAgICAgcmV0 dXJuOworCisgICAgQ09NUHRyPElEMkQxQml0bWFwPiBiaXRtYXA7CisgICAgSFJFU1VMVCBociA9 IHJlbmRlclRhcmdldC0+R2V0Qml0bWFwKCZiaXRtYXApOworICAgIEFTU0VSVChTVUNDRUVERUQo aHIpKTsKKworICAgIEFTU0VSVChzb3VyY2VSZWN0LndpZHRoKCkgPiAwKTsKKyAgICBBU1NFUlQo c291cmNlUmVjdC5oZWlnaHQoKSA+IDApOworCisgICAgQ2hlY2tlZDxpbnQ+IG9yaWdpbnggPSBz b3VyY2VSZWN0LngoKTsKKyAgICBDaGVja2VkPGludD4gZGVzdHggPSAoQ2hlY2tlZDxpbnQ+KGRl c3RQb2ludC54KCkpICsgc291cmNlUmVjdC54KCkpOworICAgIGRlc3R4ICo9IHJlc29sdXRpb25T Y2FsZTsKKyAgICBBU1NFUlQoZGVzdHgudW5zYWZlR2V0KCkgPj0gMCk7CisgICAgQVNTRVJUKGRl c3R4LnVuc2FmZUdldCgpIDwgc2l6ZS53aWR0aCgpKTsKKyAgICBBU1NFUlQob3JpZ2lueC51bnNh ZmVHZXQoKSA+PSAwKTsKKyAgICBBU1NFUlQob3JpZ2lueC51bnNhZmVHZXQoKSA8PSBzb3VyY2VS ZWN0Lm1heFgoKSk7CisKKyAgICBDaGVja2VkPGludD4gZW5keCA9IChDaGVja2VkPGludD4oZGVz dFBvaW50LngoKSkgKyBzb3VyY2VSZWN0Lm1heFgoKSk7CisgICAgZW5keCAqPSByZXNvbHV0aW9u U2NhbGU7CisgICAgQVNTRVJUKGVuZHgudW5zYWZlR2V0KCkgPD0gc2l6ZS53aWR0aCgpKTsKKwor ICAgIENoZWNrZWQ8aW50PiB3aWR0aCA9IHNvdXJjZVJlY3Qud2lkdGgoKTsKKyAgICBDaGVja2Vk PGludD4gZGVzdHcgPSBlbmR4IC0gZGVzdHg7CisKKyAgICBDaGVja2VkPGludD4gb3JpZ2lueSA9 IHNvdXJjZVJlY3QueSgpOworICAgIENoZWNrZWQ8aW50PiBkZXN0eSA9IChDaGVja2VkPGludD4o ZGVzdFBvaW50LnkoKSkgKyBzb3VyY2VSZWN0LnkoKSk7CisgICAgZGVzdHkgKj0gcmVzb2x1dGlv blNjYWxlOworICAgIEFTU0VSVChkZXN0eS51bnNhZmVHZXQoKSA+PSAwKTsKKyAgICBBU1NFUlQo ZGVzdHkudW5zYWZlR2V0KCkgPCBzaXplLmhlaWdodCgpKTsKKyAgICBBU1NFUlQob3JpZ2lueS51 bnNhZmVHZXQoKSA+PSAwKTsKKyAgICBBU1NFUlQob3JpZ2lueS51bnNhZmVHZXQoKSA8PSBzb3Vy Y2VSZWN0Lm1heFkoKSk7CisKKyAgICBDaGVja2VkPGludD4gZW5keSA9IChDaGVja2VkPGludD4o ZGVzdFBvaW50LnkoKSkgKyBzb3VyY2VSZWN0Lm1heFkoKSk7CisgICAgZW5keSAqPSByZXNvbHV0 aW9uU2NhbGU7CisgICAgQVNTRVJUKGVuZHkudW5zYWZlR2V0KCkgPD0gc2l6ZS5oZWlnaHQoKSk7 CisKKyAgICBDaGVja2VkPGludD4gaGVpZ2h0ID0gc291cmNlUmVjdC5oZWlnaHQoKTsKKyAgICBD aGVja2VkPGludD4gZGVzdGggPSBlbmR5IC0gZGVzdHk7CisKKyAgICBpZiAod2lkdGggPD0gMCB8 fCBoZWlnaHQgPD0gMCkKKyAgICAgICAgcmV0dXJuOworCisgICAgdW5zaWduZWQgc3JjQnl0ZXNQ ZXJSb3cgPSA0ICogc291cmNlU2l6ZS53aWR0aCgpOworICAgIHVuc2lnbmVkIGNoYXIqIHNyY1Jv d3MgPSBzb3VyY2UtPmRhdGEoKSArIChvcmlnaW55ICogc3JjQnl0ZXNQZXJSb3cgKyBvcmlnaW54 ICogNCkudW5zYWZlR2V0KCk7CisKKyAgICB1bnNpZ25lZCBjaGFyKiByb3cgPSBuZXcgdW5zaWdu ZWQgY2hhcltzcmNCeXRlc1BlclJvd107CisKKyAgICBmb3IgKGludCB5ID0gMDsgeSA8IGhlaWdo dC51bnNhZmVHZXQoKTsgKyt5KSB7CisgICAgICAgIGZvciAoaW50IHggPSAwOyB4IDwgd2lkdGgu dW5zYWZlR2V0KCk7IHgrKykgeworICAgICAgICAgICAgaW50IGJhc2V4ID0geCAqIDQ7CisgICAg ICAgICAgICB1bnNpZ25lZCBjaGFyIGFscGhhID0gc3JjUm93c1tiYXNleCArIDNdOworICAgICAg ICAgICAgaWYgKHVubXVsdGlwbGllZCAmJiBhbHBoYSAhPSAyNTUpIHsKKyAgICAgICAgICAgICAg ICByb3dbYmFzZXhdID0gKHNyY1Jvd3NbYmFzZXhdICogYWxwaGEgKyAyNTQpIC8gMjU1OworICAg ICAgICAgICAgICAgIHJvd1tiYXNleCArIDFdID0gKHNyY1Jvd3NbYmFzZXggKyAxXSAqIGFscGhh ICsgMjU0KSAvIDI1NTsKKyAgICAgICAgICAgICAgICByb3dbYmFzZXggKyAyXSA9IChzcmNSb3dz W2Jhc2V4ICsgMl0gKiBhbHBoYSArIDI1NCkgLyAyNTU7CisgICAgICAgICAgICAgICAgcm93W2Jh c2V4ICsgM10gPSBhbHBoYTsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIHJl aW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QqPihyb3cgKyBiYXNleClbMF0gPSByZWludGVycHJldF9j YXN0PHVpbnQzMl90Kj4oc3JjUm93cyArIGJhc2V4KVswXTsKKyAgICAgICAgfQorCisgICAgICAg IEQyRDFfUkVDVF9VIGRzdFJlY3QgPSBEMkQxOjpSZWN0VShkZXN0UG9pbnQueCgpLCBkZXN0UG9p bnQueSgpICsgeSwgZGVzdFBvaW50LngoKSArIHNpemUud2lkdGgoKSwgZGVzdFBvaW50LnkoKSAr IHkgKyAxKTsKKyAgICAgICAgaHIgPSBiaXRtYXAtPkNvcHlGcm9tTWVtb3J5KCZkc3RSZWN0LCBy b3csIHNyY0J5dGVzUGVyUm93KTsKKyAgICAgICAgQVNTRVJUKFNVQ0NFRURFRChocikpOworCisg ICAgICAgIHNyY1Jvd3MgKz0gc3JjQnl0ZXNQZXJSb3c7CisgICAgfQorCisgICAgZGVsZXRlW10g cm93OwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==