164125 2016-10-28 06:20:07 -0700 Skip 2 JS stress tests on memory limited devices 2016-10-28 07:24:00 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163937 163996 1 ossy ossy commit-queue ggaren mark.lam oldest_to_newest 1245566 0 ossy 2016-10-28 06:20:07 -0700 JSTests/stress/joined-strings-should-not-exceed-max-string-length.js introduced in r207849 and JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js introduced in r207861. Both of these test consume huge memory, so they should be skipped on memory limited devices. test1 ------ //@ runFTLNoCJIT //@ largeHeap test2 ------ //@ runFTLNoCJIT //@ slow! //@largeHeap The original intention was to skip these tests on memory limited devices, but unfortunately run-jsc-stress-tests script can't handle these annotations properly. RJST doesn't have any complex logic, it simply executes everything after "//@" magic annotation. But runFTLNoCJIT, runDefault, etc. doesn't know if you put largeHeap annotation too to the same test file. There were a similar fix not so long ago in bug162386 . I'm going to land the same workaround to this bug to unbreak JSCOnly ARM bots. But please let me know if you know a better and general fix for this RJST bug/feature. 1245577 1 293150 ossy 2016-10-28 06:48:02 -0700 Created attachment 293150 Patch for landing 1245580 2 ossy 2016-10-28 06:59:25 -0700 (In reply to comment #0) > JSTests/stress/joined-strings-should-not-exceed-max-string-length.js > introduced in r207849 and > JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error- > when-using-too-much-memory.js > introduced in r207861. Both of these test consume huge memory, so they > should be skipped on memory > limited devices. note: - JSTests/stress/joined-strings-should-not-exceed-max-string-length.js consumes 1.1Gb memory on X86_64 - JSTests/stress/string-prototype-replace-should-throw-out-of-memory-error- > when-using-too-much-memory.js consumes 6.5Gb memory on X86_64 1245587 3 293150 commit-queue 2016-10-28 07:23:56 -0700 Comment on attachment 293150 Patch for landing Clearing flags on attachment: 293150 Committed r208047: <http://trac.webkit.org/changeset/208047> 1245588 4 commit-queue 2016-10-28 07:24:00 -0700 All reviewed patches have been landed. Closing bug. 293150 2016-10-28 06:48:02 -0700 2016-10-28 07:23:56 -0700 Patch for landing bug-164125-20161028154411.patch text/plain 2142 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MDQzCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDVkYjhhNzQxODgzZDNhZTE0ZDg1ZGUyNDE5OGQ3 OTg3ZWEyNzE0ZDAuLjljZjcwYTdmZTk0YmYzNmI1YWUxZTIxNDRiYjY4NjgxNmZjMzdkNWIgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTYtMTAtMjggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0 Lm9yZz4KKworICAgICAgICBTa2lwIDIgSlMgc3RyZXNzIHRlc3RzIG9uIG1lbW9yeSBsaW1pdGVk IGRldmljZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2NDEyNQorCisgICAgICAgIFVucmV2aWV3ZWQgcXVpY2sgZml4IHRvIHVuYnJlYWsgSlNDT25s eSBBUk0gYm90cyBhcyBzb29uIGFzIHBvc3NpYmxlLgorCisgICAgICAgICogc3RyZXNzL2pvaW5l ZC1zdHJpbmdzLXNob3VsZC1ub3QtZXhjZWVkLW1heC1zdHJpbmctbGVuZ3RoLmpzOgorICAgICAg ICAqIHN0cmVzcy9zdHJpbmctcHJvdG90eXBlLXJlcGxhY2Utc2hvdWxkLXRocm93LW91dC1vZi1t ZW1vcnktZXJyb3Itd2hlbi11c2luZy10b28tbXVjaC1tZW1vcnkuanM6CisKIDIwMTYtMTAtMjcg IENhaXRsaW4gUG90dGVyICA8Y2FpdHBAaWdhbGlhLmNvbT4KIAogICAgICAgICBbSlNDXSBmb3Ji aWQgbGV4aWNhbCByZWRlY2xhcmF0aW9uIG9mIGdlbmVyYXRvciBmb3JtYWwgcGFyYW1ldGVycwpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3Mvam9pbmVkLXN0cmluZ3Mtc2hvdWxkLW5vdC1leGNl ZWQtbWF4LXN0cmluZy1sZW5ndGguanMgYi9KU1Rlc3RzL3N0cmVzcy9qb2luZWQtc3RyaW5ncy1z aG91bGQtbm90LWV4Y2VlZC1tYXgtc3RyaW5nLWxlbmd0aC5qcwppbmRleCBlMjVhNWQwOTZlMWM2 MWYzOWMzNmIyNjA5N2YyZGE1NWQwYzIyZTU5Li42N2YyNDUzNGI3ZTUwNjVjYzM2OGMyNDY0OWZj YjIwN2ZmMTdkMmYxIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9qb2luZWQtc3RyaW5ncy1z aG91bGQtbm90LWV4Y2VlZC1tYXgtc3RyaW5nLWxlbmd0aC5qcworKysgYi9KU1Rlc3RzL3N0cmVz cy9qb2luZWQtc3RyaW5ncy1zaG91bGQtbm90LWV4Y2VlZC1tYXgtc3RyaW5nLWxlbmd0aC5qcwpA QCAtMSw1ICsxLDUgQEAKLS8vQCBydW5GVExOb0NKSVQKIC8vQCBsYXJnZUhlYXAKKy8vQCBydW5G VExOb0NKSVQgaWYgISRtZW1vcnlMaW1pdGVkCiAvLyBUaGlzIHRlc3Qgc2hvdWxkIG5vdCBjcmFz aCBvciBmYWlsIGFueSBhc3NlcnRpb25zLgogCiBmdW5jdGlvbiBzaG91bGRFcXVhbChzdGVwSWQs IGFjdHVhbCwgZXhwZWN0ZWQpIHsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3N0cmluZy1w cm90b3R5cGUtcmVwbGFjZS1zaG91bGQtdGhyb3ctb3V0LW9mLW1lbW9yeS1lcnJvci13aGVuLXVz aW5nLXRvby1tdWNoLW1lbW9yeS5qcyBiL0pTVGVzdHMvc3RyZXNzL3N0cmluZy1wcm90b3R5cGUt cmVwbGFjZS1zaG91bGQtdGhyb3ctb3V0LW9mLW1lbW9yeS1lcnJvci13aGVuLXVzaW5nLXRvby1t dWNoLW1lbW9yeS5qcwppbmRleCBkMDcwMGY2ZjlmNzI4ZTAyYzlkYjhkNzAyOGJlMzcyYTU1MTA3 OGIxLi5iZmY0OTlkNzlkMzI5MWNlODUxNTAxYmE0YTA4NDM0Nzg3ODhhOWJlIDEwMDY0NAotLS0g YS9KU1Rlc3RzL3N0cmVzcy9zdHJpbmctcHJvdG90eXBlLXJlcGxhY2Utc2hvdWxkLXRocm93LW91 dC1vZi1tZW1vcnktZXJyb3Itd2hlbi11c2luZy10b28tbXVjaC1tZW1vcnkuanMKKysrIGIvSlNU ZXN0cy9zdHJlc3Mvc3RyaW5nLXByb3RvdHlwZS1yZXBsYWNlLXNob3VsZC10aHJvdy1vdXQtb2Yt bWVtb3J5LWVycm9yLXdoZW4tdXNpbmctdG9vLW11Y2gtbWVtb3J5LmpzCkBAIC0xLDYgKzEsNiBA QAotLy9AIHJ1bkZUTE5vQ0pJVAorLy9AIGxhcmdlSGVhcAorLy9AIHJ1bkZUTE5vQ0pJVCBpZiAh JG1lbW9yeUxpbWl0ZWQKIC8vQCBzbG93IQotLy9AbGFyZ2VIZWFwCiAvLyBUaGlzIHRlc3Qgc2hv dWxkIG5vdCBjcmFzaCBvciBmYWlsIGFueSBhc3NlcnRpb25zLgogCiBmdW5jdGlvbiBzaG91bGRF cXVhbCh0ZXN0SWQsIGFjdHVhbCwgZXhwZWN0ZWQpIHsK