164104 2016-10-27 20:17:41 -0700 Rename StyleRareNonInheritedData::opacity to m_opacity 2016-10-27 20:25:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue dino esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1245405 0 simon.fraser 2016-10-27 20:17:41 -0700 Rename StyleRareNonInheritedData::opacity to m_opacity 1245406 1 293103 simon.fraser 2016-10-27 20:18:12 -0700 Created attachment 293103 Patch 1245407 2 293103 hyatt 2016-10-27 20:20:51 -0700 Comment on attachment 293103 Patch r=me 1245411 3 simon.fraser 2016-10-27 20:25:24 -0700 https://trac.webkit.org/r208026 293103 2016-10-27 20:18:12 -0700 2016-10-27 20:20:51 -0700 Patch bug-164104-20161027201422.patch text/plain 6238 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4MDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTFkZDYzNDRhN2VkMTA2 MmU2MDdlM2Q2Y2NhYjMxMDViMzYzNGI2Ny4uMTc5MmM2YTdlYzZjYjg1NTg2ZWEzZWM1MGUyNTM5 ODUwOWVmNzE4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTEwLTI3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBTdHls ZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpvcGFjaXR5IHRvIG1fb3BhY2l0eQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MTA0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHVyZSByZW5hbWUuCisKKyAgICAg ICAgKiByZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyU3R5bGU6OmNoYW5nZVJlcXVpcmVzTGF5ZXJSZXBhaW50KToKKyAgICAgICAgKiByZW5k ZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclN0eWxl OjpvcGFjaXR5KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclN0eWxlOjpzZXRPcGFjaXR5KToK KyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpTdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmFyZU5vbkluaGVyaXRl ZERhdGE6Om9wZXJhdG9yPT0pOgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJhcmVOb25Jbmhlcml0 ZWREYXRhOjpoYXNPcGFjaXR5KToKKwogMjAxNi0xMC0yNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFtXZWJJRExdIE1vdmUgY29kZSBnZW5lcmF0b3JzIG9mZiBvZiBk b21TaWduYXR1cmU6OnR5cGUgYW5kIG9udG8gZG9tU2lnbmF0dXJlOjppZGxUeXBlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCA0Mjc1OTY3 OTcyNzYxODgyZjE2MmI1ZmVjZmM4NzAyNGI1NTYzMTcyLi41YWIxMTFiM2IwNjhhYzJjZDkzZjBm MzcwYzQ0NjA0MzJmOWY1NWIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvUmVuZGVyU3R5bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHAKQEAgLTc5NSw3ICs3OTUsNyBAQCBib29sIFJlbmRlclN0eWxlOjpj aGFuZ2VSZXF1aXJlc0xheWVyUmVwYWludChjb25zdCBSZW5kZXJTdHlsZSYgb3RoZXIsIHVuc2ln bmVkJgogICAgICAgICByZXR1cm4gdHJ1ZTsKICNlbmRpZgogCi0gICAgaWYgKHJhcmVOb25Jbmhl cml0ZWREYXRhLT5vcGFjaXR5ICE9IG90aGVyLnJhcmVOb25Jbmhlcml0ZWREYXRhLT5vcGFjaXR5 KSB7CisgICAgaWYgKHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX29wYWNpdHkgIT0gb3RoZXIucmFy ZU5vbkluaGVyaXRlZERhdGEtPm1fb3BhY2l0eSkgewogICAgICAgICBjaGFuZ2VkQ29udGV4dFNl bnNpdGl2ZVByb3BlcnRpZXMgfD0gQ29udGV4dFNlbnNpdGl2ZVByb3BlcnR5T3BhY2l0eTsKICAg ICAgICAgLy8gRG9uJ3QgcmV0dXJuOyBrZWVwIGxvb2tpbmcgZm9yIGFub3RoZXIgY2hhbmdlLgog ICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJT dHlsZS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKaW5k ZXggNGViOTJiYmFjZjRlNGYzZjdhMWQ0MmQ4YTM4NjVlMGU3Y2JhN2I5MS4uMGFjYTI4NWZlMTA5 MTk2Y2I1M2RlYzQwNTc0MjRkNzg4MmU0NmNjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1JlbmRlclN0eWxlLmgKQEAgLTkwNyw3ICs5MDcsNyBAQCBwdWJsaWM6CiAgICAg dm9pZCBnZXRUZXh0U2hhZG93QmxvY2tEaXJlY3Rpb25FeHRlbnQoTGF5b3V0VW5pdCYgbG9naWNh bFRvcCwgTGF5b3V0VW5pdCYgbG9naWNhbEJvdHRvbSkgY29uc3QgeyBnZXRTaGFkb3dCbG9ja0Rp cmVjdGlvbkV4dGVudCh0ZXh0U2hhZG93KCksIGxvZ2ljYWxUb3AsIGxvZ2ljYWxCb3R0b20pOyB9 CiAKICAgICBmbG9hdCB0ZXh0U3Ryb2tlV2lkdGgoKSBjb25zdCB7IHJldHVybiByYXJlSW5oZXJp dGVkRGF0YS0+dGV4dFN0cm9rZVdpZHRoOyB9Ci0gICAgZmxvYXQgb3BhY2l0eSgpIGNvbnN0IHsg cmV0dXJuIHJhcmVOb25Jbmhlcml0ZWREYXRhLT5vcGFjaXR5OyB9CisgICAgZmxvYXQgb3BhY2l0 eSgpIGNvbnN0IHsgcmV0dXJuIHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX29wYWNpdHk7IH0KICAg ICBDb250cm9sUGFydCBhcHBlYXJhbmNlKCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8Q29u dHJvbFBhcnQ+KHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX2FwcGVhcmFuY2UpOyB9CiAgICAgQXNw ZWN0UmF0aW9UeXBlIGFzcGVjdFJhdGlvVHlwZSgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0 PEFzcGVjdFJhdGlvVHlwZT4ocmFyZU5vbkluaGVyaXRlZERhdGEtPm1fYXNwZWN0UmF0aW9UeXBl KTsgfQogICAgIGZsb2F0IGFzcGVjdFJhdGlvKCkgY29uc3QgeyByZXR1cm4gYXNwZWN0UmF0aW9O dW1lcmF0b3IoKSAvIGFzcGVjdFJhdGlvRGVub21pbmF0b3IoKTsgfQpAQCAtMTUxNCw3ICsxNTE0 LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0VGV4dFN0cm9rZUNvbG9yKGNvbnN0IENvbG9yJiBj KSB7IFNFVF9WQVIocmFyZUluaGVyaXRlZERhdGEsIHRleHRTdHJva2VDb2xvciwgYyk7IH0KICAg ICB2b2lkIHNldFRleHRTdHJva2VXaWR0aChmbG9hdCB3KSB7IFNFVF9WQVIocmFyZUluaGVyaXRl ZERhdGEsIHRleHRTdHJva2VXaWR0aCwgdyk7IH0KICAgICB2b2lkIHNldFRleHRGaWxsQ29sb3Io Y29uc3QgQ29sb3ImIGMpIHsgU0VUX1ZBUihyYXJlSW5oZXJpdGVkRGF0YSwgdGV4dEZpbGxDb2xv ciwgYyk7IH0KLSAgICB2b2lkIHNldE9wYWNpdHkoZmxvYXQgZikgeyBmbG9hdCB2ID0gY2xhbXBU bzxmbG9hdD4oZiwgMCwgMSk7IFNFVF9WQVIocmFyZU5vbkluaGVyaXRlZERhdGEsIG9wYWNpdHks IHYpOyB9CisgICAgdm9pZCBzZXRPcGFjaXR5KGZsb2F0IGYpIHsgZmxvYXQgdiA9IGNsYW1wVG88 ZmxvYXQ+KGYsIDAsIDEpOyBTRVRfVkFSKHJhcmVOb25Jbmhlcml0ZWREYXRhLCBtX29wYWNpdHks IHYpOyB9CiAgICAgdm9pZCBzZXRBcHBlYXJhbmNlKENvbnRyb2xQYXJ0IGEpIHsgU0VUX1ZBUihy YXJlTm9uSW5oZXJpdGVkRGF0YSwgbV9hcHBlYXJhbmNlLCBhKTsgfQogICAgIC8vIEZvciB2YWxp ZCB2YWx1ZXMgb2YgYm94LWFsaWduIHNlZSBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDA5L1dELWNz czMtZmxleGJveC0yMDA5MDcyMy8jYWxpZ25tZW50CiAgICAgdm9pZCBzZXRCb3hBbGlnbihFQm94 QWxpZ25tZW50IGEpIHsgU0VUX05FU1RFRF9WQVIocmFyZU5vbkluaGVyaXRlZERhdGEsIG1fZGVw cmVjYXRlZEZsZXhpYmxlQm94LCBhbGlnbiwgYSk7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmNwcApp bmRleCA0OTExZWFkOTk4ZWExN2JkNmZjMTllZDJmMGEzMjFjZGY0ODVjMmNjLi5hY2ExNWUxMjlm N2FhZDU1N2Y5ZmFiNDY3NmVmN2FkYzQ3MWUzOWM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuY3Bw CkBAIC0zNyw3ICszNyw3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFN0eWxlUmFyZU5vbklu aGVyaXRlZERhdGE6OlN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEoKQotICAgIDogb3BhY2l0eShS ZW5kZXJTdHlsZTo6aW5pdGlhbE9wYWNpdHkoKSkKKyAgICA6IG1fb3BhY2l0eShSZW5kZXJTdHls ZTo6aW5pdGlhbE9wYWNpdHkoKSkKICAgICAsIG1fYXNwZWN0UmF0aW9EZW5vbWluYXRvcihSZW5k ZXJTdHlsZTo6aW5pdGlhbEFzcGVjdFJhdGlvRGVub21pbmF0b3IoKSkKICAgICAsIG1fYXNwZWN0 UmF0aW9OdW1lcmF0b3IoUmVuZGVyU3R5bGU6OmluaXRpYWxBc3BlY3RSYXRpb051bWVyYXRvcigp KQogICAgICwgbV9wZXJzcGVjdGl2ZShSZW5kZXJTdHlsZTo6aW5pdGlhbFBlcnNwZWN0aXZlKCkp CkBAIC0xMTksNyArMTE5LDcgQEAgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6U3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YSgpCiAKIGlubGluZSBTdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhOjpT dHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhKGNvbnN0IFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEm IG8pCiAgICAgOiBSZWZDb3VudGVkPFN0eWxlUmFyZU5vbkluaGVyaXRlZERhdGE+KCkKLSAgICAs IG9wYWNpdHkoby5vcGFjaXR5KQorICAgICwgbV9vcGFjaXR5KG8ubV9vcGFjaXR5KQogICAgICwg bV9hc3BlY3RSYXRpb0Rlbm9taW5hdG9yKG8ubV9hc3BlY3RSYXRpb0Rlbm9taW5hdG9yKQogICAg ICwgbV9hc3BlY3RSYXRpb051bWVyYXRvcihvLm1fYXNwZWN0UmF0aW9OdW1lcmF0b3IpCiAgICAg LCBtX3BlcnNwZWN0aXZlKG8ubV9wZXJzcGVjdGl2ZSkKQEAgLTIyNSw3ICsyMjUsNyBAQCBTdHls ZVJhcmVOb25Jbmhlcml0ZWREYXRhOjp+U3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YSgpCiAKIGJv b2wgU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YTo6b3BlcmF0b3I9PShjb25zdCBTdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhJiBvKSBjb25zdAogewotICAgIHJldHVybiBvcGFjaXR5ID09IG8ub3Bh Y2l0eQorICAgIHJldHVybiBtX29wYWNpdHkgPT0gby5tX29wYWNpdHkKICAgICAgICAgJiYgbV9h c3BlY3RSYXRpb0Rlbm9taW5hdG9yID09IG8ubV9hc3BlY3RSYXRpb0Rlbm9taW5hdG9yCiAgICAg ICAgICYmIG1fYXNwZWN0UmF0aW9OdW1lcmF0b3IgPT0gby5tX2FzcGVjdFJhdGlvTnVtZXJhdG9y CiAgICAgICAgICYmIG1fcGVyc3BlY3RpdmUgPT0gby5tX3BlcnNwZWN0aXZlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0 YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRl ZERhdGEuaAppbmRleCA4MGQ5Zjk1OTc0Y2RlZjc3YmQ4MmM4MTI0N2U5MjVjMWYzYWE0YjA2Li43 Yjk4NjE2MjQ2MTI4NmY5ODQ4ZjUyZGIzMTU0ZDdhNWExMDU5NWM3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWRE YXRhLmgKQEAgLTk2LDExICs5NiwxMSBAQCBwdWJsaWM6CiAjaWYgRU5BQkxFKEZJTFRFUlNfTEVW RUxfMikKICAgICBib29sIGhhc0JhY2tkcm9wRmlsdGVycygpIGNvbnN0OwogI2VuZGlmCi0gICAg Ym9vbCBoYXNPcGFjaXR5KCkgY29uc3QgeyByZXR1cm4gb3BhY2l0eSA8IDE7IH0KKyAgICBib29s IGhhc09wYWNpdHkoKSBjb25zdCB7IHJldHVybiBtX29wYWNpdHkgPCAxOyB9CiAKICAgICBib29s IGhhc0FuaW1hdGlvbnNPclRyYW5zaXRpb25zKCkgY29uc3QgeyByZXR1cm4gbV9hbmltYXRpb25z IHx8IG1fdHJhbnNpdGlvbnM7IH0KIAotICAgIGZsb2F0IG9wYWNpdHk7CisgICAgZmxvYXQgbV9v cGFjaXR5OwogCiAgICAgZmxvYXQgbV9hc3BlY3RSYXRpb0Rlbm9taW5hdG9yOwogICAgIGZsb2F0 IG1fYXNwZWN0UmF0aW9OdW1lcmF0b3I7Cg==