16410 2007-12-12 06:03:13 -0800 Implement isKeypadEvent() on Windows 2007-12-12 09:24:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Enhancement --- 1 ap ap oliver oldest_to_newest 64013 0 ap 2007-12-12 06:03:13 -0800 Currently, key location is not determined by PlatformKeyboardEvent on Windows. Patch forthcoming. 64018 1 17863 ap 2007-12-12 06:33:31 -0800 Created attachment 17863 proposed patch 64029 2 17863 darin 2007-12-12 08:41:30 -0800 Comment on attachment 17863 proposed patch r=me 64031 3 ap 2007-12-12 08:58:46 -0800 Committed revision 28652. 64033 4 17863 aroben 2007-12-12 09:24:19 -0800 Comment on attachment 17863 proposed patch Looks like Darin meant r+ 17863 2007-12-12 06:33:31 -0800 2007-12-12 09:24:19 -0800 proposed patch numpad.txt text/plain 7100 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODY0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMTItMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDEwCisgICAgICAgIElt cGxlbWVudCBpc0tleXBhZEV2ZW50KCkgb24gV2luZG93cworCisgICAgICAgIFRlc3Q6IHBsYXRm b3JtL3dpbi9mYXN0L2V2ZW50cy9rZXlMb2NhdGlvbi1udW1wYWQuaHRtbAorCisgICAgICAgICog cGxhdGZvcm0vd2luL0tleUV2ZW50V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmlzS2V5cGFk RXZlbnQpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6 UGxhdGZvcm1LZXlib2FyZEV2ZW50KTogQWxzbyBmaXhlZCBhIG1pc3Rha2Ugd2l0aCBhdXRvcmVw ZWF0LgorCiAyMDA3LTEyLTEyICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS93aW4vS2V5 RXZlbnRXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vd2luL0tleUV2ZW50 V2luLmNwcAkocmV2aXNpb24gMjg2NDUpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3dpbi9LZXlFdmVu dFdpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0Miw2ICsxNDIsNDggQEAgc3RhdGljIFN0cmlu ZyBrZXlJZGVudGlmaWVyRm9yV2luZG93c0tleQogICAgIH0KIH0KIAorc3RhdGljIGJvb2wgaXNL ZXlwYWRFdmVudChXUEFSQU0gY29kZSwgTFBBUkFNIGtleURhdGEsIFBsYXRmb3JtS2V5Ym9hcmRF dmVudDo6VHlwZSB0eXBlKQoreworICAgIGlmICh0eXBlICE9IFBsYXRmb3JtS2V5Ym9hcmRFdmVu dDo6UmF3S2V5RG93biAmJiB0eXBlICE9IFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6S2V5VXApCisg ICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHN3aXRjaCAoY29kZSkgeworICAgICAgICBjYXNl IFZLX05VTUxPQ0s6CisgICAgICAgIGNhc2UgVktfTlVNUEFEMDoNCisgICAgICAgIGNhc2UgVktf TlVNUEFEMToNCisgICAgICAgIGNhc2UgVktfTlVNUEFEMjoNCisgICAgICAgIGNhc2UgVktfTlVN UEFEMzoNCisgICAgICAgIGNhc2UgVktfTlVNUEFENDoNCisgICAgICAgIGNhc2UgVktfTlVNUEFE NToNCisgICAgICAgIGNhc2UgVktfTlVNUEFENjoNCisgICAgICAgIGNhc2UgVktfTlVNUEFENzoN CisgICAgICAgIGNhc2UgVktfTlVNUEFEODoNCisgICAgICAgIGNhc2UgVktfTlVNUEFEOToNCisg ICAgICAgIGNhc2UgVktfTVVMVElQTFk6DQorICAgICAgICBjYXNlIFZLX0FERDoNCisgICAgICAg IGNhc2UgVktfU0VQQVJBVE9SOg0KKyAgICAgICAgY2FzZSBWS19TVUJUUkFDVDoNCisgICAgICAg IGNhc2UgVktfREVDSU1BTDoNCisgICAgICAgIGNhc2UgVktfRElWSURFOg0KKyAgICAgICAgICAg IHJldHVybiB0cnVlOw0KKyAgICAgICAgY2FzZSBWS19SRVRVUk46DQorICAgICAgICAgICAgcmV0 dXJuIChrZXlEYXRhID4+IDE2KSAmIEtGX0VYVEVOREVEOw0KKyAgICAgICAgY2FzZSBWS19JTlNF UlQ6DQorICAgICAgICBjYXNlIFZLX0RFTEVURToNCisgICAgICAgIGNhc2UgVktfUFJJT1I6DQor ICAgICAgICBjYXNlIFZLX05FWFQ6DQorICAgICAgICBjYXNlIFZLX0VORDoNCisgICAgICAgIGNh c2UgVktfSE9NRToNCisgICAgICAgIGNhc2UgVktfTEVGVDoNCisgICAgICAgIGNhc2UgVktfVVA6 DQorICAgICAgICBjYXNlIFZLX1JJR0hUOg0KKyAgICAgICAgY2FzZSBWS19ET1dOOg0KKyAgICAg ICAgICAgIHJldHVybiAhKChrZXlEYXRhID4+IDE2KSAmIEtGX0VYVEVOREVEKTsNCisgICAgICAg IGRlZmF1bHQ6DQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOw0KKyAgICB9DQorfQorCiBzdGF0 aWMgaW5saW5lIFN0cmluZyBzaW5nbGVDaGFyYWN0ZXJTdHJpbmcoVUNoYXIgYykgeyByZXR1cm4g U3RyaW5nKCZjLCAxKTsgfQogCiBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9h cmRFdmVudChIV05ELCBXUEFSQU0gY29kZSwgTFBBUkFNIGtleURhdGEsIFR5cGUgdHlwZSwgYm9v bCBzeXN0ZW1LZXkpCkBAIC0xNDksOSArMTkxLDkgQEAgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQ bGF0Zm9ybUtleWJvYXJkRQogICAgICwgbV90ZXh0KCh0eXBlID09IENoYXIpID8gc2luZ2xlQ2hh cmFjdGVyU3RyaW5nKGNvZGUpIDogU3RyaW5nKCkpCiAgICAgLCBtX3VubW9kaWZpZWRUZXh0KCh0 eXBlID09IENoYXIpID8gc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGNvZGUpIDogU3RyaW5nKCkpCiAg ICAgLCBtX2tleUlkZW50aWZpZXIoKHR5cGUgPT0gQ2hhcikgPyBTdHJpbmcoKSA6IGtleUlkZW50 aWZpZXJGb3JXaW5kb3dzS2V5Q29kZShjb2RlKSkKLSAgICAsIG1fYXV0b1JlcGVhdChrZXlEYXRh ICYgS0ZfUkVQRUFUKQorICAgICwgbV9hdXRvUmVwZWF0KChrZXlEYXRhID4+IDE2KSAmIEtGX1JF UEVBVCkKICAgICAsIG1fd2luZG93c1ZpcnR1YWxLZXlDb2RlKCh0eXBlID09IFJhd0tleURvd24g fHwgdHlwZSA9PSBLZXlVcCkgPyBjb2RlIDogMCkKLSAgICAsIG1faXNLZXlwYWQoZmFsc2UpIC8v IEZJWE1FOiBOZWVkIHRvIGltcGxlbWVudCB0aGlzLgorICAgICwgbV9pc0tleXBhZChpc0tleXBh ZEV2ZW50KGNvZGUsIGtleURhdGEsIHR5cGUpKQogICAgICwgbV9zaGlmdEtleShHZXRLZXlTdGF0 ZShWS19TSElGVCkgJiBISUdIX0JJVF9NQVNLX1NIT1JUKQogICAgICwgbV9jdHJsS2V5KEdldEtl eVN0YXRlKFZLX0NPTlRST0wpICYgSElHSF9CSVRfTUFTS19TSE9SVCkKICAgICAsIG1fYWx0S2V5 KEdldEtleVN0YXRlKFZLX01FTlUpICYgSElHSF9CSVRfTUFTS19TSE9SVCkKQEAgLTE2Miw3ICsy MDQsNyBAQCBQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OlBsYXRmb3JtS2V5Ym9hcmRFCiAKIHZvaWQg UGxhdGZvcm1LZXlib2FyZEV2ZW50OjpkaXNhbWJpZ3VhdGVLZXlEb3duRXZlbnQoVHlwZSwgYm9v bCkKIHsKLSAgICAvLyBObyBLZXlEb3duIGV2ZW50cyBoZXJlIHRvIGNoYW5nZS4KKyAgICAvLyBO byBLZXlEb3duIGV2ZW50cyBvbiBXaW5kb3dzIHRvIGRpc2FtYmlndWF0ZS4KICAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjg2NDcpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwNy0xMi0x MiAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY0MTAKKyAgICAgICAgSW1wbGVtZW50IGlzS2V5cGFkRXZlbnQoKSBv biBXaW5kb3dzCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMva2V5TG9jYXRp b24tbnVtcGFkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vd2luL2Zh c3QvZXZlbnRzL2tleUxvY2F0aW9uLW51bXBhZC5odG1sOiBBZGRlZC4KKwogMjAwNy0xMi0xMiAg QWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgT2xpdmVyLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZXZlbnRzL2tl eUxvY2F0aW9uLW51bXBhZC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2luL2Zhc3QvZXZlbnRzL2tleUxvY2F0aW9uLW51bXBhZC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMva2V5 TG9jYXRpb24tbnVtcGFkLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw5IEBA CitUZXN0IGZvciBidWcgMTY0MTA6IEltcGxlbWVudCBpc0tleXBhZEV2ZW50KCkgb24gV2luZG93 cworCitrZXlkb3duOiBET01fS0VZX0xPQ0FUSU9OX05VTVBBRAora2V5dXA6IERPTV9LRVlfTE9D QVRJT05fTlVNUEFECitrZXlkb3duOiBET01fS0VZX0xPQ0FUSU9OX05VTVBBRAora2V5dXA6IERP TV9LRVlfTE9DQVRJT05fTlVNUEFECitrZXlkb3duOiBET01fS0VZX0xPQ0FUSU9OX05VTVBBRAor a2V5dXA6IERPTV9LRVlfTE9DQVRJT05fU1RBTkRBUkQKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjog TGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZXZlbnRzL2tleUxvY2F0aW9uLW51bXBhZC1l eHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9wbGFp bgpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRleDogTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2luL2Zhc3QvZXZlbnRzL2tleUxvY2F0aW9uLW51bXBhZC5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2ZW50cy9rZXlMb2NhdGlvbi1udW1w YWQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2 ZW50cy9rZXlMb2NhdGlvbi1udW1wYWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MSBA QAorPGJvZHk+CisgICAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MTAiPmJ1ZyAxNjQxMDwvYT46CisgICAgICAgIEltcGxlbWVu dCBpc0tleXBhZEV2ZW50KCkgb24gV2luZG93cworICAgIDwvcD4KKyAgICA8ZGl2IGNvbnRlbnRl ZGl0YWJsZSBpZD1jZSBvbmtleXVwPSJrZXlFdmVudChldmVudCkiIG9ua2V5ZG93bj0ia2V5RXZl bnQoZXZlbnQpIj48L2Rpdj4KKyAgICA8ZGl2IGlkPSJsb2ciPjwvZGl2PgorICAgIDxzY3JpcHQ+ CisgICAgICAgIGZ1bmN0aW9uIGxvY2F0aW9uTmFtZShjb2RlKSB7DQorICAgICAgICAgIHN3aXRj aCAoY29kZSkgew0KKyAgICAgICAgICAgIGNhc2UgMDoNCisgICAgICAgICAgICAgICAgcmV0dXJu ICJET01fS0VZX0xPQ0FUSU9OX1NUQU5EQVJEIjsNCisgICAgICAgICAgICBjYXNlIDE6DQorICAg ICAgICAgICAgICAgIHJldHVybiAiRE9NX0tFWV9MT0NBVElPTl9MRUZUIjsNCisgICAgICAgICAg ICBjYXNlIDI6DQorICAgICAgICAgICAgICAgIHJldHVybiAiRE9NX0tFWV9MT0NBVElPTl9SSUdI VCI7DQorICAgICAgICAgICAgY2FzZSAzOg0KKyAgICAgICAgICAgICAgICByZXR1cm4gIkRPTV9L RVlfTE9DQVRJT05fTlVNUEFEIjsNCisgICAgICAgICAgICBkZWZhdWx0Og0KKyAgICAgICAgICAg ICAgICByZXR1cm4gY29kZS50b1N0cmluZygpOw0KKyAgICAgICAgICB9DQorICAgICAgICB9DQor CisgICAgICAgIGZ1bmN0aW9uIGtleUV2ZW50KGV2ZW50KSB7CisgICAgICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgibG9nIikuaW5uZXJIVE1MICs9IChldmVudC50eXBlICsgIjogIiAr IGxvY2F0aW9uTmFtZShldmVudC5rZXlMb2NhdGlvbikgKyAiPGJyPiIpOworICAgICAgICB9CisK KyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNlIikuZm9jdXMoKTsKKworICAgICAg ICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLmRp c3BhdGNoTWVzc2FnZShldmVudFNlbmRlci5XTV9LRVlET1dOLCA5NiAvKiBWS19OVU1QQUQwICov LCAweDAwNTIwMDAxKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLmRpc3BhdGNoTWVzc2FnZShl dmVudFNlbmRlci5XTV9LRVlVUCwgOTYgLyogVktfTlVNUEFEMCAqLywgMHhjMDUyMDAwMSk7Cisg ICAgICAgICAgICBldmVudFNlbmRlci5kaXNwYXRjaE1lc3NhZ2UoZXZlbnRTZW5kZXIuV01fS0VZ RE9XTiwgNDUgLyogVktfSU5TRVJUICovLCAweDAwNTIwMDAxKTsKKyAgICAgICAgICAgIGV2ZW50 U2VuZGVyLmRpc3BhdGNoTWVzc2FnZShldmVudFNlbmRlci5XTV9LRVlVUCwgNDUgLyogVktfSU5T RVJUICovLCAweGMwNTIwMDAxKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLmRpc3BhdGNoTWVz c2FnZShldmVudFNlbmRlci5XTV9LRVlET1dOLCAxMyAvKiBWS19SRVRVUk4gKi8sIDB4MDExYzAw MDEpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIuZGlzcGF0Y2hNZXNzYWdlKGV2ZW50U2VuZGVy LldNX0tFWVVQLCAxMyAvKiBWS19SRVRVUk4gKi8sIDB4YzExYzAwMDEpOworICAgICAgICB9IGVs c2UKKyAgICAgICAgICAgIGRvY3VtZW50LndyaXRlKCJUbyB0ZXN0IG1hbnVhbGx5LCBwcmVzcyBh bnkga2V5IG9uIG51bXBhZC4iKTsKKyAgICA8L3NjcmlwdD4KKzwvYm9keT4KClByb3BlcnR5IGNo YW5nZXMgb246IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2ZW50cy9rZXlMb2NhdGlv bi1udW1wYWQuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjpleGVjdXRhYmxlCiAgICsgKgpOYW1l OiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCgo=