16408 2007-12-11 23:33:17 -0800 back/forward HTTP navigations fail to prefer loading from cache 2007-12-12 14:37:59 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) PC All RESOLVED FIXED P2 Major --- 1 fishd fishd oldest_to_newest 64000 0 fishd 2007-12-11 23:33:17 -0800 back/forward HTTP navigations fail to prefer loading from cache HTTPS navigations however are aggressively served from cache on back/forward. it seems like the behavior of HTTP and HTTPS on back/forward is reversed from what it should be. here's the code that seems wrong: case FrameLoadTypeIndexedBackForward: if (itemURL.protocol() == "https") request.setCachePolicy(ReturnCacheDataElseLoad); break; this code is in FrameLoader::loadItem i believe that the sense of that comparison should be reversed. 64003 1 17860 fishd 2007-12-11 23:57:41 -0800 Created attachment 17860 patch: reverse sense 64009 2 17860 mjs 2007-12-12 04:53:34 -0800 Comment on attachment 17860 patch: reverse sense r=me 64055 3 oliver 2007-12-12 14:37:59 -0800 Landed r28662 17860 2007-12-11 23:57:41 -0800 2007-12-12 04:53:34 -0800 patch: reverse sense bug16408-1.diff text/plain 1239 fishd SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gMjg2 MzkpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwNy0x Mi0xMSAgTW9yZ2FuTCAgPG1vcmdhbmwud2Via2l0QHlhaG9vLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlczoKKyAgICAgICAgaHR0cDov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MDgKKworICAgICAgICBXaGVuIG5h dmlnYXRpbmcgYmFjay9mb3J3YXJkIHRvIGEgaHR0cDovLyBsaW5rLCB3ZSBzaG91bGQgcHJlZmVy IHRvCisgICAgICAgIGxvYWQgZnJvbSBjYWNoZSBpZiBwb3NzaWJsZS4KKworICAgICAgICAqIGxv YWRlclxGcmFtZUxvYWRlci5jcHANOgorCiAyMDA3LTEyLTExICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBsb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAkocmV2aXNpb24gMjg2MzkpCisrKyBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00MDU4LDcgKzQwNTgsNyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpsb2FkSXRlbShIaXN0 b3J5SXRlbSogCiAgICAgICAgICAgICAgICAgICAgIGNhc2UgRnJhbWVMb2FkVHlwZUJhY2s6CiAg ICAgICAgICAgICAgICAgICAgIGNhc2UgRnJhbWVMb2FkVHlwZUZvcndhcmQ6CiAgICAgICAgICAg ICAgICAgICAgIGNhc2UgRnJhbWVMb2FkVHlwZUluZGV4ZWRCYWNrRm9yd2FyZDoKLSAgICAgICAg ICAgICAgICAgICAgICAgIGlmIChpdGVtVVJMLnByb3RvY29sKCkgPT0gImh0dHBzIikKKyAgICAg ICAgICAgICAgICAgICAgICAgIGlmIChpdGVtVVJMLnByb3RvY29sKCkgIT0gImh0dHBzIikKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICByZXF1ZXN0LnNldENhY2hlUG9saWN5KFJldHVybkNh Y2hlRGF0YUVsc2VMb2FkKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICAgICAgICAgICAgICBjYXNlIEZyYW1lTG9hZFR5cGVTdGFuZGFyZDoK