164073 2016-10-27 13:30:59 -0700 Web Inspector: Worker should recover if Inspector is closed and never sent Worker.initialized command 2016-10-27 15:23:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 163844 1 joepeck joepeck bburg joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1245231 0 joepeck 2016-10-27 13:30:59 -0700 Summary: Worker should recover if Inspector is closed and never sent Worker.initialized command In the unlikely event that the Inspector crashes and disconnects from a Worker during initialization it could leave the Worker paused waiting for debugger messages. When we disconnect from a worker we should terminate the debugger message only run loop mode. 1245235 1 293050 joepeck 2016-10-27 13:33:56 -0700 Created attachment 293050 [PATCH] Proposed Fix 1245238 2 293050 bburg 2016-10-27 13:36:49 -0700 Comment on attachment 293050 [PATCH] Proposed Fix Very nice, r=me 1245294 3 joepeck 2016-10-27 15:23:53 -0700 <https://trac.webkit.org/changeset/208011> 293050 2016-10-27 13:33:56 -0700 2016-10-27 13:36:49 -0700 [PATCH] Proposed Fix initialized-recovery.patch text/plain 5764 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMjY5ZmM5Li5lNmJjYzEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMTAt MjcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBXb3JrZXIgc2hvdWxkIHJlY292ZXIgaWYgSW5zcGVjdG9yIGlzIGNsb3NlZCBh bmQgbmV2ZXIgc2VudCBXb3JrZXIuaW5pdGlhbGl6ZWQgY29tbWFuZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MDczCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Ivd29ya2VyL3dvcmtl ci1yZWNvdmVyLWlmLWluc3BlY3Rvci1jbG9zZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGluc3BlY3Rvci93b3JrZXIvd29ya2VyLXJlY292ZXItaWYtaW5zcGVjdG9yLWNsb3NlLmh0 bWw6IEFkZGVkLgorICAgICAgICBUZXN0IHRvIGVuc3VyZSBhIFdvcmtlciByZWNvdmVycyB3aGVu IGl0IGlzIHBhdXNlZCBvbiBvcGVuaW5nIHdhaXRpbmcgZm9yCisgICAgICAgIEluc3BlY3RvciBt ZXNzYWdlcyBhbmQgdGhlIEluc3BlY3RvciBkaXNjb25uZWN0cy4KKwogMjAxNi0xMC0yMiAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEluY2x1ZGUgQ29uc29sZUFnZW50IGluIFdvcmtlcnMgLSByZWFsIGNvbnNvbGUubG9nIHN1 cHBvcnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci93b3JrZXIvd29ya2VyLXJl Y292ZXItaWYtaW5zcGVjdG9yLWNsb3NlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci93b3JrZXIvd29ya2VyLXJlY292ZXItaWYtaW5zcGVjdG9yLWNsb3NlLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hMDkxYjMyCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3dvcmtlci93b3JrZXItcmVjb3Zlci1pZi1p bnNwZWN0b3ItY2xvc2UtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAgQEAKK1Rlc3RzIHRoYXQg YSBXb3JrZXIgcmVjb3ZlcnMgYW5kIHJlc3VtZXMgaWYgV2ViIEluc3BlY3RvciBjbG9zZXMgYmVm b3JlIHNlbmRpbmcgV29ya2VyLmluaXRpYWxpemVkLgorCisKKz09IFJ1bm5pbmcgdGVzdCBzdWl0 ZTogV29ya2VyLkNyZWF0ZUFuZFRlcm1pbmF0ZQorLS0gUnVubmluZyB0ZXN0IGNhc2U6IFdvcmtl ci5lbmFibGUKK1BBR0U6IENyZWF0aW5nIHRoZSB3b3JrZXIuCitQQVNTOiBXb3JrZXIud29ya2Vy Q3JlYXRlZAorUEFHRTogQ2xvc2luZyB0aGUgaW5zcGVjdG9yLgorUEFTUzogV29ya2VyIHJlY292 ZXJlZC4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3dvcmtlci93b3JrZXIt cmVjb3Zlci1pZi1pbnNwZWN0b3ItY2xvc2UuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci93 b3JrZXIvd29ya2VyLXJlY292ZXItaWYtaW5zcGVjdG9yLWNsb3NlLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZDgzZGVjOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci93b3JrZXIvd29ya2VyLXJlY292ZXItaWYtaW5zcGVjdG9yLWNsb3Nl Lmh0bWwKQEAgLTAsMCArMSw2NyBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgor PHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlcy9wcm90b2Nv bC10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitsZXQgd29ya2VyOworbGV0IGV4cGVjdGlu Z1dvcmtlck1lc3NhZ2UgPSBmYWxzZTsKKworZnVuY3Rpb24gY3JlYXRlV29ya2VyKCkgeworICAg IGxvZygiUEFHRTogQ3JlYXRpbmcgdGhlIHdvcmtlci4iKTsKKyAgICB3b3JrZXIgPSBuZXcgV29y a2VyKCJyZXNvdXJjZXMvd29ya2VyLTEuanMiKTsKKyAgICB3b3JrZXIucG9zdE1lc3NhZ2UoImhl bGxvIik7CisgICAgd29ya2VyLm9ubWVzc2FnZSA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAg IGlmIChleHBlY3RpbmdXb3JrZXJNZXNzYWdlKSB7CisgICAgICAgICAgICBsb2coIlBBU1M6IFdv cmtlciByZWNvdmVyZWQuIik7CisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsK KyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGxvZygiRkFJTDogV29ya2VyIHNob3VsZCBo YXZlIGJlZW4gcGF1c2VkISIpOworICAgICAgICAgICAgbG9nKGV2ZW50LmRhdGEpOworICAgICAg ICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgICAgIH0KKyAgICB9Cit9CisKK2Z1 bmN0aW9uIGNsb3NlSW5zcGVjdG9yRnJvbnRlbmRBbmRDb21wbGV0ZVRlc3QoKSB7CisgICAgbG9n KCJQQUdFOiBDbG9zaW5nIHRoZSBpbnNwZWN0b3IuIik7CisgICAgZXhwZWN0aW5nV29ya2VyTWVz c2FnZSA9IHRydWU7CisgICAgd2luZG93LmludGVybmFscy5jbG9zZUR1bW15SW5zcGVjdG9yRnJv bnRlbmQoKTsKKyAgICBzZXRUaW1lb3V0KCgpID0+IHsKKyAgICAgICAgbG9nKCJGQUlMOiBOZXZl ciByZWNlaXZlZCBtZXNzYWdlISIpOworICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsK KyAgICB9LCAxMDAwKTsKK30KKworZnVuY3Rpb24gdGVzdCgpCit7CisgICAgbGV0IHdvcmtlcklk OworCisgICAgbGV0IHN1aXRlID0gUHJvdG9jb2xUZXN0LmNyZWF0ZUFzeW5jU3VpdGUoIldvcmtl ci5DcmVhdGVBbmRUZXJtaW5hdGUiKTsKKworICAgIHN1aXRlLmFkZFRlc3RDYXNlKHsKKyAgICAg ICAgbmFtZTogIldvcmtlci5lbmFibGUiLAorICAgICAgICBkZXNjcmlwdGlvbjogIldvcmtlci5l bmFibGUgaW5mb3JtcyB0aGUgZnJvbnRlbmQgb2YgdGhlIHR3byBleGlzdGluZyBXb3JrZXJzIiwK KyAgICAgICAgdGVzdChyZXNvbHZlLCByZWplY3QpIHsKKyAgICAgICAgICAgIEluc3BlY3RvclBy b3RvY29sLmF3YWl0Q29tbWFuZCh7bWV0aG9kOiAiV29ya2VyLmVuYWJsZSIsIHBhcmFtczoge319 KTsKKyAgICAgICAgICAgIFByb3RvY29sVGVzdC5ldmFsdWF0ZUluUGFnZSgiY3JlYXRlV29ya2Vy KCkiKTsKKyAgICAgICAgICAgIEluc3BlY3RvclByb3RvY29sLmF3YWl0RXZlbnQoe2V2ZW50OiAi V29ya2VyLndvcmtlckNyZWF0ZWQifSkudGhlbigobWVzc2FnZU9iamVjdCkgPT4geworICAgICAg ICAgICAgICAgIFByb3RvY29sVGVzdC5wYXNzKCJXb3JrZXIud29ya2VyQ3JlYXRlZCIpOworCisg ICAgICAgICAgICAgICAgLy8gR2l2ZSB0aGUgd29ya2VyIDUwbXMgdG8gcHJvdmUgaXQgaXMgd2Fp dGluZyBmb3IgSW5zcGVjdGlvbiBpbml0aWFsaXphdGlvbgorICAgICAgICAgICAgICAgIC8vIGFu ZCBpcyB1bmFibGUgdG8gbWVzc2FnZSB0aGUgcGFnZS4gQ2xvc2luZyB0aGUgaW5zcGVjdG9yLCB0 aGUgV29ya2VyIHNob3VsZAorICAgICAgICAgICAgICAgIC8vIHJlY292ZXIgYW5kIHJlc3VtZSBl eGVjdXRpb24uCisgICAgICAgICAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7CisgICAgICAgICAg ICAgICAgICAgIFByb3RvY29sVGVzdC5ldmFsdWF0ZUluUGFnZSgiY2xvc2VJbnNwZWN0b3JGcm9u dGVuZEFuZENvbXBsZXRlVGVzdCgpIik7CisgICAgICAgICAgICAgICAgfSwgNTApOworICAgICAg ICAgICAgfSkuY2F0Y2gocmVqZWN0KTsKKyAgICAgICAgfQorICAgIH0pOworCisgICAgc3VpdGUu cnVuVGVzdENhc2VzQW5kRmluaXNoKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9u bG9hZD0icnVuVGVzdCgpIj4KKzxwPlRlc3RzIHRoYXQgYSBXb3JrZXIgcmVjb3ZlcnMgYW5kIHJl c3VtZXMgaWYgV2ViIEluc3BlY3RvciBjbG9zZXMgYmVmb3JlIHNlbmRpbmcgV29ya2VyLmluaXRp YWxpemVkLjwvcD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1NmZiZDcyLi5jYTRm ODBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMTAtMjcgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBXb3Jr ZXIgc2hvdWxkIHJlY292ZXIgaWYgSW5zcGVjdG9yIGlzIGNsb3NlZCBhbmQgbmV2ZXIgc2VudCBX b3JrZXIuaW5pdGlhbGl6ZWQgY29tbWFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MDczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGVzdDogaW5zcGVjdG9yL3dvcmtlci93b3JrZXItcmVjb3Zlci1p Zi1pbnNwZWN0b3ItY2xvc2UuaHRtbAorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXJJbnNwZWN0 b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJJbnNwZWN0b3JQcm94eTo6ZGlz Y29ubmVjdEZyb21Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVyKToKKyAgICAgICAgRW5zdXJlIHdl IHN0b3AgdGhlIGRlYnVnZ2VyIG9ubHkgdGFzayBsb29wIGlmIG5lZWRlZCB3aGVuIHRoZSBsYXN0 IGRlYnVnZ2VyCisgICAgICAgIG1lc3NhZ2UgY29tZXMgaW4uCisKIDIwMTYtMTAtMjIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbmNsdWRlIENvbnNvbGVBZ2VudCBpbiBXb3JrZXJzIC0gcmVhbCBjb25zb2xlLmxvZyBzdXBw b3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckluc3BlY3RvclBy b3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VySW5zcGVjdG9yUHJveHkuY3Bw CmluZGV4IDkwMWM4OWQuLmNiNTdkMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtl cnMvV29ya2VySW5zcGVjdG9yUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMv V29ya2VySW5zcGVjdG9yUHJveHkuY3BwCkBAIC0xMTksNiArMTE5LDEwIEBAIHZvaWQgV29ya2Vy SW5zcGVjdG9yUHJveHk6OmRpc2Nvbm5lY3RGcm9tV29ya2VySW5zcGVjdG9yQ29udHJvbGxlcigp CiAKICAgICBtX3dvcmtlclRocmVhZC0+cnVuTG9vcCgpLnBvc3RUYXNrRm9yTW9kZShbXSAoU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCkgewogICAgICAgICBkb3duY2FzdDxXb3JrZXJH bG9iYWxTY29wZT4oY29udGV4dCkuaW5zcGVjdG9yQ29udHJvbGxlcigpLmRpc2Nvbm5lY3RGcm9u dGVuZChEaXNjb25uZWN0UmVhc29uOjpJbnNwZWN0b3JEZXN0cm95ZWQpOworCisgICAgICAgIC8v IEluIGNhc2UgdGhlIHdvcmtlciBpcyBwYXVzZWQgcnVubmluZyBkZWJ1Z2dlciB0YXNrcywgZW5z dXJlIHdlIGJyZWFrIG91dCBvZgorICAgICAgICAvLyB0aGUgcGF1c2Ugc2luY2UgdGhpcyB3aWxs IGJlIHRoZSBsYXN0IGRlYnVnZ2VyIHRhc2sgd2Ugc2VuZCB0byB0aGUgd29ya2VyLgorICAgICAg ICBkb3duY2FzdDxXb3JrZXJHbG9iYWxTY29wZT4oY29udGV4dCkudGhyZWFkKCkuc3RvcFJ1bm5p bmdEZWJ1Z2dlclRhc2tzKCk7CiAgICAgfSwgV29ya2VyUnVuTG9vcDo6ZGVidWdnZXJNb2RlKCkp OwogfQogCg==