16406 2007-12-11 19:16:46 -0800 [Gtk] JavaScriptCore needs -lpthread 2007-12-13 11:38:40 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 16411 0 sanxiyn webkit-unassigned alp mh+webkit mrowe oldest_to_newest 63985 0 sanxiyn 2007-12-11 19:16:46 -0800 JavaScriptCore build is missing -lpthread. This results in a build failure like: tmp/collector.o: In function `KJS::currentThreadStackBase()': collector.cpp:(.text+0x203): undefined reference to `pthread_getattr_np' collector.cpp:(.text+0x21b): undefined reference to `pthread_attr_getstack' tmp/collector.o: In function `KJS::Collector::markCurrentThreadConservatively()': collector.cpp:(.text+0x825): undefined reference to `pthread_getattr_np' collector.cpp:(.text+0x83d): undefined reference to `pthread_attr_getstack' collect2: ld returned 1 exit status In Gtk port, JavaScriptCore is built using compiler flags from icu-config. Normally, icu-config output includes -lpthread, like: -lpthread -lm -L/usr/lib -licui18n -licuuc -licudata -lpthread -lm But one doesn't need to link against libpthread when one is using only ICU functions. So as a part of general campaign to reduce spurious library dependency, Debian's icu-config doesn't output -lpthread starting from 3.8-5. Then the output looks like: -lm -L/usr/lib -licui18n -licuuc -licudata -lm 63986 1 17858 sanxiyn 2007-12-11 19:24:37 -0800 Created attachment 17858 Include -lpthread 63988 2 17858 mrowe 2007-12-11 19:50:46 -0800 Comment on attachment 17858 Include -lpthread You should set the review flag to ? if you'd like your patch looked at for review. You should also include a description of your change in the ChangeLog at JavaScriptCore/ChangeLog. See http://webkit.org/coding/contributing.html for more info. The change looks fine to me. It's not great to always add -lpthread as some platforms may not use pthreads, but as JavaScriptCore makes the assumption that they do when building multi-threaded I think it's fine for the meantime. Marking as r- for now pending a ChangeLog entry. Thanks for the patch! 63991 3 17859 alp 2007-12-11 20:20:17 -0800 Created attachment 17859 Remove kjs pthread dependency Proposed fix (needs review from someone who knows the collector and what correct behaviour is when threading is disabled) 63992 4 17859 mrowe 2007-12-11 21:06:58 -0800 Comment on attachment 17859 Remove kjs pthread dependency That will prevent the stack from being scanned at all, which is really bad. 63995 5 mh+webkit 2007-12-11 22:25:33 -0800 Check out bug #15118, which is exactly the same issue, except that in the end, I couldn't reproduce with the icu not having -lpthread in its -config script. 63996 6 mh+webkit 2007-12-11 22:27:49 -0800 (In reply to comment #5) > Check out bug #15118, which is exactly the same issue, except that in the end, > I couldn't reproduce with the icu not having -lpthread in its -config script. It could actually be reproduced by debian buildds... http://buildd.debian.org/fetch.cgi?pkg=webkit;ver=0%7Esvn27674-1;arch=sparc;stamp=1197008842 64032 7 17864 alp 2007-12-12 09:15:55 -0800 Created attachment 17864 Prospective build fix This patch links to pthread only when not building on Windows, and does it in JavaScriptCore.pri rather than testkjs.pro as proposed previously. Untested since I can't reproduce the build breakage. Can someone try this? 64098 8 17864 alp 2007-12-13 11:37:42 -0800 Comment on attachment 17864 Prospective build fix Build fix; tested and works. 64099 9 alp 2007-12-13 11:38:40 -0800 Landed in r28692. 17858 2007-12-11 19:24:37 -0800 2007-12-11 20:20:17 -0800 Include -lpthread lpthread.patch text/plain 480 sanxiyn SW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy90ZXN0a2pzLnBybwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh U2NyaXB0Q29yZS9ranMvdGVzdGtqcy5wcm8JKHJldmlzaW9uIDI4NjM2KQorKysgSmF2YVNjcmlw dENvcmUva2pzL3Rlc3RranMucHJvCSh3b3JraW5nIGNvcHkpCkBAIC0xMCw3ICsxMCw3IEBACiAj cXQtcG9ydDpMSUJTICs9IC1MJCRPVVRQVVRfRElSL2xpYiAtbFF0V2ViS2l0CiBndGstcG9ydCB7 CiAgICAgUU1BS0VfQ1hYRkxBR1MgKz0gJCRzeXN0ZW0oaWN1LWNvbmZpZyAtLWNwcGZsYWdzKQot ICAgIExJQlMgKz0gJCRzeXN0ZW0oaWN1LWNvbmZpZyAtLWxkZmxhZ3MpCisgICAgTElCUyArPSAk JHN5c3RlbShpY3UtY29uZmlnIC0tbGRmbGFncykgLWxwdGhyZWFkCiB9CiBRTUFLRV9SUEFUSERJ UiArPSAkJE9VVFBVVF9ESVIvbGliCiAK 17859 2007-12-11 20:20:17 -0800 2007-12-11 21:06:58 -0800 Remove kjs pthread dependency thread-dep.patch text/plain 1791 alp SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NjM3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTItMTEgIEFscCBUb2tl ciAgPGFscEBhdG9rZXIuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIERlYmlhbiBHTlUvTGludXggJ3Vuc3RhYmxlJyBidWlsZCBmaXguCisKKyAg ICAgICAgbWFya0N1cnJlbnRUaHJlYWRDb25zZXJ2YXRpdmVseSgpIHNob3VsZCBiZSBhIG5vLW9w IHdoZW4gdGhyZWFkaW5nIGlzCisgICAgICAgIGRpc2FibGVkLgorCisgICAgICAgIExvb2tzIGxp a2UgYW4gdW5pbnRlbnRpb25hbCBkZXBlbmRlbmN5IG9uIGxpYnB0aHJlYWQgd2FzIGludHJvZHVj ZWQgYXQKKyAgICAgICAgc29tZSBwb2ludC4KKworICAgICAgICAqIGtqcy9jb2xsZWN0b3IuY3Bw OgorICAgICAgICAoS0pTOjpDb2xsZWN0b3I6Om1hcmtDdXJyZW50VGhyZWFkQ29uc2VydmF0aXZl bHkpOgorCiAyMDA3LTEyLTExICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tq cy9jb2xsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9jb2xsZWN0 b3IuY3BwCShyZXZpc2lvbiAyODYzNykKKysrIEphdmFTY3JpcHRDb3JlL2tqcy9jb2xsZWN0b3Iu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTIsNiArMzEyLDcgQEAgdm9pZCogQ29sbGVjdG9yOjph bGxvY2F0ZU51bWJlcihzaXplX3QgcwogICAgIHJldHVybiBoZWFwQWxsb2NhdGU8TnVtYmVySGVh cD4ocyk7CiB9CiAKKyNpZiBVU0UoTVVMVElQTEVfVEhSRUFEUykKIHN0YXRpYyBpbmxpbmUgdm9p ZCogY3VycmVudFRocmVhZFN0YWNrQmFzZSgpCiB7CiAjaWYgUExBVEZPUk0oREFSV0lOKQpAQCAt MzYwLDYgKzM2MSw3IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCogY3VycmVudFRocmVhZFN0YWNrQmEK ICNlcnJvciBOZWVkIGEgd2F5IHRvIGdldCB0aGUgc3RhY2sgYmFzZSBvbiB0aGlzIHBsYXRmb3Jt CiAjZW5kaWYKIH0KKyNlbmRpZgogCiAjaWYgVVNFKE1VTFRJUExFX1RIUkVBRFMpCiBzdGF0aWMg cHRocmVhZF90IG1haW5UaHJlYWQ7CkBAIC01MzgsNiArNTQwLDcgQEAgdm9pZCBDb2xsZWN0b3I6 Om1hcmtTdGFja09iamVjdHNDb25zZXJ2YQogCiB2b2lkIENvbGxlY3Rvcjo6bWFya0N1cnJlbnRU aHJlYWRDb25zZXJ2YXRpdmVseSgpCiB7CisjaWYgVVNFKE1VTFRJUExFX1RIUkVBRFMpCiAgICAg Ly8gc2V0am1wIGZvcmNlcyB2b2xhdGlsZSByZWdpc3RlcnMgb250byB0aGUgc3RhY2sKICAgICBq bXBfYnVmIHJlZ2lzdGVyczsKICNpZiBDT01QSUxFUihNU1ZDKQpAQCAtNTU0LDYgKzU1Nyw3IEBA IHZvaWQgQ29sbGVjdG9yOjptYXJrQ3VycmVudFRocmVhZENvbnNlcnYKICAgICB2b2lkKiBzdGFj a0Jhc2UgPSBjdXJyZW50VGhyZWFkU3RhY2tCYXNlKCk7CiAKICAgICBtYXJrU3RhY2tPYmplY3Rz Q29uc2VydmF0aXZlbHkoc3RhY2tQb2ludGVyLCBzdGFja0Jhc2UpOworI2VuZGlmCiB9CiAKICNp ZiBVU0UoTVVMVElQTEVfVEhSRUFEUykK 17864 2007-12-12 09:15:55 -0800 2007-12-13 11:37:42 -0800 Prospective build fix pthread-link.patch text/plain 1158 alp SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NjUzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTItMTIgIEFscCBUb2tl ciAgPGFscEBhdG9rZXIuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NDA2 CisgICAgICAgIFtHdGtdIEphdmFTY3JpcHRDb3JlIG5lZWRzIC1scHRocmVhZAorCisgICAgICAg IExpbmsgdG8gcHRocmVhZCBvbiBub24tV2luZG93cyBwbGF0Zm9ybXMgdW50aWwgdGhpcyBkZXBl bmRlbmN5IGlzCisgICAgICAgIHJlbW92ZWQgZnJvbSBKU0MuCisKIDIwMDctMTItMTEgIEdlb2Zm cmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0g V2VpbmlnLgpJbmRleDogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQkocmV2aXNpb24gMjg2NTMp CisrKyBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAg LTksNiArOSwxMCBAQCBxdC1wb3J0OklOQ0xVREVQQVRIICs9ICQkUFdEL2JpbmRpbmdzL3F0CiBx dC1wb3J0OkRFRklORVMgKz0gQlVJTERJTkdfUVRfXwogZ3RrLXBvcnQ6REVGSU5FUyArPSBCVUlM RElOR19HVEtfXwogCisjIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 NDA2CisjIFtHdGtdIEphdmFTY3JpcHRDb3JlIG5lZWRzIC1scHRocmVhZAorZ3RrLXBvcnQ6IXdp bjMyLSo6TElCUyArPSAtbHB0aHJlYWQKKwogd2luMzItbXN2Yyo6IElOQ0xVREVQQVRIICs9ICQk UFdEL29zLXdpbjMyCiAKIGlzRW1wdHkoR0VORVJBVEVEX1NPVVJDRVNfRElSKTpHRU5FUkFURURf U09VUkNFU19ESVIgPSB0bXAK