<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>16404</bug_id>
          
          <creation_ts>2007-12-11 12:50:35 -0800</creation_ts>
          <short_desc>[WX] ASSERT failures in HashTable for FontPlatformData</short_desc>
          <delta_ts>2007-12-15 17:58:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit wx</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Kevin Watters">kevinwatters</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kevino</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>63956</commentid>
    <comment_count>0</comment_count>
    <who name="Kevin Watters">kevinwatters</who>
    <bug_when>2007-12-11 12:50:35 -0800</bug_when>
    <thetext>The WX port fails randomly with an ASSERT(!isDeletedBucket...) on line 721 of HashTable.h when navigating to several websites.

FontPlatformData&apos;s &quot;Deleted&quot; constructor appears to be the fault, since it will compare equal to a FontPlatformData created with the default constructor.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63957</commentid>
    <comment_count>1</comment_count>
      <attachid>17854</attachid>
    <who name="Kevin Watters">kevinwatters</who>
    <bug_when>2007-12-11 12:53:25 -0800</bug_when>
    <thetext>Created attachment 17854
Changes the FontPlatformData(Deleted) constructor so that m_font is -1 instead of 0

This patch follows the other ports in using -1 as a &quot;Deleted&quot; value which must be different than the NULL used in the default constructor.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63974</commentid>
    <comment_count>2</comment_count>
      <attachid>17854</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-12-11 16:05:11 -0800</bug_when>
    <thetext>Comment on attachment 17854
Changes the FontPlatformData(Deleted) constructor so that m_font is -1 instead of 0

Looks good! Good fix.

 45     FontPlatformData::FontPlatformData(const FontDescription&amp; desc, const AtomicString&amp; family);

Explicitly qualifying the name here with the class name (X::X) is incorrect syntax, and not all compilers accept it. Also, it&apos;s WebKit practice to omit unnecessary argument names when the type of hte parameter already makes it clear, so &quot;desc&quot; should be omitted.

 46     FontPlatformData(wxFont* f);

As should &quot;f&quot; here.

This patch makes a bunch of formerly-inline functions no longer inline. Was that intentional? Will it make the code slower? I like that it reduces the amount exposed in the header.

39      switch (family){
40          case FontDescription::StandardFamily:

 41     switch (family) {
 42     case FontDescription::StandardFamily:

Here, you have changed the WebKit standard indentation of switch statements (cases indented inside the switch, then contents indented one additional level) to another format.

 83     if (m_font != 0 &amp;&amp; m_font != DELETED_FONT)

WebKit coding style omits the != 0 in cases like this one.

review- because of the FontPlatformData::FontPlatformData issue. The other issues are smaller ones.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63976</commentid>
    <comment_count>3</comment_count>
      <attachid>17856</attachid>
    <who name="Kevin Watters">kevinwatters</who>
    <bug_when>2007-12-11 17:25:40 -0800</bug_when>
    <thetext>Created attachment 17856
cleaned up version of the previous patch

Darin: I addressed the issues mentioned in your comment; attached is a much smaller patch, changing only the FontPlatformData(Deleted) constructor, and the destructor. Functions remain inlined in the header file.

Just as a note: I made the &quot;switch&quot; indentation changes after reading the WebKit Coding Style Guidelines (http://webkit.org/coding/coding-style.html), so if the example there doesn&apos;t reflect current dogma, that page should probably change :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>64017</commentid>
    <comment_count>4</comment_count>
      <attachid>17856</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-12-12 06:27:38 -0800</bug_when>
    <thetext>Comment on attachment 17856
cleaned up version of the previous patch

Needs ChangeLog.

Don&apos;t forget to set the review? flag!  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>64036</commentid>
    <comment_count>5</comment_count>
      <attachid>17865</attachid>
    <who name="Kevin Watters">kevinwatters</who>
    <bug_when>2007-12-12 09:30:04 -0800</bug_when>
    <thetext>Created attachment 17865
cleaned up patch with changelog diff

Cleaned up patch, including a ChangeLog diff.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>64218</commentid>
    <comment_count>6</comment_count>
      <attachid>17865</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2007-12-14 15:26:07 -0800</bug_when>
    <thetext>Comment on attachment 17865
cleaned up patch with changelog diff

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>64337</commentid>
    <comment_count>7</comment_count>
    <who name="Kevin Ollivier">kevino</who>
    <bug_when>2007-12-15 17:58:09 -0800</bug_when>
    <thetext>landed in r28766</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>17854</attachid>
            <date>2007-12-11 12:53:25 -0800</date>
            <delta_ts>2007-12-12 09:30:04 -0800</delta_ts>
            <desc>Changes the FontPlatformData(Deleted) constructor so that m_font is -1 instead of 0</desc>
            <filename>wxwebkit-FontPlatformData-deleted-fix.patch</filename>
            <type>text/plain</type>
            <size>4779</size>
            <attacher name="Kevin Watters">kevinwatters</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oDQo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1E
YXRhLmgJKHJldmlzaW9uIDI4NjI0KQ0KKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gv
Rm9udFBsYXRmb3JtRGF0YS5oCSh3b3JraW5nIGNvcHkpDQpAQCAtNDEsMzcgKzQxLDE2IEBADQog
Y2xhc3MgRm9udFBsYXRmb3JtRGF0YSB7CiBwdWJsaWM6CiAgICAgY2xhc3MgRGVsZXRlZCB7fTsK
LQotICAgIEZvbnRQbGF0Zm9ybURhdGEoRGVsZXRlZCkKLSAgICA6IG1fZm9udChOVUxMKQotICAg
IHsgfQotCisgICAgCisgICAgRm9udFBsYXRmb3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0YShjb25z
dCBGb250RGVzY3JpcHRpb24mIGRlc2MsIGNvbnN0IEF0b21pY1N0cmluZyYgZmFtaWx5KTsKKyAg
ICBGb250UGxhdGZvcm1EYXRhKHd4Rm9udCogZik7CisgICAgRm9udFBsYXRmb3JtRGF0YShEZWxl
dGVkKTsKKyAgICBGb250UGxhdGZvcm1EYXRhKCk7ICAgICAgICAKICAgICB+Rm9udFBsYXRmb3Jt
RGF0YSgpOwotCi0gICAgRm9udFBsYXRmb3JtRGF0YSh3eEZvbnQqIGYpIAotICAgIDogbV9mb250
KGYpCi0gICAgewotICAgIH0KLSAgICAKLSAgICBGb250UGxhdGZvcm1EYXRhKGNvbnN0IEZvbnRE
ZXNjcmlwdGlvbiYsIGNvbnN0IEF0b21pY1N0cmluZyYpOwotICAgIAotICAgIEZvbnRQbGF0Zm9y
bURhdGEoKSAKLSAgICA6IG1fZm9udChOVUxMKQotICAgIHsKLSAgICB9Ci0gICAgCi0gICAgd3hG
b250KiBmb250KCkgY29uc3QgeyByZXR1cm4gbV9mb250OyB9CiAgICAgCi0gICAgdW5zaWduZWQg
aGFzaCgpIGNvbnN0Ci0gICAgewotICAgICAgICB1aW50cHRyX3QgaGFzaENvZGVzWzFdID0geyBy
ZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4obV9mb250KSB9OwotICAgICAgICByZXR1cm4gU3Ry
aW5nSW1wbDo6Y29tcHV0ZUhhc2gocmVpbnRlcnByZXRfY2FzdDxVQ2hhcio+KGhhc2hDb2Rlcyks
IHNpemVvZihoYXNoQ29kZXMpIC8gc2l6ZW9mKFVDaGFyKSk7Ci0gICAgfQotCi0gICAgYm9vbCBv
cGVyYXRvcj09KGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIG90aGVyKSBjb25zdAotICAgIHsgCi0g
ICAgICAgIHJldHVybiBtX2ZvbnQgPT0gb3RoZXIubV9mb250OwotICAgIH0KKyAgICB3eEZvbnQq
IGZvbnQoKSBjb25zdDsKKyAgICB1bnNpZ25lZCBoYXNoKCkgY29uc3Q7CisgICAgYm9vbCBvcGVy
YXRvcj09KGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIG90aGVyKSBjb25zdDsgICAKIAogcHJpdmF0
ZToKICAgICB3eEZvbnQqIG1fZm9udDsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
d3gvRm9udFBsYXRmb3JtRGF0YVd4LmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YVd4LmNwcAkocmV2aXNpb24gMjg2MjQpDQor
KysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1EYXRhV3guY3BwCSh3
b3JraW5nIGNvcHkpDQpAQCAtMzIsNiArMzIsOCBAQA0KICNpbmNsdWRlIDx3eC9nZGljbW4uaD4K
ICNpbmNsdWRlIDx3eC9mb250Lmg+CiAKK3N0YXRpYyB3eEZvbnQqIERFTEVURURfRk9OVCA9ICh3
eEZvbnQqKS0xOyAKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBzdGF0aWMgd3hGb250RmFtaWx5
IGZvbnRGYW1pbHlUb1d4Rm9udEZhbWlseShjb25zdCBpbnQgZmFtaWx5KQpAQCAtMzYsMjEgKzM4
LDIxIEBADQogCiBzdGF0aWMgd3hGb250RmFtaWx5IGZvbnRGYW1pbHlUb1d4Rm9udEZhbWlseShj
b25zdCBpbnQgZmFtaWx5KQogewotICAgIHN3aXRjaCAoZmFtaWx5KXsKLSAgICAgICAgY2FzZSBG
b250RGVzY3JpcHRpb246OlN0YW5kYXJkRmFtaWx5OgotICAgICAgICAgICAgcmV0dXJuIHd4Rk9O
VEZBTUlMWV9ERUZBVUxUOwotICAgICAgICBjYXNlIEZvbnREZXNjcmlwdGlvbjo6U2VyaWZGYW1p
bHk6Ci0gICAgICAgICAgICByZXR1cm4gd3hGT05URkFNSUxZX1JPTUFOOwotICAgICAgICBjYXNl
IEZvbnREZXNjcmlwdGlvbjo6U2Fuc1NlcmlmRmFtaWx5OgotICAgICAgICAgICAgcmV0dXJuIHd4
Rk9OVEZBTUlMWV9NT0RFUk47Ci0gICAgICAgIGNhc2UgRm9udERlc2NyaXB0aW9uOjpNb25vc3Bh
Y2VGYW1pbHk6Ci0gICAgICAgICAgICByZXR1cm4gd3hGT05URkFNSUxZX1RFTEVUWVBFOyAvLyBU
T0RPOiBDaGVjayB0aGVzZSBhcmUgZXF1aXZhbGVudAotICAgICAgICBjYXNlIEZvbnREZXNjcmlw
dGlvbjo6Q3Vyc2l2ZUZhbWlseToKLSAgICAgICAgICAgIHJldHVybiB3eEZPTlRGQU1JTFlfU0NS
SVBUOwotICAgICAgICBjYXNlIEZvbnREZXNjcmlwdGlvbjo6RmFudGFzeUZhbWlseToKLSAgICAg
ICAgICAgIHJldHVybiB3eEZPTlRGQU1JTFlfREVDT1JBVElWRTsKLSAgICAgICAgZGVmYXVsdDoK
LSAgICAgICAgICAgIHJldHVybiB3eEZPTlRGQU1JTFlfREVGQVVMVDsKKyAgICBzd2l0Y2ggKGZh
bWlseSkgeworICAgIGNhc2UgRm9udERlc2NyaXB0aW9uOjpTdGFuZGFyZEZhbWlseToKKyAgICAg
ICAgcmV0dXJuIHd4Rk9OVEZBTUlMWV9ERUZBVUxUOworICAgIGNhc2UgRm9udERlc2NyaXB0aW9u
OjpTZXJpZkZhbWlseToKKyAgICAgICAgcmV0dXJuIHd4Rk9OVEZBTUlMWV9ST01BTjsKKyAgICBj
YXNlIEZvbnREZXNjcmlwdGlvbjo6U2Fuc1NlcmlmRmFtaWx5OgorICAgICAgICByZXR1cm4gd3hG
T05URkFNSUxZX01PREVSTjsKKyAgICBjYXNlIEZvbnREZXNjcmlwdGlvbjo6TW9ub3NwYWNlRmFt
aWx5OgorICAgICAgICByZXR1cm4gd3hGT05URkFNSUxZX1RFTEVUWVBFOyAvLyBUT0RPOiBDaGVj
ayB0aGVzZSBhcmUgZXF1aXZhbGVudAorICAgIGNhc2UgRm9udERlc2NyaXB0aW9uOjpDdXJzaXZl
RmFtaWx5OgorICAgICAgICByZXR1cm4gd3hGT05URkFNSUxZX1NDUklQVDsKKyAgICBjYXNlIEZv
bnREZXNjcmlwdGlvbjo6RmFudGFzeUZhbWlseToKKyAgICAgICAgcmV0dXJuIHd4Rk9OVEZBTUlM
WV9ERUNPUkFUSVZFOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiB3eEZPTlRGQU1JTFlf
REVGQVVMVDsKICAgICB9CiB9CiAKQEAgLTcwLDYgKzcyLDQ1IEBADQogICAgIHJldHVybiB3eEZP
TlRTVFlMRV9OT1JNQUw7CiB9CiAKKworRm9udFBsYXRmb3JtRGF0YTo6Rm9udFBsYXRmb3JtRGF0
YShEZWxldGVkKQorICAgIDogbV9mb250KERFTEVURURfRk9OVCkKK3sKK30KKworRm9udFBsYXRm
b3JtRGF0YTo6fkZvbnRQbGF0Zm9ybURhdGEoKQoreworICAgIGlmIChtX2ZvbnQgIT0gMCAmJiBt
X2ZvbnQgIT0gREVMRVRFRF9GT05UKQorICAgICAgICBkZWxldGUgbV9mb250OworfQorCisKK0Zv
bnRQbGF0Zm9ybURhdGE6OkZvbnRQbGF0Zm9ybURhdGEod3hGb250KiBmKSAKKyAgICA6IG1fZm9u
dChmKQoreworfQorCitGb250UGxhdGZvcm1EYXRhOjpGb250UGxhdGZvcm1EYXRhKCkgCisgICAg
OiBtX2ZvbnQoMCkKK3sKK30KKword3hGb250KiBGb250UGxhdGZvcm1EYXRhOjpmb250KCkgY29u
c3QgCit7CisgICAgcmV0dXJuIG1fZm9udDsKK30KKwordW5zaWduZWQgRm9udFBsYXRmb3JtRGF0
YTo6aGFzaCgpIGNvbnN0Cit7CisgICAgdWludHB0cl90IGhhc2hDb2Rlc1sxXSA9IHsgcmVpbnRl
cnByZXRfY2FzdDx1aW50cHRyX3Q+KG1fZm9udCkgfTsKKyAgICByZXR1cm4gU3RyaW5nSW1wbDo6
Y29tcHV0ZUhhc2gocmVpbnRlcnByZXRfY2FzdDxVQ2hhcio+KGhhc2hDb2RlcyksIHNpemVvZiho
YXNoQ29kZXMpIC8gc2l6ZW9mKFVDaGFyKSk7Cit9CisKK2Jvb2wgRm9udFBsYXRmb3JtRGF0YTo6
b3BlcmF0b3I9PShjb25zdCBGb250UGxhdGZvcm1EYXRhJiBvdGhlcikgY29uc3QKK3sKKyAgICBy
ZXR1cm4gbV9mb250ID09IG90aGVyLm1fZm9udDsKK30KKwogRm9udFBsYXRmb3JtRGF0YTo6Rm9u
dFBsYXRmb3JtRGF0YShjb25zdCBGb250RGVzY3JpcHRpb24mIGRlc2MsIGNvbnN0IEF0b21pY1N0
cmluZyYgZmFtaWx5KQogewogLy8gTkI6IFRoZSBXaW5kb3dzIHd4Rm9udCBjb25zdHJ1Y3RvciBo
YXMgdHdvIGZvcm1zLCBvbmUgdGFraW5nIGEgd3hTaXplICh3aXRoIHBpeGVscykKQEAgLTc3LDYg
KzExOCw3IEBADQogLy8gYSBwaXhlbCBzaXplIHVzaW5nIGFuIGFsZ29yaXRobSB3aGljaCBjYXVz
ZXMgdGhlIHNpemUgdG8gYmUgd2F5IG9mZi4gSG93ZXZlciwKIC8vIHRoaXMgaXMgYSBtb290IGlz
c3VlIG9uIExpbnV4IGFuZCBNYWMgYXMgdGhleSBvbmx5IGFjY2VwdCB0aGUgcG9pbnQgYXJndW1l
bnQuIFNvLAogLy8gd2UgdXNlIHRoZSBwaXhlbCBzaXplIGNvbnN0cnVjdG9yIG9uIFdpbmRvd3Ms
IGJ1dCB3ZSB1c2UgcG9pbnQgc2l6ZSBvbiBMaW51eCBhbmQgTWFjLgorICAgCiAjaWYgX19XWE1T
V19fCiAgICAgbV9mb250ID0gbmV3IHd4Rm9udCggICB3eFNpemUoMCwgZGVzYy5jb21wdXRlZFBp
eGVsU2l6ZSgpKSwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvbnRGYW1pbHlU
b1d4Rm9udEZhbWlseShkZXNjLmdlbmVyaWNGYW1pbHkoKSksIApAQCAtOTUsOSArMTM3LDUgQEAN
CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKTsgCiAjZW5kaWYKIH0KLSAgICAKLUZvbnRQ
bGF0Zm9ybURhdGE6On5Gb250UGxhdGZvcm1EYXRhKCkKLXsKLX0KIAotfQorfQ0K
</data>
<flag name="review"
          id="7707"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>17856</attachid>
            <date>2007-12-11 17:25:40 -0800</date>
            <delta_ts>2007-12-12 09:30:04 -0800</delta_ts>
            <desc>cleaned up version of the previous patch</desc>
            <filename>wx-fontplatformdata-withcleanup.patch</filename>
            <type>text/plain</type>
            <size>864</size>
            <attacher name="Kevin Watters">kevinwatters</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0
YS5oCShyZXZpc2lvbiAyODYyNCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9u
dFBsYXRmb3JtRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3IEBACiAgICAgY2xh
c3MgRGVsZXRlZCB7fTsKIAogICAgIEZvbnRQbGF0Zm9ybURhdGEoRGVsZXRlZCkKLSAgICA6IG1f
Zm9udChOVUxMKQorICAgIDogbV9mb250KHJlaW50ZXJwcmV0X2Nhc3Q8d3hGb250Kj4oLTEpKQog
ICAgIHsgfQogCiAgICAgfkZvbnRQbGF0Zm9ybURhdGEoKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YVd4LmNwcAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3d4L0ZvbnRQbGF0Zm9ybURhdGFXeC5jcHAJKHJldmlzaW9u
IDI4NjI0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1EYXRh
V3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCw4IEBACiAgICAgCiBGb250UGxhdGZv
cm1EYXRhOjp+Rm9udFBsYXRmb3JtRGF0YSgpCiB7CisgICAgaWYgKG1fZm9udCAmJiBtX2ZvbnQg
IT0gcmVpbnRlcnByZXRfY2FzdDx3eEZvbnQqPigtMSkpCisgICAgICAgIGRlbGV0ZSBtX2ZvbnQ7
CiB9CiAKIH0K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>17865</attachid>
            <date>2007-12-12 09:30:04 -0800</date>
            <delta_ts>2007-12-14 15:26:07 -0800</delta_ts>
            <desc>cleaned up patch with changelog diff</desc>
            <filename>wx-fontplatformdata.diff</filename>
            <type>text/plain</type>
            <size>1413</size>
            <attacher name="Kevin Watters">kevinwatters</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAyODY1MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTIgQEAKKzIwMDctMTItMTIgIEtldmluIFdhdHRlcnMgIDxrZXZpbkBkb3RzeW50
YXguY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEZpeGVkIHRoZSBXeCBwb3J0J3MgRm9udFBsYXRmb3JtRGF0YSBmb3IgdXNlIGluIEhhc2hUYWJs
ZS4KKyAgICAgICAgLSBGb250UGxhdGZvcm1EYXRhKERlbGV0ZWQpIG1hZGUgdW5lcXVhbCB0byBG
b250UGxhdGZvcm1EYXRhKCkKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3d4L0ZvbnRQ
bGF0Zm9ybURhdGEuaDoKKwogMjAwNy0xMi0xMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUu
Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4KSW5kZXg6IFdlYkNvcmUvcGxhdGZv
cm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv
cGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCShyZXZpc2lvbiAyODY1MSkK
KysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBsYXRmb3JtRGF0YS5oCSh3b3Jr
aW5nIGNvcHkpCkBAIC00Myw3ICs0Myw3IEBACiAgICAgY2xhc3MgRGVsZXRlZCB7fTsKIAogICAg
IEZvbnRQbGF0Zm9ybURhdGEoRGVsZXRlZCkKLSAgICA6IG1fZm9udChOVUxMKQorICAgIDogbV9m
b250KHJlaW50ZXJwcmV0X2Nhc3Q8d3hGb250Kj4oLTEpKQogICAgIHsgfQogCiAgICAgfkZvbnRQ
bGF0Zm9ybURhdGEoKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd3gvRm9udFBs
YXRmb3JtRGF0YVd4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L3d4L0ZvbnRQbGF0Zm9ybURhdGFXeC5jcHAJKHJldmlzaW9uIDI4NjUxKQorKysgV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy93eC9Gb250UGxhdGZvcm1EYXRhV3guY3BwCSh3b3JraW5nIGNvcHkp
CkBAIC05OCw2ICs5OCw4IEBACiAgICAgCiBGb250UGxhdGZvcm1EYXRhOjp+Rm9udFBsYXRmb3Jt
RGF0YSgpCiB7CisgICAgaWYgKG1fZm9udCAmJiBtX2ZvbnQgIT0gcmVpbnRlcnByZXRfY2FzdDx3
eEZvbnQqPigtMSkpCisgICAgICAgIGRlbGV0ZSBtX2ZvbnQ7CiB9CiAKIH0K
</data>
<flag name="review"
          id="7720"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>