164026 2016-10-26 11:52:15 -0700 [cmake][MinGW] Don't use MS bitfield layout to reduce sizes of data structures 2016-11-03 15:26:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen commit-queue lforschler mcatanzaro ossy pvollan oldest_to_newest 1244862 0 annulen 2016-10-26 11:52:15 -0700 With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of different alignment requirements, invoking static_assert. Instead of muting assert for MinGW like it's done for MSVC, it's a better choice to use more dense layout, as bitfields are not used in public APIs. Also, suppress MinGW warnings from "#pragma warning" which it doesn't understand. 1244864 1 292953 annulen 2016-10-26 11:54:09 -0700 Created attachment 292953 Patch 1244892 2 292953 mcatanzaro 2016-10-26 13:59:30 -0700 Comment on attachment 292953 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292953&action=review > ChangeLog:8 > + With MS bitfileds RegisterAtOffset becomes wider than ptrdiff_t because of bitfileds -> bitfields 1247887 3 292953 commit-queue 2016-11-03 15:26:20 -0700 Comment on attachment 292953 Patch Clearing flags on attachment: 292953 Committed r208350: <http://trac.webkit.org/changeset/208350> 1247888 4 commit-queue 2016-11-03 15:26:24 -0700 All reviewed patches have been landed. Closing bug. 292953 2016-10-26 11:54:09 -0700 2016-11-03 15:26:20 -0700 Patch bug-164026-20161026215021.patch text/plain 1876 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3OTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDM1MzMxZWYwNDY1ZTJiNTliNDViNmJmZjYxNzhiMGVkOGIyNTAyMjUuLjhjZmVmN2Y2ZWQzYzQy YmQxNDc3ZjI2OTNmMjczYTM0ZTdhNzU4YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC00OCw2ICs0OCwxMCBAQCBpZiAoQ09NUElMRVJfSVNfQ0xBTkcgQU5EIENNQUtFX0dFTkVSQVRP UiBTVFJFUVVBTCAiTmluamEiKQogICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01BS0VfQ1hY X0ZMQUdTfSAtZmNvbG9yLWRpYWdub3N0aWNzIikKIGVuZGlmICgpCiAKK2lmIChXSU4zMiBBTkQg Q09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQorICAgIHNldChDTUFLRV9DWFhfRkxBR1MgIiR7Q01B S0VfQ1hYX0ZMQUdTfSAtbW5vLW1zLWJpdGZpZWxkcyAtV25vLXVua25vd24tcHJhZ21hcyIpCitl bmRpZiAoKQorCiAjIEVuc3VyZSB0aGF0IHRoZSBkZWZhdWx0IGluY2x1ZGUgc3lzdGVtIGRpcmVj dG9yaWVzIGFyZSBhZGRlZCB0byB0aGUgbGlzdCBvZiBDTWFrZSBpbXBsaWNpdCBpbmNsdWRlcy4K ICMgVGhpcyB3b3JrYXJvdW5kcyBhbiBpc3N1ZSB0aGF0IGhhcHBlbnMgd2hlbiB1c2luZyBHQ0Mg NiBhbmQgdXNpbmcgc3lzdGVtIGluY2x1ZGVzICgtaXN5c3RlbSkuCiAjIEZvciBtb3JlIGRldGFp bHMgY2hlY2s6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjE2OTcK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiYWJhODRiMmE3OTUyOTU3 MTg0YWQ4Y2ZkYmQ0NjUzZDFkYzQ4YmQ4Li43OGFiNGQ4NjMwYWNjMThhZTJkOTliMTI5MTdhYzE2 ZDc0YWYzY2FmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjAgQEAKKzIwMTYtMTAtMjYgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4 LnJ1PgorCisgICAgICAgIFtjbWFrZV1bTWluR1ddIERvbid0IHVzZSBNUyBiaXRmaWVsZCBsYXlv dXQgdG8gcmVkdWNlIHNpemVzIG9mIGRhdGEgc3RydWN0dXJlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY0MDI2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2l0aCBNUyBiaXRmaWxlZHMgUmVnaXN0ZXJB dE9mZnNldCBiZWNvbWVzIHdpZGVyIHRoYW4gcHRyZGlmZl90IGJlY2F1c2Ugb2YKKyAgICAgICAg ZGlmZmVyZW50IGFsaWdubWVudCByZXF1aXJlbWVudHMsIGludm9raW5nIHN0YXRpY19hc3NlcnQu IEluc3RlYWQgb2YKKyAgICAgICAgbXV0aW5nIGFzc2VydCBmb3IgTWluR1cgbGlrZSBpdCdzIGRv bmUgZm9yIE1TVkMsIGl0J3MgYSBiZXR0ZXIgY2hvaWNlIHRvCisgICAgICAgIHVzZSBtb3JlIGRl bnNlIGxheW91dCwgYXMgYml0ZmllbGRzIGFyZSBub3QgdXNlZCBpbiBwdWJsaWMgQVBJcy4KKwor ICAgICAgICBBbHNvLCBzdXBwcmVzcyBNaW5HVyB3YXJuaW5ncyBmcm9tICIjcHJhZ21hIHdhcm5p bmciIHdoaWNoIGl0IGRvZXNuJ3QKKyAgICAgICAgdW5kZXJzdGFuZC4KKworICAgICAgICAqIFNv dXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDE2LTEwLTI2ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBV cGRhdGUgT3B0aW9uc0dUSy5jbWFrZSBhbmQgTkVXUyBmb3IgMi4xNS4xIHJlbGVhc2UuCg==