<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>163967</bug_id>
          
          <creation_ts>2016-10-25 12:48:19 -0700</creation_ts>
          <short_desc>Regression(r203848): 百度糯米 app fails to load content due to a JavaScript error</short_desc>
          <delta_ts>2016-10-26 17:40:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>iPhone / iPad</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=161162</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar, WebExposed</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>160320</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>annevk</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>jiewen_tan</cc>
    
    <cc>kangil.han</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>mkwst</cc>
    
    <cc>Ms2ger</cc>
    
    <cc>rniwa</cc>
    
    <cc>sam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1244365</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 12:48:19 -0700</bug_when>
    <thetext>Making all Event.initEvent() parameters mandatory caused some breakage. There are some iOS apps passing only the first parameter (event type). Since this is a legacy API, I don&apos;t think it is worth the trouble and I propose we scale back the change to mark only the first parameter as mandatory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244366</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 12:48:36 -0700</bug_when>
    <thetext>&lt;rdar://problem/28707838&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244394</commentid>
    <comment_count>2</comment_count>
      <attachid>292808</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 13:32:27 -0700</bug_when>
    <thetext>Created attachment 292808
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244424</commentid>
    <comment_count>3</comment_count>
      <attachid>292808</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-10-25 14:11:38 -0700</bug_when>
    <thetext>Comment on attachment 292808
Patch

OK. Don’t want to use quirk for old apps that we can remove some day?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244437</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 14:29:43 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; Comment on attachment 292808 [details]
&gt; Patch
&gt; 
&gt; OK. Don’t want to use quirk for old apps that we can remove some day?

Hmm, I personally think making the 2 booleans mandatory does not result in a nicer API. Those 2 boolean parameters are expected to be false by default when using the constructor. The one that was bothering me was the first one because it did not make sense to use &quot;undefined&quot; as default event type.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244441</commentid>
    <comment_count>5</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-10-25 14:30:54 -0700</bug_when>
    <thetext>Can we get the specification changed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244444</commentid>
    <comment_count>6</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 14:33:18 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; Can we get the specification changed?

We could if it broke actual sites. I don&apos;t think breaking engine-specific apps or extensions would be enough to get the spec changed, especially considering Blink and Gecko were able to do this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244445</commentid>
    <comment_count>7</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 14:35:48 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #5)
&gt; &gt; Can we get the specification changed?
&gt; 
&gt; We could if it broke actual sites. I don&apos;t think breaking engine-specific
&gt; apps or extensions would be enough to get the spec changed, especially
&gt; considering Blink and Gecko were able to do this.

One thing we could do to help steer in the right direction would be to log a console warning when calling initEvent() with only 1 parameter so that app developers are more likely to update their code. thoughts?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244456</commentid>
    <comment_count>8</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-10-25 14:44:38 -0700</bug_when>
    <thetext>I just hate having our engine fail a test suite. A solution that would cause us to pass the test suite and still keep the apps working would make me happy.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244462</commentid>
    <comment_count>9</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-25 14:50:54 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; I just hate having our engine fail a test suite. A solution that would cause
&gt; us to pass the test suite and still keep the apps working would make me
&gt; happy.

So, then I think we would have to:
- Mark the 2 last parameters as optional in the IDL (or add an overload taking only 1 parameter)
- Update the implementation to detect broken apps, and use default parameter values if a broken app is detected. Otherwise, throw a TypeError from the implementation.

We would still fail some W3C checks because Event.prototype.initEvent.length would be 1 instead of 3. I guess we could add an IDL extended attribute (or special casing for initEvent in the bindings generator) so that length keeps returning 3.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244785</commentid>
    <comment_count>10</comment_count>
    <who name="Ms2ger (he/him; ⌚ UTC+1/+2)">Ms2ger</who>
    <bug_when>2016-10-26 07:14:39 -0700</bug_when>
    <thetext>As long as your implementation doesn&apos;t match the spec, I&apos;ll ensure it fails wpt tests, so don&apos;t bother adding workarounds for the existing tests :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244803</commentid>
    <comment_count>11</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-26 09:10:10 -0700</bug_when>
    <thetext>(In reply to comment #10)
&gt; As long as your implementation doesn&apos;t match the spec, I&apos;ll ensure it fails
&gt; wpt tests, so don&apos;t bother adding workarounds for the existing tests :)

Not sure I understand your comment. Our implementation matches the specification and we are talking about maintaining our standard behavior for the Web, merely introducing a quirk for a specific iOS app until its developers have a chance to fix their bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244833</commentid>
    <comment_count>12</comment_count>
      <attachid>292942</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-26 10:39:48 -0700</bug_when>
    <thetext>Created attachment 292942
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244848</commentid>
    <comment_count>13</comment_count>
      <attachid>292948</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-26 11:18:38 -0700</bug_when>
    <thetext>Created attachment 292948
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244877</commentid>
    <comment_count>14</comment_count>
      <attachid>292948</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2016-10-26 13:12:07 -0700</bug_when>
    <thetext>Comment on attachment 292948
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292948&amp;action=review

I&apos;ve got a feeling that we might need to make the spec change to make this parameter optional instead.

&gt; Source/WebCore/dom/Event.cpp:96
&gt; +    // FIXME: Temporary quirk for ç¾åº¦ç³¯ç±³ App which calls initEvent() with too few parameters (rdar://problem/28707838).

Can we just use ASCII names like Baidu Nuomi App in the comment?

&gt; Source/WebCore/platform/RuntimeApplicationChecks.mm:258
&gt; +    // ç¾åº¦ç³¯ç±³ app.

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244878</commentid>
    <comment_count>15</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2016-10-26 13:20:16 -0700</bug_when>
    <thetext>Committed r207908: &lt;http://trac.webkit.org/changeset/207908&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1244981</commentid>
    <comment_count>16</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2016-10-26 17:40:56 -0700</bug_when>
    <thetext>Another part of our standard practice for this is to use &quot;linked on or after&quot; to make sure this quirk only works for versions of apps not yet updated with the SDK for a new release of iOS. Should we do that?</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>292808</attachid>
            <date>2016-10-25 13:32:27 -0700</date>
            <delta_ts>2016-10-26 09:37:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-163967-20161025132841.patch</filename>
            <type>text/plain</type>
            <size>6524</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE2MzVmYzZlYmJkYTQz
ZDFkNDUxMjlmZjBmMWU3Njg2MzkyMmU0OS4uYTMyOGI3OTQ4M2M2MDQ0MjMzZDQ2NmJjOWQ2ZGEw
NjJiYjExMDhlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTEwLTI1ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFraW5nIGFsbCBFdmVudC5p
bml0RXZlbnQoKSBwYXJhbWV0ZXJzIG1hbmRhdG9yeSBjYXVzZWQgc29tZSBicmVha2FnZQorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTY3CisgICAg
ICAgIDxyZGFyOi8vcHJvYmxlbS8yODcwNzgzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBNYWtpbmcgYWxsIEV2ZW50LmluaXRFdmVudCgpIHBhcmFt
ZXRlcnMgbWFuZGF0b3J5IGNhdXNlZCBzb21lIGJyZWFrYWdlLgorICAgICAgICBUaGVyZSBhcmUg
c29tZSBpT1MgYXBwcyBwYXNzaW5nIG9ubHkgdGhlIGZpcnN0IHBhcmFtZXRlciAoZXZlbnQgdHlw
ZSkuCisgICAgICAgIFNpbmNlIHRoaXMgaXMgYSBsZWdhY3kgQVBJLCB0aGlzIHBhdGNoIHNjYWxl
cyBiYWNrIHRoZSBjaGFuZ2UgdG8gbWFyaworICAgICAgICBvbmx5IHRoZSBmaXJzdCBwYXJhbWV0
ZXIgYXMgbWFuZGF0b3J5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmViYXNlbGluZWQgZXhp
c3RpbmcgdGVzdC4KKworICAgICAgICAqIGRvbS9FdmVudC5pZGw6CisKIDIwMTYtMTAtMjUgIENv
bW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3
ZWQsIHJvbGxpbmcgb3V0IHIyMDc4MjcgYW5kIHIyMDc4MjguCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9kb20vRXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmlkbAppbmRl
eCA4MjBhZTRjMWRmNzg3ODE0NDBlOTMwMmU0OGQ1Y2FiNjdjZTY1MDI3Li4xMjE2MmM1MjM5ZmMz
ZDQ2MGUxOTc3MDFkYThmNWY1M2JmNGY1ZjVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9k
b20vRXZlbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5pZGwKQEAgLTY1LDcg
KzY1LDggQEAgdHlwZWRlZiB1bnNpZ25lZCBsb25nIGxvbmcgRE9NVGltZVN0YW1wOwogICAgIHZv
aWQgc3RvcFByb3BhZ2F0aW9uKCk7CiAgICAgdm9pZCBwcmV2ZW50RGVmYXVsdCgpOwogCi0gICAg
dm9pZCBpbml0RXZlbnQoRE9NU3RyaW5nIGV2ZW50VHlwZUFyZywgYm9vbGVhbiBjYW5CdWJibGVB
cmcsIGJvb2xlYW4gY2FuY2VsYWJsZUFyZyk7CisgICAgLy8gVGhlIDIgbGFzdCBwYXJhbWV0ZXJz
IGFyZSBtYW5kYXRvcnkgaW4gdGhlIHNwZWNpZmljYXRpb24gYnV0IHRoaXMgd291bGQgYnJlYWsg
c29tZSBpT1MgYXBwcyAoPHJkYXI6Ly9wcm9ibGVtLzI4NzA3ODM4PikuCisgICAgdm9pZCBpbml0
RXZlbnQoRE9NU3RyaW5nIHR5cGUsIG9wdGlvbmFsIGJvb2xlYW4gYnViYmxlcyA9IGZhbHNlLCBv
cHRpb25hbCBib29sZWFuIGNhbmNlbGFibGUgPSBmYWxzZSk7CiAKICAgICByZWFkb25seSBhdHRy
aWJ1dGUgYm9vbGVhbiBkZWZhdWx0UHJldmVudGVkOwogICAgIHZvaWQgc3RvcEltbWVkaWF0ZVBy
b3BhZ2F0aW9uKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl
TG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCA5MTYzMTVkODIx
ZTk0ZWE2Y2RiYmYwNjJiMTJmODBkNWFjMjRlZmQ4Li4yZmE4OTE2MmZmMmE4OTdhNWNiNGFiNTg1
ZDllMTZjOWVkNjUxNGJhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hh
bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAgLTEsMyAr
MSwxNSBAQAorMjAxNi0xMC0yNSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisg
ICAgICAgIE1ha2luZyBhbGwgRXZlbnQuaW5pdEV2ZW50KCkgcGFyYW1ldGVycyBtYW5kYXRvcnkg
Y2F1c2VkIHNvbWUgYnJlYWthZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTE2Mzk2NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjg3MDc4Mzg+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGlu
ZSB3M2MgdGVzdCBub3cgdGhhdCB3ZSBhcmUgZmFpbGluZyBhIGZldyBjaGVja3MuCisKKyAgICAg
ICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvZG9tL2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0OgorCiAy
MDE2LTEwLTI1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBJ
bmRleGVkREIgMi4wOiBTdXBwb3J0IG5ldyBJREJUcmFuc2FjdGlvbiBpbnRlcmZhY2VzLgpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9kb20v
aW50ZXJmYWNlcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs
YXRmb3JtLXRlc3RzL2RvbS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4dAppbmRleCBmZGJkNTFiOTgz
Yzg5ZDFmZWFmM2FjOWZkMDZjYjJhMGY0ZWEzYWJiLi44NmIzMmU3MzUzZjFkMDZiNDQ0ZjgxNmJh
NDRlODk4YWZjMWRlNGIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi
LXBsYXRmb3JtLXRlc3RzL2RvbS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU
ZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9pbnRlcmZhY2VzLWV4cGVj
dGVkLnR4dApAQCAtMjYsNyArMjYsNyBAQCBQQVNTIEV2ZW50IGludGVyZmFjZTogYXR0cmlidXRl
IGNhbmNlbGFibGUKIFBBU1MgRXZlbnQgaW50ZXJmYWNlOiBvcGVyYXRpb24gcHJldmVudERlZmF1
bHQoKSAKIFBBU1MgRXZlbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgZGVmYXVsdFByZXZlbnRlZCAK
IFBBU1MgRXZlbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgdGltZVN0YW1wIAotUEFTUyBFdmVudCBp
bnRlcmZhY2U6IG9wZXJhdGlvbiBpbml0RXZlbnQoRE9NU3RyaW5nLGJvb2xlYW4sYm9vbGVhbikg
CitGQUlMIEV2ZW50IGludGVyZmFjZTogb3BlcmF0aW9uIGluaXRFdmVudChET01TdHJpbmcsYm9v
bGVhbixib29sZWFuKSBhc3NlcnRfZXF1YWxzOiBwcm9wZXJ0eSBoYXMgd3JvbmcgLmxlbmd0aCBl
eHBlY3RlZCAzIGJ1dCBnb3QgMQogUEFTUyBFdmVudCBtdXN0IGJlIHByaW1hcnkgaW50ZXJmYWNl
IG9mIGRvY3VtZW50LmNyZWF0ZUV2ZW50KCJFdmVudCIpIAogUEFTUyBTdHJpbmdpZmljYXRpb24g
b2YgZG9jdW1lbnQuY3JlYXRlRXZlbnQoIkV2ZW50IikgCiBQQVNTIEV2ZW50IGludGVyZmFjZTog
ZG9jdW1lbnQuY3JlYXRlRXZlbnQoIkV2ZW50IikgbXVzdCBpbmhlcml0IHByb3BlcnR5ICJ0eXBl
IiB3aXRoIHRoZSBwcm9wZXIgdHlwZSAoMCkgCkBAIC00Niw3ICs0Niw5IEBAIFBBU1MgRXZlbnQg
aW50ZXJmYWNlOiBkb2N1bWVudC5jcmVhdGVFdmVudCgiRXZlbnQiKSBtdXN0IGluaGVyaXQgcHJv
cGVydHkgImRlZmF1CiBQQVNTIEV2ZW50IGludGVyZmFjZTogZG9jdW1lbnQuY3JlYXRlRXZlbnQo
IkV2ZW50IikgbXVzdCBoYXZlIG93biBwcm9wZXJ0eSAiaXNUcnVzdGVkIiAKIFBBU1MgRXZlbnQg
aW50ZXJmYWNlOiBkb2N1bWVudC5jcmVhdGVFdmVudCgiRXZlbnQiKSBtdXN0IGluaGVyaXQgcHJv
cGVydHkgInRpbWVTdGFtcCIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDE1KSAKIFBBU1MgRXZlbnQg
aW50ZXJmYWNlOiBkb2N1bWVudC5jcmVhdGVFdmVudCgiRXZlbnQiKSBtdXN0IGluaGVyaXQgcHJv
cGVydHkgImluaXRFdmVudCIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDE2KSAKLVBBU1MgRXZlbnQg
aW50ZXJmYWNlOiBjYWxsaW5nIGluaXRFdmVudChET01TdHJpbmcsYm9vbGVhbixib29sZWFuKSBv
biBkb2N1bWVudC5jcmVhdGVFdmVudCgiRXZlbnQiKSB3aXRoIHRvbyBmZXcgYXJndW1lbnRzIG11
c3QgdGhyb3cgVHlwZUVycm9yIAorRkFJTCBFdmVudCBpbnRlcmZhY2U6IGNhbGxpbmcgaW5pdEV2
ZW50KERPTVN0cmluZyxib29sZWFuLGJvb2xlYW4pIG9uIGRvY3VtZW50LmNyZWF0ZUV2ZW50KCJF
dmVudCIpIHdpdGggdG9vIGZldyBhcmd1bWVudHMgbXVzdCB0aHJvdyBUeXBlRXJyb3IgYXNzZXJ0
X3Rocm93czogQ2FsbGVkIHdpdGggMSBhcmd1bWVudHMgZnVuY3Rpb24gImZ1bmN0aW9uICgpIHsK
KyAgICAgICAgICAgIGZuLmFwcGx5KG9iaiwgYXJncyk7CisgICAgICAgIH0iIGRpZCBub3QgdGhy
b3cKIFBBU1MgRXZlbnQgbXVzdCBiZSBwcmltYXJ5IGludGVyZmFjZSBvZiBuZXcgRXZlbnQoImZv
byIpIAogUEFTUyBTdHJpbmdpZmljYXRpb24gb2YgbmV3IEV2ZW50KCJmb28iKSAKIFBBU1MgRXZl
bnQgaW50ZXJmYWNlOiBuZXcgRXZlbnQoImZvbyIpIG11c3QgaW5oZXJpdCBwcm9wZXJ0eSAidHlw
ZSIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDApIApAQCAtNjYsNyArNjgsOSBAQCBQQVNTIEV2ZW50
IGludGVyZmFjZTogbmV3IEV2ZW50KCJmb28iKSBtdXN0IGluaGVyaXQgcHJvcGVydHkgImRlZmF1
bHRQcmV2ZW50ZWQiCiBQQVNTIEV2ZW50IGludGVyZmFjZTogbmV3IEV2ZW50KCJmb28iKSBtdXN0
IGhhdmUgb3duIHByb3BlcnR5ICJpc1RydXN0ZWQiIAogUEFTUyBFdmVudCBpbnRlcmZhY2U6IG5l
dyBFdmVudCgiZm9vIikgbXVzdCBpbmhlcml0IHByb3BlcnR5ICJ0aW1lU3RhbXAiIHdpdGggdGhl
IHByb3BlciB0eXBlICgxNSkgCiBQQVNTIEV2ZW50IGludGVyZmFjZTogbmV3IEV2ZW50KCJmb28i
KSBtdXN0IGluaGVyaXQgcHJvcGVydHkgImluaXRFdmVudCIgd2l0aCB0aGUgcHJvcGVyIHR5cGUg
KDE2KSAKLVBBU1MgRXZlbnQgaW50ZXJmYWNlOiBjYWxsaW5nIGluaXRFdmVudChET01TdHJpbmcs
Ym9vbGVhbixib29sZWFuKSBvbiBuZXcgRXZlbnQoImZvbyIpIHdpdGggdG9vIGZldyBhcmd1bWVu
dHMgbXVzdCB0aHJvdyBUeXBlRXJyb3IgCitGQUlMIEV2ZW50IGludGVyZmFjZTogY2FsbGluZyBp
bml0RXZlbnQoRE9NU3RyaW5nLGJvb2xlYW4sYm9vbGVhbikgb24gbmV3IEV2ZW50KCJmb28iKSB3
aXRoIHRvbyBmZXcgYXJndW1lbnRzIG11c3QgdGhyb3cgVHlwZUVycm9yIGFzc2VydF90aHJvd3M6
IENhbGxlZCB3aXRoIDEgYXJndW1lbnRzIGZ1bmN0aW9uICJmdW5jdGlvbiAoKSB7CisgICAgICAg
ICAgICBmbi5hcHBseShvYmosIGFyZ3MpOworICAgICAgICB9IiBkaWQgbm90IHRocm93CiBQQVNT
IEN1c3RvbUV2ZW50IGludGVyZmFjZTogZXhpc3RlbmNlIGFuZCBwcm9wZXJ0aWVzIG9mIGludGVy
ZmFjZSBvYmplY3QgCiBQQVNTIEN1c3RvbUV2ZW50IGludGVyZmFjZSBvYmplY3QgbGVuZ3RoIAog
UEFTUyBDdXN0b21FdmVudCBpbnRlcmZhY2Ugb2JqZWN0IG5hbWUgCkBAIC05Niw3ICsxMDAsOSBA
QCBQQVNTIEV2ZW50IGludGVyZmFjZTogbmV3IEN1c3RvbUV2ZW50KCJmb28iKSBtdXN0IGluaGVy
aXQgcHJvcGVydHkgImRlZmF1bHRQcmV2ZQogUEFTUyBFdmVudCBpbnRlcmZhY2U6IG5ldyBDdXN0
b21FdmVudCgiZm9vIikgbXVzdCBoYXZlIG93biBwcm9wZXJ0eSAiaXNUcnVzdGVkIiAKIFBBU1Mg
RXZlbnQgaW50ZXJmYWNlOiBuZXcgQ3VzdG9tRXZlbnQoImZvbyIpIG11c3QgaW5oZXJpdCBwcm9w
ZXJ0eSAidGltZVN0YW1wIiB3aXRoIHRoZSBwcm9wZXIgdHlwZSAoMTUpIAogUEFTUyBFdmVudCBp
bnRlcmZhY2U6IG5ldyBDdXN0b21FdmVudCgiZm9vIikgbXVzdCBpbmhlcml0IHByb3BlcnR5ICJp
bml0RXZlbnQiIHdpdGggdGhlIHByb3BlciB0eXBlICgxNikgCi1QQVNTIEV2ZW50IGludGVyZmFj
ZTogY2FsbGluZyBpbml0RXZlbnQoRE9NU3RyaW5nLGJvb2xlYW4sYm9vbGVhbikgb24gbmV3IEN1
c3RvbUV2ZW50KCJmb28iKSB3aXRoIHRvbyBmZXcgYXJndW1lbnRzIG11c3QgdGhyb3cgVHlwZUVy
cm9yIAorRkFJTCBFdmVudCBpbnRlcmZhY2U6IGNhbGxpbmcgaW5pdEV2ZW50KERPTVN0cmluZyxi
b29sZWFuLGJvb2xlYW4pIG9uIG5ldyBDdXN0b21FdmVudCgiZm9vIikgd2l0aCB0b28gZmV3IGFy
Z3VtZW50cyBtdXN0IHRocm93IFR5cGVFcnJvciBhc3NlcnRfdGhyb3dzOiBDYWxsZWQgd2l0aCAx
IGFyZ3VtZW50cyBmdW5jdGlvbiAiZnVuY3Rpb24gKCkgeworICAgICAgICAgICAgZm4uYXBwbHko
b2JqLCBhcmdzKTsKKyAgICAgICAgfSIgZGlkIG5vdCB0aHJvdwogUEFTUyBFdmVudFRhcmdldCBp
bnRlcmZhY2U6IGV4aXN0ZW5jZSBhbmQgcHJvcGVydGllcyBvZiBpbnRlcmZhY2Ugb2JqZWN0IAog
UEFTUyBFdmVudFRhcmdldCBpbnRlcmZhY2Ugb2JqZWN0IGxlbmd0aCAKIFBBU1MgRXZlbnRUYXJn
ZXQgaW50ZXJmYWNlIG9iamVjdCBuYW1lIAo=
</data>
<flag name="review"
          id="315802"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>292942</attachid>
            <date>2016-10-26 10:39:48 -0700</date>
            <delta_ts>2016-10-26 11:18:33 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-163967-20161026103600.patch</filename>
            <type>text/plain</type>
            <size>6562</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3ODk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzIyZDk1M2ZmMzg2NWMy
MmViMjliYTk3MjBmYTI5MGI0MzY3N2EyNS4uNjM3OWM4Mzc2NDAwYjljZjQwZjNiOTFjNzFiOWYx
Y2RiYjc5YTEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTEwLTI2ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjAzODQ4
KTog55m+5bqm57Ov57GzIGFwcCBmYWlscyB0byBsb2FkIGNvbnRlbnQgZHVlIHRvIGEgSmF2YVNj
cmlwdCBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTYzOTY3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODcwNzgzOD4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcXVpcmsgZm9yIOeZvuW6
puezr+exsyBhcHAgbWFraW5nIHRoZSAyIGxhc3QgcGFyYW1ldGVycyB0byBFdmVudC5wcm90b3R5
cGUuaW5pdEV2ZW50KCkKKyAgICAgICAgb3B0aW9uYWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz
LCBjaGFuZ2Ugb25seSBpbXBhY3RzIHRoaXMgc3BlY2lmaWMgYXBwbGljYXRpb24uCisKKyAgICAg
ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEdlbmVy
YXRlUHJvcGVydGllc0hhc2hUYWJsZSk6CisgICAgICAgICogZG9tL0V2ZW50LmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkV2ZW50Ojppbml0RXZlbnRGb3JCaW5kaW5ncyk6CisgICAgICAgICogZG9t
L0V2ZW50Lmg6CisgICAgICAgICogZG9tL0V2ZW50LmlkbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9S
dW50aW1lQXBwbGljYXRpb25DaGVja3MuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9SdW50aW1lQXBw
bGljYXRpb25DaGVja3MubW06CisgICAgICAgIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNC
YWludW8pOgorCiAyMDE2LTEwLTI2ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNv
bT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXhpbmcgY29tcGlsZXIgd2FybmluZ3MgaW4gUGxh
eWJhY2tQaXBlbGluZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0
cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv
ZGVHZW5lcmF0b3JKUy5wbQppbmRleCA5M2RmZTZhZmI0YTg3YzVkNDNmYmZjOTMxMmY4NGMwZjk3
NTI3ZDNhLi5hZGFmMjBhYzhjMjUzZTNjMzVlMDEyNWQ1ZDk3YzFmY2NlNGQ2YmU3IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQor
KysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpA
QCAtMTg1OSw2ICsxODU5LDEwIEBAIHN1YiBHZW5lcmF0ZVByb3BlcnRpZXNIYXNoVGFibGUKICAg
ICAgICAgcHVzaChAJGhhc2hWYWx1ZTEsICRmdW5jdGlvbk5hbWUpOwogCiAgICAgICAgIG15ICRm
dW5jdGlvbkxlbmd0aCA9IEdldEZ1bmN0aW9uTGVuZ3RoKCRmdW5jdGlvbik7CisKKyAgICAgICAg
IyBGSVhNRTogUmVtb3ZlIHRoaXMgb25jZSB3ZSBjYW4gZ2V0IHJpZCBvZiB0aGUgcXVpcmsgaW50
cm9kdWNlZCBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTY3
LgorICAgICAgICAkZnVuY3Rpb25MZW5ndGggPSAzIGlmICRpbnRlcmZhY2VOYW1lIGVxICJFdmVu
dCIgYW5kICRmdW5jdGlvbi0+c2lnbmF0dXJlLT5uYW1lIGVxICJpbml0RXZlbnQiOworCiAgICAg
ICAgIHB1c2goQCRoYXNoVmFsdWUyLCAkZnVuY3Rpb25MZW5ndGgpOwogCiAgICAgICAgIHB1c2go
QCRoYXNoU3BlY2lhbHMsIENvbXB1dGVGdW5jdGlvblNwZWNpYWwoJGludGVyZmFjZSwgJGZ1bmN0
aW9uKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuY3BwIGIvU291cmNl
L1dlYkNvcmUvZG9tL0V2ZW50LmNwcAppbmRleCA3ZGQxYTgzMDUyMjJjNDc0MWUzNGRiOTU2M2E3
ZDUyZWVmYTQwMjkxLi44N2UxNjMwNjczMWY0Yzk0ZjgxNjk1MDk4ZmRkMzAxZjc4MjA4YmJlIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD
b3JlL2RvbS9FdmVudC5jcHAKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJFdmVudE5hbWVz
LmgiCiAjaW5jbHVkZSAiRXZlbnRQYXRoLmgiCiAjaW5jbHVkZSAiRXZlbnRUYXJnZXQuaCIKKyNp
bmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKICNpbmNsdWRlICJVc2VyR2VzdHVy
ZUluZGljYXRvci5oIgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogCkBAIC04OSw2ICs5
MCwyMyBAQCB2b2lkIEV2ZW50Ojppbml0RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5
cGVBcmcsIGJvb2wgY2FuQnViYmxlQXJnLCBib29sCiAgICAgbV9jYW5jZWxhYmxlID0gY2FuY2Vs
YWJsZUFyZzsKIH0KIAorRXhjZXB0aW9uT3I8dm9pZD4gRXZlbnQ6OmluaXRFdmVudEZvckJpbmRp
bmdzKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQmIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIGNvbnN0
IEF0b21pY1N0cmluZyYgdHlwZSwgYm9vbCBidWJibGVzKQoreworI2lmIFBMQVRGT1JNKElPUykK
KyAgICAvLyBGSVhNRTogVGVtcG9yYXJ5IHF1aXJrIGZvciDnmb7luqbns6/nsbMgQXBwIHdoaWNo
IGNhbGxzIGluaXRFdmVudCgpIHdpdGggdG9vIGZldyBwYXJhbWV0ZXJzIChyZGFyOi8vcHJvYmxl
bS8yODcwNzgzOCkuCisgICAgaWYgKElPU0FwcGxpY2F0aW9uOjppc0JhaW51bygpKSB7CisgICAg
ICAgIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuYWRkQ29uc29sZU1lc3NhZ2UoTWVzc2FnZVNvdXJj
ZTo6SlMsIE1lc3NhZ2VMZXZlbDo6V2FybmluZywgQVNDSUlMaXRlcmFsKCJDYWxsaW5nIEV2ZW50
LnByb3RvdHlwZS5pbml0RXZlbnQoKSB3aXRoIGxlc3MgdGhhbiAzIHBhcmFtZXRlcnMgaXMgZGVw
cmVjYXRlZC4iKSk7CisgICAgICAgIGluaXRFdmVudCh0eXBlLCBidWJibGVzLCBmYWxzZSk7Cisg
ICAgICAgIHJldHVybiB7IH07CisgICAgfQorI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0oc2NyaXB0
RXhlY3V0aW9uQ29udGV4dCk7CisgICAgVU5VU0VEX1BBUkFNKHR5cGUpOworICAgIFVOVVNFRF9Q
QVJBTShidWJibGVzKTsKKyNlbmRpZgorICAgIHJldHVybiBFeGNlcHRpb24geyBUeXBlRXJyb3Is
IEFTQ0lJTGl0ZXJhbCgiTm90IGVub3VnaCBhcmd1bWVudHMiKSB9OworfQorCiBib29sIEV2ZW50
Ojpjb21wb3NlZCgpIGNvbnN0CiB7CiAgICAgaWYgKG1fY29tcG9zZWQpCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5oCmlu
ZGV4IDk0MGFiYjM3MzVkMmYwY2I3ZWM4NjUxZDcyMmZkNjBlOWNkZTY3MWUuLmIxYjVmZjFjZmE4
M2RmNzYyYmVhMmI3YTM5MmU3NmI2ZjIwN2NlMjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L2RvbS9FdmVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5oCkBAIC0yNyw2ICsy
Nyw3IEBACiAjaW5jbHVkZSAiRE9NVGltZVN0YW1wLmgiCiAjaW5jbHVkZSAiRXZlbnRJbml0Lmgi
CiAjaW5jbHVkZSAiRXZlbnRJbnRlcmZhY2VzLmgiCisjaW5jbHVkZSAiRXhjZXB0aW9uT3IuaCIK
ICNpbmNsdWRlICJTY3JpcHRXcmFwcGFibGUuaCIKICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5o
PgogI2luY2x1ZGUgPHd0Zi9UeXBlQ2FzdHMuaD4KQEAgLTM4LDYgKzM5LDcgQEAgY2xhc3MgRGF0
YVRyYW5zZmVyOwogY2xhc3MgRXZlbnRQYXRoOwogY2xhc3MgRXZlbnRUYXJnZXQ7CiBjbGFzcyBI
VE1MSUZyYW1lRWxlbWVudDsKK2NsYXNzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ7CiAKIGVudW0g
RXZlbnRJbnRlcmZhY2UgewogCkBAIC05NSw2ICs5Nyw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFs
IH5FdmVudCgpOwogCiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBpbml0RXZlbnQoY29uc3QgQXRv
bWljU3RyaW5nJiB0eXBlLCBib29sIGNhbkJ1YmJsZSwgYm9vbCBjYW5jZWxhYmxlKTsKKyAgICBF
eGNlcHRpb25Pcjx2b2lkPiBpbml0RXZlbnRGb3JCaW5kaW5ncyhTY3JpcHRFeGVjdXRpb25Db250
ZXh0JiwgY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29sIGJ1YmJsZXMpOyAvLyBRdWlyay4K
KwogICAgIGJvb2wgaXNJbml0aWFsaXplZCgpIGNvbnN0IHsgcmV0dXJuIG1faXNJbml0aWFsaXpl
ZDsgfQogCiAgICAgY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlKCkgY29uc3QgeyByZXR1cm4gbV90
eXBlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaWRsIGIvU291cmNl
L1dlYkNvcmUvZG9tL0V2ZW50LmlkbAppbmRleCA4MjBhZTRjMWRmNzg3ODE0NDBlOTMwMmU0OGQ1
Y2FiNjdjZTY1MDI3Li42MzdkNGNmNTU3MGJkZTAzZGRhOWM2YTM5NWRkMzBjMTVjOTEyNDdjIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJD
b3JlL2RvbS9FdmVudC5pZGwKQEAgLTY1LDcgKzY1LDggQEAgdHlwZWRlZiB1bnNpZ25lZCBsb25n
IGxvbmcgRE9NVGltZVN0YW1wOwogICAgIHZvaWQgc3RvcFByb3BhZ2F0aW9uKCk7CiAgICAgdm9p
ZCBwcmV2ZW50RGVmYXVsdCgpOwogCi0gICAgdm9pZCBpbml0RXZlbnQoRE9NU3RyaW5nIGV2ZW50
VHlwZUFyZywgYm9vbGVhbiBjYW5CdWJibGVBcmcsIGJvb2xlYW4gY2FuY2VsYWJsZUFyZyk7Cisg
ICAgdm9pZCBpbml0RXZlbnQoRE9NU3RyaW5nIHR5cGUsIGJvb2xlYW4gYnViYmxlcywgYm9vbGVh
biBjYW5jZWxhYmxlKTsgLy8gU3RhbmRhcmQuCisgICAgW01heVRocm93RXhjZXB0aW9uLCBJbXBs
ZW1lbnRlZEFzPWluaXRFdmVudEZvckJpbmRpbmdzLCBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25D
b250ZXh0XSB2b2lkIGluaXRFdmVudChET01TdHJpbmcgdHlwZSwgb3B0aW9uYWwgYm9vbGVhbiBi
dWJibGVzID0gZmFsc2UpOyAvLyBRdWlyay4KIAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBib29s
ZWFuIGRlZmF1bHRQcmV2ZW50ZWQ7CiAgICAgdm9pZCBzdG9wSW1tZWRpYXRlUHJvcGFnYXRpb24o
KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlv
bkNoZWNrcy5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hl
Y2tzLmgKaW5kZXggOGNhZDgyYzYwYzkzZDg2ZjhhZjFjNWExZDI5M2FjZTFmOWY3YWZlOC4uNWJj
YmJjNjA3NjRiMjQzNGFlNjBhZWY2MjkxNTIyMDcwNThlNWM0MyAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmgKKysrIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmgKQEAgLTc1LDYgKzc1
LDcgQEAgV0VCQ09SRV9FWFBPUlQgYm9vbCBpc1RoZUVjb25vbWlzdE9uSXBob25lKCk7CiBXRUJD
T1JFX0VYUE9SVCBib29sIGlzV2ViUHJvY2VzcygpOwogYm9vbCBpc0lCb29rcygpOwogV0VCQ09S
RV9FWFBPUlQgYm9vbCBpc1RoZVNlY3JldFNvY2lldHlIaWRkZW5NeXN0ZXJ5KCk7Citib29sIGlz
QmFpbnVvKCk7CiAKIH0gLy8gSU9TQXBwbGljYXRpb24KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLm1tIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLm1tCmluZGV4IDhkNDcyMmM2YzQ5
MjhmZGE3ZDVmMDI1MGE4OGJhNjA1OTZjZDQ3ZDcuLmNmNmM4ZTcxN2QxMTQ1NzAwMmQyYjIxOTY2
OTU0NDA1Y2RlYTI5ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1J1bnRp
bWVBcHBsaWNhdGlvbkNoZWNrcy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50
aW1lQXBwbGljYXRpb25DaGVja3MubW0KQEAgLTI1Miw3ICsyNTIsMTQgQEAgYm9vbCBJT1NBcHBs
aWNhdGlvbjo6aXNUaGVTZWNyZXRTb2NpZXR5SGlkZGVuTXlzdGVyeSgpCiAgICAgc3RhdGljIGJv
b2wgaXNUaGVTZWNyZXRTb2NpZXR5SGlkZGVuTXlzdGVyeSA9IGFwcGxpY2F0aW9uQnVuZGxlSXNF
cXVhbFRvKCJjb20uZzVlLnNlY3JldHNvY2lldHkiKTsKICAgICByZXR1cm4gaXNUaGVTZWNyZXRT
b2NpZXR5SGlkZGVuTXlzdGVyeTsKIH0KLSAgICAKKworYm9vbCBJT1NBcHBsaWNhdGlvbjo6aXNC
YWludW8oKQoreworICAgIC8vIOeZvuW6puezr+exsyBhcHAuCisgICAgc3RhdGljIGJvb2wgaXNC
YWludW8gPSBhcHBsaWNhdGlvbkJ1bmRsZUlzRXF1YWxUbygiY29tLnJlbnJlbi1pbmMubnVvbWki
KTsKKyAgICByZXR1cm4gaXNCYWludW87Cit9CisKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBX
ZWJDb3JlCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>292948</attachid>
            <date>2016-10-26 11:18:38 -0700</date>
            <delta_ts>2016-10-26 13:12:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-163967-20161026111450.patch</filename>
            <type>text/plain</type>
            <size>6586</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3ODk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzIyZDk1M2ZmMzg2NWMy
MmViMjliYTk3MjBmYTI5MGI0MzY3N2EyNS4uMTcwNmI0ZjgxYjk5Mzg2YjEwN2M4Y2JlZmM0MTA1
NGUxYWQ0ZmQxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTEwLTI2ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjAzODQ4
KTog55m+5bqm57Ov57GzIGFwcCBmYWlscyB0byBsb2FkIGNvbnRlbnQgZHVlIHRvIGEgSmF2YVNj
cmlwdCBlcnJvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTYzOTY3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODcwNzgzOD4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgcXVpcmsgZm9yIOeZvuW6
puezr+exsyBhcHAgbWFraW5nIHRoZSAyIGxhc3QgcGFyYW1ldGVycyB0byBFdmVudC5wcm90b3R5
cGUuaW5pdEV2ZW50KCkKKyAgICAgICAgb3B0aW9uYWwuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz
LCBjaGFuZ2Ugb25seSBpbXBhY3RzIHRoaXMgc3BlY2lmaWMgYXBwbGljYXRpb24uCisKKyAgICAg
ICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEdlbmVy
YXRlUHJvcGVydGllc0hhc2hUYWJsZSk6CisgICAgICAgICogZG9tL0V2ZW50LmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkV2ZW50Ojppbml0RXZlbnRGb3JCaW5kaW5ncyk6CisgICAgICAgICogZG9t
L0V2ZW50Lmg6CisgICAgICAgICogZG9tL0V2ZW50LmlkbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9S
dW50aW1lQXBwbGljYXRpb25DaGVja3MuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9SdW50aW1lQXBw
bGljYXRpb25DaGVja3MubW06CisgICAgICAgIChXZWJDb3JlOjpJT1NBcHBsaWNhdGlvbjo6aXNC
YWlkdU51b21pKToKKwogMjAxNi0xMC0yNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxp
YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gRml4aW5nIGNvbXBpbGVyIHdhcm5pbmdzIGlu
IFBsYXliYWNrUGlwZWxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Nj
cmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0
cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggOTNkZmU2YWZiNGE4N2M1ZDQzZmJmYzkzMTJmODRj
MGY5NzUyN2QzYS4uYWRhZjIwYWM4YzI1M2UzYzM1ZTAxMjVkNWQ5N2MxZmNjZTRkNmJlNyAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMu
cG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMu
cG0KQEAgLTE4NTksNiArMTg1OSwxMCBAQCBzdWIgR2VuZXJhdGVQcm9wZXJ0aWVzSGFzaFRhYmxl
CiAgICAgICAgIHB1c2goQCRoYXNoVmFsdWUxLCAkZnVuY3Rpb25OYW1lKTsKIAogICAgICAgICBt
eSAkZnVuY3Rpb25MZW5ndGggPSBHZXRGdW5jdGlvbkxlbmd0aCgkZnVuY3Rpb24pOworCisgICAg
ICAgICMgRklYTUU6IFJlbW92ZSB0aGlzIG9uY2Ugd2UgY2FuIGdldCByaWQgb2YgdGhlIHF1aXJr
IGludHJvZHVjZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2
Mzk2Ny4KKyAgICAgICAgJGZ1bmN0aW9uTGVuZ3RoID0gMyBpZiAkaW50ZXJmYWNlTmFtZSBlcSAi
RXZlbnQiIGFuZCAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSBlcSAiaW5pdEV2ZW50IjsKKwog
ICAgICAgICBwdXNoKEAkaGFzaFZhbHVlMiwgJGZ1bmN0aW9uTGVuZ3RoKTsKIAogICAgICAgICBw
dXNoKEAkaGFzaFNwZWNpYWxzLCBDb21wdXRlRnVuY3Rpb25TcGVjaWFsKCRpbnRlcmZhY2UsICRm
dW5jdGlvbikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL2RvbS9FdmVudC5jcHAKaW5kZXggN2RkMWE4MzA1MjIyYzQ3NDFlMzRkYjk1
NjNhN2Q1MmVlZmE0MDI5MS4uMTc1M2RhZWE0OWY5YjBjNDZmOGUxOTE4ZWY3NzU4ODVlNTU3OGI3
MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9kb20vRXZlbnQuY3BwCkBAIC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSAiRXZlbnRO
YW1lcy5oIgogI2luY2x1ZGUgIkV2ZW50UGF0aC5oIgogI2luY2x1ZGUgIkV2ZW50VGFyZ2V0Lmgi
CisjaW5jbHVkZSAiUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLmgiCiAjaW5jbHVkZSAiVXNlckdl
c3R1cmVJbmRpY2F0b3IuaCIKICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KIApAQCAtODks
NiArOTAsMjMgQEAgdm9pZCBFdmVudDo6aW5pdEV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZl
bnRUeXBlQXJnLCBib29sIGNhbkJ1YmJsZUFyZywgYm9vbAogICAgIG1fY2FuY2VsYWJsZSA9IGNh
bmNlbGFibGVBcmc7CiB9CiAKK0V4Y2VwdGlvbk9yPHZvaWQ+IEV2ZW50Ojppbml0RXZlbnRGb3JC
aW5kaW5ncyhTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBzY3JpcHRFeGVjdXRpb25Db250ZXh0LCBj
b25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIGJvb2wgYnViYmxlcykKK3sKKyNpZiBQTEFURk9STShJ
T1MpCisgICAgLy8gRklYTUU6IFRlbXBvcmFyeSBxdWlyayBmb3Ig55m+5bqm57Ov57GzIEFwcCB3
aGljaCBjYWxscyBpbml0RXZlbnQoKSB3aXRoIHRvbyBmZXcgcGFyYW1ldGVycyAocmRhcjovL3By
b2JsZW0vMjg3MDc4MzgpLgorICAgIGlmIChJT1NBcHBsaWNhdGlvbjo6aXNCYWlkdU51b21pKCkp
IHsKKyAgICAgICAgc2NyaXB0RXhlY3V0aW9uQ29udGV4dC5hZGRDb25zb2xlTWVzc2FnZShNZXNz
YWdlU291cmNlOjpKUywgTWVzc2FnZUxldmVsOjpXYXJuaW5nLCBBU0NJSUxpdGVyYWwoIkNhbGxp
bmcgRXZlbnQucHJvdG90eXBlLmluaXRFdmVudCgpIHdpdGggbGVzcyB0aGFuIDMgcGFyYW1ldGVy
cyBpcyBkZXByZWNhdGVkLiIpKTsKKyAgICAgICAgaW5pdEV2ZW50KHR5cGUsIGJ1YmJsZXMsIGZh
bHNlKTsKKyAgICAgICAgcmV0dXJuIHsgfTsKKyAgICB9CisjZWxzZQorICAgIFVOVVNFRF9QQVJB
TShzY3JpcHRFeGVjdXRpb25Db250ZXh0KTsKKyAgICBVTlVTRURfUEFSQU0odHlwZSk7CisgICAg
VU5VU0VEX1BBUkFNKGJ1YmJsZXMpOworI2VuZGlmCisgICAgcmV0dXJuIEV4Y2VwdGlvbiB7IFR5
cGVFcnJvciwgQVNDSUlMaXRlcmFsKCJOb3QgZW5vdWdoIGFyZ3VtZW50cyIpIH07Cit9CisKIGJv
b2wgRXZlbnQ6OmNvbXBvc2VkKCkgY29uc3QKIHsKICAgICBpZiAobV9jb21wb3NlZCkKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2
ZW50LmgKaW5kZXggOTQwYWJiMzczNWQyZjBjYjdlYzg2NTFkNzIyZmQ2MGU5Y2RlNjcxZS4uYjFi
NWZmMWNmYTgzZGY3NjJiZWEyYjdhMzkyZTc2YjZmMjA3Y2UyMyAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvZG9tL0V2ZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmgKQEAg
LTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlICJET01UaW1lU3RhbXAuaCIKICNpbmNsdWRlICJFdmVu
dEluaXQuaCIKICNpbmNsdWRlICJFdmVudEludGVyZmFjZXMuaCIKKyNpbmNsdWRlICJFeGNlcHRp
b25Pci5oIgogI2luY2x1ZGUgIlNjcmlwdFdyYXBwYWJsZS5oIgogI2luY2x1ZGUgPHd0Zi9SZWZD
b3VudGVkLmg+CiAjaW5jbHVkZSA8d3RmL1R5cGVDYXN0cy5oPgpAQCAtMzgsNiArMzksNyBAQCBj
bGFzcyBEYXRhVHJhbnNmZXI7CiBjbGFzcyBFdmVudFBhdGg7CiBjbGFzcyBFdmVudFRhcmdldDsK
IGNsYXNzIEhUTUxJRnJhbWVFbGVtZW50OworY2xhc3MgU2NyaXB0RXhlY3V0aW9uQ29udGV4dDsK
IAogZW51bSBFdmVudEludGVyZmFjZSB7CiAKQEAgLTk1LDYgKzk3LDggQEAgcHVibGljOgogICAg
IHZpcnR1YWwgfkV2ZW50KCk7CiAKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGluaXRFdmVudChj
b25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIGJvb2wgY2FuQnViYmxlLCBib29sIGNhbmNlbGFibGUp
OworICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IGluaXRFdmVudEZvckJpbmRpbmdzKFNjcmlwdEV4ZWN1
dGlvbkNvbnRleHQmLCBjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUsIGJvb2wgYnViYmxlcyk7IC8v
IFF1aXJrLgorCiAgICAgYm9vbCBpc0luaXRpYWxpemVkKCkgY29uc3QgeyByZXR1cm4gbV9pc0lu
aXRpYWxpemVkOyB9CiAKICAgICBjb25zdCBBdG9taWNTdHJpbmcmIHR5cGUoKSBjb25zdCB7IHJl
dHVybiBtX3R5cGU7IH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5pZGwg
Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuaWRsCmluZGV4IDgyMGFlNGMxZGY3ODc4MTQ0MGU5
MzAyZTQ4ZDVjYWI2N2NlNjUwMjcuLjYzN2Q0Y2Y1NTcwYmRlMDNkZGE5YzZhMzk1ZGQzMGMxNWM5
MTI0N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVudC5pZGwKKysrIGIvU291
cmNlL1dlYkNvcmUvZG9tL0V2ZW50LmlkbApAQCAtNjUsNyArNjUsOCBAQCB0eXBlZGVmIHVuc2ln
bmVkIGxvbmcgbG9uZyBET01UaW1lU3RhbXA7CiAgICAgdm9pZCBzdG9wUHJvcGFnYXRpb24oKTsK
ICAgICB2b2lkIHByZXZlbnREZWZhdWx0KCk7CiAKLSAgICB2b2lkIGluaXRFdmVudChET01TdHJp
bmcgZXZlbnRUeXBlQXJnLCBib29sZWFuIGNhbkJ1YmJsZUFyZywgYm9vbGVhbiBjYW5jZWxhYmxl
QXJnKTsKKyAgICB2b2lkIGluaXRFdmVudChET01TdHJpbmcgdHlwZSwgYm9vbGVhbiBidWJibGVz
LCBib29sZWFuIGNhbmNlbGFibGUpOyAvLyBTdGFuZGFyZC4KKyAgICBbTWF5VGhyb3dFeGNlcHRp
b24sIEltcGxlbWVudGVkQXM9aW5pdEV2ZW50Rm9yQmluZGluZ3MsIENhbGxXaXRoPVNjcmlwdEV4
ZWN1dGlvbkNvbnRleHRdIHZvaWQgaW5pdEV2ZW50KERPTVN0cmluZyB0eXBlLCBvcHRpb25hbCBi
b29sZWFuIGJ1YmJsZXMgPSBmYWxzZSk7IC8vIFF1aXJrLgogCiAgICAgcmVhZG9ubHkgYXR0cmli
dXRlIGJvb2xlYW4gZGVmYXVsdFByZXZlbnRlZDsKICAgICB2b2lkIHN0b3BJbW1lZGlhdGVQcm9w
YWdhdGlvbigpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFw
cGxpY2F0aW9uQ2hlY2tzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGlj
YXRpb25DaGVja3MuaAppbmRleCA4Y2FkODJjNjBjOTNkODZmOGFmMWM1YTFkMjkzYWNlMWY5Zjdh
ZmU4Li5hOTgxMjEyMTliMDdjOGE3Y2Y3MjM5MWQzMzhjZmE1ZWFhYzA2ZDE0IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MuaApAQCAt
NzUsNiArNzUsNyBAQCBXRUJDT1JFX0VYUE9SVCBib29sIGlzVGhlRWNvbm9taXN0T25JcGhvbmUo
KTsKIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNXZWJQcm9jZXNzKCk7CiBib29sIGlzSUJvb2tzKCk7
CiBXRUJDT1JFX0VYUE9SVCBib29sIGlzVGhlU2VjcmV0U29jaWV0eUhpZGRlbk15c3RlcnkoKTsK
K2Jvb2wgaXNCYWlkdU51b21pKCk7CiAKIH0gLy8gSU9TQXBwbGljYXRpb24KIApkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLm1tIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzLm1tCmluZGV4
IDhkNDcyMmM2YzQ5MjhmZGE3ZDVmMDI1MGE4OGJhNjA1OTZjZDQ3ZDcuLmQzMWQzMzJlNGY1OTI3
MWE4ZDlkNmUwZGUzNmZjYWE2YTNjY2Q4MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL1J1bnRpbWVBcHBsaWNhdGlvbkNoZWNrcy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9SdW50aW1lQXBwbGljYXRpb25DaGVja3MubW0KQEAgLTI1Miw3ICsyNTIsMTQgQEAg
Ym9vbCBJT1NBcHBsaWNhdGlvbjo6aXNUaGVTZWNyZXRTb2NpZXR5SGlkZGVuTXlzdGVyeSgpCiAg
ICAgc3RhdGljIGJvb2wgaXNUaGVTZWNyZXRTb2NpZXR5SGlkZGVuTXlzdGVyeSA9IGFwcGxpY2F0
aW9uQnVuZGxlSXNFcXVhbFRvKCJjb20uZzVlLnNlY3JldHNvY2lldHkiKTsKICAgICByZXR1cm4g
aXNUaGVTZWNyZXRTb2NpZXR5SGlkZGVuTXlzdGVyeTsKIH0KLSAgICAKKworYm9vbCBJT1NBcHBs
aWNhdGlvbjo6aXNCYWlkdU51b21pKCkKK3sKKyAgICAvLyDnmb7luqbns6/nsbMgYXBwLgorICAg
IHN0YXRpYyBib29sIGlzQmFpZHVOdW9taSA9IGFwcGxpY2F0aW9uQnVuZGxlSXNFcXVhbFRvKCJj
b20ucmVucmVuLWluYy5udW9taSIpOworICAgIHJldHVybiBpc0JhaWR1TnVvbWk7Cit9CisKICNl
bmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==
</data>
<flag name="review"
          id="315922"
          type_id="1"
          status="+"
          setter="rniwa"
    />
          </attachment>
      

    </bug>

</bugzilla>