163966 2016-10-25 12:39:42 -0700 IDBDatabase.transaction() should take a union in parameter 2016-10-25 15:04:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://www.w3.org/TR/IndexedDB/#widl-IDBDatabase-transaction-IDBTransaction-DOMString-sequence-DOMString--storeNames-IDBTransactionMode-mode P2 Normal --- 1 cdumez cdumez alecflett beidson commit-queue darin esprehn+autocc jsbell kondapallykalyan sam oldest_to_newest 1244359 0 cdumez 2016-10-25 12:39:42 -0700 IDBDatabase.transaction() should take a union in parameter: - https://www.w3.org/TR/IndexedDB/#widl-IDBDatabase-transaction-IDBTransaction-DOMString-sequence-DOMString--storeNames-IDBTransactionMode-mode 1244372 1 292804 cdumez 2016-10-25 13:06:12 -0700 Created attachment 292804 Patch 1244450 2 292804 sam 2016-10-25 14:41:42 -0700 Comment on attachment 292804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review > Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179 > if (objectStores.isEmpty()) > return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") }; Can this case happen? 1244452 3 292804 cdumez 2016-10-25 14:43:40 -0700 Comment on attachment 292804 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292804&action=review >> Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:179 >> return Exception { IDBDatabaseException::InvalidAccessError, ASCIILiteral("Failed to execute 'transaction' on 'IDBDatabase': The storeNames parameter was empty.") }; > > Can this case happen? database.transaction([]) ? 1244471 4 292804 cdumez 2016-10-25 15:04:45 -0700 Comment on attachment 292804 Patch Clearing flags on attachment: 292804 Committed r207847: <http://trac.webkit.org/changeset/207847> 1244472 5 cdumez 2016-10-25 15:04:50 -0700 All reviewed patches have been landed. Closing bug. 292804 2016-10-25 13:06:12 -0700 2016-10-25 15:04:45 -0700 Patch bug-163966-20161025130226.patch text/plain 5312 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3ODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhjNGVmNzg4MjMxOTdl MWJhMDMzOGVjZDk3OTYzYzcyMmJhNjE3Ni4uNDczYjZlMGE1YjgwZTBjOTVmMzRjZjMwODJiZmM5 ZTZhYjhkNTUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTEwLTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSURCRGF0YWJhc2UudHJhbnNh Y3Rpb24oKSBzaG91bGQgdGFrZSBhIHVuaW9uIGluIHBhcmFtZXRlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTY2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSURCRGF0YWJhc2UudHJhbnNhY3Rpb24o KSBzaG91bGQgdGFrZSBhIHVuaW9uIGluIHBhcmFtZXRlcjoKKyAgICAgICAgLSBodHRwczovL3d3 dy53My5vcmcvVFIvSW5kZXhlZERCLyN3aWRsLUlEQkRhdGFiYXNlLXRyYW5zYWN0aW9uLUlEQlRy YW5zYWN0aW9uLURPTVN0cmluZy1zZXF1ZW5jZS1ET01TdHJpbmctLXN0b3JlTmFtZXMtSURCVHJh bnNhY3Rpb25Nb2RlLW1vZGUKKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGV4cGVjdGVkIFdl Yi1leHBvc2VkIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIE1vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFiYXNlOjp0cmFuc2Fj dGlvbik6CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuaDoKKyAgICAg ICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5pZGw6CisKIDIwMTYtMTAtMjUgIEFu dG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbTW9kZXJuIE1lZGlh IENvbnRyb2xzXSBNZWRpYSBDb250cm9sbGVyOiBza2lwIGJhY2sgc3VwcG9ydApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuY3BwCmluZGV4IGI2OTM4 NzY2MDUzY2QxMmJkN2Q0YzhlZjc0MThmMjY0MTE5NjJlZjkuLjE1NWI0ZDBjNTgzYzNmNDVkNTc2 ODk0NDk2MmQwMzIyZjA3OTVlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2lu ZGV4ZWRkYi9JREJEYXRhYmFzZS5jcHAKQEAgLTE2MCw3ICsxNjAsNyBAQCBFeGNlcHRpb25PcjxS ZWY8SURCT2JqZWN0U3RvcmU+PiBJREJEYXRhYmFzZTo6Y3JlYXRlT2JqZWN0U3RvcmUoY29uc3Qg U3RyaW5nJiBuYQogICAgIHJldHVybiBtX3ZlcnNpb25DaGFuZ2VUcmFuc2FjdGlvbi0+Y3JlYXRl T2JqZWN0U3RvcmUoaW5mbyk7CiB9CiAKLUV4Y2VwdGlvbk9yPFJlZjxJREJUcmFuc2FjdGlvbj4+ IElEQkRhdGFiYXNlOjp0cmFuc2FjdGlvbihjb25zdCBWZWN0b3I8U3RyaW5nPiYgb2JqZWN0U3Rv cmVzLCBjb25zdCBTdHJpbmcmIG1vZGVTdHJpbmcpCitFeGNlcHRpb25PcjxSZWY8SURCVHJhbnNh Y3Rpb24+PiBJREJEYXRhYmFzZTo6dHJhbnNhY3Rpb24oU3RyaW5nT3JWZWN0b3JPZlN0cmluZ3Mm JiBzdG9yZU5hbWVzLCBjb25zdCBTdHJpbmcmIG1vZGVTdHJpbmcpCiB7CiAgICAgTE9HKEluZGV4 ZWREQiwgIklEQkRhdGFiYXNlOjp0cmFuc2FjdGlvbiIpOwogCkBAIC0xNjksNiArMTY5LDEyIEBA IEV4Y2VwdGlvbk9yPFJlZjxJREJUcmFuc2FjdGlvbj4+IElEQkRhdGFiYXNlOjp0cmFuc2FjdGlv bihjb25zdCBWZWN0b3I8U3RyaW5nPiYKICAgICBpZiAobV9jbG9zZVBlbmRpbmcpCiAgICAgICAg IHJldHVybiBFeGNlcHRpb24geyBJREJEYXRhYmFzZUV4Y2VwdGlvbjo6SW52YWxpZFN0YXRlRXJy b3IsIEFTQ0lJTGl0ZXJhbCgiRmFpbGVkIHRvIGV4ZWN1dGUgJ3RyYW5zYWN0aW9uJyBvbiAnSURC RGF0YWJhc2UnOiBUaGUgZGF0YWJhc2UgY29ubmVjdGlvbiBpcyBjbG9zaW5nLiIpIH07CiAKKyAg ICBWZWN0b3I8U3RyaW5nPiBvYmplY3RTdG9yZXM7CisgICAgaWYgKFdURjo6aG9sZHNfYWx0ZXJu YXRpdmU8VmVjdG9yPFN0cmluZz4+KHN0b3JlTmFtZXMpKQorICAgICAgICBvYmplY3RTdG9yZXMg PSBXVEZNb3ZlKFdURjo6Z2V0PFZlY3RvcjxTdHJpbmc+PihzdG9yZU5hbWVzKSk7CisgICAgZWxz ZQorICAgICAgICBvYmplY3RTdG9yZXMuYXBwZW5kKFdURk1vdmUoV1RGOjpnZXQ8U3RyaW5nPihz dG9yZU5hbWVzKSkpOworCiAgICAgaWYgKG9iamVjdFN0b3Jlcy5pc0VtcHR5KCkpCiAgICAgICAg IHJldHVybiBFeGNlcHRpb24geyBJREJEYXRhYmFzZUV4Y2VwdGlvbjo6SW52YWxpZEFjY2Vzc0Vy cm9yLCBBU0NJSUxpdGVyYWwoIkZhaWxlZCB0byBleGVjdXRlICd0cmFuc2FjdGlvbicgb24gJ0lE QkRhdGFiYXNlJzogVGhlIHN0b3JlTmFtZXMgcGFyYW1ldGVyIHdhcyBlbXB0eS4iKSB9OwogCkBA IC0xOTgsMTUgKzIwNCw2IEBAIEV4Y2VwdGlvbk9yPFJlZjxJREJUcmFuc2FjdGlvbj4+IElEQkRh dGFiYXNlOjp0cmFuc2FjdGlvbihjb25zdCBWZWN0b3I8U3RyaW5nPiYKICAgICByZXR1cm4gV1RG TW92ZSh0cmFuc2FjdGlvbik7CiB9CiAKLUV4Y2VwdGlvbk9yPFJlZjxJREJUcmFuc2FjdGlvbj4+ IElEQkRhdGFiYXNlOjp0cmFuc2FjdGlvbihjb25zdCBTdHJpbmcmIG9iamVjdFN0b3JlLCBjb25z dCBTdHJpbmcmIG1vZGUpCi17Ci0gICAgQVNTRVJUKGN1cnJlbnRUaHJlYWQoKSA9PSBvcmlnaW5U aHJlYWRJRCgpKTsKLQotICAgIFZlY3RvcjxTdHJpbmc+IG9iamVjdFN0b3JlcygxKTsKLSAgICBv YmplY3RTdG9yZXNbMF0gPSBvYmplY3RTdG9yZTsKLSAgICByZXR1cm4gdHJhbnNhY3Rpb24ob2Jq ZWN0U3RvcmVzLCBtb2RlKTsKLX0KLQogRXhjZXB0aW9uT3I8dm9pZD4gSURCRGF0YWJhc2U6OmRl bGV0ZU9iamVjdFN0b3JlKGNvbnN0IFN0cmluZyYgb2JqZWN0U3RvcmVOYW1lKQogewogICAgIExP RyhJbmRleGVkREIsICJJREJEYXRhYmFzZTo6ZGVsZXRlT2JqZWN0U3RvcmUiKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5oCmluZGV4IDBiNDA3NjEx YWM1MjE4YjBmNTA5NTRhZTkxZWNmNTAxMWYzMTc1YmIuLjJiODY4NTdkMTg3NTIzMDJmNWUxZWRi YWMzMDJjMDEyNjBmNzhiNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5k ZXhlZGRiL0lEQkRhdGFiYXNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvSURCRGF0YWJhc2UuaApAQCAtNjMsOCArNjMsOCBAQCBwdWJsaWM6CiAKICAgICBFeGNlcHRp b25PcjxSZWY8SURCT2JqZWN0U3RvcmU+PiBjcmVhdGVPYmplY3RTdG9yZShjb25zdCBTdHJpbmcm IG5hbWUsIE9iamVjdFN0b3JlUGFyYW1ldGVycyYmKTsKIAotICAgIEV4Y2VwdGlvbk9yPFJlZjxJ REJUcmFuc2FjdGlvbj4+IHRyYW5zYWN0aW9uKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiwgY29uc3Qg U3RyaW5nJiBtb2RlKTsKLSAgICBFeGNlcHRpb25PcjxSZWY8SURCVHJhbnNhY3Rpb24+PiB0cmFu c2FjdGlvbihjb25zdCBTdHJpbmcmLCBjb25zdCBTdHJpbmcmIG1vZGUpOworICAgIHVzaW5nIFN0 cmluZ09yVmVjdG9yT2ZTdHJpbmdzID0gV1RGOjpWYXJpYW50PFN0cmluZywgVmVjdG9yPFN0cmlu Zz4+OworICAgIEV4Y2VwdGlvbk9yPFJlZjxJREJUcmFuc2FjdGlvbj4+IHRyYW5zYWN0aW9uKFN0 cmluZ09yVmVjdG9yT2ZTdHJpbmdzJiYgc3RvcmVOYW1lcywgY29uc3QgU3RyaW5nJiBtb2RlKTsK ICAgICBFeGNlcHRpb25Pcjx2b2lkPiBkZWxldGVPYmplY3RTdG9yZShjb25zdCBTdHJpbmcmIG5h bWUpOwogICAgIHZvaWQgY2xvc2UoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2UuaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvSURCRGF0YWJhc2UuaWRsCmluZGV4IDg1ZDJhYjI1YTIxNzU4MjZhOWQxY2I2Mzkz NDUxMTIzOTc0YzQwNzAuLjQ1NTJjM2M0NmI3OTQ4OGY2NWRjNGE4Y2YzZGQ1MTFmYjJhYzlhZWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNl LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZS5p ZGwKQEAgLTM2LDggKzM2LDEwIEBACiAKICAgICBbTWF5VGhyb3dFeGNlcHRpb25dIElEQk9iamVj dFN0b3JlIGNyZWF0ZU9iamVjdFN0b3JlKERPTVN0cmluZyBuYW1lLCBvcHRpb25hbCBJREJPYmpl Y3RTdG9yZVBhcmFtZXRlcnMgcGFyYW1ldGVycyk7CiAgICAgW01heVRocm93RXhjZXB0aW9uXSB2 b2lkIGRlbGV0ZU9iamVjdFN0b3JlKERPTVN0cmluZyBuYW1lKTsKLSAgICBbTWF5VGhyb3dFeGNl cHRpb25dIElEQlRyYW5zYWN0aW9uIHRyYW5zYWN0aW9uKERPTVN0cmluZyBzdG9yZU5hbWUsIG9w dGlvbmFsIERPTVN0cmluZyBtb2RlID0gInJlYWRvbmx5Iik7Ci0gICAgW01heVRocm93RXhjZXB0 aW9uXSBJREJUcmFuc2FjdGlvbiB0cmFuc2FjdGlvbihzZXF1ZW5jZTxET01TdHJpbmc+IHN0b3Jl TmFtZXMsIG9wdGlvbmFsIERPTVN0cmluZyBtb2RlID0gInJlYWRvbmx5Iik7CisKKyAgICAvLyBG SVhNRTogbW9kZSBwYXJhbWV0ZXIgdHlwZSBzaG91bGQgYmUgYSBJREJUcmFuc2FjdGlvbk1vZGUg c3RyaW5nIGVudW1lcmF0aW9uLgorICAgIFtNYXlUaHJvd0V4Y2VwdGlvbl0gSURCVHJhbnNhY3Rp b24gdHJhbnNhY3Rpb24oKERPTVN0cmluZyBvciBzZXF1ZW5jZTxET01TdHJpbmc+KSBzdG9yZU5h bWVzLCBvcHRpb25hbCBET01TdHJpbmcgbW9kZSA9ICJyZWFkb25seSIpOworCiAgICAgLy8gRklY TUU6IFRoaXMgaXMgbm90IHBhcnQgb2YgdGhlIHNwZWMsIGJ1dCBpcyBuZWVkZWQgZm9yIGNvbXBh dGliaWxpdHkuCiAgICAgLy8gU2VlIGh0dHBzOi8vZ2l0aHViLmNvbS93M2MvSW5kZXhlZERCL2lz c3Vlcy84NQogICAgIFtNYXlUaHJvd0V4Y2VwdGlvbl0gSURCVHJhbnNhY3Rpb24gdHJhbnNhY3Rp b24oRE9NU3RyaW5nTGlzdCBzdG9yZU5hbWVzLCBvcHRpb25hbCBET01TdHJpbmcgbW9kZSA9ICJy ZWFkb25seSIpOwo=