163961 2016-10-25 12:02:34 -0700 Web Inspector: Cmd-+ doesn't "zoom in" to increase text size in the Web Inspector 2016-10-25 15:29:59 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy vicki webkit-bug-importer oldest_to_newest 1244327 0 joepeck 2016-10-25 12:02:34 -0700 Summary: Cmd-+ doesn't "zoom in" to increase text size in the Web Inspector Steps to Reproduce: 1. Inspect this page 2. Shift-Cmd-Plus / Shift-Cmd-Minus => Expected zoom-in/zoom-out and nothing happened Notes: Safari supports: Cmd-Plus (really this is Cmd-Equals) Cmd-Minus (really this is Cmd-Minus) Shift-Cmd-Plus (really this is Cmd-Plus) Shift-Cmd-Minus (really this is Cmd-Underscore) We just need to add the Shift variants! 1244328 1 joepeck 2016-10-25 12:02:43 -0700 <rdar://problem/28895308> 1244329 2 292796 joepeck 2016-10-25 12:03:41 -0700 Created attachment 292796 [PATCH] Proposed Fix 1244367 3 292796 bburg 2016-10-25 12:48:44 -0700 Comment on attachment 292796 [PATCH] Proposed Fix r=me 1244488 4 292796 commit-queue 2016-10-25 15:29:55 -0700 Comment on attachment 292796 [PATCH] Proposed Fix Clearing flags on attachment: 292796 Committed r207850: <http://trac.webkit.org/changeset/207850> 1244489 5 commit-queue 2016-10-25 15:29:59 -0700 All reviewed patches have been landed. Closing bug. 292796 2016-10-25 12:03:41 -0700 2016-10-25 15:29:55 -0700 [PATCH] Proposed Fix zoom-1.patch text/plain 3378 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhjNjFiNGMuLmQxYWMzZDUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEwLTI1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ21kLSsg ZG9lc24ndCAiem9vbSBpbiIgdG8gaW5jcmVhc2UgdGV4dCBzaXplIGluIHRoZSBXZWIgSW5zcGVj dG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjM5 NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4ODk1MzA4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4u anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCk6CisgICAgICAgIEFkZCBh IGR1cGxpY2F0ZSBzZXQgb2Yga2V5Ym9hcmQgc2hvcnRjdXRzIGZvciB0aGUgU2hpZnQgdmFyaWFu dHMuCisKIDIwMTYtMTAtMjIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbmNsdWRlIENvbnNvbGVBZ2VudCBpbiBXb3JrZXJz IC0gcmVhbCBjb25zb2xlLmxvZyBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggMTc1MTU3NS4uZDY0YTVjNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAt Mjc1LDggKzI3NSwxMiBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkK ICAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2Rp Zmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9k aWZpZXIuU2hpZnQsICIwIiwgdGhpcy50b2dnbGVOYXZpZ2F0aW9uU2lkZWJhci5iaW5kKHRoaXMp KTsKICAgICB0aGlzLmRldGFpbHNTaWRlYmFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2Rp Zmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9k aWZpZXIuT3B0aW9uLCAiMCIsIHRoaXMudG9nZ2xlRGV0YWlsc1NpZGViYXIuYmluZCh0aGlzKSk7 CiAKLSAgICB0aGlzLl9pbmNyZWFzZVpvb21LZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3Bl Y3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlm aWVyLkNvbW1hbmRPckNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5Q bHVzLCB0aGlzLl9pbmNyZWFzZVpvb20uYmluZCh0aGlzKSk7Ci0gICAgdGhpcy5fZGVjcmVhc2Va b29tS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCBX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuTWludXMsIHRoaXMuX2RlY3JlYXNlWm9v bS5iaW5kKHRoaXMpKTsKKyAgICBsZXQgYm91bmRJbmNyZWFzZVpvb20gPSB0aGlzLl9pbmNyZWFz ZVpvb20uYmluZCh0aGlzKTsKKyAgICBsZXQgYm91bmREZWNyZWFzZVpvb20gPSB0aGlzLl9kZWNy ZWFzZVpvb20uYmluZCh0aGlzKTsKKyAgICB0aGlzLl9pbmNyZWFzZVpvb21LZXlib2FyZFNob3J0 Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsIFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0LktleS5QbHVzLCBib3VuZEluY3JlYXNlWm9vbSk7CisgICAgdGhpcy5fZGVj cmVhc2Vab29tS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9y dGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250 cm9sLCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuTWludXMsIGJvdW5kRGVjcmVh c2Vab29tKTsKKyAgICB0aGlzLl9pbmNyZWFzZVpvb21LZXlib2FyZFNob3J0Y3V0MiA9IG5ldyBX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQuTW9kaWZpZXIuU2hpZnQsIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LktleS5QbHVz LCBib3VuZEluY3JlYXNlWm9vbSk7CisgICAgdGhpcy5fZGVjcmVhc2Vab29tS2V5Ym9hcmRTaG9y dGN1dDIgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktl eWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9y dGN1dC5LZXkuTWludXMsIGJvdW5kRGVjcmVhc2Vab29tKTsKICAgICB0aGlzLl9yZXNldFpvb21L ZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYklu c3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsICIwIiwg dGhpcy5fcmVzZXRab29tLmJpbmQodGhpcykpOwogCiAgICAgdGhpcy5fc2hvd1RhYkF0SW5kZXhL ZXlib2FyZFNob3J0Y3V0cyA9IFsxLCAyLCAzLCA0LCA1LCA2LCA3LCA4LCA5XS5tYXAoKGkpID0+ IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuTW9kaWZpZXIuT3B0aW9uLCBgJHtpfWAsIHRoaXMuX3Nob3dUYWJBdEluZGV4LmJp bmQodGhpcywgaSkpKTsK