163959 2016-10-25 11:34:16 -0700 WebAssembly: fix unknown section name handling, and check for section size overflow 2016-10-25 14:13:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159775 163963 1 jfbastien jfbastien commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1244312 0 jfbastien 2016-10-25 11:34:16 -0700 See: https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#high-level-structure Name length and name are already included in the payload length. 1244314 1 292792 jfbastien 2016-10-25 11:37:32 -0700 Created attachment 292792 patch 1244426 2 292792 commit-queue 2016-10-25 14:13:36 -0700 Comment on attachment 292792 patch Clearing flags on attachment: 292792 Committed r207843: <http://trac.webkit.org/changeset/207843> 1244427 3 commit-queue 2016-10-25 14:13:39 -0700 All reviewed patches have been landed. Closing bug. 292792 2016-10-25 11:37:32 -0700 2016-10-25 14:13:36 -0700 patch 0001-WebAssembly-fix-unknown-section-name-handling-and-ch.patch text/plain 3612 jfbastien RnJvbSBmM2U1Mjk5YzliYTA3OTYzZjIzZDdiZmMxMmM2ZTMwYmVkNDQ0OWE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUdWUsIDI1IE9jdCAyMDE2IDExOjMzOjE3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gV2ViQXNz ZW1ibHk6IGZpeCB1bmtub3duIHNlY3Rpb24gbmFtZSBoYW5kbGluZywgYW5kIGNoZWNrIGZvcgog c2VjdGlvbiBzaXplIG92ZXJmbG93CgpTZWU6IGh0dHBzOi8vZ2l0aHViLmNvbS9XZWJBc3NlbWJs eS9kZXNpZ24vYmxvYi9tYXN0ZXIvQmluYXJ5RW5jb2RpbmcubWQjaGlnaC1sZXZlbC1zdHJ1Y3R1 cmUKCk5hbWUgbGVuZ3RoIGFuZCBuYW1lIGFyZSBhbHJlYWR5IGluY2x1ZGVkIGluIHRoZSBwYXls b2FkIGxlbmd0aC4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg ICAgICAgICB8IDE0ICsrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dh c21Nb2R1bGVQYXJzZXIuY3BwIHwgMjcgKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwppbmRleCBhODUxYzYxLi41MjZlNTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsNSArMSwxOSBAQAogMjAxNi0xMC0yNSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBh cHBsZS5jb20+CiAKKyAgICAgICAgV2ViQXNzZW1ibHk6IGZpeCB1bmtub3duIHNlY3Rpb24gbmFt ZSBoYW5kbGluZywgYW5kIGNoZWNrIGZvciBzZWN0aW9uIHNpemUgb3ZlcmZsb3cKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mzk1OQorCisgICAgICAg IFNlZTogaHR0cHM6Ly9naXRodWIuY29tL1dlYkFzc2VtYmx5L2Rlc2lnbi9ibG9iL21hc3Rlci9C aW5hcnlFbmNvZGluZy5tZCNoaWdoLWxldmVsLXN0cnVjdHVyZQorCisgICAgICAgIE5hbWUgbGVu Z3RoIGFuZCBuYW1lIGFyZSBhbHJlYWR5IGluY2x1ZGVkIGluIHRoZSBwYXlsb2FkIGxlbmd0aC4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdhc20v V2FzbU1vZHVsZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6Oldhc206Ok1vZHVsZVBhcnNlcjo6 cGFyc2UpOgorCisyMDE2LTEwLTI1ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4K KwogICAgICAgICBXZWJBc3NlbWJseSBKUyBBUEk6IGltcGxlbWVudCBNb2R1bGUKIAogICAgICAg ICBUaGlzIGltcGxlbWVudGF0aW9uIGFsbG93cyB1cyB0bzoKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dhc21Nb2R1bGVQYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3dhc20vV2FzbU1vZHVsZVBhcnNlci5jcHAKaW5kZXggMjc2ZDg5Ny4uZGE5ZDA5MiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1vZHVsZVBhcnNlci5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1vZHVsZVBhcnNlci5jcHAK QEAgLTg4LDI0ICs4OCw2IEBAIGJvb2wgTW9kdWxlUGFyc2VyOjpwYXJzZSgpCiAgICAgICAgIGlm IChzZWN0aW9uQnl0ZSkgewogICAgICAgICAgICAgaWYgKHNlY3Rpb25CeXRlIDwgU2VjdGlvbnM6 OlVua25vd24pCiAgICAgICAgICAgICAgICAgc2VjdGlvbiA9IHN0YXRpY19jYXN0PFNlY3Rpb25z OjpTZWN0aW9uPihzZWN0aW9uQnl0ZSk7Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICB1 aW50MzJfdCBzZWN0aW9uTmFtZUxlbmd0aDsKLSAgICAgICAgICAgIGlmICghcGFyc2VWYXJVSW50 MzIoc2VjdGlvbk5hbWVMZW5ndGgpKSB7Ci0gICAgICAgICAgICAgICAgLy8gRklYTUUgaW1wcm92 ZSBlcnJvciBtZXNzYWdlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjM5MTkKLSAgICAgICAgICAgICAgICBtX2Vycm9yTWVzc2FnZSA9ICJjb3VsZG4ndCBnZXQgc2Vj dGlvbiBuYW1lIGxlbmd0aCI7Ci0gICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgICAg ICAgICAgfQotCi0gICAgICAgICAgICAvLyBNYWtlIHN1cmUgd2UgY2FuIHJlYWQgdXAgdG8gdGhl IHNlY3Rpb24ncyBzaXplLgotICAgICAgICAgICAgaWYgKG1fb2Zmc2V0ICsgc2VjdGlvbk5hbWVM ZW5ndGggKyBXVEY6OkxFQkRlY29kZXI6Om1heDMyQml0TEVCQnl0ZUxlbmd0aCA+PSBsZW5ndGgo KSkgewotICAgICAgICAgICAgICAgIC8vIEZJWE1FIGltcHJvdmUgZXJyb3IgbWVzc2FnZSBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTE5Ci0gICAgICAgICAgICAg ICAgbV9lcnJvck1lc3NhZ2UgPSAic2VjdGlvbiBsZW5ndGggaXMgYmlnZ2VyIHRoYW4gYWN0dWFs IHNpemUiOwotICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgICAgIH0KLQot ICAgICAgICAgICAgLy8gV2UgZG9uJ3Qgc3VwcG9ydCBhbnkgY3VzdG9tIHNlY3Rpb25zIHlldC4K LQotICAgICAgICAgICAgbV9vZmZzZXQgKz0gc2VjdGlvbk5hbWVMZW5ndGg7CiAgICAgICAgIH0K IAogICAgICAgICBpZiAoIVNlY3Rpb25zOjp2YWxpZGF0ZU9yZGVyKHByZXZpb3VzU2VjdGlvbiwg c2VjdGlvbikpIHsKQEAgLTEyMSw3ICsxMDMsMTMgQEAgYm9vbCBNb2R1bGVQYXJzZXI6OnBhcnNl KCkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQogCi0gICAgICAgIHVuc2ln bmVkIGVuZCA9IG1fb2Zmc2V0ICsgc2VjdGlvbkxlbmd0aDsKKyAgICAgICAgaWYgKHNlY3Rpb25M ZW5ndGggPiBsZW5ndGgoKSAtIG1fb2Zmc2V0KSB7CisgICAgICAgICAgICAvLyBGSVhNRSBpbXBy b3ZlIGVycm9yIG1lc3NhZ2UgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE2MzkxOQorICAgICAgICAgICAgbV9lcnJvck1lc3NhZ2UgPSAic2VjdGlvbiBjb250ZW50IHdv dWxkIG92ZXJmbG93IE1vZHVsZSdzIHNpemUiOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwor ICAgICAgICB9CisKKyAgICAgICAgYXV0byBlbmQgPSBtX29mZnNldCArIHNlY3Rpb25MZW5ndGg7 CiAKICAgICAgICAgc3dpdGNoIChzZWN0aW9uKSB7CiAKQEAgLTE3NCw2ICsxNjIsNyBAQCBib29s IE1vZHVsZVBhcnNlcjo6cGFyc2UoKQogICAgICAgICBkZWZhdWx0OiB7CiAgICAgICAgICAgICBp ZiAodmVyYm9zZSkKICAgICAgICAgICAgICAgICBkYXRhTG9nTG4oIlVua25vd24gc2VjdGlvbiwg c2tpcHBpbmcuIik7CisgICAgICAgICAgICAvLyBJZ25vcmUgc2VjdGlvbidzIG5hbWUgTEVCIGFu ZCBieXRlczogdGhleSdyZSBhbHJlYWR5IGluY2x1ZGVkIGluIHNlY3Rpb25MZW5ndGguCiAgICAg ICAgICAgICBtX29mZnNldCArPSBzZWN0aW9uTGVuZ3RoOwogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KLS0gCjIuMTAuMQoK