163957 2016-10-25 11:07:53 -0700 Remove redundant argument count check 2016-10-25 15:44:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfbastien jfbastien commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1244296 0 jfbastien 2016-10-25 11:07:53 -0700 As pointed out in https://bugs.webkit.org/show_bug.cgi?id=163903, indexing argument out of bounds already returns jsUndefined(). 1244302 1 292787 jfbastien 2016-10-25 11:11:23 -0700 Created attachment 292787 patch 1244303 2 292787 keith_miller 2016-10-25 11:12:15 -0700 Comment on attachment 292787 patch r=me. 1244498 3 292787 commit-queue 2016-10-25 15:43:59 -0700 Comment on attachment 292787 patch Clearing flags on attachment: 292787 Committed r207852: <http://trac.webkit.org/changeset/207852> 1244499 4 commit-queue 2016-10-25 15:44:02 -0700 All reviewed patches have been landed. Closing bug. 292787 2016-10-25 11:11:23 -0700 2016-10-25 15:43:59 -0700 patch 0001-Remove-redundant-argument-count-check.patch text/plain 3852 jfbastien RnJvbSBmOTcwYmQ0ZGQzMmI4ODc0MmNlOTJjYTBhZDg5NzA2YWNmMTJlNzYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUdWUsIDI1IE9jdCAyMDE2IDExOjA0OjQxIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gUmVtb3Zl IHJlZHVuZGFudCBhcmd1bWVudCBjb3VudCBjaGVjawoKSW5kZXhpbmcgYXJndW1lbnQgb3V0IG9m IGJvdW5kcyBhbHJlYWR5IHJldHVybnMganNVbmRlZmluZWQoKS4KLS0tCiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTcgKysrKysrKysr KysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Vycm9yQ29uc3RydWN0b3Iu Y3BwICAgICAgfCAgNCArKy0tCiAuLi4vd2FzbS9qcy9XZWJBc3NlbWJseVJ1bnRpbWVFcnJvckNv bnN0cnVjdG9yLmNwcCAgICAgIHwgIDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBhODUxYzYx Li43N2QwYzM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAx Ni0xMC0yNSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVt b3ZlIHJlZHVuZGFudCBhcmd1bWVudCBjb3VudCBjaGVjaworCisgICAgICAgIEluZGV4aW5nIGFy Z3VtZW50IG91dCBvZiBib3VuZHMgYWxyZWFkeSByZXR1cm5zIGpzVW5kZWZpbmVkKCkuCisKKyAg ICAgICAgUmVtb3ZlIHJlZHVuZGFudCBhcmd1bWVudCBjb3VudCBjaGVjaworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTU3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0Vycm9yQ29uc3Ry dWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRlcjo6Y29uc3RydWN0V2l0aEVycm9y Q29uc3RydWN0b3IpOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRlcjo6Y2FsbEVycm9yQ29uc3Ry dWN0b3IpOgorICAgICAgICAqIHdhc20vanMvV2ViQXNzZW1ibHlSdW50aW1lRXJyb3JDb25zdHJ1 Y3Rvci5jcHA6CisgICAgICAgIChKU0M6OmNvbnN0cnVjdEpTV2ViQXNzZW1ibHlSdW50aW1lRXJy b3IpOgorCisyMDE2LTEwLTI1ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KKwog ICAgICAgICBXZWJBc3NlbWJseSBKUyBBUEk6IGltcGxlbWVudCBNb2R1bGUKIAogICAgICAgICBU aGlzIGltcGxlbWVudGF0aW9uIGFsbG93cyB1cyB0bzoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0Vycm9yQ29uc3RydWN0b3IuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvRXJyb3JDb25zdHJ1Y3Rvci5jcHAKaW5kZXggMWQwZTIzMy4uZGQ4ZDE0 YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXJyb3JDb25zdHJ1 Y3Rvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXJyb3JDb25zdHJ1 Y3Rvci5jcHAKQEAgLTUyLDcgKzUyLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBJ bnRlcnByZXRlcjo6Y29uc3RydWN0V2l0aEVycm9yQ29uc3RydWN0b3IoRXhlY1N0YXQKIHsKICAg ICBWTSYgdm0gPSBleGVjLT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1ND T1BFKHZtKTsKLSAgICBKU1ZhbHVlIG1lc3NhZ2UgPSBleGVjLT5hcmd1bWVudENvdW50KCkgPyBl eGVjLT5hcmd1bWVudCgwKSA6IGpzVW5kZWZpbmVkKCk7CisgICAgSlNWYWx1ZSBtZXNzYWdlID0g ZXhlYy0+YXJndW1lbnQoMCk7CiAgICAgU3RydWN0dXJlKiBlcnJvclN0cnVjdHVyZSA9IEludGVy bmFsRnVuY3Rpb246OmNyZWF0ZVN1YmNsYXNzU3RydWN0dXJlKGV4ZWMsIGV4ZWMtPm5ld1Rhcmdl dCgpLCBhc0ludGVybmFsRnVuY3Rpb24oZXhlYy0+Y2FsbGVlKCkpLT5nbG9iYWxPYmplY3QoKS0+ ZXJyb3JTdHJ1Y3R1cmUoKSk7CiAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2Rl ZEpTVmFsdWUoKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShFcnJvckluc3RhbmNlOjpj cmVhdGUoZXhlYywgZXJyb3JTdHJ1Y3R1cmUsIG1lc3NhZ2UsIG51bGxwdHIsIFR5cGVOb3RoaW5n LCBmYWxzZSkpOwpAQCAtNjYsNyArNjYsNyBAQCBDb25zdHJ1Y3RUeXBlIEVycm9yQ29uc3RydWN0 b3I6OmdldENvbnN0cnVjdERhdGEoSlNDZWxsKiwgQ29uc3RydWN0RGF0YSYgY29uc3RydQogCiBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIEludGVycHJldGVyOjpjYWxsRXJyb3JDb25zdHJ1 Y3RvcihFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgSlNWYWx1ZSBtZXNzYWdlID0gZXhlYy0+YXJn dW1lbnRDb3VudCgpID8gZXhlYy0+YXJndW1lbnQoMCkgOiBqc1VuZGVmaW5lZCgpOworICAgIEpT VmFsdWUgbWVzc2FnZSA9IGV4ZWMtPmFyZ3VtZW50KDApOwogICAgIFN0cnVjdHVyZSogZXJyb3JT dHJ1Y3R1cmUgPSBhc0ludGVybmFsRnVuY3Rpb24oZXhlYy0+Y2FsbGVlKCkpLT5nbG9iYWxPYmpl Y3QoKS0+ZXJyb3JTdHJ1Y3R1cmUoKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEVycm9y SW5zdGFuY2U6OmNyZWF0ZShleGVjLCBlcnJvclN0cnVjdHVyZSwgbWVzc2FnZSwgbnVsbHB0ciwg VHlwZU5vdGhpbmcsIGZhbHNlKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd2FzbS9qcy9XZWJBc3NlbWJseVJ1bnRpbWVFcnJvckNvbnN0cnVjdG9yLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL1dlYkFzc2VtYmx5UnVudGltZUVycm9yQ29uc3RydWN0 b3IuY3BwCmluZGV4IDAxYjMyZjcuLmFkMzNmYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL2pzL1dlYkFzc2VtYmx5UnVudGltZUVycm9yQ29uc3RydWN0b3IuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL1dlYkFzc2VtYmx5UnVudGltZUVycm9y Q29uc3RydWN0b3IuY3BwCkBAIC00OCw3ICs0OCw3IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBK U0NfSE9TVF9DQUxMIGNvbnN0cnVjdEpTV2ViQXNzZW1ibHlSdW50aW1lRXJyb3IoRXhlY1N0YXRl CiB7CiAgICAgYXV0byYgdm0gPSBzdGF0ZS0+dm0oKTsKICAgICBhdXRvIHNjb3BlID0gREVDTEFS RV9USFJPV19TQ09QRSh2bSk7Ci0gICAgSlNWYWx1ZSBtZXNzYWdlID0gc3RhdGUtPmFyZ3VtZW50 Q291bnQoKSA/IHN0YXRlLT5hcmd1bWVudCgwKSA6IGpzVW5kZWZpbmVkKCk7CisgICAgSlNWYWx1 ZSBtZXNzYWdlID0gc3RhdGUtPmFyZ3VtZW50KDApOwogICAgIGF1dG8qIHN0cnVjdHVyZSA9IElu dGVybmFsRnVuY3Rpb246OmNyZWF0ZVN1YmNsYXNzU3RydWN0dXJlKHN0YXRlLCBzdGF0ZS0+bmV3 VGFyZ2V0KCksIGFzSW50ZXJuYWxGdW5jdGlvbihzdGF0ZS0+Y2FsbGVlKCkpLT5nbG9iYWxPYmpl Y3QoKS0+V2ViQXNzZW1ibHlSdW50aW1lRXJyb3JTdHJ1Y3R1cmUoKSk7CiAgICAgUkVUVVJOX0lG X0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7CiAgICAgcmV0dXJuIEpTVmFsdWU6 OmVuY29kZShKU1dlYkFzc2VtYmx5UnVudGltZUVycm9yOjpjcmVhdGUoc3RhdGUsIHN0cnVjdHVy ZSwgbWVzc2FnZSwgZmFsc2UpKTsKLS0gCjIuMTAuMQoK