163949 2016-10-25 09:34:23 -0700 [cmake] Don't add -fPIC flag when on Windows (MinGW) 2016-10-25 10:29:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen achristensen lforschler mcatanzaro ossy oldest_to_newest 1244236 0 annulen 2016-10-25 09:34:23 -0700 -fPIC flag does not do anything on Windows and produces warning noise with MinGW. There is no position independent code in Unix sense on 32-bit Windows, and 64-bit Windows code is always relocatable. For reference see https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00836.html 1244238 1 292763 annulen 2016-10-25 09:35:26 -0700 Created attachment 292763 Patch 1244267 2 292763 annulen 2016-10-25 10:29:50 -0700 Comment on attachment 292763 Patch Clearing flags on attachment: 292763 Committed r207826: <http://trac.webkit.org/changeset/207826> 1244268 3 annulen 2016-10-25 10:29:57 -0700 All reviewed patches have been landed. Closing bug. 292763 2016-10-25 09:35:26 -0700 2016-10-25 10:29:50 -0700 Patch bug-163949-20161025193140.patch text/plain 1912 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0SGVscGVycy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCmluZGV4 IDM4ZmZiZDU0OWYzZmM4ZDQzZWVjODk4OTdjNjdkMTE2NTg5YjMwMWQuLjI4MzVmY2FmNzBhYzY1 NjljZWJiZjhmODM4OTA0M2UxYWUxODcyOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9XZWJL aXRIZWxwZXJzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRIZWxwZXJzLmNtYWtlCkBA IC0xMCw5ICsxMCwxMSBAQCBtYWNybyhXRUJLSVRfU0VUX0VYVFJBX0NPTVBJTEVSX0ZMQUdTIF90 YXJnZXQpCiAgICAgICAgICAgICBzZXQoT0xEX0NPTVBJTEVfRkxBR1MgIiIpCiAgICAgICAgIGVu ZGlmICgpCiAKLSAgICAgICAgZ2V0X3RhcmdldF9wcm9wZXJ0eShUQVJHRVRfVFlQRSAke190YXJn ZXR9IFRZUEUpCi0gICAgICAgIGlmICgke1RBUkdFVF9UWVBFfSBTVFJFUVVBTCAiU1RBVElDX0xJ QlJBUlkiKSAjIC1mUElDIGlzIGF1dG9tYXRpY2FsbHkgYWRkZWQgdG8gc2hhcmVkIGxpYnJhcmll cwotICAgICAgICAgICAgc2V0KE9MRF9DT01QSUxFX0ZMQUdTICItZlBJQyAke09MRF9DT01QSUxF X0ZMQUdTfSIpCisgICAgICAgIGlmIChOT1QgV0lOMzIpCisgICAgICAgICAgICBnZXRfdGFyZ2V0 X3Byb3BlcnR5KFRBUkdFVF9UWVBFICR7X3RhcmdldH0gVFlQRSkKKyAgICAgICAgICAgIGlmICgk e1RBUkdFVF9UWVBFfSBTVFJFUVVBTCAiU1RBVElDX0xJQlJBUlkiKSAjIC1mUElDIGlzIGF1dG9t YXRpY2FsbHkgYWRkZWQgdG8gc2hhcmVkIGxpYnJhcmllcworICAgICAgICAgICAgICAgIHNldChP TERfQ09NUElMRV9GTEFHUyAiLWZQSUMgJHtPTERfQ09NUElMRV9GTEFHU30iKQorICAgICAgICAg ICAgZW5kaWYgKCkKICAgICAgICAgZW5kaWYgKCkKIAogICAgICAgICAjIFN1cHByZXNzIC1XcGFy ZW50aGVzZXMtZXF1YWxpdHkgd2FybmluZyBvZiBDbGFuZwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9n IGIvQ2hhbmdlTG9nCmluZGV4IDdhMDYyNjllMjBiNTM1MzBjNDFkZWJlOTNlMzZhZmY1NDczMTk5 ZGMuLjk2NzQzZTJjOTY3M2QyZjgyYzVkM2YzOGY0NzVlN2IzZWYyNjk2ZmEgMTAwNjQ0Ci0tLSBh L0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNi0xMC0yNSAg S29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CisKKyAgICAgICAgW2NtYWtl XSBEb24ndCBhZGQgLWZQSUMgZmxhZyB3aGVuIG9uIFdpbmRvd3MgKE1pbkdXKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTQ5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgLWZQSUMgZmxhZyBkb2VzIG5v dCBkbyBhbnl0aGluZyBvbiBXaW5kb3dzIGFuZCBwcm9kdWNlcyB3YXJuaW5nIG5vaXNlCisgICAg ICAgIHdpdGggTWluR1cuIFRoZXJlIGlzIG5vIHBvc2l0aW9uIGluZGVwZW5kZW50IGNvZGUgaW4g VW5peCBzZW5zZSBvbgorICAgICAgICAzMi1iaXQgV2luZG93cywgYW5kIDY0LWJpdCBXaW5kb3dz IGNvZGUgaXMgYWx3YXlzIHJlbG9jYXRhYmxlLgorCisgICAgICAgIEZvciByZWZlcmVuY2Ugc2Vl CisgICAgICAgIGh0dHBzOi8vZ2NjLmdudS5vcmcvbWwvZ2NjLXBhdGNoZXMvMjAxNS0wOC9tc2cw MDgzNi5odG1sCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvV2ViS2l0SGVscGVycy5jbWFrZToK KwogMjAxNi0xMC0yMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFtFRkxdIFJFR1JFU1NJT04ocjIwNzYxNik6IEJ1aWxkIGlzIGJyb2tlbiBkdWUgdG8g bWlzc2luZyBsaWJnZW9jbHVlLWRldiBwYWNrYWdlCg==