163906 2016-10-24 12:10:03 -0700 The URLSearchParams constructor should take a union in parameter 2016-10-26 16:18:48 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://url.spec.whatwg.org/#urlsearchparams P2 Normal --- 1 cdumez cdumez achristensen cdumez commit-queue darin esprehn+autocc gyuyoung.kim kondapallykalyan sam oldest_to_newest 1243832 0 cdumez 2016-10-24 12:10:03 -0700 The URLSearchParams constructor should take a union in parameter: - https://url.spec.whatwg.org/#urlsearchparams 1243833 1 292640 cdumez 2016-10-24 12:11:26 -0700 Created attachment 292640 Patch 1243842 2 292640 darin 2016-10-24 12:36:47 -0700 Comment on attachment 292640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292640&action=review > Source/WebCore/html/URLSearchParams.h:59 > +Ref<URLSearchParams> URLSearchParams::create(const StringOrURLSearchParams& variant, DOMURL* associatedURL) If we put this in the header, it has to be marked inline. 1243858 3 292647 cdumez 2016-10-24 13:23:45 -0700 Created attachment 292647 Patch 1244942 4 292647 commit-queue 2016-10-26 16:18:42 -0700 Comment on attachment 292647 Patch Clearing flags on attachment: 292647 Committed r207914: <http://trac.webkit.org/changeset/207914> 1244943 5 commit-queue 2016-10-26 16:18:48 -0700 All reviewed patches have been landed. Closing bug. 292640 2016-10-24 12:11:26 -0700 2016-10-24 13:23:41 -0700 Patch bug-163906-20161024120742.patch text/plain 3241 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUzZDMyZGEyNDFlYzE4 NzNkZDA1YzU4OTUwZWMyYjFjNjU2YTA0NC4uODg1MzI1N2Q1MDZiZDMwZjA4M2VjYTZkMTQ4MjNh YTFlMmQ3ZTVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEwLTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFVSTFNlYXJjaFBhcmFt cyBjb25zdHJ1Y3RvciBzaG91bGQgdGFrZSBhIHVuaW9uIGluIHBhcmFtZXRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTA2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFVSTFNlYXJjaFBhcmFt cyBjb25zdHJ1Y3RvciBzaG91bGQgdGFrZSBhIHVuaW9uIGluIHBhcmFtZXRlcjoKKyAgICAgICAg LSBodHRwczovL3VybC5zcGVjLndoYXR3Zy5vcmcvI3VybHNlYXJjaHBhcmFtcworCisgICAgICAg IE5vIG5ldyB0ZXN0cywgbm8gd2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAg ICogaHRtbC9VUkxTZWFyY2hQYXJhbXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTFNlYXJjaFBh cmFtczo6Y3JlYXRlKToKKyAgICAgICAgKiBodG1sL1VSTFNlYXJjaFBhcmFtcy5pZGw6CisKIDIw MTYtMTAtMjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEFj dGl2YXRlIFdFQl9SVEMgY29tcGlsYXRpb24gZmxhZ3MgZm9yIE1hYyBib3RzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL1VSTFNlYXJjaFBhcmFtcy5oIGIvU291cmNlL1dlYkNvcmUv aHRtbC9VUkxTZWFyY2hQYXJhbXMuaAppbmRleCBjYzMxNDRjYzk0Njc5ODdmZmQ0MmMxZDY1MGVh YmZmNDhhY2FlOGY1Li5jZjI4ZDczNDZiMjBmZDdhMzQ3ZDM1ZjlhYTJhM2U2ZTkyMDZlNmIxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1VSTFNlYXJjaFBhcmFtcy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvVVJMU2VhcmNoUGFyYW1zLmgKQEAgLTI1LDYgKzI1LDcgQEAKICNw cmFnbWEgb25jZQogCiAjaW5jbHVkZSAiRE9NVVJMLmgiCisjaW5jbHVkZSA8d3RmL1ZhcmlhbnQu aD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5n Lmg+CiAKQEAgLTMyLDggKzMzLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBVUkxT ZWFyY2hQYXJhbXMgOiBwdWJsaWMgUmVmQ291bnRlZDxVUkxTZWFyY2hQYXJhbXM+IHsKIHB1Ymxp YzoKLSAgICBzdGF0aWMgUmVmPFVSTFNlYXJjaFBhcmFtcz4gY3JlYXRlKGNvbnN0IFN0cmluZyYg c3RyaW5nLCBET01VUkwqIGFzc29jaWF0ZWRVUkwgPSBudWxscHRyKSB7IHJldHVybiBhZG9wdFJl ZigqbmV3IFVSTFNlYXJjaFBhcmFtcyhzdHJpbmcsIGFzc29jaWF0ZWRVUkwpKTsgfQotICAgIHN0 YXRpYyBSZWY8VVJMU2VhcmNoUGFyYW1zPiBjcmVhdGUoY29uc3QgVmVjdG9yPHN0ZDo6cGFpcjxT dHJpbmcsIFN0cmluZz4+JiBwYWlycykgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBVUkxTZWFyY2hQ YXJhbXMocGFpcnMpKTsgfQorICAgIHVzaW5nIFN0cmluZ09yVVJMU2VhcmNoUGFyYW1zID0gV1RG OjpWYXJpYW50PFN0cmluZywgUmVmUHRyPFVSTFNlYXJjaFBhcmFtcz4+OworICAgIHN0YXRpYyBS ZWY8VVJMU2VhcmNoUGFyYW1zPiBjcmVhdGUoY29uc3QgU3RyaW5nT3JVUkxTZWFyY2hQYXJhbXMm LCBET01VUkwqIGFzc29jaWF0ZWRVUkwgPSBudWxscHRyKTsKIAogICAgIHZvaWQgYXNzb2NpYXRl ZFVSTERlc3Ryb3llZCgpIHsgbV9hc3NvY2lhdGVkVVJMID0gbnVsbHB0cjsgfQogICAgIHZvaWQg YXBwZW5kKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1ZSk7CkBAIC01NSw0 ICs1NiwxNCBAQCBwcml2YXRlOgogICAgIFZlY3RvcjxzdGQ6OnBhaXI8U3RyaW5nLCBTdHJpbmc+ PiBtX3BhaXJzOwogfTsKIAorUmVmPFVSTFNlYXJjaFBhcmFtcz4gVVJMU2VhcmNoUGFyYW1zOjpj cmVhdGUoY29uc3QgU3RyaW5nT3JVUkxTZWFyY2hQYXJhbXMmIHZhcmlhbnQsIERPTVVSTCogYXNz b2NpYXRlZFVSTCkKK3sKKyAgICBhdXRvIHZpc2l0b3IgPSBXVEY6Om1ha2VWaXNpdG9yKFsmXShj b25zdCBTdHJpbmcmIHN0cmluZykgeworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBVUkxT ZWFyY2hQYXJhbXMoc3RyaW5nLCBhc3NvY2lhdGVkVVJMKSk7CisgICAgfSwgWyZdKGNvbnN0IFJl ZlB0cjxVUkxTZWFyY2hQYXJhbXM+JiBwYXJhbXMpIHsKKyAgICAgICAgcmV0dXJuIGFkb3B0UmVm KCpuZXcgVVJMU2VhcmNoUGFyYW1zKHN0YXRpY19jYXN0PGNvbnN0IFZlY3RvcjxzdGQ6OnBhaXI8 U3RyaW5nLCBTdHJpbmc+PiY+KCpwYXJhbXMpKSk7CisgICAgfSk7CisgICAgcmV0dXJuIFdURjo6 dmlzaXQodmlzaXRvciwgdmFyaWFudCk7CiB9CisKK30gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVVJMU2VhcmNoUGFyYW1zLmlkbCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvVVJMU2VhcmNoUGFyYW1zLmlkbAppbmRleCA0ZjEwMTNlMDljYWE1OTAw NjIzMGQ2ZGI4MjEwOTExYjA2MGIzNjNiLi4xNzBmNWNiY2RiYmIwYzg2Nzk2YjM0NjEzYmE0ZjM1 MGU1NDAzMDdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1VSTFNlYXJjaFBhcmFt cy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9VUkxTZWFyY2hQYXJhbXMuaWRsCkBAIC0y NCw5ICsyNCw3IEBACiAgKi8KIAogWwotICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgdW5p b25zIG9uY2UgdGhleSBhcmUgc3VwcG9ydGVkCi0gICAgQ29uc3RydWN0b3Iob3B0aW9uYWwgVVNW U3RyaW5nIGFyZyA9ICIiKSwKLSAgICBDb25zdHJ1Y3RvcihVUkxTZWFyY2hQYXJhbXMgaW5pdCks CisgICAgQ29uc3RydWN0b3Iob3B0aW9uYWwgKFVTVlN0cmluZyBvciBVUkxTZWFyY2hQYXJhbXMp IGluaXQgPSAiIiksCiAgICAgRXhwb3NlZD0oV2luZG93LFdvcmtlciksCiAgICAgSW1wbGVtZW50 YXRpb25MYWNrc1ZUYWJsZSwKIF0gaW50ZXJmYWNlIFVSTFNlYXJjaFBhcmFtcyB7Cg== 292647 2016-10-24 13:23:45 -0700 2016-10-26 16:18:42 -0700 Patch bug-163906-20161024132000.patch text/plain 3246 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzk3NzUzYzZhOWEzYTlm MWM1OTUxOThjOTYyZWZmODA5ZDY2OTE2Ni4uMGU5MzJhYTNkZDhlNThjMjQ2YjgwM2Q3ZWE5YzYy OTEyZDE3ZDU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEwLTI0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFVSTFNlYXJjaFBhcmFt cyBjb25zdHJ1Y3RvciBzaG91bGQgdGFrZSBhIHVuaW9uIGluIHBhcmFtZXRlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzOTA2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgVGhlIFVSTFNlYXJjaFBhcmFtcyBj b25zdHJ1Y3RvciBzaG91bGQgdGFrZSBhIHVuaW9uIGluIHBhcmFtZXRlcjoKKyAgICAgICAgLSBo dHRwczovL3VybC5zcGVjLndoYXR3Zy5vcmcvI3VybHNlYXJjaHBhcmFtcworCisgICAgICAgIE5v IG5ldyB0ZXN0cywgbm8gd2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICog aHRtbC9VUkxTZWFyY2hQYXJhbXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OlVSTFNlYXJjaFBhcmFt czo6Y3JlYXRlKToKKyAgICAgICAgKiBodG1sL1VSTFNlYXJjaFBhcmFtcy5pZGw6CisKIDIwMTYt MTAtMjQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBUcnkgdG8gZml4IFdpbmRvd3MgYnVpbGQgYWZ0ZXIgcjIwNzc2NwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaHRtbC9VUkxTZWFyY2hQYXJhbXMuaCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvVVJMU2VhcmNoUGFyYW1zLmgKaW5kZXggY2MzMTQ0Y2M5NDY3OTg3ZmZkNDJjMWQ2NTBlYWJm ZjQ4YWNhZThmNS4uZGY1N2U0ZjkwYmVkZDdlZTY4NWJiNmYzNmI5MWFlOWI0ZTQ2ZWRiMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9VUkxTZWFyY2hQYXJhbXMuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL1VSTFNlYXJjaFBhcmFtcy5oCkBAIC0yNSw2ICsyNSw3IEBACiAjcHJh Z21hIG9uY2UKIAogI2luY2x1ZGUgIkRPTVVSTC5oIgorI2luY2x1ZGUgPHd0Zi9WYXJpYW50Lmg+ CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5o PgogCkBAIC0zMiw4ICszMyw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgVVJMU2Vh cmNoUGFyYW1zIDogcHVibGljIFJlZkNvdW50ZWQ8VVJMU2VhcmNoUGFyYW1zPiB7CiBwdWJsaWM6 Ci0gICAgc3RhdGljIFJlZjxVUkxTZWFyY2hQYXJhbXM+IGNyZWF0ZShjb25zdCBTdHJpbmcmIHN0 cmluZywgRE9NVVJMKiBhc3NvY2lhdGVkVVJMID0gbnVsbHB0cikgeyByZXR1cm4gYWRvcHRSZWYo Km5ldyBVUkxTZWFyY2hQYXJhbXMoc3RyaW5nLCBhc3NvY2lhdGVkVVJMKSk7IH0KLSAgICBzdGF0 aWMgUmVmPFVSTFNlYXJjaFBhcmFtcz4gY3JlYXRlKGNvbnN0IFZlY3RvcjxzdGQ6OnBhaXI8U3Ry aW5nLCBTdHJpbmc+PiYgcGFpcnMpIHsgcmV0dXJuIGFkb3B0UmVmKCpuZXcgVVJMU2VhcmNoUGFy YW1zKHBhaXJzKSk7IH0KKyAgICB1c2luZyBTdHJpbmdPclVSTFNlYXJjaFBhcmFtcyA9IFdURjo6 VmFyaWFudDxTdHJpbmcsIFJlZlB0cjxVUkxTZWFyY2hQYXJhbXM+PjsKKyAgICBzdGF0aWMgUmVm PFVSTFNlYXJjaFBhcmFtcz4gY3JlYXRlKGNvbnN0IFN0cmluZ09yVVJMU2VhcmNoUGFyYW1zJiwg RE9NVVJMKiBhc3NvY2lhdGVkVVJMID0gbnVsbHB0cik7CiAKICAgICB2b2lkIGFzc29jaWF0ZWRV UkxEZXN0cm95ZWQoKSB7IG1fYXNzb2NpYXRlZFVSTCA9IG51bGxwdHI7IH0KICAgICB2b2lkIGFw cGVuZChjb25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpOwpAQCAtNTUsNCAr NTYsMTQgQEAgcHJpdmF0ZToKICAgICBWZWN0b3I8c3RkOjpwYWlyPFN0cmluZywgU3RyaW5nPj4g bV9wYWlyczsKIH07CiAKK2lubGluZSBSZWY8VVJMU2VhcmNoUGFyYW1zPiBVUkxTZWFyY2hQYXJh bXM6OmNyZWF0ZShjb25zdCBTdHJpbmdPclVSTFNlYXJjaFBhcmFtcyYgdmFyaWFudCwgRE9NVVJM KiBhc3NvY2lhdGVkVVJMKQoreworICAgIGF1dG8gdmlzaXRvciA9IFdURjo6bWFrZVZpc2l0b3Io WyZdKGNvbnN0IFN0cmluZyYgc3RyaW5nKSB7CisgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3 IFVSTFNlYXJjaFBhcmFtcyhzdHJpbmcsIGFzc29jaWF0ZWRVUkwpKTsKKyAgICB9LCBbJl0oY29u c3QgUmVmUHRyPFVSTFNlYXJjaFBhcmFtcz4mIHBhcmFtcykgeworICAgICAgICByZXR1cm4gYWRv cHRSZWYoKm5ldyBVUkxTZWFyY2hQYXJhbXMoc3RhdGljX2Nhc3Q8Y29uc3QgVmVjdG9yPHN0ZDo6 cGFpcjxTdHJpbmcsIFN0cmluZz4+Jj4oKnBhcmFtcykpKTsKKyAgICB9KTsKKyAgICByZXR1cm4g V1RGOjp2aXNpdCh2aXNpdG9yLCB2YXJpYW50KTsKIH0KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9VUkxTZWFyY2hQYXJhbXMuaWRsIGIv U291cmNlL1dlYkNvcmUvaHRtbC9VUkxTZWFyY2hQYXJhbXMuaWRsCmluZGV4IDRmMTAxM2UwOWNh YTU5MDA2MjMwZDZkYjgyMTA5MTFiMDYwYjM2M2IuLjE3MGY1Y2JjZGJiYjBjODY3OTZiMzQ2MTNi YTRmMzUwZTU0MDMwN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvVVJMU2VhcmNo UGFyYW1zLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL1VSTFNlYXJjaFBhcmFtcy5pZGwK QEAgLTI0LDkgKzI0LDcgQEAKICAqLwogCiBbCi0gICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHVz ZSB1bmlvbnMgb25jZSB0aGV5IGFyZSBzdXBwb3J0ZWQKLSAgICBDb25zdHJ1Y3RvcihvcHRpb25h bCBVU1ZTdHJpbmcgYXJnID0gIiIpLAotICAgIENvbnN0cnVjdG9yKFVSTFNlYXJjaFBhcmFtcyBp bml0KSwKKyAgICBDb25zdHJ1Y3RvcihvcHRpb25hbCAoVVNWU3RyaW5nIG9yIFVSTFNlYXJjaFBh cmFtcykgaW5pdCA9ICIiKSwKICAgICBFeHBvc2VkPShXaW5kb3csV29ya2VyKSwKICAgICBJbXBs ZW1lbnRhdGlvbkxhY2tzVlRhYmxlLAogXSBpbnRlcmZhY2UgVVJMU2VhcmNoUGFyYW1zIHsK