163880 2016-10-24 01:26:52 -0700 [CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it 2016-10-24 03:18:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 163885 P2 Normal --- 1 zan zan cdumez commit-queue youennf oldest_to_newest 1243647 0 zan 2016-10-24 01:26:52 -0700 [CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it 1243649 1 292595 zan 2016-10-24 01:32:45 -0700 Created attachment 292595 Patch 1243656 2 292595 youennf 2016-10-24 02:21:48 -0700 Comment on attachment 292595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review > Source/WebCore/ChangeLog:16 > + specified in the same file. Can we add a binding test to cover this then? 1243657 3 292595 zan 2016-10-24 02:33:15 -0700 Comment on attachment 292595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review >> Source/WebCore/ChangeLog:16 >> + specified in the same file. > > Can we add a binding test to cover this then? The problem is that standalone dictionaries don't generate enumeration conversion code ATM. But I have a patch to fix that, so this AddToImplIncludes() call can be patched there. 1243663 4 zan 2016-10-24 03:18:07 -0700 *** This bug has been marked as a duplicate of bug 163885 *** 292595 2016-10-24 01:32:45 -0700 2016-10-24 02:33:15 -0700 Patch bug-163880-20161024012901.patch text/plain 2101 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3NzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGJjNWNkNWJmMGE1MTA0 M2YyOTQ0NzJlYTM2NTkzNjk3ODcyZTZhNC4uMzU3MWY0ZDIxYTg5MmU4MzM4MmQyODAyM2QzZjgz OTI1ZjYxZjVhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTEwLTI0ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ29kZUdlbmVyYXRv ckpTXSBFbnVtIGdlbmVyYXRpb24gdXNlcyBOZXZlckRlc3Ryb3llZDw+LCBkb2Vzbid0IGluY2x1 ZGUgaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 Mzg4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElu IEdlbmVyYXRlRW51bWVyYXRpb25zSW1wbGVtZW50YXRpb25Db250ZW50KCksIGFkZCB0aGUKKyAg ICAgICAgTmV2ZXJEZXN0cm95ZWQuaCBoZWFkZXIgdG8gaW1wbGVtZW50YXRpb24gZmlsZSBpbmNs dWRlcyBzaW5jZQorICAgICAgICB0aGF0IGNsYXNzIGlzIHVzZWQgdG8gY29udGFpbiBhbiBhcnJh eSBvZiBwb3NzaWJsZSBlbnVtIHZhbHVlcywKKyAgICAgICAgYW5kIGl0J3Mgbm90IGNlcnRhaW4g dGhhdCBpdCBpcyBpbmNsdWRlZCBieSBhbnkgb3RoZXIgZ2VuZXJhdGVkCisgICAgICAgIG9yIGlu ZGlyZWN0bHkgaW5jbHVkZWQgY29kZS4KKworICAgICAgICBUaGlzIGRvZXNuJ3QgYWZmZWN0IGFu eXRoaW5nIGN1cnJlbnRseSwgYnV0IGNhbiBiZSBoaXQgd2hlbgorICAgICAgICBzcGVjaWZ5aW5n IGEgc3RhbmRhbG9uZSBXZWJJREwgZGljdGlvbmFyeSB0aGF0IGFsc28gaGFzIGFuIGVudW0KKyAg ICAgICAgc3BlY2lmaWVkIGluIHRoZSBzYW1lIGZpbGUuCisKKyAgICAgICAgKiBiaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEdlbmVyYXRlRW51bWVyYXRpb25z SW1wbGVtZW50YXRpb25Db250ZW50KToKKwogMjAxNi0xMC0yMiAgU2FtIFdlaW5pZyAgPHNhbUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFtXZWJJRExdIEFkZCBJRExUeXBlIGJhc2VkIHRvSlMgY29u dmVyc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5l cmF0b3JKUy5wbQppbmRleCA4ZTgxOWI3NmY4ZjNmMmVmM2M2NzNjNTNjNjg3NmQyZjExYjIwYmE3 Li4xNGNhYTJhMjc3NGIyOTM3ODU5YjIyYWI1Y2JmMDY1NTA1NjA5NTUwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtODg5 LDYgKzg4OSw3IEBAIHN1YiBHZW5lcmF0ZUVudW1lcmF0aW9uc0ltcGxlbWVudGF0aW9uQ29udGVu dAogICAgICAgICAkcmVzdWx0IC49ICJ7XG4iOwogICAgICAgICAjIEZJWE1FOiBNaWdodCBiZSBu aWNlIHRvIG1ha2UgdGhpcyBnbG9iYWwgYmUgImNvbnN0IiwgYnV0IE5ldmVyRGVzdHJveWVkIGRv ZXMgbm90IGN1cnJlbnRseSBzdXBwb3J0IHRoYXQuCiAgICAgICAgICMgRklYTUU6IE1pZ2h0IGJl IG5pY2UgdG8gbWFrZSB0aGUgZW50aXJlIGFycmF5IGJlIE5ldmVyRGVzdHJveWVkIGluc3RlYWQg b2YgZWFjaCB2YWx1ZSwgYnV0IG5vdCBzdXJlIHdoYXQgdGhlIHN5bnRheCBmb3IgdGhhdCBpcy4K KyAgICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIjx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4iKTsKICAg ICAgICAgJHJlc3VsdCAuPSAiICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxjb25zdCBTdHJpbmc+ IHZhbHVlc1tdID0ge1xuIjsKICAgICAgICAgZm9yZWFjaCBteSAkdmFsdWUgKEB7JGVudW1lcmF0 aW9uLT52YWx1ZXN9KSB7CiAgICAgICAgICAgICBpZiAoJHZhbHVlIGVxICIiKSB7Cg==