16388 2007-12-10 14:33:01 -0800 [GTK] Widget::setCursor() gets called frequently 2007-12-12 09:34:33 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED Gtk P2 Normal --- 1 alp webkit-unassigned oldest_to_newest 63864 0 alp 2007-12-10 14:33:01 -0800 Widget::setCursor() seems to get called on every mouse motion event and it seems the underlying implementation gdk_window_set_cursor() isn't too cheap. This looks like it might be a WebCore bug. Confirmation on ports other than GTK+ would be helpful. 63865 1 17827 alp 2007-12-10 14:34:46 -0800 Created attachment 17827 Workaround (cache the current GdkCursor*) 63987 2 17827 mjs 2007-12-11 19:26:27 -0800 Comment on attachment 17827 Workaround (cache the current GdkCursor*) r=me 64037 3 alp 2007-12-12 09:34:33 -0800 Landed in r28655. 17827 2007-12-10 14:34:46 -0800 2007-12-11 19:26:27 -0800 Workaround (cache the current GdkCursor*) cursor-cache.patch text/plain 1887 alp SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODU4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMTItMTAgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhY2hlIHRo ZSBjdXJyZW50IGN1cnNvciB0byBhdm9pZCBjYWxsaW5nIGdka193aW5kb3dfc2V0X2N1cnNvcigp IHdoZW4KKyAgICAgICAgdGhlcmUncyBubyBjaGFuZ2UgaW4gY3Vyc29yLgorCisgICAgICAgICog cGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6Oldp ZGdldCk6CisgICAgICAgIChXZWJDb3JlOjpXaWRnZXQ6OmN1cnNvcik6CisgICAgICAgIChXZWJD b3JlOjpXaWRnZXQ6OnNldEN1cnNvcik6CisKIDIwMDctMTItMTAgIEFscCBUb2tlciAgPGFscEBh dG9rZXIuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa28uCkluZGV4OiBXZWJDb3JlL3Bs YXRmb3JtL2d0ay9XaWRnZXRHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v Z3RrL1dpZGdldEd0ay5jcHAJKHJldmlzaW9uIDI4NTg4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n dGsvV2lkZ2V0R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTAsNiArNTAsNyBAQCBwdWJsaWM6 CiAgICAgU2Nyb2xsVmlldyogcGFyZW50OwogICAgIEd0a0NvbnRhaW5lciogY29udGFpbmluZ1dp bmRvdzsKICAgICBib29sIHN1cHByZXNzSW52YWxpZGF0aW9uOworICAgIEdka0N1cnNvciogY3Vy c29yOwogCiAgICAgR2RrRHJhd2FibGUqIGdka0RyYXdhYmxlKCkgY29uc3QKICAgICB7CkBAIC02 NCw2ICs2NSw3IEBAIFdpZGdldDo6V2lkZ2V0KCkKICAgICBkYXRhLT5wYXJlbnQgPSAwOwogICAg IGRhdGEtPmNvbnRhaW5pbmdXaW5kb3cgPSAwOwogICAgIGRhdGEtPnN1cHByZXNzSW52YWxpZGF0 aW9uID0gZmFsc2U7CisgICAgZGF0YS0+Y3Vyc29yID0gMDsKIH0KIAogR3RrV2lkZ2V0KiBXaWRn ZXQ6Omd0a1dpZGdldCgpIGNvbnN0CkBAIC0xMjYsMTIgKzEyOCwyMiBAQCB2b2lkIFdpZGdldDo6 c2V0Rm9jdXMoKQogICAgIGd0a193aWRnZXRfZ3JhYl9mb2N1cyhndGtXaWRnZXQoKSA/IGd0a1dp ZGdldCgpIDogR1RLX1dJREdFVChjb250YWluaW5nV2luZG93KCkpKTsKIH0KIAorQ3Vyc29yIFdp ZGdldDo6Y3Vyc29yKCkKK3sKKyAgICByZXR1cm4gQ3Vyc29yKGRhdGEtPmN1cnNvcik7Cit9CisK IHZvaWQgV2lkZ2V0OjpzZXRDdXJzb3IoY29uc3QgQ3Vyc29yJiBjdXJzb3IpCiB7CiAgICAgR2Rr Q3Vyc29yKiBwY3VyID0gY3Vyc29yLmltcGwoKTsKLSAgICBpZiAoIXBjdXIpCisKKyAgICAvLyBn ZGtfd2luZG93X3NldF9jdXJzb3IoKSBpbiBjZXJ0YWluIEdESyBiYWNrZW5kcyBzZWVtcyB0byBi ZSBhbgorICAgIC8vIGV4cGVuc2l2ZSBvcGVyYXRpb24sIHNvIGF2b2lkIGl0IGlmIHBvc3NpYmxl LgorICAgIGlmIChwY3VyID09IGRhdGEtPmN1cnNvcikKICAgICAgICAgcmV0dXJuOworCiAgICAg Z2RrX3dpbmRvd19zZXRfY3Vyc29yKGRhdGEtPmdka0RyYXdhYmxlKCkgPyBHREtfV0lORE9XKGRh dGEtPmdka0RyYXdhYmxlKCkpIDogR1RLX1dJREdFVChjb250YWluaW5nV2luZG93KCkpLT53aW5k b3csIHBjdXIpOworICAgIGRhdGEtPmN1cnNvciA9IHBjdXI7CiB9CiAKIHZvaWQgV2lkZ2V0Ojpz aG93KCkK