163873 2016-10-23 12:10:51 -0700 REGRESSION (r207424): ERROR: Unhandled web process message 'WebPage:SetPageSuppressed' 2016-11-30 09:35:37 -0800 1 1 1 Unclassified WebKit WebKit2 Other PC Linux RESOLVED DUPLICATE 165158 P2 Normal --- 1 mcatanzaro mcatanzaro barraclough bugs-noreply cgarcia darin mcatanzaro simon.fraser thorton oldest_to_newest 1243532 0 mcatanzaro 2016-10-23 12:10:51 -0700 This error prints once when opening every page: ERROR: Unhandled web process message 'WebPage:SetPageSuppressed' ../../Source/WebKit2/WebProcess/WebProcess.cpp(654) : virtual void WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) Not sure why the message isn't being handled by WebPage. Maybe it's being received before the WebPage object is created. 1243533 1 mcatanzaro 2016-10-23 12:11:06 -0700 (In reply to comment #0) > This error prints once when opening every page: (when opening a new browser tab) 1243650 2 cgarcia 2016-10-24 01:52:19 -0700 I don't think this is specific to GTK+, the updateThrottleState() can be called too early. Actually, I think the problem is that is called right after the web process is launched, but before the WebPage has registered its message receiver. 1248270 3 thorton 2016-11-04 14:18:41 -0700 Yeah, this is a regression from r207424 I believe. 1248284 4 thorton 2016-11-04 14:39:03 -0700 Gavin, we can't send messages (like updateThrottleState does) before WebPageProxy::initializeWebPage(). Do you think it's safe to move it? 1253114 5 mcatanzaro 2016-11-19 14:23:43 -0800 (In reply to comment #4) > Do you think it's safe to move it? Well we should either move it or roll it out. Here's an attempt at the former. It avoids the warning and it *looks* like it's right, but I'm not sure. 1253115 6 295270 mcatanzaro 2016-11-19 14:24:50 -0800 Created attachment 295270 Patch 1253159 7 295270 darin 2016-11-20 16:10:25 -0800 Comment on attachment 295270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295270&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:-468 > - updateThrottleState(); What’s the reasoning behind removing this one? 1253160 8 darin 2016-11-20 16:11:19 -0800 Gavin should look! 1253165 9 mcatanzaro 2016-11-20 16:36:38 -0800 (In reply to comment #7) > > Source/WebKit2/UIProcess/WebPageProxy.cpp:-468 > > - updateThrottleState(); > > What’s the reasoning behind removing this one? That's in the constructor before the first call to WebPageProxy::initializeWebPage, which only ever occurs in reattachToWebProcess. I moved the calls in that function to be right after initializeWebPage to ensure it's called ASAP. Is it right? I don't know; we don't have an implementation of throttling to test. :( 1253166 10 darin 2016-11-20 16:45:55 -0800 Seems likely we’d want to do the same thing with updateActivityState. Ultimately I do want Gavin to look at this. Should we land some kind of change in the mean time? 1253176 11 mcatanzaro 2016-11-20 17:43:48 -0800 If Gavin's not available to look at it soon, then we should roll out r207699 and r207424. 1253833 12 mcatanzaro 2016-11-28 06:34:46 -0800 (In reply to comment #11) > If Gavin's not available to look at it soon, then we should roll out r207699 > and r207424. I looked into this. There are a few more quite significant commits that would need to be rolled out, including bringing back the PageThrottler class. I'll roll them out if Gavin doesn't respond soon (he's been CCed on this for a month now) but it'd certainly be better to avoid doing that. 1254473 13 barraclough 2016-11-29 14:29:57 -0800 We should just remove SetPageSuppressed – we've got to the point we can do so. *** This bug has been marked as a duplicate of bug 165158 *** 1254505 14 mcatanzaro 2016-11-29 15:12:08 -0800 Super, thanks for handling this properly Gavin! 295270 2016-11-19 14:24:50 -0800 2016-11-30 09:35:37 -0800 Patch bug-163873-20161119162441.patch text/plain 2323 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA4OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzBlYTg0NTEwOGI4MjFh MjVlOWNjZWM3OWM4OTQ2OGM4ZmRlNzM5Zi4uYjZjZDI2MGRkZDgwZmE0NDZkMDE4ZDNjOTc4N2Ez Mzk1YjMxMDkzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTExLTE5ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNT SU9OIChyMjA3NDI0KTogRVJST1I6IFVuaGFuZGxlZCB3ZWIgcHJvY2VzcyBtZXNzYWdlICdXZWJQ YWdlOlNldFBhZ2VTdXBwcmVzc2VkJworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYzODczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRG8gbm90IHNlbmQgU2V0UGFnZVN1cHByZXNzZWQgbWVzc2FnZSB1bnRp bCBhZnRlciB0aGUgV2ViUGFnZSBoYXMgYmVlbiBjcmVhdGVkIGluIHRoZSB3ZWIKKyAgICAgICAg cHJvY2Vzcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OldlYlBhZ2VQcm94eSk6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VQcm94eTo6cmVhdHRhY2hUb1dlYlByb2Nlc3MpOgorCiAyMDE2LTExLTE5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1MgV0syXSBX aGVuIHpvb21lZCBpbiBhbmQgcGFubmluZyBvbiBwYWdlcyB3aXRoIGZpeGVkIGJhcnMsIHBhcnRz IG9mIHRoZSBiYXJzIGFyZSBzb21ldGltZXMgbWlzc2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCA1YWRkYTAxYTE3ZmU0ZDRiMjhmZTNhYzU3YTYxYWQx MmQ2YjlkYjNlLi5iZjg5NDIyMTViOWM2NTc0YjlhYTI2YzJiYmEyYWU0MDRiMDk3MjdjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApAQCAtNDY1LDcgKzQ2NSw2 IEBAIFdlYlBhZ2VQcm94eTo6V2ViUGFnZVByb3h5KFBhZ2VDbGllbnQmIHBhZ2VDbGllbnQsIFdl YlByb2Nlc3NQcm94eSYgcHJvY2VzcywgdWluCiAgICAgbV93ZWJQcm9jZXNzTGlmZXRpbWVUcmFj a2VyLmFkZE9ic2VydmVyKG1fd2Vic2l0ZURhdGFTdG9yZSk7CiAKICAgICB1cGRhdGVBY3Rpdml0 eVN0YXRlKCk7Ci0gICAgdXBkYXRlVGhyb3R0bGVTdGF0ZSgpOwogICAgIHVwZGF0ZUhpZGRlblBh Z2VUaHJvdHRsaW5nQXV0b0luY3JlYXNlcygpOwogICAgIAogI2lmIEhBVkUoT1VUX09GX1BST0NF U1NfTEFZRVJfSE9TVElORykKQEAgLTczNSw5ICs3MzQsNiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6 cmVhdHRhY2hUb1dlYlByb2Nlc3MoKQogICAgIG1fcHJvY2Vzcy0+YWRkRXhpc3RpbmdXZWJQYWdl KHRoaXMsIG1fcGFnZUlEKTsKICAgICBtX3Byb2Nlc3MtPmFkZE1lc3NhZ2VSZWNlaXZlcihNZXNz YWdlczo6V2ViUGFnZVByb3h5OjptZXNzYWdlUmVjZWl2ZXJOYW1lKCksIG1fcGFnZUlELCAqdGhp cyk7CiAKLSAgICB1cGRhdGVBY3Rpdml0eVN0YXRlKCk7Ci0gICAgdXBkYXRlVGhyb3R0bGVTdGF0 ZSgpOwotCiAgICAgbV9pbnNwZWN0b3IgPSBXZWJJbnNwZWN0b3JQcm94eTo6Y3JlYXRlKHRoaXMp OwogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBtX2Z1bGxTY3JlZW5NYW5hZ2VyID0g V2ViRnVsbFNjcmVlbk1hbmFnZXJQcm94eTo6Y3JlYXRlKCp0aGlzLCBtX3BhZ2VDbGllbnQuZnVs bFNjcmVlbk1hbmFnZXJQcm94eUNsaWVudCgpKTsKQEAgLTc1NSw2ICs3NTEsOSBAQCB2b2lkIFdl YlBhZ2VQcm94eTo6cmVhdHRhY2hUb1dlYlByb2Nlc3MoKQogCiAgICAgbV9wYWdlQ2xpZW50LmRp ZFJlbGF1bmNoUHJvY2VzcygpOwogICAgIG1fZHJhd2luZ0FyZWEtPndhaXRGb3JCYWNraW5nU3Rv cmVVcGRhdGVPbk5leHRQYWludCgpOworCisgICAgdXBkYXRlQWN0aXZpdHlTdGF0ZSgpOworICAg IHVwZGF0ZVRocm90dGxlU3RhdGUoKTsKIH0KIAogUmVmUHRyPEFQSTo6TmF2aWdhdGlvbj4gV2Vi UGFnZVByb3h5OjpyZWF0dGFjaFRvV2ViUHJvY2Vzc0ZvclJlbG9hZCgpCg==