<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>16383</bug_id>
          
          <creation_ts>2007-12-10 11:36:22 -0800</creation_ts>
          <short_desc>Ambiguous Window Usage in kjs_dom.cpp</short_desc>
          <delta_ts>2007-12-10 21:22:23 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore JavaScript</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Rodney Dawes">dobey</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>63844</commentid>
    <comment_count>0</comment_count>
    <who name="Rodney Dawes">dobey</who>
    <bug_when>2007-12-10 11:36:22 -0800</bug_when>
    <thetext>Ambiguous usage of Window popping up in kjs_dom.cpp again. This conflicts with the Window type in X11, so we need to namespace it properly with KJS:: here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63845</commentid>
    <comment_count>1</comment_count>
      <attachid>17823</attachid>
    <who name="Rodney Dawes">dobey</who>
    <bug_when>2007-12-10 11:36:54 -0800</bug_when>
    <thetext>Created attachment 17823
Patch to use KJS::Window instead of just Window</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63878</commentid>
    <comment_count>2</comment_count>
      <attachid>17823</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-12-10 19:44:54 -0800</bug_when>
    <thetext>Comment on attachment 17823
Patch to use KJS::Window instead of just Window

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63886</commentid>
    <comment_count>3</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-12-10 20:52:34 -0800</bug_when>
    <thetext>Committed r28606

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>63888</commentid>
    <comment_count>4</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-12-10 20:55:46 -0800</bug_when>
    <thetext>Fixed ChangeLog entry in r28607.

</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>17823</attachid>
            <date>2007-12-10 11:36:54 -0800</date>
            <delta_ts>2007-12-10 21:22:23 -0800</delta_ts>
            <desc>Patch to use KJS::Window instead of just Window</desc>
            <filename>webkit-more-windows.patch</filename>
            <type>text/plain</type>
            <size>1081</size>
            <attacher name="Rodney Dawes">dobey</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMva2pzX2RvbS5jcHAKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi
Q29yZS9iaW5kaW5ncy9qcy9ranNfZG9tLmNwcAkocmV2aXNpb24gMjg1MjUpCisrKyBXZWJDb3Jl
L2JpbmRpbmdzL2pzL2tqc19kb20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Miw3ICs2Miw3IEBA
IGJvb2wgY2hlY2tOb2RlU2VjdXJpdHkoRXhlY1N0YXRlKiBleGVjLCAKICAgICByZXR1cm4gZmFs
c2U7CiAKICAgLy8gQ2hlY2sgdG8gc2VlIGlmIHRoZSBjdXJyZW50bHkgZXhlY3V0aW5nIGludGVy
cHJldGVyIGlzIGFsbG93ZWQgdG8gYWNjZXNzIHRoZSBzcGVjaWZpZWQgbm9kZQotICBXaW5kb3cq
IHdpbiA9IFdpbmRvdzo6cmV0cmlldmVXaW5kb3cobi0+ZG9jdW1lbnQoKS0+ZnJhbWUoKSk7Cisg
IEtKUzo6V2luZG93KiB3aW4gPSBLSlM6OldpbmRvdzo6cmV0cmlldmVXaW5kb3cobi0+ZG9jdW1l
bnQoKS0+ZnJhbWUoKSk7CiAgIHJldHVybiB3aW4gJiYgd2luLT5pc1NhZmVTY3JpcHQoZXhlYyk7
CiB9CiAKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyODU4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNv
cHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDctMTItMTAgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdh
eW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhISkK
KworICAgICAgICBVc2UgS0pTOjpXaW5kb3cgbm90IHRoZSBhbWJpZ3VvdXMgV2luZG93CisKKyAg
ICAgICAgKiBiaW5kaW5ncy9qcy9ranNfZG9tLmNwcCAoY2hlY2tOb2RlU2VjdXJpdHkpOgorCiAy
MDA3LTEyLTEwICBEYXZpZCBELiBLaWx6ZXIgIDxkZGtpbHplckB3ZWJraXQub3JnPgogCiAgICAg
ICAgIEJ1ZyA5NjgzOiBJbXBsZW1lbnQgc2VsZWN0Lm9wdGlvbnMucmVtb3ZlKCkgbWV0aG9kCg==
</data>
<flag name="review"
          id="7698"
          type_id="1"
          status="+"
          setter="ddkilzer"
    />
          </attachment>
      

    </bug>

</bugzilla>