163793 2016-10-21 09:53:33 -0700 [Web IDL] MediaControlsHost has invalid operation overloads 2016-10-21 11:55:55 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163791 1 cdumez cdumez cdumez commit-queue darin eric.carlson jer.noble sam oldest_to_newest 1242933 0 cdumez 2016-10-21 09:53:33 -0700 MediaControlsHost has invalid operation overloads: - sortedTrackListForMenu() - displayNameForTrack() The parameter is nullable for both overloads which is not valid IDL. 1242976 1 292371 cdumez 2016-10-21 10:41:49 -0700 Created attachment 292371 Patch 1243022 2 292371 commit-queue 2016-10-21 11:55:51 -0700 Comment on attachment 292371 Patch Clearing flags on attachment: 292371 Committed r207690: <http://trac.webkit.org/changeset/207690> 1243023 3 commit-queue 2016-10-21 11:55:55 -0700 All reviewed patches have been landed. Closing bug. 292371 2016-10-21 10:41:49 -0700 2016-10-21 11:55:51 -0700 Patch bug-163793-20161021103810.patch text/plain 6623 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA3Njc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE2ZDg2YzFlNmFiYjAx ZjA3NDAyZDY0NjgzYTA0ZGMzMTIzNGZmMy4uZmU4MmU4ZDRiZDA3ZTM3NGMyZTFiYTVlNjM5NGQ4 MDVjOTFiODIwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE2LTEwLTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dlYiBJRExdIE1lZGlhQ29u dHJvbHNIb3N0IGhhcyBpbnZhbGlkIG9wZXJhdGlvbiBvdmVybG9hZHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2Mzc5MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lZGlhQ29udHJvbHNIb3N0IGhhcyBp bnZhbGlkIG9wZXJhdGlvbiBvdmVybG9hZHM6CisgICAgICAgIC0gc29ydGVkVHJhY2tMaXN0Rm9y TWVudSgpCisgICAgICAgIC0gZGlzcGxheU5hbWVGb3JUcmFjaygpCisKKyAgICAgICAgVGhlIHBh cmFtZXRlciBpcyBudWxsYWJsZSBmb3IgYm90aCBvdmVybG9hZHMgd2hpY2ggaXMgbm90IHZhbGlk IElETC4KKworICAgICAgICAtIHNvcnRlZFRyYWNrTGlzdEZvck1lbnUoKTogVGhlIHBhcmFtZXRl ciBpcyBubyBsb25nZXIgbnVsbGFibGUuIFRoaXMgaXMgYSBtaW5vcgorICAgICAgICAgIGJlaGF2 aW9yIGNoYW5nZSBhbmQgaXQgc2hvdWxkIGJlIHNhZmUgc2luY2UgdGhpcyBpcyBBcHBsZS1zcGVj aWZpYyBhbmQgb25seQorICAgICAgICAgIGNhbGxlZCBmcm9tIG1lZGlhQ29udHJvbHNBcHBsZS5q cyB3aGljaCB1c2VzIEhUTUxNZWRpYUVsZW1lbnQudmlkZW9UcmFja3MgYW5kCisgICAgICAgICAg SFRNTE1lZGlhRWxlbWVudC5hdWRpb1RyYWNrcyBhcyBpbnB1dCwgYm90aCBvZiB3aGljaCBhcmUg bm90IG51bGxhYmxlLgorICAgICAgICAgIE5vdGUgdGhhdCB3ZSBjb3VsZCBoYXZlIGFsc28ga2Vw dCBvbmUgb2YgdGhlIHBhcmFtZXRlcnMgYXMgbnVsbGFibGUgdG8gbm90CisgICAgICAgICAgY2hh bmdlIGJlaGF2aW9yIGJ1dCBhbGxvd2luZyBudWxsIGRvZXMgbm90IHNlZW0gdXNlZnVsIGhlcmUu CisgICAgICAgIC0gZGlzcGxheU5hbWVGb3JUcmFjaygpOiBVc2UgYSB1bmlvbiBpbnN0ZWFkIG9m IG92ZXJsb2FkaW5nLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBNb2R1bGVzL21l ZGlhY29udHJvbHMvTWVkaWFDb250cm9sc0hvc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFDb250cm9sc0hvc3Q6OnNvcnRlZFRyYWNrTGlzdEZvck1lbnUpOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFDb250cm9sc0hvc3Q6OmRpc3BsYXlOYW1lRm9yVHJhY2spOgorICAgICAgICAqIE1v ZHVsZXMvbWVkaWFjb250cm9scy9NZWRpYUNvbnRyb2xzSG9zdC5oOgorICAgICAgICAqIE1vZHVs ZXMvbWVkaWFjb250cm9scy9NZWRpYUNvbnRyb2xzSG9zdC5pZGw6CisKIDIwMTYtMTAtMjEgIERh dmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NTUyBQYXJzZXJdIEFkZCBz dXBwb3J0IGZvciBALXdlYmtpdC1yZWdpb24gcnVsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9NZWRpYUNvbnRyb2xzSG9zdC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvTWVkaWFDb250cm9sc0hvc3QuY3BwCmluZGV4 IGZhZjUxY2YzNjY5NTAwOTRmY2M1MDg4MjRjNDk3ZDBmZTkxMzRkYTUuLjA0MjBkNzIzOThkMTE0 MmM1YmI1YWZiYTk1NmYxOWVkODhmZjdlZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvbWVkaWFjb250cm9scy9NZWRpYUNvbnRyb2xzSG9zdC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL01lZGlhQ29udHJvbHNIb3N0LmNwcApAQCAtODQs NDMgKzg0LDI1IEBAIE1lZGlhQ29udHJvbHNIb3N0Ojp+TWVkaWFDb250cm9sc0hvc3QoKQogewog fQogCi1WZWN0b3I8UmVmUHRyPFRleHRUcmFjaz4+IE1lZGlhQ29udHJvbHNIb3N0Ojpzb3J0ZWRU cmFja0xpc3RGb3JNZW51KFRleHRUcmFja0xpc3QqIHRyYWNrTGlzdCkKK1ZlY3RvcjxSZWZQdHI8 VGV4dFRyYWNrPj4gTWVkaWFDb250cm9sc0hvc3Q6OnNvcnRlZFRyYWNrTGlzdEZvck1lbnUoVGV4 dFRyYWNrTGlzdCYgdHJhY2tMaXN0KQogewotICAgIGlmICghdHJhY2tMaXN0KQotICAgICAgICBy ZXR1cm4gVmVjdG9yPFJlZlB0cjxUZXh0VHJhY2s+PigpOwotCi0gICAgUGFnZSogcGFnZSA9IG1f bWVkaWFFbGVtZW50LT5kb2N1bWVudCgpLnBhZ2UoKTsKLSAgICBpZiAoIXBhZ2UpCi0gICAgICAg IHJldHVybiBWZWN0b3I8UmVmUHRyPFRleHRUcmFjaz4+KCk7Ci0KLSAgICByZXR1cm4gcGFnZS0+ Z3JvdXAoKS5jYXB0aW9uUHJlZmVyZW5jZXMoKS5zb3J0ZWRUcmFja0xpc3RGb3JNZW51KHRyYWNr TGlzdCk7Ci19Ci0KLVZlY3RvcjxSZWZQdHI8QXVkaW9UcmFjaz4+IE1lZGlhQ29udHJvbHNIb3N0 Ojpzb3J0ZWRUcmFja0xpc3RGb3JNZW51KEF1ZGlvVHJhY2tMaXN0KiB0cmFja0xpc3QpCi17Ci0g ICAgaWYgKCF0cmFja0xpc3QpCi0gICAgICAgIHJldHVybiBWZWN0b3I8UmVmUHRyPEF1ZGlvVHJh Y2s+PigpOwotCiAgICAgUGFnZSogcGFnZSA9IG1fbWVkaWFFbGVtZW50LT5kb2N1bWVudCgpLnBh Z2UoKTsKICAgICBpZiAoIXBhZ2UpCi0gICAgICAgIHJldHVybiBWZWN0b3I8UmVmUHRyPEF1ZGlv VHJhY2s+PigpOworICAgICAgICByZXR1cm4geyB9OwogCi0gICAgcmV0dXJuIHBhZ2UtPmdyb3Vw KCkuY2FwdGlvblByZWZlcmVuY2VzKCkuc29ydGVkVHJhY2tMaXN0Rm9yTWVudSh0cmFja0xpc3Qp OworICAgIHJldHVybiBwYWdlLT5ncm91cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLnNvcnRlZFRy YWNrTGlzdEZvck1lbnUoJnRyYWNrTGlzdCk7CiB9CiAKLVN0cmluZyBNZWRpYUNvbnRyb2xzSG9z dDo6ZGlzcGxheU5hbWVGb3JUcmFjayhUZXh0VHJhY2sqIHRyYWNrKQorVmVjdG9yPFJlZlB0cjxB dWRpb1RyYWNrPj4gTWVkaWFDb250cm9sc0hvc3Q6OnNvcnRlZFRyYWNrTGlzdEZvck1lbnUoQXVk aW9UcmFja0xpc3QmIHRyYWNrTGlzdCkKIHsKLSAgICBpZiAoIXRyYWNrKQotICAgICAgICByZXR1 cm4gZW1wdHlTdHJpbmcoKTsKLQogICAgIFBhZ2UqIHBhZ2UgPSBtX21lZGlhRWxlbWVudC0+ZG9j dW1lbnQoKS5wYWdlKCk7CiAgICAgaWYgKCFwYWdlKQotICAgICAgICByZXR1cm4gZW1wdHlTdHJp bmcoKTsKKyAgICAgICAgcmV0dXJuIHsgfTsKIAotICAgIHJldHVybiBwYWdlLT5ncm91cCgpLmNh cHRpb25QcmVmZXJlbmNlcygpLmRpc3BsYXlOYW1lRm9yVHJhY2sodHJhY2spOworICAgIHJldHVy biBwYWdlLT5ncm91cCgpLmNhcHRpb25QcmVmZXJlbmNlcygpLnNvcnRlZFRyYWNrTGlzdEZvck1l bnUoJnRyYWNrTGlzdCk7CiB9CiAKLVN0cmluZyBNZWRpYUNvbnRyb2xzSG9zdDo6ZGlzcGxheU5h bWVGb3JUcmFjayhBdWRpb1RyYWNrKiB0cmFjaykKK1N0cmluZyBNZWRpYUNvbnRyb2xzSG9zdDo6 ZGlzcGxheU5hbWVGb3JUcmFjayhjb25zdCBPcHRpb25hbDxUZXh0T3JBdWRpb1RyYWNrPiYgdHJh Y2spCiB7CiAgICAgaWYgKCF0cmFjaykKICAgICAgICAgcmV0dXJuIGVtcHR5U3RyaW5nKCk7CkBA IC0xMjksNyArMTExLDkgQEAgU3RyaW5nIE1lZGlhQ29udHJvbHNIb3N0OjpkaXNwbGF5TmFtZUZv clRyYWNrKEF1ZGlvVHJhY2sqIHRyYWNrKQogICAgIGlmICghcGFnZSkKICAgICAgICAgcmV0dXJu IGVtcHR5U3RyaW5nKCk7CiAKLSAgICByZXR1cm4gcGFnZS0+Z3JvdXAoKS5jYXB0aW9uUHJlZmVy ZW5jZXMoKS5kaXNwbGF5TmFtZUZvclRyYWNrKHRyYWNrKTsKKyAgICByZXR1cm4gV1RGOjp2aXNp dChbJnBhZ2VdKGF1dG8mIHRyYWNrKSB7CisgICAgICAgIHJldHVybiBwYWdlLT5ncm91cCgpLmNh cHRpb25QcmVmZXJlbmNlcygpLmRpc3BsYXlOYW1lRm9yVHJhY2sodHJhY2suZ2V0KCkpOworICAg IH0sIHRyYWNrLnZhbHVlKCkpOwogfQogCiBUZXh0VHJhY2sqIE1lZGlhQ29udHJvbHNIb3N0Ojpj YXB0aW9uTWVudU9mZkl0ZW0oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL01lZGlhQ29udHJvbHNIb3N0LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhY29udHJvbHMvTWVkaWFDb250cm9sc0hvc3QuaAppbmRleCA2ZjIwYjNiZTU2MjgyZTBi MmY5YjkwNWM2N2IwN2VjZWJjNTllNjdkLi41MDUzODIyMTkwOGU0YmFhZjI1NWUzYmRhYjNmM2Ri ZjQxNWQ2MmNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJv bHMvTWVkaWFDb250cm9sc0hvc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh Y29udHJvbHMvTWVkaWFDb250cm9sc0hvc3QuaApAQCAtMjksNiArMjksNyBAQAogCiAjaW5jbHVk ZSA8YmluZGluZ3MvU2NyaXB0T2JqZWN0Lmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4K KyNpbmNsdWRlIDx3dGYvVmFyaWFudC5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KICNpbmNs dWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIApAQCAtNTIsMTAgKzUzLDEyIEBAIHB1YmxpYzoK ICAgICBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nJiBhbHdheXNPbktleXdvcmQoKTsKICAgICBz dGF0aWMgY29uc3QgQXRvbWljU3RyaW5nJiBtYW51YWxLZXl3b3JkKCk7CiAKLSAgICBWZWN0b3I8 UmVmUHRyPFRleHRUcmFjaz4+IHNvcnRlZFRyYWNrTGlzdEZvck1lbnUoVGV4dFRyYWNrTGlzdCop OwotICAgIFZlY3RvcjxSZWZQdHI8QXVkaW9UcmFjaz4+IHNvcnRlZFRyYWNrTGlzdEZvck1lbnUo QXVkaW9UcmFja0xpc3QqKTsKLSAgICBTdHJpbmcgZGlzcGxheU5hbWVGb3JUcmFjayhUZXh0VHJh Y2sqKTsKLSAgICBTdHJpbmcgZGlzcGxheU5hbWVGb3JUcmFjayhBdWRpb1RyYWNrKik7CisgICAg VmVjdG9yPFJlZlB0cjxUZXh0VHJhY2s+PiBzb3J0ZWRUcmFja0xpc3RGb3JNZW51KFRleHRUcmFj a0xpc3QmKTsKKyAgICBWZWN0b3I8UmVmUHRyPEF1ZGlvVHJhY2s+PiBzb3J0ZWRUcmFja0xpc3RG b3JNZW51KEF1ZGlvVHJhY2tMaXN0Jik7CisKKyAgICB1c2luZyBUZXh0T3JBdWRpb1RyYWNrID0g V1RGOjpWYXJpYW50PFJlZlB0cjxUZXh0VHJhY2s+LCBSZWZQdHI8QXVkaW9UcmFjaz4+OworICAg IFN0cmluZyBkaXNwbGF5TmFtZUZvclRyYWNrKGNvbnN0IE9wdGlvbmFsPFRleHRPckF1ZGlvVHJh Y2s+Jik7CisKICAgICBUZXh0VHJhY2sqIGNhcHRpb25NZW51T2ZmSXRlbSgpOwogICAgIFRleHRU cmFjayogY2FwdGlvbk1lbnVBdXRvbWF0aWNJdGVtKCk7CiAgICAgQXRvbWljU3RyaW5nIGNhcHRp b25EaXNwbGF5TW9kZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YWNvbnRyb2xzL01lZGlhQ29udHJvbHNIb3N0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFjb250cm9scy9NZWRpYUNvbnRyb2xzSG9zdC5pZGwKaW5kZXggYTZlMzA0ZTA5YjU3YWJi MDY2MDFmOWNlMWNhZDNlYTA5NWI4YTM5My4uMjJhM2Y3NWFlNDM3Y2M4NWRjOWQwMmYxYjg4YTY1 NDFhNTUwM2I4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRy b2xzL01lZGlhQ29udHJvbHNIb3N0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhY29udHJvbHMvTWVkaWFDb250cm9sc0hvc3QuaWRsCkBAIC0zNCwxMCArMzQsOSBAQCBlbnVt IERldmljZVR5cGUgewogICAgIEltcGxlbWVudGF0aW9uTGFja3NWVGFibGUsCiAgICAgTm9JbnRl cmZhY2VPYmplY3QsCiBdIGludGVyZmFjZSBNZWRpYUNvbnRyb2xzSG9zdCB7Ci0gICAgc2VxdWVu Y2U8VGV4dFRyYWNrPiBzb3J0ZWRUcmFja0xpc3RGb3JNZW51KFRleHRUcmFja0xpc3Q/IHRyYWNr TGlzdCk7Ci0gICAgc2VxdWVuY2U8QXVkaW9UcmFjaz4gc29ydGVkVHJhY2tMaXN0Rm9yTWVudShB dWRpb1RyYWNrTGlzdD8gdHJhY2tMaXN0KTsKLSAgICBET01TdHJpbmcgZGlzcGxheU5hbWVGb3JU cmFjayhUZXh0VHJhY2s/IHRyYWNrKTsKLSAgICBET01TdHJpbmcgZGlzcGxheU5hbWVGb3JUcmFj ayhBdWRpb1RyYWNrPyB0cmFjayk7CisgICAgc2VxdWVuY2U8VGV4dFRyYWNrPiBzb3J0ZWRUcmFj a0xpc3RGb3JNZW51KFRleHRUcmFja0xpc3QgdHJhY2tMaXN0KTsKKyAgICBzZXF1ZW5jZTxBdWRp b1RyYWNrPiBzb3J0ZWRUcmFja0xpc3RGb3JNZW51KEF1ZGlvVHJhY2tMaXN0IHRyYWNrTGlzdCk7 CisgICAgRE9NU3RyaW5nIGRpc3BsYXlOYW1lRm9yVHJhY2soKFRleHRUcmFjayBvciBBdWRpb1Ry YWNrKT8gdHJhY2spOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBUZXh0VHJhY2sgY2FwdGlvbk1l bnVPZmZJdGVtOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBUZXh0VHJhY2sgY2FwdGlvbk1lbnVB dXRvbWF0aWNJdGVtOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgY2FwdGlvbkRp c3BsYXlNb2RlOwo=