163763 2016-10-20 15:38:57 -0700 AX: VoiceOver is not detecting ARIA treeview if it contains role="presentation" 2016-10-20 18:18:10 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario n_wang samuel_white webkit-bug-importer oldest_to_newest 1242625 0 n_wang 2016-10-20 15:38:57 -0700 VoiceOver does not recognise a tree if there are elements with role=“presentation” in the structure. <rdar://problem/28280231> 1242633 1 292273 n_wang 2016-10-20 15:48:38 -0700 Created attachment 292273 patch 1242637 2 292273 cfleizach 2016-10-20 15:55:55 -0700 Comment on attachment 292273 patch View in context: https://bugs.webkit.org/attachment.cgi?id=292273&action=review > Source/WebCore/accessibility/AccessibilityTree.cpp:100 > + if (!nodeHasTreeItemChild(*child)) does this only work one level deep then? 1242638 3 292273 n_wang 2016-10-20 16:02:45 -0700 Comment on attachment 292273 patch View in context: https://bugs.webkit.org/attachment.cgi?id=292273&action=review >> Source/WebCore/accessibility/AccessibilityTree.cpp:100 >> + if (!nodeHasTreeItemChild(*child)) > > does this only work one level deep then? Yes. I think normally web author will just have this one level. Do you think we should cover multiple level case? 1242707 4 292273 commit-queue 2016-10-20 18:18:06 -0700 Comment on attachment 292273 patch Clearing flags on attachment: 292273 Committed r207647: <http://trac.webkit.org/changeset/207647> 1242708 5 commit-queue 2016-10-20 18:18:10 -0700 All reviewed patches have been landed. Closing bug. 292273 2016-10-20 15:48:38 -0700 2016-10-20 18:18:06 -0700 patch patch.txt text/plain 7344 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzY0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTEwLTIwICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFZvaWNlT3ZlciBpcyBub3QgZGV0 ZWN0aW5nIEFSSUEgdHJlZXZpZXcgaWYgaXQgY29udGFpbnMgcm9sZT0icHJlc2VudGF0aW9uIgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNzYzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogYWNj ZXNzaWJpbGl0eS9tYWMvYXJpYS10cmVlLXdpdGgtcHJlc2VudGF0aW9uLXJvbGUuaHRtbAorCisg ICAgICAgIFdlYiBhdXRob3JzIHNvbWV0aW1lcyB1c2UgcHJlc2VudGF0aW9uIHJvbGUgaW4gdGhl IGFyaWEgdHJlZSB0byBoaWRlIGVsZW1lbnRzLiBXZSBzaG91bGQKKyAgICAgICAgY29uc2lkZXIg dGhpcyBhIHZhbGlkIGNhc2UgaWYgdGhleSBzcGVjaWZ5IHRyZWUgaXRlbXMgYW5kIGdyb3VwcyBj b3JyZWN0bHkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjpoaWVy YXJjaGljYWxMZXZlbCk6CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VHJl ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VHJlZTo6bm9kZUhhc1RyZWVJ dGVtQ2hpbGQpOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRyZWU6OmlzVHJlZVZh bGlkKToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUcmVlLmg6CisKIDIw MTYtMTAtMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtl IHRhYmxlLmRlbGV0ZVJvdygtMSkgYSBuby1vcCB3aGVuIHRoZXJlIGFyZSBubyByb3dzCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlOb2RlT2JqZWN0LmNwcAkocmV2aXNpb24gMjA3NjQwKQorKysgU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE2MTUsNyArMTYxNSw3IEBAIHVuc2lnbmVkIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0OjpoaWVy YXIKICAgICAvLyBXZSBtZWFzdXJlIHRyZWUgaGllcmFyY2h5IGJ5IHRoZSBudW1iZXIgb2YgZ3Jv dXBzIHRoYXQgdGhlIGl0ZW0gaXMgd2l0aGluLgogICAgIHVuc2lnbmVkIGxldmVsID0gMTsKICAg ICBmb3IgKEFjY2Vzc2liaWxpdHlPYmplY3QqIHBhcmVudCA9IHBhcmVudE9iamVjdCgpOyBwYXJl bnQ7IHBhcmVudCA9IHBhcmVudC0+cGFyZW50T2JqZWN0KCkpIHsKLSAgICAgICAgQWNjZXNzaWJp bGl0eVJvbGUgcGFyZW50Um9sZSA9IHBhcmVudC0+cm9sZVZhbHVlKCk7CisgICAgICAgIEFjY2Vz c2liaWxpdHlSb2xlIHBhcmVudFJvbGUgPSBwYXJlbnQtPmFyaWFSb2xlQXR0cmlidXRlKCk7CiAg ICAgICAgIGlmIChwYXJlbnRSb2xlID09IEdyb3VwUm9sZSkKICAgICAgICAgICAgIGxldmVsKys7 CiAgICAgICAgIGVsc2UgaWYgKHBhcmVudFJvbGUgPT0gVHJlZVJvbGUpCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUcmVlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUcmVlLmNwcAkocmV2 aXNpb24gMjA3NjQwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5VHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3LDYgKzY3LDE1IEBAIEFjY2Vzc2liaWxp dHlSb2xlIEFjY2Vzc2liaWxpdHlUcmVlOjpkZXQKICAgICByZXR1cm4gaXNUcmVlVmFsaWQoKSA/ IFRyZWVSb2xlIDogR3JvdXBSb2xlOwogfQogCitib29sIEFjY2Vzc2liaWxpdHlUcmVlOjpub2Rl SGFzVHJlZUl0ZW1DaGlsZChOb2RlJiBub2RlKSBjb25zdAoreworICAgIGZvciAoYXV0byogY2hp bGQgPSBub2RlLmZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5n KCkpIHsKKyAgICAgICAgaWYgKG5vZGVIYXNSb2xlKGNoaWxkLCAidHJlZWl0ZW0iKSkKKyAgICAg ICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIGJvb2wg QWNjZXNzaWJpbGl0eVRyZWU6OmlzVHJlZVZhbGlkKCkgY29uc3QKIHsKICAgICAvLyBBIHZhbGlk IHRyZWUgY2FuIG9ubHkgaGF2ZSB0cmVlaXRlbSBvciBncm91cCBvZiB0cmVlaXRlbXMgYXMgYSBj aGlsZApAQCAtODcsNiArOTYsMTEgQEAgYm9vbCBBY2Nlc3NpYmlsaXR5VHJlZTo6aXNUcmVlVmFs aWQoKSBjbwogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIGlmIChub2RlSGFzUm9sZShj aGlsZCwgInRyZWVpdGVtIikpCiAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgaWYgKG5v ZGVIYXNSb2xlKGNoaWxkLCAicHJlc2VudGF0aW9uIikpIHsKKyAgICAgICAgICAgIGlmICghbm9k ZUhhc1RyZWVJdGVtQ2hpbGQoKmNoaWxkKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQogICAgICAgICBpZiAoIW5vZGVIYXNS b2xlKGNoaWxkLCAiZ3JvdXAiKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIApJbmRleDog U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VHJlZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRyZWUuaAko cmV2aXNpb24gMjA3NjQwKQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5VHJlZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw3IEBAIHByaXZhdGU6CiAg ICAgYm9vbCBjb21wdXRlQWNjZXNzaWJpbGl0eUlzSWdub3JlZCgpIGNvbnN0IG92ZXJyaWRlOwog ICAgIEFjY2Vzc2liaWxpdHlSb2xlIGRldGVybWluZUFjY2Vzc2liaWxpdHlSb2xlKCkgb3ZlcnJp ZGU7CiAgICAgYm9vbCBpc1RyZWVWYWxpZCgpIGNvbnN0OworICAgIGJvb2wgbm9kZUhhc1RyZWVJ dGVtQ2hpbGQoTm9kZSYpIGNvbnN0OwogfTsKICAgICAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIwNzY0MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEwLTIwICBOYW4gV2FuZyAgPG5fd2Fu Z0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFZvaWNlT3ZlciBpcyBub3QgZGV0ZWN0aW5nIEFS SUEgdHJlZXZpZXcgaWYgaXQgY29udGFpbnMgcm9sZT0icHJlc2VudGF0aW9uIgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNzYzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L21h Yy9hcmlhLXRyZWUtd2l0aC1wcmVzZW50YXRpb24tcm9sZS1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL2FyaWEtdHJlZS13aXRoLXByZXNlbnRhdGlvbi1y b2xlLmh0bWw6IEFkZGVkLgorCiAyMDE2LTEwLTIwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBnYXJkZW5pbmcuCkluZGV4OiBMYXlvdXRUZXN0 cy9hY2Nlc3NpYmlsaXR5L21hYy9hcmlhLXRyZWUtd2l0aC1wcmVzZW50YXRpb24tcm9sZS1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJp YS10cmVlLXdpdGgtcHJlc2VudGF0aW9uLXJvbGUtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkK KysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtdHJlZS13aXRoLXByZXNlbnRh dGlvbi1yb2xlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIyIEBACitS ZWxlYXNlIE5vdGVzCitVc2luZyBTZWFyY2gKK1Bvd2VyIFNlYXJjaAorQ29tbW9uIEluZm8gQXJl YQorVGhpcyB0ZXN0cyB0aGF0IGFyaWEgdHJlZXMgYXJlIGNvcnJlY3RseSBleHBvc2VkIHdoZW4g dGhlcmUgaXMgcm9sZT0ncHJlc2VudGF0aW9uJyBwcmVzZW50ZWQuCisKK09uIHN1Y2Nlc3MsIHlv dSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNU IENPTVBMRVRFIi4KKworCitBWFJvbGU6IEFYT3V0bGluZSBBWFZhbHVlOiAKKyAgQVhSb2xlOiBB WFJvdyBsZXZlbDogMAorICAgIEFYUm9sZTogQVhTdGF0aWNUZXh0IEFYVmFsdWU6IFJlbGVhc2Ug Tm90ZXMKKyAgQVhSb2xlOiBBWFJvdyBsZXZlbDogMAorICAgIEFYUm9sZTogQVhTdGF0aWNUZXh0 IEFYVmFsdWU6IFVzaW5nIFNlYXJjaAorICBBWFJvbGU6IEFYUm93IGxldmVsOiAxCisgICAgQVhS b2xlOiBBWFN0YXRpY1RleHQgQVhWYWx1ZTogUG93ZXIgU2VhcmNoCisgIEFYUm9sZTogQVhSb3cg bGV2ZWw6IDAKKyAgICBBWFJvbGU6IEFYU3RhdGljVGV4dCBBWFZhbHVlOiBDb21tb24gSW5mbyBB cmVhCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJ bmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9tYWMvYXJpYS10cmVlLXdpdGgtcHJlc2Vu dGF0aW9uLXJvbGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5 L21hYy9hcmlhLXRyZWUtd2l0aC1wcmVzZW50YXRpb24tcm9sZS5odG1sCShub25leGlzdGVudCkK KysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvbWFjL2FyaWEtdHJlZS13aXRoLXByZXNlbnRh dGlvbi1yb2xlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1NyBAQAorPCFET0NUWVBF IEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8dWwgaWQ9InRyZWUiIHJvbGU9InRyZWUiIGFyaWEt bGFiZWw9IkhlbHAgVG9waWNzIj4KKzxsaSByb2xlPSJ0cmVlaXRlbSI+UmVsZWFzZSBOb3Rlczwv bGk+Cis8bGkgcm9sZT0icHJlc2VudGF0aW9uIj4gIAorPHNwYW4gcm9sZT0idHJlZWl0ZW0iIGFy aWEtZXhwYW5kZWQ9InRydWUiPlVzaW5nIFNlYXJjaDwvc3Bhbj4KKzx1bCByb2xlPSJncm91cCIg YXJpYS1sYWJlbD0iVXNpbmcgU2VhcmNoIiBhcmlhLWV4cGFuZGVkPSJ0cnVlIj4KKzxsaSByb2xl PSJ0cmVlaXRlbSI+UG93ZXIgU2VhcmNoPC9saT4KKzwvdWw+Cis8L2xpPgorPGxpIHJvbGU9InBy ZXNlbnRhdGlvbiI+Cis8c3BhbiByb2xlPSJ0cmVlaXRlbSIgYXJpYS1leHBhbmRlZD0iZmFsc2Ui PkNvbW1vbiBJbmZvIEFyZWE8L3NwYW4+Cis8L2xpPgorPC91bD4KKworPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworICAgIGRl c2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgYXJpYSB0cmVlcyBhcmUgY29ycmVjdGx5IGV4cG9z ZWQgd2hlbiB0aGVyZSBpcyByb2xlPSdwcmVzZW50YXRpb24nIHByZXNlbnRlZC4iKTsKKworICAg IGlmICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAKKyAgICAgICAgICAv LyBUZXN0IHRyZWUgYXR0cmlidXRlcy4KKyAgICAgICAgICB2YXIgdHJlZSA9IGFjY2Vzc2liaWxp dHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgidHJlZSIpOworICAgICAgICAgIGR1 bXBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW4odHJlZSwgMCk7CisgICAgfQorICAgIAorICAgIGZ1bmN0 aW9uIGR1bXBBY2Nlc3NpYmlsaXR5Q2hpbGRyZW4oZWxlbWVudCwgbGV2ZWwpIHsKKyAgICAgICAg aWYgKGVsZW1lbnQuc3RyaW5nVmFsdWUuaW5kZXhPZignRW5kIG9mIHRlc3QnKSA+PSAwKQorICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIHZhciBpbmRlbnQgPSAiIjsKKyAgICAg ICAgZm9yICh2YXIgayA9IDA7IGsgPCBsZXZlbDsgaysrKSB7IGluZGVudCArPSAiICAiOyB9Cisg ICAgICAgIGlmIChlbGVtZW50LnJvbGUgPT0gIkFYUm9sZTogQVhSb3ciKQorICAgICAgICAgICAg ZGVidWcoaW5kZW50ICsgZWxlbWVudC5yb2xlICsgIiAiICsgImxldmVsOiAiICsgZWxlbWVudC5o aWVyYXJjaGljYWxMZXZlbCk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGRlYnVnKGluZGVu dCArIGVsZW1lbnQucm9sZSArICIgIiArIGVsZW1lbnQuc3RyaW5nVmFsdWUpOworICAgICAgICB2 YXIgY2hpbGRyZW5Db3VudCA9IGVsZW1lbnQuY2hpbGRyZW5Db3VudDsKKyAgICAgICAgZm9yICh2 YXIgayA9IDA7IGsgPCBjaGlsZHJlbkNvdW50OyBrKyspIHsKKyAgICAgICAgICAgIGlmICghZHVt cEFjY2Vzc2liaWxpdHlDaGlsZHJlbihlbGVtZW50LmNoaWxkQXRJbmRleChrKSwgbGV2ZWwrMSkp CisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisgICAgICAgIHJldHVy biB0cnVlOworICAgIH0KKworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K