163758 2016-10-20 14:04:16 -0700 [iOS] _webViewWillEndNavigationGesture:withNavigationToBackForwardListItem: is never called 2016-10-22 00:26:25 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz thorton oldest_to_newest 1242596 0 mitz 2016-10-20 14:04:16 -0700 Because ViewGestureControllerIOS.mm’s implementation of ViewGestureController::beginSwipeGesture sets the transition context’s interactive update handler to the empty block right after setting it to the block that calls navigationGestureWillEnd(), the latter never gets called. 1243242 1 292452 mitz 2016-10-21 20:43:15 -0700 Created attachment 292452 Don't reset the update handler 1243326 2 mitz 2016-10-22 00:26:25 -0700 Fixed in <https://trac.webkit.org/r207709>. 292452 2016-10-21 20:43:15 -0700 2016-10-21 22:51:47 -0700 Don't reset the update handler bug-163758-20161021203935.patch text/plain 1551 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzcwNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEwLTIxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gX3dlYlZpZXdXaWxsRW5k TmF2aWdhdGlvbkdlc3R1cmU6d2l0aE5hdmlnYXRpb25Ub0JhY2tGb3J3YXJkTGlzdEl0ZW06IGlz IG5ldmVyIGNhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTYzNzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1ZpZXdHZXN0dXJlQ29udHJvbGxlcklPUy5tbToKKyAgICAg ICAgKFdlYktpdDo6Vmlld0dlc3R1cmVDb250cm9sbGVyOjpiZWdpblN3aXBlR2VzdHVyZSk6IERv buKAmXQgcmVzZXQgdGhlIGludGVyYWN0aXZlIHVwZGF0ZQorICAgICAgICAgIGhhbmRsZXIuCisK IDIwMTYtMTAtMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW01lZGlhU3RyZWFtXSBEeW5hbWljYWxseSBnZW5lcmF0ZSBtZWRpYSBjYXB0dXJlIHNh bmRib3ggZXh0ZW5zaW9ucwpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9WaWV3 R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2lvcy9WaWV3R2VzdHVyZUNvbnRyb2xsZXJJT1MubW0JKHJldmlzaW9uIDIwNzcwMykK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvVmlld0dlc3R1cmVDb250cm9sbGVySU9T Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMjksNyArMjI5LDYgQEAgdm9pZCBWaWV3R2VzdHVyZUNv bnRyb2xsZXI6OmJlZ2luU3dpcGVHZQogICAgICAgICBpZiAoYXV0byBnZXN0dXJlQ29udHJvbGxl ciA9IGdlc3R1cmVDb250cm9sbGVyRm9yUGFnZShwYWdlSUQpKQogICAgICAgICAgICAgZ2VzdHVy ZUNvbnRyb2xsZXItPmVuZFN3aXBlR2VzdHVyZSh0YXJnZXRJdGVtLmdldCgpLCBjb250ZXh0LCAh ZGlkQ29tcGxldGUpOwogICAgIH1dOwotICAgIFttX3N3aXBlVHJhbnNpdGlvbkNvbnRleHQgX3Nl dEludGVyYWN0aXZlVXBkYXRlSGFuZGxlcjpeKEJPT0wsIENHRmxvYXQsIEJPT0wsIF9VSVZpZXdD b250cm9sbGVyVHJhbnNpdGlvbkNvbnRleHQgKikgeyB9XTsKIAogICAgIFt0cmFuc2l0aW9uIHNl dEFuaW1hdGlvbkNvbnRyb2xsZXI6YW5pbWF0aW9uQ29udHJvbGxlci5nZXQoKV07CiAgICAgW3Ry YW5zaXRpb24gc3RhcnRJbnRlcmFjdGl2ZVRyYW5zaXRpb246bV9zd2lwZVRyYW5zaXRpb25Db250 ZXh0LmdldCgpXTsK