16375 2007-12-09 23:00:17 -0800 REGRESSION: Safari crashes on quit 2007-12-10 05:15:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz darin darin oldest_to_newest 63791 0 mitz 2007-12-09 23:00:17 -0800 Steps to reproduce: 1) Open Safari with TOT WebKit 2) Go to javascript: 0; 3) Quit Safari Result: Safari crashed. Backtrace: 0 com.apple.JavaScriptCore 0x005d8568 KJS::UString::Rep::deref() + 74 (ustring.h:159) 1 com.apple.JavaScriptCore 0x005d85bd WTF::RefPtr<KJS::UString::Rep>::~RefPtr() + 31 (RefPtr.h:45) 2 com.apple.JavaScriptCore 0x005d85d1 WTF::RefPtr<KJS::UString::Rep>::~RefPtr() + 17 (RefPtr.h:45) 3 com.apple.JavaScriptCore 0x005d85e5 KJS::UString::~UString() + 17 (ustring.h:229) 4 com.apple.JavaScriptCore 0x005d85f9 KJS::UString::~UString() + 17 (ustring.h:229) 5 com.apple.JavaScriptCore 0x005dbb63 KJS::Parser::~Parser() + 31 (Parser.h:41) 6 com.apple.JavaScriptCore 0x005dbb81 KJS::Parser::~Parser() + 17 (Parser.h:41) 7 com.apple.JavaScriptCore 0x00585125 __tcf_6 + 27 (Parser.cpp:111) 8 libSystem.B.dylib 0x901c195c __cxa_finalize + 241 9 libSystem.B.dylib 0x901c1850 exit + 33 10 com.apple.AppKit 0x91231060 -[NSApplication terminate:] + 772 11 com.apple.AppKit 0x91151f94 -[NSApplication sendAction:to:from:] + 112 63793 1 darin 2007-12-09 23:22:35 -0800 What a coincidence! I have a patch for this already. 63794 2 17814 darin 2007-12-09 23:24:28 -0800 Created attachment 17814 patch 63795 3 17815 darin 2007-12-09 23:28:32 -0800 Created attachment 17815 patch (this time with the correct ChangeLog) 63808 4 mrowe 2007-12-10 05:15:34 -0800 I landed this in r28580 as it was causing havoc on the buildbots. 17814 2007-12-09 23:24:28 -0800 2007-12-09 23:28:32 -0800 patch QuitCrashPatch.txt text/plain 834 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NTc4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDctMTItMDkgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICoga2pzL1BhcnNlci5jcHA6CisgICAgICAgIChLSlM6OnBhcnNlcik6 CisKIDIwMDctMTItMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvUGFyc2Vy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvUGFyc2VyLmNwcAkocmV2aXNp b24gMjg1NzcpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvUGFyc2VyLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTA4LDcgKzEwOCw3IEBAIFBhcnNlciYgcGFyc2VyKCkKIHsKICAgICBBU1NFUlQoSlNM b2NrOjpjdXJyZW50VGhyZWFkSXNIb2xkaW5nTG9jaygpKTsKIAotICAgIHN0YXRpYyBQYXJzZXIg c3RhdGljUGFyc2VyOworICAgIHN0YXRpYyBQYXJzZXImIHN0YXRpY1BhcnNlciA9ICpuZXcgUGFy c2VyOwogICAgIHJldHVybiBzdGF0aWNQYXJzZXI7CiB9CiAK 17815 2007-12-09 23:28:32 -0800 2007-12-10 05:08:18 -0800 patch (this time with the correct ChangeLog) QuitCrashPatch.txt text/plain 1077 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4NTc4KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMTItMDkgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2Mzc1CisgICAgICAgICAgUkVHUkVTU0lPTjogU2FmYXJpIGNyYXNoZXMgb24gcXVpdAor CisgICAgICAgIFByb2JhYmx5IGEgZGVidWctb25seSBpc3N1ZS4KKworICAgICAgICAqIGtqcy9Q YXJzZXIuY3BwOgorICAgICAgICAoS0pTOjpwYXJzZXIpOiBDcmVhdGUgdGhlIHBhcnNlciBhbmQg bmV2ZXIgZGVzdHJveSBpdCBieSB1c2luZyBhIHBvaW50ZXIgaW5zdGVhZAorICAgICAgICBvZiBh IGdsb2JhbCBvYmplY3QuCisKIDIwMDctMTItMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS9ranMvUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvUGFy c2VyLmNwcAkocmV2aXNpb24gMjg1NzcpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvUGFyc2VyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTA4LDcgKzEwOCw3IEBAIFBhcnNlciYgcGFyc2VyKCkKIHsK ICAgICBBU1NFUlQoSlNMb2NrOjpjdXJyZW50VGhyZWFkSXNIb2xkaW5nTG9jaygpKTsKIAotICAg IHN0YXRpYyBQYXJzZXIgc3RhdGljUGFyc2VyOworICAgIHN0YXRpYyBQYXJzZXImIHN0YXRpY1Bh cnNlciA9ICpuZXcgUGFyc2VyOwogICAgIHJldHVybiBzdGF0aWNQYXJzZXI7CiB9CiAK