163743 2016-10-20 11:24:08 -0700 [CSS Parser] Fix region, column and page break parsing 2016-10-20 11:38:50 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt commit-queue oldest_to_newest 1242494 0 hyatt 2016-10-20 11:24:08 -0700 Fix region, column and page break parsing. 1242496 1 292228 hyatt 2016-10-20 11:26:49 -0700 Created attachment 292228 Patch 1242497 2 commit-queue 2016-10-20 11:28:02 -0700 Attachment 292228 did not pass style-queue: ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:603: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:609: Line contains only semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1242503 3 hyatt 2016-10-20 11:38:50 -0700 Landed in r207629. 292228 2016-10-20 11:26:49 -0700 2016-10-20 11:29:07 -0700 Patch patch.txt text/plain 6929 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNzYyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE2LTEwLTIwICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBGaXggcmVnaW9u LCBjb2x1bW4gYW5kIHBhZ2UgYnJlYWsgcGFyc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYzNzQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgICogY3NzL3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0aHMu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyRmFzdFBhdGhzOjppc1ZhbGlkS2V5d29y ZFByb3BlcnR5QW5kVmFsdWUpOgorICAgICAgICBBZGQgdGhlIG1pc3NpbmcgdmFsdWVzIGZvciBi cmVhayBzdXBwb3J0LgorCisgICAgICAgICogY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjppc0xlZ2FjeUJyZWFrUHJvcGVydHkpOgorICAgICAgICAo V2ViQ29yZTo6Q1NTUHJvcGVydHlQYXJzZXI6OnBhcnNlVmFsdWVTdGFydCk6CisgICAgICAgIEFk ZCBhIHNwZWNpYWwgY2FzZSBmb3IgaGFuZGxpbmcgbGVnYWN5IGJyZWFrIHByb3BlcnRpZXMuIEJs aW5rIHRyZWF0cyB0aGVtIGxpa2UKKyAgICAgICAgc2hvcnRoYW5kcywgYnV0IHdlIGNhbid0IGRv IHRoYXQgd2l0aG91dCBicmVha2luZyB0aGUgb2xkIHBhcnNlciwgc28gZm9yIG5vdworICAgICAg ICB3ZSBhZGQgYSBzcGVjaWFsIGNhc2UuCisKKyAgICAgICAgKFdlYkNvcmU6Om1hcEZyb21QYWdl QnJlYWtCZXR3ZWVuKToKKyAgICAgICAgKFdlYkNvcmU6Om1hcEZyb21Db2x1bW5CcmVha0JldHdl ZW4pOgorICAgICAgICAoV2ViQ29yZTo6bWFwRnJvbVJlZ2lvbkJyZWFrQmV0d2Vlbik6CisgICAg ICAgIFVwZGF0ZWQgdG8gaGF2ZSB0aGUgQXZvaWRYWFggdmFsdWVzICh3aGVyZSBYWFggaXMgQ29s dW1uL1BhZ2UvUmVnaW9uKS4KKworICAgICAgICAoV2ViQ29yZTo6Q1NTUHJvcGVydHlQYXJzZXI6 OnBhcnNlU2hvcnRoYW5kKToKKyAgICAgICAgUmVtb3ZlIHRoZSBjb25zdW1lTGVnYWN5QnJlYWsg ZnJvbSB0aGUgc2hvcnRoYW5kIGZ1bmN0aW9uLCBzaW5jZSB3ZSBjYW4ndCB0cmVhdAorICAgICAg ICB0aGUgbGVnYWN5IGJyZWFrIHByb3BlcnRpZXMgYXMgc2hvcnRoYW5kcyB5ZXQuCisKIDIwMTYt MTAtMjAgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NTUyBQYXJz ZXJdIEZpeCBmb250IGZhbWlseSBwYXJzaW5nIGFuZCBhZGQgQ1NTIHJlZ2lvbiBwcm9wZXJ0eSBw YXJzaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1BhcnNlckZhc3RQYXRo cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJG YXN0UGF0aHMuY3BwCShyZXZpc2lvbiAyMDc2MjIpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvcGFy c2VyL0NTU1BhcnNlckZhc3RQYXRocy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5Niw5ICs1OTYs MTcgQEAgYm9vbCBDU1NQYXJzZXJGYXN0UGF0aHM6OmlzVmFsaWRLZXl3b3JkUAogICAgICAgICBy ZXR1cm4gdmFsdWVJRCA9PSBDU1NWYWx1ZVZpc2libGUgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUhp ZGRlbiB8fCB2YWx1ZUlEID09IENTU1ZhbHVlU2Nyb2xsIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVB dXRvIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVPdmVybGF5IHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVX ZWJraXRQYWdlZFggfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZVdlYmtpdFBhZ2VkWTsKICAgICBjYXNl IENTU1Byb3BlcnR5QnJlYWtBZnRlcjoKICAgICBjYXNlIENTU1Byb3BlcnR5QnJlYWtCZWZvcmU6 Ci0gICAgICAgIHJldHVybiB2YWx1ZUlEID09IENTU1ZhbHVlQXV0byB8fCB2YWx1ZUlEID09IENT U1ZhbHVlQXZvaWQgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUF2b2lkUGFnZSB8fCB2YWx1ZUlEID09 IENTU1ZhbHVlUGFnZSB8fCB2YWx1ZUlEID09IENTU1ZhbHVlTGVmdCB8fCB2YWx1ZUlEID09IENT U1ZhbHVlUmlnaHQgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZVJlY3RvIHx8IHZhbHVlSUQgPT0gQ1NT VmFsdWVWZXJzbyB8fCB2YWx1ZUlEID09IENTU1ZhbHVlQXZvaWRDb2x1bW4gfHwgdmFsdWVJRCA9 PSBDU1NWYWx1ZUNvbHVtbjsKKyAgICAgICAgcmV0dXJuIHZhbHVlSUQgPT0gQ1NTVmFsdWVBdXRv IHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVBdm9pZCB8fCB2YWx1ZUlEID09IENTU1ZhbHVlQXZvaWRQ YWdlIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVQYWdlIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVMZWZ0 IHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVSaWdodCB8fCB2YWx1ZUlEID09IENTU1ZhbHVlUmVjdG8g fHwgdmFsdWVJRCA9PSBDU1NWYWx1ZVZlcnNvIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVBdm9pZENv bHVtbiB8fCB2YWx1ZUlEID09IENTU1ZhbHVlQ29sdW1uCisjaWYgRU5BQkxFKENTU19SRUdJT05T KQorICAgICAgICAgICAgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZVJlZ2lvbiB8fCB2YWx1ZUlEID09 IENTU1ZhbHVlQXZvaWRSZWdpb24KKyNlbmRpZgorICAgICAgICA7CiAgICAgY2FzZSBDU1NQcm9w ZXJ0eUJyZWFrSW5zaWRlOgotICAgICAgICByZXR1cm4gdmFsdWVJRCA9PSBDU1NWYWx1ZUF1dG8g fHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUF2b2lkIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVBdm9pZFBh Z2UgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUF2b2lkQ29sdW1uOworICAgICAgICByZXR1cm4gdmFs dWVJRCA9PSBDU1NWYWx1ZUF1dG8gfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUF2b2lkIHx8IHZhbHVl SUQgPT0gQ1NTVmFsdWVBdm9pZFBhZ2UgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUF2b2lkQ29sdW1u CisjaWYgRU5BQkxFKENTU19SRUdJT05TKQorICAgICAgICAgICAgfHwgdmFsdWVJRCA9PSBDU1NW YWx1ZUF2b2lkUmVnaW9uCisjZW5kaWYKKyAgICAgICAgOwogICAgIGNhc2UgQ1NTUHJvcGVydHlQ b2ludGVyRXZlbnRzOgogICAgICAgICAvLyBub25lIHwgdmlzaWJsZVBhaW50ZWQgfCB2aXNpYmxl RmlsbCB8IHZpc2libGVTdHJva2UgfCB2aXNpYmxlIHwKICAgICAgICAgLy8gcGFpbnRlZCB8IGZp bGwgfCBzdHJva2UgfCBhdXRvIHwgYWxsIHwgYm91bmRpbmctYm94CkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAkocmV2aXNpb24gMjA3 NjIyKQorKysgU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTI2Niw2ICsyNjYsMjcgQEAgUmVmUHRyPENTU1ZhbHVlPiBDU1NQ cm9wZXJ0eVBhcnNlcjo6cGFycwogICAgIHJldHVybiB2YWx1ZTsKIH0KIAorc3RhdGljIGJvb2wg aXNMZWdhY3lCcmVha1Byb3BlcnR5KENTU1Byb3BlcnR5SUQgcHJvcGVydHlJRCkKK3sKKyAgICBz d2l0Y2ggKHByb3BlcnR5SUQpIHsKKyAgICBjYXNlIENTU1Byb3BlcnR5UGFnZUJyZWFrQWZ0ZXI6 CisgICAgY2FzZSBDU1NQcm9wZXJ0eVBhZ2VCcmVha0JlZm9yZToKKyAgICBjYXNlIENTU1Byb3Bl cnR5UGFnZUJyZWFrSW5zaWRlOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRDb2x1bW5CcmVh a0FmdGVyOgorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRDb2x1bW5CcmVha0JlZm9yZToKKyAg ICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Q29sdW1uQnJlYWtJbnNpZGU6CisjaWYgRU5BQkxFKENT U19SRUdJT05TKQorICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRSZWdpb25CcmVha0FmdGVyOgor ICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRSZWdpb25CcmVha0JlZm9yZToKKyAgICBjYXNlIENT U1Byb3BlcnR5V2Via2l0UmVnaW9uQnJlYWtJbnNpZGU6CisjZW5kaWYKKyAgICAgICAgcmV0dXJu IHRydWU7CisgICAgZGVmYXVsdDoKKyAgICAgICAgYnJlYWs7CisgICAgfQorICAgIHJldHVybiBm YWxzZTsKK30KKwogYm9vbCBDU1NQcm9wZXJ0eVBhcnNlcjo6cGFyc2VWYWx1ZVN0YXJ0KENTU1By b3BlcnR5SUQgcHJvcGVydHlJRCwgYm9vbCBpbXBvcnRhbnQpCiB7CiAgICAgaWYgKGNvbnN1bWVD U1NXaWRlS2V5d29yZChwcm9wZXJ0eUlELCBpbXBvcnRhbnQpKQpAQCAtMjc4LDYgKzI5OSwxMSBA QCBib29sIENTU1Byb3BlcnR5UGFyc2VyOjpwYXJzZVZhbHVlU3RhcnQoCiAgICAgICAgIC8vIFZh cmlhYmxlIHJlZmVyZW5jZXMgd2lsbCBmYWlsIHRvIHBhcnNlIGhlcmUgYW5kIHdpbGwgZmFsbCBv dXQgdG8gdGhlIHZhcmlhYmxlIHJlZiBwYXJzZXIgYmVsb3cuCiAgICAgICAgIGlmIChwYXJzZVNo b3J0aGFuZChwcm9wZXJ0eUlELCBpbXBvcnRhbnQpKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7 CisgICAgfSBlbHNlIGlmIChpc0xlZ2FjeUJyZWFrUHJvcGVydHkocHJvcGVydHlJRCkpIHsKKyAg ICAgICAgLy8gRklYTUUtTkVXUEFSU0VSOiBDYW4gdHVybiB0aGlzIGludG8gYSBzaG9ydGhhbmQg b25jZSBvbGQgcGFyc2VyIGlzIGdvbmUsIGFuZCB0aGVuCisgICAgICAgIC8vIHdlIGRvbid0IG5l ZWQgdGhlIHNwZWNpYWwgY2FzZS4KKyAgICAgICAgaWYgKGNvbnN1bWVMZWdhY3lCcmVha1Byb3Bl cnR5KHByb3BlcnR5SUQsIGltcG9ydGFudCkpCisgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICB9IGVsc2UgewogICAgICAgICBSZWZQdHI8Q1NTVmFsdWU+IHBhcnNlZFZhbHVlID0gcGFyc2VT aW5nbGVWYWx1ZShwcm9wZXJ0eUlEKTsKICAgICAgICAgaWYgKHBhcnNlZFZhbHVlICYmIG1fcmFu Z2UuYXRFbmQoKSkgewpAQCAtNDAwMyw4ICs0MDI5LDEwIEBAIHN0YXRpYyBpbmxpbmUgQ1NTVmFs dWVJRCBtYXBGcm9tUGFnZUJyZWEKIHsKICAgICBpZiAodmFsdWUgPT0gQ1NTVmFsdWVBbHdheXMp CiAgICAgICAgIHJldHVybiBDU1NWYWx1ZVBhZ2U7Ci0gICAgaWYgKHZhbHVlID09IENTU1ZhbHVl QXV0byB8fCB2YWx1ZSA9PSBDU1NWYWx1ZUF2b2lkIHx8IHZhbHVlID09IENTU1ZhbHVlTGVmdCB8 fCB2YWx1ZSA9PSBDU1NWYWx1ZVJpZ2h0KQorICAgIGlmICh2YWx1ZSA9PSBDU1NWYWx1ZUF1dG8g fHwgdmFsdWUgPT0gQ1NTVmFsdWVMZWZ0IHx8IHZhbHVlID09IENTU1ZhbHVlUmlnaHQpCiAgICAg ICAgIHJldHVybiB2YWx1ZTsKKyAgICBpZiAodmFsdWUgPT0gQ1NTVmFsdWVBdm9pZCkKKyAgICAg ICAgcmV0dXJuIENTU1ZhbHVlQXZvaWRQYWdlOwogICAgIHJldHVybiBDU1NWYWx1ZUludmFsaWQ7 CiB9CiAKQEAgLTQwMTIsOCArNDA0MCwxMCBAQCBzdGF0aWMgaW5saW5lIENTU1ZhbHVlSUQgbWFw RnJvbUNvbHVtbkJyCiB7CiAgICAgaWYgKHZhbHVlID09IENTU1ZhbHVlQWx3YXlzKQogICAgICAg ICByZXR1cm4gQ1NTVmFsdWVDb2x1bW47Ci0gICAgaWYgKHZhbHVlID09IENTU1ZhbHVlQXV0byB8 fCB2YWx1ZSA9PSBDU1NWYWx1ZUF2b2lkKQorICAgIGlmICh2YWx1ZSA9PSBDU1NWYWx1ZUF1dG8p CiAgICAgICAgIHJldHVybiB2YWx1ZTsKKyAgICBpZiAodmFsdWUgPT0gQ1NTVmFsdWVBdm9pZCkK KyAgICAgICAgcmV0dXJuIENTU1ZhbHVlQXZvaWRDb2x1bW47CiAgICAgcmV0dXJuIENTU1ZhbHVl SW52YWxpZDsKIH0KIApAQCAtNDAyMiw4ICs0MDUyLDEwIEBAIHN0YXRpYyBpbmxpbmUgQ1NTVmFs dWVJRCBtYXBGcm9tUmVnaW9uQnIKIHsKICAgICBpZiAodmFsdWUgPT0gQ1NTVmFsdWVBbHdheXMp CiAgICAgICAgIHJldHVybiBDU1NWYWx1ZVJlZ2lvbjsKLSAgICBpZiAodmFsdWUgPT0gQ1NTVmFs dWVBdXRvIHx8IHZhbHVlID09IENTU1ZhbHVlQXZvaWQpCisgICAgaWYgKHZhbHVlID09IENTU1Zh bHVlQXV0bykKICAgICAgICAgcmV0dXJuIHZhbHVlOworICAgIGlmICh2YWx1ZSA9PSBDU1NWYWx1 ZUF2b2lkKQorICAgICAgICByZXR1cm4gQ1NTVmFsdWVBdm9pZFJlZ2lvbjsKICAgICByZXR1cm4g Q1NTVmFsdWVJbnZhbGlkOwogfQogI2VuZGlmCkBAIC00NTcxLDEzICs0NjAzLDYgQEAgYm9vbCBD U1NQcm9wZXJ0eVBhcnNlcjo6cGFyc2VTaG9ydGhhbmQoQwogICAgICAgICByZXR1cm4gY29uc3Vt ZUJvcmRlcihpbXBvcnRhbnQpOwogICAgIGNhc2UgQ1NTUHJvcGVydHlCb3JkZXJJbWFnZToKICAg ICAgICAgcmV0dXJuIGNvbnN1bWVCb3JkZXJJbWFnZShwcm9wZXJ0eSwgaW1wb3J0YW50KTsKLSAg ICBjYXNlIENTU1Byb3BlcnR5UGFnZUJyZWFrQWZ0ZXI6Ci0gICAgY2FzZSBDU1NQcm9wZXJ0eVBh Z2VCcmVha0JlZm9yZToKLSAgICBjYXNlIENTU1Byb3BlcnR5UGFnZUJyZWFrSW5zaWRlOgotICAg IGNhc2UgQ1NTUHJvcGVydHlXZWJraXRDb2x1bW5CcmVha0FmdGVyOgotICAgIGNhc2UgQ1NTUHJv cGVydHlXZWJraXRDb2x1bW5CcmVha0JlZm9yZToKLSAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0 Q29sdW1uQnJlYWtJbnNpZGU6Ci0gICAgICAgIHJldHVybiBjb25zdW1lTGVnYWN5QnJlYWtQcm9w ZXJ0eShwcm9wZXJ0eSwgaW1wb3J0YW50KTsKICAgICBjYXNlIENTU1Byb3BlcnR5V2Via2l0TWFz a1Bvc2l0aW9uOgogICAgIGNhc2UgQ1NTUHJvcGVydHlCYWNrZ3JvdW5kUG9zaXRpb246IHsKICAg ICAgICAgUmVmUHRyPENTU1ZhbHVlPiByZXN1bHRYOwo=